From nobody Sun Oct 5 21:10:01 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1599083893; cv=none; d=zohomail.com; s=zohoarc; b=DrcMkb8+M2oKvusQt0M6f02jLOFm00rYsHe93PFJVpvZN5n1GJvxXGkLlv71T8yGJNHgtyrQ9J2WO8HgnwB44ReiDrd1zBtEF/N2JqZFZPs1nzxKZKm6jLlBbw7HRFd1Qa99+WAvlfS5pP85ZX7U8mc/VvUa/jnBW7iQVodP+5E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599083893; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=J2tYQkyVYDZ3Na2n5cIcAsIsopY2LFgv8iyHrh2+JYQ=; b=Zt/KJV9QiTQ07tRIQXN/SWC+4G9eWVubYJbBGcHyCb6xAvxVVseXB20Vhi4RRiaRl7EurgYGlmv6hNJVQ5ItLUcZLecGltaFNbE5GClc0oZ6vu7UD9eTmPEIo6WJbVsuK1P+gesWdyhf4mmFu6UWUEO72CHBF0IZxhSJw8LBJI0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1599083893987943.6641382339119; Wed, 2 Sep 2020 14:58:13 -0700 (PDT) Received: from localhost ([::1]:44106 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDalh-0005Y4-5U for importer@patchew.org; Wed, 02 Sep 2020 17:58:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54310) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDaht-00082k-Jx for qemu-devel@nongnu.org; Wed, 02 Sep 2020 17:54:17 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:32710) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kDahp-0002bV-NH for qemu-devel@nongnu.org; Wed, 02 Sep 2020 17:54:17 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-429-wzxyT1xyMpGPZDKCIgsUYg-1; Wed, 02 Sep 2020 17:54:06 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BB9F5802B63; Wed, 2 Sep 2020 21:54:05 +0000 (UTC) Received: from blue.redhat.com (ovpn-113-128.phx2.redhat.com [10.3.113.128]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6C4A576E01; Wed, 2 Sep 2020 21:54:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599083653; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J2tYQkyVYDZ3Na2n5cIcAsIsopY2LFgv8iyHrh2+JYQ=; b=JTwpQNfMyLYz3FZS8ZJsE/90ULzCvD/SfTQ6pkQ+rdk5gLUjAa99bRzy65uKqpgTDWLMJC v4pp+tP6g/sjm+TE85m0lhp4ZWVut0bjVYhN26rWO9R8ITMIaJk+P5QYn6zxwzh9nKeRcP zsIC3N6QKUQ0ZQhbzaq80p2kwWRIbRU= X-MC-Unique: wzxyT1xyMpGPZDKCIgsUYg-1 From: Eric Blake To: qemu-devel@nongnu.org Subject: [PULL 6/6] nbd: disable signals and forking on Windows builds Date: Wed, 2 Sep 2020 16:54:00 -0500 Message-Id: <20200902215400.2673028-7-eblake@redhat.com> In-Reply-To: <20200902215400.2673028-1-eblake@redhat.com> References: <20200902215400.2673028-1-eblake@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/02 17:54:06 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , "open list:Network Block Dev..." Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Daniel P. Berrang=C3=A9 Disabling these parts are sufficient to get the qemu-nbd program compiling in a Windows build. Signed-off-by: Daniel P. Berrang=C3=A9 Message-Id: <20200825103850.119911-4-berrange@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Eric Blake --- qemu-nbd.c | 5 +++++ meson.build | 7 ++----- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/qemu-nbd.c b/qemu-nbd.c index dc6ef089afd5..33476a1000c8 100644 --- a/qemu-nbd.c +++ b/qemu-nbd.c @@ -899,6 +899,7 @@ int main(int argc, char **argv) #endif if ((device && !verbose) || fork_process) { +#ifndef WIN32 int stderr_fd[2]; pid_t pid; int ret; @@ -962,6 +963,10 @@ int main(int argc, char **argv) */ exit(errors); } +#else /* WIN32 */ + error_report("Unable to fork into background on Windows hosts"); + exit(EXIT_FAILURE); +#endif /* WIN32 */ } if (device !=3D NULL && sockpath =3D=3D NULL) { diff --git a/meson.build b/meson.build index 55c7d2318cdb..5aaa3647305d 100644 --- a/meson.build +++ b/meson.build @@ -1095,12 +1095,9 @@ if have_tools dependencies: [authz, block, crypto, io, qom, qemuutil], inst= all: true) qemu_io =3D executable('qemu-io', files('qemu-io.c'), dependencies: [block, qemuutil], install: true) - qemu_block_tools +=3D [qemu_img, qemu_io] - if targetos !=3D 'windows' - qemu_nbd =3D executable('qemu-nbd', files('qemu-nbd.c'), + qemu_nbd =3D executable('qemu-nbd', files('qemu-nbd.c'), dependencies: [block, qemuutil], install: true) - qemu_block_tools +=3D [qemu_nbd] - endif + qemu_block_tools +=3D [qemu_img, qemu_io, qemu_nbd] subdir('storage-daemon') subdir('contrib/rdmacm-mux') --=20 2.28.0