From nobody Sun Nov 16 07:38:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1599066781; cv=none; d=zohomail.com; s=zohoarc; b=bWWuYB/0fQWnyVTL8keI+i3ZKaalGlI+chmzT8YFJJuIhS9x82FgCdCD08EPeB1p6Hy4N2cDgEquR46holaN0eyI2EkpnOSBe5CGrraO3F6WF4zeGY4Uec1DmRVyiL5/lPaUd5aay5vXbY2DrMi5i1yez4JkPA36rn40BLhsVCw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599066781; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Ke2Gq7O9miraf4qjtV+qmMUZy8GFd4yQ/tYyZZhtSBE=; b=FNKuJSTzxtuwXBRADGXRcj525J7CbulOrFgaMoa0h6fl/lnK7zGCyqbQjPgETz4uTd9NcSzsIJFVshXZmdU+yHgeR6bxdtuY6Jcmzup0n1pWAmpN5/PkeC5YrTlxwXz4bzPF/mucZFHZb37y/1U2ON2MjroMSK5mzlxznBwfcso= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1599066781275633.7187655081171; Wed, 2 Sep 2020 10:13:01 -0700 (PDT) Received: from localhost ([::1]:43358 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDWJg-000344-GP for importer@patchew.org; Wed, 02 Sep 2020 13:13:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47896) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDWGY-0006Ek-JJ for qemu-devel@nongnu.org; Wed, 02 Sep 2020 13:09:46 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:33689 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kDWGW-0001O6-Up for qemu-devel@nongnu.org; Wed, 02 Sep 2020 13:09:46 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-201-97JOlisTPOqHHXQm9X71AQ-1; Wed, 02 Sep 2020 13:09:40 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 08B8518B9EC4; Wed, 2 Sep 2020 17:09:39 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.36.110.55]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4830B19C59; Wed, 2 Sep 2020 17:09:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599066584; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ke2Gq7O9miraf4qjtV+qmMUZy8GFd4yQ/tYyZZhtSBE=; b=AEpTQUua0suGxTnc6fsuxCPhWNukK0sU5vn7ArZgxW56asrF8vCjx7VXQrTXIEziNf/PiJ ata9JRZlEtBf/g0MaqFeULeCT2tZhWrCiseKBOeGW25+LfhAbXMuzF2haR0uv2T8ku3QHd FOyU8WoneyDVs2dwY2hto06SCZckVbs= X-MC-Unique: 97JOlisTPOqHHXQm9X71AQ-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v5 5/8] util: add Error object for qemu_open_internal error reporting Date: Wed, 2 Sep 2020 18:09:10 +0100 Message-Id: <20200902170913.1785194-6-berrange@redhat.com> In-Reply-To: <20200902170913.1785194-1-berrange@redhat.com> References: <20200902170913.1785194-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.120; envelope-from=berrange@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/02 02:07:24 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , qemu-block@nongnu.org, Markus Armbruster , Max Reitz , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Instead of relying on the limited information from errno, we can now also provide detailed error messages to callers that ask for it. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Markus Armbruster --- util/osdep.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/util/osdep.c b/util/osdep.c index dd34b58bb7..28aa89adc9 100644 --- a/util/osdep.c +++ b/util/osdep.c @@ -298,7 +298,7 @@ static int qemu_open_cloexec(const char *name, int flag= s, mode_t mode) * Opens a file with FD_CLOEXEC set */ static int -qemu_open_internal(const char *name, int flags, mode_t mode) +qemu_open_internal(const char *name, int flags, mode_t mode, Error **errp) { int ret; =20 @@ -312,12 +312,15 @@ qemu_open_internal(const char *name, int flags, mode_= t mode) =20 fdset_id =3D qemu_parse_fdset(fdset_id_str); if (fdset_id =3D=3D -1) { + error_setg(errp, "Could not parse fdset %s", name); errno =3D EINVAL; return -1; } =20 dupfd =3D monitor_fdset_dup_fd_add(fdset_id, flags); if (dupfd =3D=3D -1) { + error_setg_errno(errp, errno, "Could not dup FD for %s flags %= x", + name, flags); return -1; } =20 @@ -327,6 +330,13 @@ qemu_open_internal(const char *name, int flags, mode_t= mode) =20 ret =3D qemu_open_cloexec(name, flags, mode); =20 + if (ret =3D=3D -1) { + const char *action =3D flags & O_CREAT ? "create" : "open"; + error_setg_errno(errp, errno, "Could not %s '%s'", + action, name); + } + + return ret; } =20 @@ -343,7 +353,7 @@ int qemu_open_old(const char *name, int flags, ...) } va_end(ap); =20 - ret =3D qemu_open_internal(name, flags, mode); + ret =3D qemu_open_internal(name, flags, mode, NULL); =20 #ifdef O_DIRECT if (ret =3D=3D -1 && errno =3D=3D EINVAL && (flags & O_DIRECT)) { --=20 2.26.2