From nobody Sun Nov 16 07:44:33 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1599048295; cv=none; d=zohomail.com; s=zohoarc; b=Nh4m/sddy4HIJV7s3QVrSJC89uzYFPGu6ws0zAlJJPqam5VCM9rSnpKQ3Ox1LQsn+HPvHcnHzcn5PuSWcPSAL4FpGxkxdDRxH4NYn4o9uKf8kvWGLhJhAFOhaHu+5mq0NqEP1IFecxTgKft2476Ny4h2fzro9FLzzzPH2EVldgQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599048295; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lAfU3w4m27H9HfN6VPDufFMPcYXUZcVL2eGbGwf078M=; b=AguZUaqsuwW5FR7iZjfy70fjIuxs9gEvYQgiTyTNal4DVpN0Ilm55cY5HSs688dwvg4ZQxAWmngz2iLMu4kY2xBM3D7zdiskg5GXrlezRx08KddtKw9HbcOBk+9RIGLWpx0yCEOqeQtl/vSlJN8Ly7r9Hjyk+iPLd//qLbnDNZE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1599048295576121.76235263452384; Wed, 2 Sep 2020 05:04:55 -0700 (PDT) Received: from localhost ([::1]:49098 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDRVV-0004Zk-TH for importer@patchew.org; Wed, 02 Sep 2020 08:04:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47102) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDRKy-0002sV-3m for qemu-devel@nongnu.org; Wed, 02 Sep 2020 07:54:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:41239) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kDRKw-0006yo-9M for qemu-devel@nongnu.org; Wed, 02 Sep 2020 07:53:59 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-400-iCfj3y4OMVqmVL-ZLwbbHQ-1; Wed, 02 Sep 2020 07:53:55 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E333510082EA; Wed, 2 Sep 2020 11:53:53 +0000 (UTC) Received: from localhost (ovpn-66-226.rdu2.redhat.com [10.10.66.226]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7CF225D9CD; Wed, 2 Sep 2020 11:53:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599047637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lAfU3w4m27H9HfN6VPDufFMPcYXUZcVL2eGbGwf078M=; b=FBt46wbzTWHau3/aPlnWWiYYVXzrGg8p9q5kPFuq6uhlPztmThaKRxfHJ8xnzQyyt+KBvp xUOw6vodHl/jYj9b3OXCD3yVhRKlYTBQYldVFo7hGkKykx4uDIGH7UN7jGEW92exK1P3g2 ucGDOL7MmcWyHD9zU12oSFEpjcw+vOY= X-MC-Unique: iCfj3y4OMVqmVL-ZLwbbHQ-1 From: Eduardo Habkost To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 19/20] target/i386/cpu: Fix memleak in x86_cpu_class_check_missing_features Date: Wed, 2 Sep 2020 07:53:22 -0400 Message-Id: <20200902115323.850385-20-ehabkost@redhat.com> In-Reply-To: <20200902115323.850385-1-ehabkost@redhat.com> References: <20200902115323.850385-1-ehabkost@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/02 02:42:29 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Li Qiang , Pan Nengyuan , Markus Armbruster , Euler Robot , Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Pan Nengyuan 'err' forgot to free in x86_cpu_class_check_missing_features error path. Fix that. Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Reviewed-by: Li Qiang Reviewed-by: Markus Armbruster Message-Id: <20200831134315.1221-7-pannengyuan@huawei.com> Signed-off-by: Eduardo Habkost --- target/i386/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index ba4667b33c..49d8958528 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -4947,6 +4947,7 @@ static void x86_cpu_class_check_missing_features(X86C= PUClass *xcc, new->value =3D g_strdup("type"); *next =3D new; next =3D &new->next; + error_free(err); } =20 x86_cpu_filter_features(xc, false); --=20 2.26.2