From nobody Fri Dec 19 04:33:02 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1598975605; cv=none; d=zohomail.com; s=zohoarc; b=k1lM8vuFAfuPYG//socAnAV9flel2T1dKwc9euAd91D77Wz45XOXVH3ZUjUofDC5gfiOYynAxthWXacR8r5d4fmDVfLDxBKF1McCp+etPHFLhRz2gv8KDxPXH3SyGFnbys71bZf850OoDs1gBwf3IwswTxKAVoqyO5iOCiNTbYM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598975605; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=kCMIRBdBD+xxV9Xrbw/I3rXmj5T1GkkcLppYl0e6YnQ=; b=kRQfS4wgwcTNnui63Gb1DYNihgLL99SoWTm/3hr8tatfkCROmUFNI5GaqElo41Rx5nFbzsSJCVVnu2OxVFBiUEGxTQJMDis0CWbv07LzFPHu6X4Lmz2j3ELC7/Rp5OshGFu+gtWtV5BSm2vI4Qg4pd1LLYPPy09fH5T754qlVRk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1598975605080655.518600702888; Tue, 1 Sep 2020 08:53:25 -0700 (PDT) Received: from localhost ([::1]:52642 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD8b4-0003ey-B6 for importer@patchew.org; Tue, 01 Sep 2020 11:53:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48234) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD842-0000gx-EH for qemu-devel@nongnu.org; Tue, 01 Sep 2020 11:19:14 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]:51361) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kD840-0006IF-DT for qemu-devel@nongnu.org; Tue, 01 Sep 2020 11:19:14 -0400 Received: by mail-wm1-x32a.google.com with SMTP id w2so1549491wmi.1 for ; Tue, 01 Sep 2020 08:19:11 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id z9sm2242317wma.4.2020.09.01.08.19.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 08:19:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=kCMIRBdBD+xxV9Xrbw/I3rXmj5T1GkkcLppYl0e6YnQ=; b=P89o3I5/IxIlmBV2ghG+2nk+f0jioqAqrRPyZ450KWLUFpwMJ/R1mZMmfBNvTcqXpk WxHiMaDwmP7EXG3qKU69acfcH2Tc8sN4M7UVxxwKzuXAnyYw32ag6A+46PG0uY1DdJrT 0yhz4arfBbCShXwoOYTMXBU+A6mqtOMvYmQC5vsE6/14xCicjY4clMDRRmDCSbHfucWk dk3DRjK5X6CyUABD1T0K4bNqmIM3VEEDkeFav7/2A1TatJFHPimGNY9OgX3hEC1suuDq fLqqekHg6gL0FYLCGLBx4be4rHPkf2HmYhTLRzG2DzroLqs+SNXu/NMU/uPnu7d3a5ph RxOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kCMIRBdBD+xxV9Xrbw/I3rXmj5T1GkkcLppYl0e6YnQ=; b=jk7sNGfX6jxJ4tJqQ7Gus6HNbvRQxYnwASW6HLU9azyNoB+o/bisoKQ5cjxFJHWpFD mU8oi2K1TIfVgAjPL8Mva2NjTIqO1/20B/kRe4O+y8iVaPKxT63XzVRm14A1QgHICvsz G+gfCKaMpV+3b4r7UqoDxCCJIcf44utTMjXbaGkcJ7UL9kv8I+xBuxZ/epfMsQ4bZSuu KNpIVbJZVYvPx82+D1GuVY47PpL+vMlODs0ozaHerZZibNPoLbQyj7SFsVjVIOo1Ffam Oew/5DsgmbJl5zR7sQxEvYzrSzVUveZQ2APjD2oZSJIejVtWO/Bb+3C8/1UV0irLM06s NO5Q== X-Gm-Message-State: AOAM533ZquJNwSyfA5CCFP+A2ff2SH1JmutcJuTG4TVyjPmTTV9rvW+h +GoO7tPthZlDBiv4hEalWkg5Fd5kbII4q6LD X-Google-Smtp-Source: ABdhPJz8ApiVVWeADv/63KhmCd7rO4zKQVRcGL6ZYV9XkDWZcCHthUfJt60pzSr9UUKAK2jjoz/1eA== X-Received: by 2002:a7b:c2aa:: with SMTP id c10mr2276099wmk.86.1598973550879; Tue, 01 Sep 2020 08:19:10 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 36/47] target/arm: Convert Neon VCVT fixed-point to gvec Date: Tue, 1 Sep 2020 16:18:12 +0100 Message-Id: <20200901151823.29785-37-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200901151823.29785-1-peter.maydell@linaro.org> References: <20200901151823.29785-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32a.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" Convert the Neon VCVT float<->fixed-point insns to a gvec style, in preparation for adding fp16 support. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 20200828183354.27913-38-peter.maydell@linaro.org --- target/arm/helper.h | 5 +++++ target/arm/vec_helper.c | 20 +++++++++++++++++++ target/arm/translate-neon.c.inc | 35 +++++++++++++++++---------------- 3 files changed, 43 insertions(+), 17 deletions(-) diff --git a/target/arm/helper.h b/target/arm/helper.h index 1d8badf4a21..09e0fa052ef 100644 --- a/target/arm/helper.h +++ b/target/arm/helper.h @@ -623,6 +623,11 @@ DEF_HELPER_FLAGS_4(gvec_tosizs, TCG_CALL_NO_RWG, void,= ptr, ptr, ptr, i32) DEF_HELPER_FLAGS_4(gvec_touszh, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) DEF_HELPER_FLAGS_4(gvec_touizs, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) =20 +DEF_HELPER_FLAGS_4(gvec_vcvt_sf, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) +DEF_HELPER_FLAGS_4(gvec_vcvt_uf, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) +DEF_HELPER_FLAGS_4(gvec_vcvt_fs, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) +DEF_HELPER_FLAGS_4(gvec_vcvt_fu, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) + DEF_HELPER_FLAGS_4(gvec_frecpe_h, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i3= 2) DEF_HELPER_FLAGS_4(gvec_frecpe_s, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i3= 2) DEF_HELPER_FLAGS_4(gvec_frecpe_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i3= 2) diff --git a/target/arm/vec_helper.c b/target/arm/vec_helper.c index 6ea9807b790..6d83953ee8f 100644 --- a/target/arm/vec_helper.c +++ b/target/arm/vec_helper.c @@ -1845,3 +1845,23 @@ DO_NEON_PAIRWISE(neon_pmax, max) DO_NEON_PAIRWISE(neon_pmin, min) =20 #undef DO_NEON_PAIRWISE + +#define DO_VCVT_FIXED(NAME, FUNC, TYPE) \ + void HELPER(NAME)(void *vd, void *vn, void *stat, uint32_t desc) \ + { \ + intptr_t i, oprsz =3D simd_oprsz(desc); \ + int shift =3D simd_data(desc); \ + TYPE *d =3D vd, *n =3D vn; = \ + float_status *fpst =3D stat; \ + for (i =3D 0; i < oprsz / sizeof(TYPE); i++) { \ + d[i] =3D FUNC(n[i], shift, fpst); \ + } \ + clear_tail(d, oprsz, simd_maxsz(desc)); \ + } + +DO_VCVT_FIXED(gvec_vcvt_sf, helper_vfp_sltos, uint32_t) +DO_VCVT_FIXED(gvec_vcvt_uf, helper_vfp_ultos, uint32_t) +DO_VCVT_FIXED(gvec_vcvt_fs, helper_vfp_tosls_round_to_zero, uint32_t) +DO_VCVT_FIXED(gvec_vcvt_fu, helper_vfp_touls_round_to_zero, uint32_t) + +#undef DO_VCVT_FIXED diff --git a/target/arm/translate-neon.c.inc b/target/arm/translate-neon.c.= inc index 5aaea867d8c..7e4324c5397 100644 --- a/target/arm/translate-neon.c.inc +++ b/target/arm/translate-neon.c.inc @@ -1608,17 +1608,24 @@ static bool trans_VSHLL_U_2sh(DisasContext *s, arg_= 2reg_shift *a) } =20 static bool do_fp_2sh(DisasContext *s, arg_2reg_shift *a, - NeonGenTwoSingleOpFn *fn) + gen_helper_gvec_2_ptr *fn) { /* FP operations in 2-reg-and-shift group */ - TCGv_i32 tmp, shiftv; - TCGv_ptr fpstatus; - int pass; + int vec_size =3D a->q ? 16 : 8; + int rd_ofs =3D neon_reg_offset(a->vd, 0); + int rm_ofs =3D neon_reg_offset(a->vm, 0); + TCGv_ptr fpst; =20 if (!arm_dc_feature(s, ARM_FEATURE_NEON)) { return false; } =20 + if (a->size !=3D 0) { + if (!dc_isar_feature(aa32_fp16_arith, s)) { + return false; + } + } + /* UNDEF accesses to D16-D31 if they don't exist. */ if (!dc_isar_feature(aa32_simd_r32, s) && ((a->vd | a->vm) & 0x10)) { @@ -1633,15 +1640,9 @@ static bool do_fp_2sh(DisasContext *s, arg_2reg_shif= t *a, return true; } =20 - fpstatus =3D fpstatus_ptr(FPST_STD); - shiftv =3D tcg_const_i32(a->shift); - for (pass =3D 0; pass < (a->q ? 4 : 2); pass++) { - tmp =3D neon_load_reg(a->vm, pass); - fn(tmp, tmp, shiftv, fpstatus); - neon_store_reg(a->vd, pass, tmp); - } - tcg_temp_free_ptr(fpstatus); - tcg_temp_free_i32(shiftv); + fpst =3D fpstatus_ptr(a->size ? FPST_STD_F16 : FPST_STD); + tcg_gen_gvec_2_ptr(rd_ofs, rm_ofs, fpst, vec_size, vec_size, a->shift,= fn); + tcg_temp_free_ptr(fpst); return true; } =20 @@ -1651,10 +1652,10 @@ static bool do_fp_2sh(DisasContext *s, arg_2reg_shi= ft *a, return do_fp_2sh(s, a, FUNC); \ } =20 -DO_FP_2SH(VCVT_SF, gen_helper_vfp_sltos) -DO_FP_2SH(VCVT_UF, gen_helper_vfp_ultos) -DO_FP_2SH(VCVT_FS, gen_helper_vfp_tosls_round_to_zero) -DO_FP_2SH(VCVT_FU, gen_helper_vfp_touls_round_to_zero) +DO_FP_2SH(VCVT_SF, gen_helper_gvec_vcvt_sf) +DO_FP_2SH(VCVT_UF, gen_helper_gvec_vcvt_uf) +DO_FP_2SH(VCVT_FS, gen_helper_gvec_vcvt_fs) +DO_FP_2SH(VCVT_FU, gen_helper_gvec_vcvt_fu) =20 static uint64_t asimd_imm_const(uint32_t imm, int cmode, int op) { --=20 2.20.1