From nobody Fri Dec 19 04:31:20 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1598975403; cv=none; d=zohomail.com; s=zohoarc; b=DnF3wFnXBqpbpZTqhVludD0AOWBfxzygY0FTCzRhTnRfQLct2QQ/6KfqMJ+uddAVvuCIj/6wCyH0Q5hv4mzFW2Z5JBzDEdkPcX3uP4nqGI4O56UJisRoxbenbsELFZtltpTbMpbM3cVT8InyAG0ZlDLXtQXH/F16QUcR2u9l/AU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598975403; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2IBHZr2iN5N8J3HTc91OllsBCx17+RuT7Dw2JX4RKWs=; b=Tg/y0K9BAFa5Mr6ZyFp50M4RJId4XDvvOqpZQMzb1D/TAmuJAajnwRDMsj+6l6nXOTIJF+cRiwoNMwzoD7uKsjrfjISO/zB8BpDOYUMKWg6vQc4fUCMdA5v9ASSn/YeVX0DLhl0a+SduiG9urufW2PXxR/ynfAvQlsNIto07Hng= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1598975403821657.447963948387; Tue, 1 Sep 2020 08:50:03 -0700 (PDT) Received: from localhost ([::1]:39378 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD8Xr-0006L0-0k for importer@patchew.org; Tue, 01 Sep 2020 11:50:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47974) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD83m-0008Nl-AN for qemu-devel@nongnu.org; Tue, 01 Sep 2020 11:18:58 -0400 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:37240) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kD83k-0006EP-5b for qemu-devel@nongnu.org; Tue, 01 Sep 2020 11:18:57 -0400 Received: by mail-wr1-x432.google.com with SMTP id z4so1987656wrr.4 for ; Tue, 01 Sep 2020 08:18:55 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id z9sm2242317wma.4.2020.09.01.08.18.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 08:18:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=2IBHZr2iN5N8J3HTc91OllsBCx17+RuT7Dw2JX4RKWs=; b=yvUNXtxQCALnk6j6Moi1zFTu+2HBGbrcm40e+mOYklNlg15nnFDB6Y8jiytIoQfgTQ vdfapBlStB61wLqt6Z+Oh6qhz/FgDYAKRtXyvGJj4Z3bSyOfEVDtTCg7lmMMQYbw7qUZ KDliv6DcGPysWz/uJrgNgpMypqWPCkuSZXAuZI6zmjO/QWYR4dH2z398vo68VXJLnJMP KXaL/QJSiJuhMxd9oucKA3yeq1OZBp2k2nGHQeHsOgmeXYDlH5E1rR3mAlf97GjX6iQF g0PRlG4C9ADpr5/NtPuzk6aRgdotJGOfsapesRUiA+dV1WdCJ4O7mgvy91E/LWKP5D6K 0IAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2IBHZr2iN5N8J3HTc91OllsBCx17+RuT7Dw2JX4RKWs=; b=Y6n+p14Es3Qcb3t+g15+NZ8CNUTuNl8WhH24/snaDz92AfZmr9Vof5Q8kHVn89IG8j AZ+a2cSsRGXFuZhfJ7dMZoMuRJqXCpt7PBlc2TsrR7gKy8RqwjcAtEY89E0BgWX3o664 edysfGPAGs+sep5N2EJIho4jEdKFAVPHHR7/+VvNX/gmnoIqWPB6NJOkKsAOYBkg7N3k RWfxREEooLtDoEPHBIald56Iqdcj1wg/mOTU35A7Mbi8TT0Uhj+iYZd8GCbeAwqYZiUp JbvRiTXiWTwcpb/7YTv1rv+hibSkgFfrY8jKRWLyaTAtLamPLo04Sese2nph6AwMMrUH UN9Q== X-Gm-Message-State: AOAM532OX7pgMfGxL5lMR/Woh792Erg7btRYlwgwv6xPN6ea7XlzESxs 1+uL1WUsWTFTUh8aTFH8dvMdcbrVxFrGWC5Y X-Google-Smtp-Source: ABdhPJyaxwEypOJh+FQJxJb9wp55T0hKiKgNfyrUVWoRxM/Ryzrcg4jOrG47XL/4wRNRanHwI+73Sg== X-Received: by 2002:adf:db88:: with SMTP id u8mr2449872wri.184.1598973534496; Tue, 01 Sep 2020 08:18:54 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 22/47] target/arm: Implement FP16 for Neon VADD, VSUB, VABD, VMUL Date: Tue, 1 Sep 2020 16:17:58 +0100 Message-Id: <20200901151823.29785-23-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200901151823.29785-1-peter.maydell@linaro.org> References: <20200901151823.29785-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x432.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" Implement FP16 support for the Neon insns which use the DO_3S_FP_GVEC macro: VADD, VSUB, VABD, VMUL. For VABD this requires us to implement a new gvec_fabd_h helper using the machinery we have already for the other helpers. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 20200828183354.27913-24-peter.maydell@linaro.org --- target/arm/helper.h | 1 + target/arm/vec_helper.c | 6 ++++++ target/arm/translate-neon.c.inc | 36 +++++++++++++++++---------------- 3 files changed, 26 insertions(+), 17 deletions(-) diff --git a/target/arm/helper.h b/target/arm/helper.h index f5ad5088bf1..aa1ac75571f 100644 --- a/target/arm/helper.h +++ b/target/arm/helper.h @@ -629,6 +629,7 @@ DEF_HELPER_FLAGS_5(gvec_fmul_h, TCG_CALL_NO_RWG, void, = ptr, ptr, ptr, ptr, i32) DEF_HELPER_FLAGS_5(gvec_fmul_s, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, ptr,= i32) DEF_HELPER_FLAGS_5(gvec_fmul_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, ptr,= i32) =20 +DEF_HELPER_FLAGS_5(gvec_fabd_h, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, ptr,= i32) DEF_HELPER_FLAGS_5(gvec_fabd_s, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, ptr,= i32) =20 DEF_HELPER_FLAGS_5(gvec_ftsmul_h, TCG_CALL_NO_RWG, diff --git a/target/arm/vec_helper.c b/target/arm/vec_helper.c index a6c53d2ab6c..988d5784e83 100644 --- a/target/arm/vec_helper.c +++ b/target/arm/vec_helper.c @@ -707,6 +707,11 @@ static float64 float64_ftsmul(float64 op1, uint64_t op= 2, float_status *stat) return result; } =20 +static float16 float16_abd(float16 op1, float16 op2, float_status *stat) +{ + return float16_abs(float16_sub(op1, op2, stat)); +} + static float32 float32_abd(float32 op1, float32 op2, float_status *stat) { return float32_abs(float32_sub(op1, op2, stat)); @@ -739,6 +744,7 @@ DO_3OP(gvec_ftsmul_h, float16_ftsmul, float16) DO_3OP(gvec_ftsmul_s, float32_ftsmul, float32) DO_3OP(gvec_ftsmul_d, float64_ftsmul, float64) =20 +DO_3OP(gvec_fabd_h, float16_abd, float16) DO_3OP(gvec_fabd_s, float32_abd, float32) =20 #ifdef TARGET_AARCH64 diff --git a/target/arm/translate-neon.c.inc b/target/arm/translate-neon.c.= inc index 9879731a521..9d0959517fa 100644 --- a/target/arm/translate-neon.c.inc +++ b/target/arm/translate-neon.c.inc @@ -1082,34 +1082,36 @@ static bool do_3same_fp(DisasContext *s, arg_3same = *a, VFPGen3OpSPFn *fn, return true; } =20 -/* - * For all the functions using this macro, size =3D=3D 1 means fp16, - * which is an architecture extension we don't implement yet. - */ -#define DO_3S_FP_GVEC(INSN,FUNC) \ - static void gen_##INSN##_3s(unsigned vece, uint32_t rd_ofs, \ - uint32_t rn_ofs, uint32_t rm_ofs, \ - uint32_t oprsz, uint32_t maxsz) \ +#define WRAP_FP_GVEC(WRAPNAME, FPST, FUNC) \ + static void WRAPNAME(unsigned vece, uint32_t rd_ofs, \ + uint32_t rn_ofs, uint32_t rm_ofs, \ + uint32_t oprsz, uint32_t maxsz) \ { \ - TCGv_ptr fpst =3D fpstatus_ptr(FPST_STD); \ + TCGv_ptr fpst =3D fpstatus_ptr(FPST); \ tcg_gen_gvec_3_ptr(rd_ofs, rn_ofs, rm_ofs, fpst, \ oprsz, maxsz, 0, FUNC); \ tcg_temp_free_ptr(fpst); \ - } \ + } + +#define DO_3S_FP_GVEC(INSN,SFUNC,HFUNC) \ + WRAP_FP_GVEC(gen_##INSN##_fp32_3s, FPST_STD, SFUNC) \ + WRAP_FP_GVEC(gen_##INSN##_fp16_3s, FPST_STD_F16, HFUNC) \ static bool trans_##INSN##_fp_3s(DisasContext *s, arg_3same *a) \ { \ if (a->size !=3D 0) { \ - /* TODO fp16 support */ \ - return false; \ + if (!dc_isar_feature(aa32_fp16_arith, s)) { \ + return false; \ + } \ + return do_3same(s, a, gen_##INSN##_fp16_3s); \ } \ - return do_3same(s, a, gen_##INSN##_3s); \ + return do_3same(s, a, gen_##INSN##_fp32_3s); \ } =20 =20 -DO_3S_FP_GVEC(VADD, gen_helper_gvec_fadd_s) -DO_3S_FP_GVEC(VSUB, gen_helper_gvec_fsub_s) -DO_3S_FP_GVEC(VABD, gen_helper_gvec_fabd_s) -DO_3S_FP_GVEC(VMUL, gen_helper_gvec_fmul_s) +DO_3S_FP_GVEC(VADD, gen_helper_gvec_fadd_s, gen_helper_gvec_fadd_h) +DO_3S_FP_GVEC(VSUB, gen_helper_gvec_fsub_s, gen_helper_gvec_fsub_h) +DO_3S_FP_GVEC(VABD, gen_helper_gvec_fabd_s, gen_helper_gvec_fabd_h) +DO_3S_FP_GVEC(VMUL, gen_helper_gvec_fmul_s, gen_helper_gvec_fmul_h) =20 /* * For all the functions using this macro, size =3D=3D 1 means fp16, --=20 2.20.1