From nobody Tue Feb 10 02:30:27 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1598971962; cv=none; d=zohomail.com; s=zohoarc; b=CPNMo6nFMg3YiW5JB5cNG6VhSCeSvPN8WhhF/kOnCr+CPzjdObkBqDIbTP48CbAMt2OBa3ouPt2tsTkPl1lPOyzmZRqHj4jTh2mPKiYdaEOJgI+TS9uqyX5fKSF3pdx60pSBBoUdsKQJfDUH/MDucnYIQzvZVf0P+g0nWUrO+us= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598971962; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=rAhktimVFCszyYC4+nx01hoqbRzDBH/DRe69/BnxAq8=; b=fuvkPS+QS7yg83hlYCRN+u3PuCYzeRpgC+4cKe8TnrSxbeVCojiWe86vUFHtUhHtZxKMFc+JFAWBbpr5ehDHFEntO6Q8aFftzs8UYtXg18Bqqw++e2StvCUhS3ffu0YOdM3WOqjTusKwigWi8BRdP4zpl7ocB/uJ8PFpctf272o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1598971962574477.1251524764134; Tue, 1 Sep 2020 07:52:42 -0700 (PDT) Received: from localhost ([::1]:39924 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD7eL-0000Vz-Jv for importer@patchew.org; Tue, 01 Sep 2020 10:52:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34096) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD7NP-000059-Sc for qemu-devel@nongnu.org; Tue, 01 Sep 2020 10:35:11 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:37476 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kD7NO-00079P-4w for qemu-devel@nongnu.org; Tue, 01 Sep 2020 10:35:11 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-331-p6QPn0_HMyaPysIKtIAT1g-1; Tue, 01 Sep 2020 10:35:08 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9DC98801AB4; Tue, 1 Sep 2020 14:35:06 +0000 (UTC) Received: from localhost (ovpn-113-83.ams2.redhat.com [10.36.113.83]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3DEFE1002D59; Tue, 1 Sep 2020 14:35:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598970909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rAhktimVFCszyYC4+nx01hoqbRzDBH/DRe69/BnxAq8=; b=TwuOzSlnD9vnRSAvBTIsYqquXagnUl79Z2qgnmc8pBaI+8e0+7Fr2bIlEK/vUpgCFXM5W8 6Aiv6Rp4obaJAaY0aFLUTIVApbI+WVdGrYOaISC6lpRGAmHEwUMtfytIIOvXuc00+IXR9t 2NAP9I4IUJYBCo3PnIyaorZaBpCVzDA= X-MC-Unique: p6QPn0_HMyaPysIKtIAT1g-1 From: Max Reitz To: qemu-block@nongnu.org Subject: [PATCH v8 17/43] vmdk: Drop vmdk_co_flush() Date: Tue, 1 Sep 2020 16:33:58 +0200 Message-Id: <20200901143424.884735-18-mreitz@redhat.com> In-Reply-To: <20200901143424.884735-1-mreitz@redhat.com> References: <20200901143424.884735-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mreitz@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.120; envelope-from=mreitz@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 00:57:59 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Andrey Shinkevich , Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Before HEAD^, we needed this because bdrv_co_flush() by itself would only flush bs->file. With HEAD^, bdrv_co_flush() will flush all children on which a WRITE or WRITE_UNCHANGED permission has been taken. Thus, vmdk no longer needs to do it itself. Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf --- block/vmdk.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index bf9df5ce92..393365b5c2 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -2806,21 +2806,6 @@ static void vmdk_close(BlockDriverState *bs) error_free(s->migration_blocker); } =20 -static coroutine_fn int vmdk_co_flush(BlockDriverState *bs) -{ - BDRVVmdkState *s =3D bs->opaque; - int i, err; - int ret =3D 0; - - for (i =3D 0; i < s->num_extents; i++) { - err =3D bdrv_co_flush(s->extents[i].file->bs); - if (err < 0) { - ret =3D err; - } - } - return ret; -} - static int64_t vmdk_get_allocated_file_size(BlockDriverState *bs) { int i; @@ -3084,7 +3069,6 @@ static BlockDriver bdrv_vmdk =3D { .bdrv_close =3D vmdk_close, .bdrv_co_create_opts =3D vmdk_co_create_opts, .bdrv_co_create =3D vmdk_co_create, - .bdrv_co_flush_to_disk =3D vmdk_co_flush, .bdrv_co_block_status =3D vmdk_co_block_status, .bdrv_get_allocated_file_size =3D vmdk_get_allocated_file_size, .bdrv_has_zero_init =3D vmdk_has_zero_init, --=20 2.26.2