From nobody Tue Feb 10 04:15:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1598972078; cv=none; d=zohomail.com; s=zohoarc; b=RUEG6SWGHsWjjTPeKM7GyfhcfbshAGlUbzrl4FcMA8uU5gq6O7qXHU5+vrQ6ekT4z5WHTy5/9n0HxNpaOcJ8GTLykADqqCoOr9nNq2Fg19t3Cxn+UBx/mJquBf8FR2wc0y7pCQdp/Tl2YHUSCq+ofwVOvRVrr/Xq5FY8r7k8n1M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598972078; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gZ0uuXyfMg4AHTi6QDcHMi1QLw/IZlf+8AcYRwxXTfE=; b=Srdld5SgLjTtuMvudnUFE9gPqPFWh75A7wosuu4xiArV6d7P1Gc5jmGTIqWgVowIEIRM0Fj87g85oWgPJA2rVgyc46L+SXXsguIJ/Ip6PeBFFo3UCkrRxZNitPKzyLIXKES8DlKhims+mNEbRvcK9/ZPsMw3l3JWTBPP9eZ1SX4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1598972078644576.1482265381817; Tue, 1 Sep 2020 07:54:38 -0700 (PDT) Received: from localhost ([::1]:49944 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD7gD-0004km-B0 for importer@patchew.org; Tue, 01 Sep 2020 10:54:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34030) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD7NJ-0008Ek-G3 for qemu-devel@nongnu.org; Tue, 01 Sep 2020 10:35:05 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:32557 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kD7NH-00078V-Mh for qemu-devel@nongnu.org; Tue, 01 Sep 2020 10:35:05 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-11-s50ZE2bVNyupAvzG6DbbyQ-1; Tue, 01 Sep 2020 10:35:01 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id ED1578015A8; Tue, 1 Sep 2020 14:34:59 +0000 (UTC) Received: from localhost (ovpn-113-83.ams2.redhat.com [10.36.113.83]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8F36B78B5D; Tue, 1 Sep 2020 14:34:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598970902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gZ0uuXyfMg4AHTi6QDcHMi1QLw/IZlf+8AcYRwxXTfE=; b=i9R5WYV5/48U2xn+7YM6hwz19K7CdJSowXwyndX//0WgvFJgnWcAoSaDoY9t5uhLAuIw0L 4wXDMMWjuy7wCT9WKcbtaSUge7LAURsUTUxEA7xJGzLB29sYeglaKusJCKAVglWWUxQpX7 oDTmq+wp2Otp2bcztr5Z5N8gqMXCngw= X-MC-Unique: s50ZE2bVNyupAvzG6DbbyQ-1 From: Max Reitz To: qemu-block@nongnu.org Subject: [PATCH v8 14/43] block: Use bdrv_cow_child() in bdrv_co_truncate() Date: Tue, 1 Sep 2020 16:33:55 +0200 Message-Id: <20200901143424.884735-15-mreitz@redhat.com> In-Reply-To: <20200901143424.884735-1-mreitz@redhat.com> References: <20200901143424.884735-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mreitz@redhat.com X-Mimecast-Spam-Score: 0.0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.81; envelope-from=mreitz@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 02:08:15 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Andrey Shinkevich , Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The condition modified here is not about potentially filtered children, but only about COW sources (i.e. traditional backing files). Signed-off-by: Max Reitz Reviewed-by: Andrey Shinkevich Reviewed-by: Kevin Wolf --- block/io.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/block/io.c b/block/io.c index 4ee8fe5465..6f9402117e 100644 --- a/block/io.c +++ b/block/io.c @@ -3310,7 +3310,7 @@ int coroutine_fn bdrv_co_truncate(BdrvChild *child, i= nt64_t offset, bool exact, Error **errp) { BlockDriverState *bs =3D child->bs; - BdrvChild *filtered; + BdrvChild *filtered, *backing; BlockDriver *drv =3D bs->drv; BdrvTrackedRequest req; int64_t old_size, new_bytes; @@ -3363,6 +3363,7 @@ int coroutine_fn bdrv_co_truncate(BdrvChild *child, i= nt64_t offset, bool exact, } =20 filtered =3D bdrv_filter_child(bs); + backing =3D bdrv_cow_child(bs); =20 /* * If the image has a backing file that is large enough that it would @@ -3374,10 +3375,10 @@ int coroutine_fn bdrv_co_truncate(BdrvChild *child,= int64_t offset, bool exact, * backing file, taking care of keeping things consistent with that ba= cking * file is the user's responsibility. */ - if (new_bytes && bs->backing) { + if (new_bytes && backing) { int64_t backing_len; =20 - backing_len =3D bdrv_getlength(backing_bs(bs)); + backing_len =3D bdrv_getlength(backing->bs); if (backing_len < 0) { ret =3D backing_len; error_setg_errno(errp, -ret, "Could not get backing file size"= ); --=20 2.26.2