From nobody Tue Feb 10 11:12:51 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1598969060; cv=none; d=zohomail.com; s=zohoarc; b=DFrm3RwCZZzOmBnGemqWaL/iUsecvWVo8MxKbRt9BmJSNLWB4+70H7mYhxTrlEPe4tIWhusozVYF4gv7753jrQzbu0ZRM09g93J4F4r/IKXY1aP0pWHbQ7scTdxmGwsUCxU8ug4jj2Duj+18NAurOiDJCjMj/Sj/GwV09KRTRa0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598969060; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=IACbjPDFBmwQpji6CF0wwL/53xVgGp9xNZwMZtgSUrg=; b=SqSIfYFkLiPEK+zYiRt8WGXQulmtKA1h9W6Glh8KkyijfuUT4VWLbng2FFSP9iyPFXcHII1ytgaRXbBsKGh6NgDBKh4HxtNqGdpGXiqVghKPJ+hX1eGe3eniQLw3kE2N4rgkS2pNK0F+rZa68Okh4M9zjDAkcos+wAoiATteK34= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1598969060803990.5976231883402; Tue, 1 Sep 2020 07:04:20 -0700 (PDT) Received: from localhost ([::1]:34236 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD6tX-0003d6-Vl for importer@patchew.org; Tue, 01 Sep 2020 10:04:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52392) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6qw-00085W-Hb; Tue, 01 Sep 2020 10:01:40 -0400 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:55949) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kD6qt-0002Uu-Qk; Tue, 01 Sep 2020 10:01:38 -0400 Received: by mail-wm1-x342.google.com with SMTP id a65so1267763wme.5; Tue, 01 Sep 2020 07:01:34 -0700 (PDT) Received: from localhost.localdomain (50.red-83-52-54.dynamicip.rima-tde.net. [83.52.54.50]) by smtp.gmail.com with ESMTPSA id m13sm1492107wrr.74.2020.09.01.07.01.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 07:01:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IACbjPDFBmwQpji6CF0wwL/53xVgGp9xNZwMZtgSUrg=; b=aDZUTtiv+t4GlDVqnyuPRsG2ZKip/MB1GI6IjSqhwx8Uki5y9x7IYnbTBzXBH9UKXq 4AsPYi1qurw+1IXSqIf6N/CPMSJVt6mdv2lNusSE+5T5GCHjF1+qkyRuvybzKVahxAm7 NT1YJl3tarXRGb0NbyPcLjrafUw/JBuCnTW5Sajs5/BJ3CZnqnve7UuKDN/rUAt2MKY5 /tS0tFMvYKZJMitVREcA0fCy1DbdL9b5cqHrYhy61wzphF2L6VoGAUf0tvZtDvtNuvsH yRxo2jK23s0QoWdhfemY4mcYe6ieMXMxX12D4cRoOtI6ZcP5ufWe0mGMaLGDRI/XAqxa APog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=IACbjPDFBmwQpji6CF0wwL/53xVgGp9xNZwMZtgSUrg=; b=WTerz078JHY372KLAzlmiOe8zZ2XLR1PvkgiU6g2f//N0MO4uq3JAg3vTREms6Y1Iq +bVZOl8vZn937fd5M9l7vYg2RRwPadKvd85/B9iQIv/1YB0y1+tftsz4eErROEzb+jGT +rbut7SXePn9K5vFOH0s5MgL72YjexEIcp0a1JJUYH5K+bPj13kG7/GreTFXaSAwE0nL 23KeQZn836Vx0/NGzj1xsUH86vLW8x7l3SiLOm3isyUoOEY4FWBSAnKY0ihdw4lwoowf jpK3esBOkwzIiYWC1aC6WZYX01YWFIiDV/sh0lJkRO1OAmNfXsRwzPqp0MWqacoYOKpo O5vQ== X-Gm-Message-State: AOAM530GSONLl9mGCmkcOCz8wGllSZAy6+PNqTyjy3UYscxyKsbjzC5W wk5l44q5mcHzndHi4jU/AOF9HW4XmZ0= X-Google-Smtp-Source: ABdhPJzNkn6wObGk0wVOJi/AmTr2wHxQnYLXUl4rvdQPALAZoqFSdVunNGtv1C/Zh4fA5AB1guFj4w== X-Received: by 2002:a1c:b60b:: with SMTP id g11mr1990066wmf.48.1598968893483; Tue, 01 Sep 2020 07:01:33 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 3/3] hw/sd/sdhci: Fix DMA Transfer Block Size field Date: Tue, 1 Sep 2020 16:01:27 +0200 Message-Id: <20200901140127.111454-4-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140127.111454-1-f4bug@amsat.org> References: <20200901140127.111454-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::342; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x342.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Prasad J Pandit , qemu-block@nongnu.org, 1892960@bugs.launchpad.net, Igor Mitsyanko , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-stable@nongnu.org, Alexander Bulekov , bugs-syssec@rub.de, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) The 'Transfer Block Size' field is 12-bit wide. See section '2.2.2. Block Size Register (Offset 004h)' in datasheet. Cc: qemu-stable@nongnu.org Cc: Igor Mitsyanko Buglink: https://bugs.launchpad.net/qemu/+bug/1892960 Fixes: d7dfca0807a ("hw/sdhci: introduce standard SD host controller") Reported-by: Alexander Bulekov Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- Cc: 1892960@bugs.launchpad.net --- hw/sd/sdhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index 60f083b84c1..beb7b7ea092 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -1104,7 +1104,7 @@ sdhci_write(void *opaque, hwaddr offset, uint64_t val= , unsigned size) break; case SDHC_BLKSIZE: if (!TRANSFERRING_DATA(s->prnsts)) { - MASKED_WRITE(s->blksize, mask, value); + MASKED_WRITE(s->blksize, mask, extract32(s->blksize, 0, 12)); MASKED_WRITE(s->blkcnt, mask >> 16, value >> 16); } =20 --=20 2.26.2