From nobody Tue Feb 10 19:17:04 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1598858494; cv=none; d=zohomail.com; s=zohoarc; b=eBVus6M2lGLvZ7skJWVskwIP4H1PRn4dMhOOb32H8ZY1B0dO8fuo/BrimOtJLsR3ivcuWOKjvl6Lolq2rWRFKjIhXuiPCMxxOkqTrM2bjXXfLQfCscqWKWezo3Jgx1mVdBu11wXVt1Sr48m5ifXE9BYibKccoMfNlZVBDnjBUHk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598858494; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=wXXEb7/cs8hy0rGqkjkXBcq/+sxoXYpdZ2MB6mgIZ+M=; b=PA57PXVHM2KggXs1ShnyfxH5FE28uGE3Jr4TIZE/BYl//RcXONkfdXrGzsZ0UZk/uAmOaxDFHHPejlPnKcFGZvgBz6ziYuXTB9Wh0LqUgUMibhYVXtzk/og6S1cIaplzYWIRpogkqQDr/fOieQdvSCqm97rgxLm5pr9/JvplSRg= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 159885849472453.29094587851591; Mon, 31 Aug 2020 00:21:34 -0700 (PDT) Received: from localhost ([::1]:48030 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCe8D-0001uH-Ep for importer@patchew.org; Mon, 31 Aug 2020 03:21:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54254) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCe4A-0002eo-H3 for qemu-devel@nongnu.org; Mon, 31 Aug 2020 03:17:22 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:40246 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCe45-0005tG-Hc for qemu-devel@nongnu.org; Mon, 31 Aug 2020 03:17:22 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 9613ACA25855F5D7D6B4; Mon, 31 Aug 2020 15:17:10 +0800 (CST) Received: from opensource.huawei.com (10.175.100.152) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Mon, 31 Aug 2020 15:17:02 +0800 From: Pan Nengyuan To: Subject: [PATCH v2 06/10] target/i386/cpu: Fix memleak in x86_cpu_class_check_missing_features Date: Mon, 31 Aug 2020 09:43:11 -0400 Message-ID: <20200831134315.1221-7-pannengyuan@huawei.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20200831134315.1221-1-pannengyuan@huawei.com> References: <20200831134315.1221-1-pannengyuan@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.100.152] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.32; envelope-from=pannengyuan@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/31 03:17:11 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DATE_IN_FUTURE_06_12=1.947, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, euler.robot@huawei.com, Pan Nengyuan , Eduardo Habkost , Paolo Bonzini , kuhn.chenqun@huawei.com, Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" 'err' forgot to free in x86_cpu_class_check_missing_features error path. Fix that. Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Reviewed-by: Li Qiang Reviewed-by: Markus Armbruster --- Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost --- - V2: no changes in v2. --- target/i386/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 588f32e136..4678aac0b4 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -4872,6 +4872,7 @@ static void x86_cpu_class_check_missing_features(X86C= PUClass *xcc, new->value =3D g_strdup("type"); *next =3D new; next =3D &new->next; + error_free(err); } =20 x86_cpu_filter_features(xc, false); --=20 2.18.2