From nobody Tue Feb 10 17:45:08 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1598858314; cv=none; d=zohomail.com; s=zohoarc; b=fA4nViv4GMlO8HmP7HEawMPfOdRVsC67zhlfz37wxAtqkv/J7+mMT+vnC5YRBBqSpn06cc+0MAswAfHmm0NYa9BbFpgGRZ25AGipsB0LXWuqKhYk3IFpZH4VD8rUJVrftiFi3DmDbY1dBaXQIbONz5FbD3g72nukY/JfwTtkqYw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598858314; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=JToF0eO+S4KySsCp+Qj6mU1qKCFItmPZ72zPn5CP8MU=; b=lbI12DCh4OHw08+SJ5I71642v8B8Kiak5GbfXjiMfM2/gk6HuBnCmeXRM/rZWXcWkReok0ZZVzm75Nwz3RvrBLJf5oNNaiEQH48wBopcC6p7RRFf/iUL5oG51Jfu4n+gUkPhDJefjDYxCknyeHaSUjH3Z3CFgCgmmqRPTuo/4Wo= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1598858314281864.244326465266; Mon, 31 Aug 2020 00:18:34 -0700 (PDT) Received: from localhost ([::1]:33238 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCe5J-0004H8-0L for importer@patchew.org; Mon, 31 Aug 2020 03:18:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54186) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCe48-0002bw-Fb for qemu-devel@nongnu.org; Mon, 31 Aug 2020 03:17:20 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:40248 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCe45-0005tD-Gu for qemu-devel@nongnu.org; Mon, 31 Aug 2020 03:17:20 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id C7662753174EF9D15823; Mon, 31 Aug 2020 15:17:10 +0800 (CST) Received: from opensource.huawei.com (10.175.100.152) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Mon, 31 Aug 2020 15:17:00 +0800 From: Pan Nengyuan To: Subject: [PATCH v2 04/10] target/i386/sev: Plug memleak in sev_read_file_base64 Date: Mon, 31 Aug 2020 09:43:09 -0400 Message-ID: <20200831134315.1221-5-pannengyuan@huawei.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20200831134315.1221-1-pannengyuan@huawei.com> References: <20200831134315.1221-1-pannengyuan@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.100.152] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.32; envelope-from=pannengyuan@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/31 03:17:11 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DATE_IN_FUTURE_06_12=1.947, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, euler.robot@huawei.com, Pan Nengyuan , Eduardo Habkost , Paolo Bonzini , kuhn.chenqun@huawei.com, Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Missing g_error_free() in sev_read_file_base64() error path. Fix that. Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Reviewed-by: Li Qiang --- Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost --- - v2: no changes in v2 --- target/i386/sev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/i386/sev.c b/target/i386/sev.c index c3ecf86704..de4818da6d 100644 --- a/target/i386/sev.c +++ b/target/i386/sev.c @@ -500,6 +500,7 @@ sev_read_file_base64(const char *filename, guchar **dat= a, gsize *len) =20 if (!g_file_get_contents(filename, &base64, &sz, &error)) { error_report("failed to read '%s' (%s)", filename, error->message); + g_error_free(error); return -1; } =20 --=20 2.18.2