From nobody Wed Feb 11 02:14:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1598858567; cv=none; d=zohomail.com; s=zohoarc; b=FHwtc3G41s0UKOhgeelcWWxhVl/J0Koc0mPpVNo1l9D4VXGOc1IQ6EFMDzXfXBMwY+vPMkvyjDq4gNQ7rKWsXsUoET4jSyM/J6t0ZsY6kINRxLA9zaQn+QPkDT+qEbElQRALRXyR+w7bDCScfNVPXLaGHF8VHt8/nsoDJBDrAQ4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598858567; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=UtmQtbaJa9s8QYCaZLcfSd/NpM8ySwfkOEsZNQgChwA=; b=DX175zt5/6EgNpknChYL2jr6K+3Jsgpys1ejOCzpqq7OzFw0xY0whpgx3gN+sTuRTTtZKgWiwbHloCDrzk0fuBkMtqP+00tWIvsc2wEYcU0jczYp6VGmHVaFcd9p4Kb0JLBe7Z3pemgJABcpnEILB3qv0ISDCp7HtmKTpavRKCg= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1598858567007541.0534915183508; Mon, 31 Aug 2020 00:22:47 -0700 (PDT) Received: from localhost ([::1]:53200 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCe9N-0003yq-OB for importer@patchew.org; Mon, 31 Aug 2020 03:22:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54272) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCe4B-0002hz-Th for qemu-devel@nongnu.org; Mon, 31 Aug 2020 03:17:23 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:4721 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCe47-0005ug-CI for qemu-devel@nongnu.org; Mon, 31 Aug 2020 03:17:23 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id A09FC9B32A6B6634E84F; Mon, 31 Aug 2020 15:17:15 +0800 (CST) Received: from opensource.huawei.com (10.175.100.152) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Mon, 31 Aug 2020 15:17:08 +0800 From: Pan Nengyuan To: Subject: [PATCH v2 10/10] vnc-auth-sasl: Plug memleak in vnc_socket_ip_addr_string Date: Mon, 31 Aug 2020 09:43:15 -0400 Message-ID: <20200831134315.1221-11-pannengyuan@huawei.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20200831134315.1221-1-pannengyuan@huawei.com> References: <20200831134315.1221-1-pannengyuan@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.100.152] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.191; envelope-from=pannengyuan@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/31 03:17:16 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DATE_IN_FUTURE_06_12=1.947, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kuhn.chenqun@huawei.com, Gerd Hoffmann , Pan Nengyuan , zhang.zhanghailiang@huawei.com, euler.robot@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" 'addr' is forgot to free in vnc_socket_ip_addr_string error path. Fix that. Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Reviewed-by: Li Qiang --- Cc: Gerd Hoffmann --- - V2: no changes in v2. --- ui/vnc-auth-sasl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/vnc-auth-sasl.c b/ui/vnc-auth-sasl.c index 7b2b09f242..0517b2ead9 100644 --- a/ui/vnc-auth-sasl.c +++ b/ui/vnc-auth-sasl.c @@ -522,6 +522,7 @@ vnc_socket_ip_addr_string(QIOChannelSocket *ioc, =20 if (addr->type !=3D SOCKET_ADDRESS_TYPE_INET) { error_setg(errp, "Not an inet socket type"); + qapi_free_SocketAddress(addr); return NULL; } ret =3D g_strdup_printf("%s;%s", addr->u.inet.host, addr->u.inet.port); --=20 2.18.2