From nobody Wed Feb 11 07:50:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1598858493; cv=none; d=zohomail.com; s=zohoarc; b=CU4zo5i6Ue00/7m9nnPTomLq+RGWLkz9aAGb/MhbMSBPgMETfeqRaFIfhWRGBHV1tVJoSIuEj7e3kdDblH20GUv4TDOJd++O+qt0WunMBDMb7d3axqvBhCSto1IIdeHzJaJpWyUG1sEwPj+mYoa/c8Ti17F4VHvSvzv2rDwNv+w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598858493; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ckUNDu3IQ0STRKwQw2o9T6FtVWgH7PrtxaYg7auQOHg=; b=Wwqm2no2/TFW6dL5lfvuYXuthX9hrTXn4YUq96EgZvBizbNDeTwiHs72HBP5Y+VFxi8Cd7YTn7/Cw7QsRjhdib84A8oWCWlrTqQaY0XwLW9M8xpW6sqpGYDkYrvt/jCGgv9SeKDZ6pq+Q1uf2VZkfCONE8c5LupAlXxR3ABtJ3I= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1598858493421832.9385143876048; Mon, 31 Aug 2020 00:21:33 -0700 (PDT) Received: from localhost ([::1]:47900 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCe8C-0001r9-6M for importer@patchew.org; Mon, 31 Aug 2020 03:21:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCe4B-0002hK-Ja; Mon, 31 Aug 2020 03:17:23 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:4720 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCe47-0005ue-Q8; Mon, 31 Aug 2020 03:17:23 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id A8610A9B13E3BD0BD447; Mon, 31 Aug 2020 15:17:15 +0800 (CST) Received: from opensource.huawei.com (10.175.100.152) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Mon, 31 Aug 2020 15:17:06 +0800 From: Pan Nengyuan To: Subject: [PATCH v2 09/10] block/file-posix: fix a possible undefined behavior Date: Mon, 31 Aug 2020 09:43:14 -0400 Message-ID: <20200831134315.1221-10-pannengyuan@huawei.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20200831134315.1221-1-pannengyuan@huawei.com> References: <20200831134315.1221-1-pannengyuan@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.100.152] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.191; envelope-from=pannengyuan@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/31 03:17:16 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DATE_IN_FUTURE_06_12=1.947, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , zhang.zhanghailiang@huawei.com, qemu-block@nongnu.org, Pan Nengyuan , Max Reitz , euler.robot@huawei.com, kuhn.chenqun@huawei.com, Aarushi Mehta Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" local_err is not initialized to NULL, it will cause a assert error as below: qemu/util/error.c:59: error_setv: Assertion `*errp =3D=3D NULL' failed. Fixes: c6447510690 Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Reviewed-by: Stefano Garzarella Reviewed-by: Li Qiang --- Cc: Kevin Wolf Cc: Max Reitz Cc: Aarushi Mehta Cc: qemu-block@nongnu.org --- - V2: no changes in v2. --- block/file-posix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/file-posix.c b/block/file-posix.c index 9a00d4190a..697a7d9eea 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -2113,7 +2113,7 @@ static void raw_aio_attach_aio_context(BlockDriverSta= te *bs, #endif #ifdef CONFIG_LINUX_IO_URING if (s->use_linux_io_uring) { - Error *local_err; + Error *local_err =3D NULL; if (!aio_setup_linux_io_uring(new_context, &local_err)) { error_reportf_err(local_err, "Unable to use linux io_uring, " "falling back to thread pool: "); --=20 2.18.2