From nobody Mon Feb 9 17:36:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1598871928; cv=none; d=zohomail.com; s=zohoarc; b=XdOPS0noQlq2EDAf7HUiH5dLLUJX1zOQDMHNKtY1CjcFMt2AZ/2X1icNvOMIN03JTcPMTV+UaMzBQqyEmM4p/JelkywfQoaF00IFlf45yHqVRQXRLNvulaV6QWk6W4/TwKE7RTRKAbU2XudLxkbNGtG5Q/5gEf/yB2reaOfeF1w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598871928; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=7MEBuq0zfJBQ1/zxCRza1DPT/6+tMCyqccviMn0hSOs=; b=VpPoAsvg+vSxBZxBIyVfhA3Jo6RdKvSTtmmPWwkxnuPexzgpGZPF2A6MfvZKEbhBSUQBjdBk1gHu7X82gwCuDlm8WSHa50ZKgX0EwH3ZlYN3cHQyY8TYhtoYfhll+a12NT9FfKwKc0COGx1fc/vGJAPM9YJBvTSekjQStlvjLIw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1598871928926480.3692544190509; Mon, 31 Aug 2020 04:05:28 -0700 (PDT) Received: from localhost ([::1]:55752 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kChct-0002sz-J7 for importer@patchew.org; Mon, 31 Aug 2020 07:05:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47058) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kChbw-0001FM-JZ for qemu-devel@nongnu.org; Mon, 31 Aug 2020 07:04:28 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:47826 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kChbv-0008My-1r for qemu-devel@nongnu.org; Mon, 31 Aug 2020 07:04:28 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-379-mIbTpIIRM-qIZClj-GrNIA-1; Mon, 31 Aug 2020 07:04:22 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EEEC910066FA; Mon, 31 Aug 2020 11:04:20 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-54.ams2.redhat.com [10.36.112.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id E684F7E303; Mon, 31 Aug 2020 11:04:16 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 1FF8D7828; Mon, 31 Aug 2020 13:04:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598871866; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7MEBuq0zfJBQ1/zxCRza1DPT/6+tMCyqccviMn0hSOs=; b=Q67TXJpVjVZbqbSTWCjWy5o8is0VTKVuc6yhntYY3lmxkR0Wf+5Mx4UKxeTPpmhQkZzg9n E9GqBYWCDjtO+qpC/lTHwkCcNjl7n0gI0fjPdSQM/i+S03h09SHMaLniZnG3fZZ784rExZ kGWpwcqWDsYIFX17CAdCXDR/I1AIATo= X-MC-Unique: mIbTpIIRM-qIZClj-GrNIA-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PULL 2/5] vnc-auth-sasl: Plug memleak in vnc_socket_ip_addr_string Date: Mon, 31 Aug 2020 13:04:13 +0200 Message-Id: <20200831110416.15176-3-kraxel@redhat.com> In-Reply-To: <20200831110416.15176-1-kraxel@redhat.com> References: <20200831110416.15176-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.120; envelope-from=kraxel@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/31 02:54:46 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Li Qiang , Pan Nengyuan , Gerd Hoffmann , Euler Robot Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Pan Nengyuan 'addr' is forgot to free in vnc_socket_ip_addr_string error path. Fix that. Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Reviewed-by: Li Qiang Message-Id: <20200831134315.1221-11-pannengyuan@huawei.com> Signed-off-by: Gerd Hoffmann --- ui/vnc-auth-sasl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/vnc-auth-sasl.c b/ui/vnc-auth-sasl.c index 7b2b09f24276..0517b2ead9ce 100644 --- a/ui/vnc-auth-sasl.c +++ b/ui/vnc-auth-sasl.c @@ -522,6 +522,7 @@ vnc_socket_ip_addr_string(QIOChannelSocket *ioc, =20 if (addr->type !=3D SOCKET_ADDRESS_TYPE_INET) { error_setg(errp, "Not an inet socket type"); + qapi_free_SocketAddress(addr); return NULL; } ret =3D g_strdup_printf("%s;%s", addr->u.inet.host, addr->u.inet.port); --=20 2.27.0