From nobody Mon Feb 9 11:15:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1598872043; cv=none; d=zohomail.com; s=zohoarc; b=NwqOz8Ek/Liw6zOndr2lxqRTLCF5KZ4JDyKukqMyT811Xk8Nkhm8a4edlpfuNlWCp0ZH001sCIFrKQZHM04ASanOxxbB5rUrefzSPHT/yfFWHn+qLiQf93AexaQ9BT+yZLec2mZkiSa7m80LIyIqXRXDQh3gmec7IqhuWUGQ3q0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598872043; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=BaguJ2WSzeibm8mZbk8IKzsTNlpI0vXc3Qjo2TYJ018=; b=IMV6QYIAmk7R7940woMC6dJbOnTDtELJ0DmiHLfK+udNk8EyAn3UB2VIyP++gTJI85Y6xC1rMPXDuKwV8g2w/kwkwH6PC6Io5lQlntSdLCwy+Lz+P/0wER8xNVf24aOKHoIBx0AlGM+Y+igQXpdxcYexuppvJ5LeqInmlttbbmQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1598872043492941.0454014152062; Mon, 31 Aug 2020 04:07:23 -0700 (PDT) Received: from localhost ([::1]:35008 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kChek-0006Fr-3S for importer@patchew.org; Mon, 31 Aug 2020 07:07:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47048) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kChbw-0001EG-1T for qemu-devel@nongnu.org; Mon, 31 Aug 2020 07:04:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:57336) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kChbt-0008MU-OX for qemu-devel@nongnu.org; Mon, 31 Aug 2020 07:04:27 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-266-IrCaOKm0NCGjYv62UkOJ2g-1; Mon, 31 Aug 2020 07:04:22 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E537A18A2246; Mon, 31 Aug 2020 11:04:20 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-54.ams2.redhat.com [10.36.112.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id E30A660C15; Mon, 31 Aug 2020 11:04:16 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 170EB45B2; Mon, 31 Aug 2020 13:04:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598871864; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BaguJ2WSzeibm8mZbk8IKzsTNlpI0vXc3Qjo2TYJ018=; b=db6ndYWMrBp97I8nJCOB7rJtLrgU3alp8UUpjfv34XOT+abud+P2BxWszPp7+oXoEuOQM7 ZERIESKlFBqyBAHS2YyPSVtdRExftSO54qUrrYDjfuzVF0tnbrcAD5faXy+det7ONYIPeW Jcjhee/N65MtHj84gln2Zzf0FcgSKHc= X-MC-Unique: IrCaOKm0NCGjYv62UkOJ2g-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PULL 1/5] ui/gtk-gl-area: Plug memleak in gd_gl_area_create_context() Date: Mon, 31 Aug 2020 13:04:12 +0200 Message-Id: <20200831110416.15176-2-kraxel@redhat.com> In-Reply-To: <20200831110416.15176-1-kraxel@redhat.com> References: <20200831110416.15176-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/31 03:02:42 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pan Nengyuan , Gerd Hoffmann , Euler Robot Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Pan Nengyuan Receiving error in local variable err, and forgot to free it. This patch check the return value of 'gdk_window_create_gl_context' and 'gdk_gl_context_realize', then free err to fix it. Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Message-Id: <20200831134315.1221-6-pannengyuan@huawei.com> Signed-off-by: Gerd Hoffmann --- ui/gtk-gl-area.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c index 85f9d14c51f1..98c22d23f501 100644 --- a/ui/gtk-gl-area.c +++ b/ui/gtk-gl-area.c @@ -147,10 +147,21 @@ QEMUGLContext gd_gl_area_create_context(DisplayChange= Listener *dcl, gtk_gl_area_make_current(GTK_GL_AREA(vc->gfx.drawing_area)); window =3D gtk_widget_get_window(vc->gfx.drawing_area); ctx =3D gdk_window_create_gl_context(window, &err); + if (err) { + g_printerr("Create gdk gl context failed: %s\n", err->message); + g_error_free(err); + return NULL; + } gdk_gl_context_set_required_version(ctx, params->major_ver, params->minor_ver); gdk_gl_context_realize(ctx, &err); + if (err) { + g_printerr("Realize gdk gl context failed: %s\n", err->message); + g_error_free(err); + g_clear_object(&ctx); + return NULL; + } return ctx; } =20 --=20 2.27.0 From nobody Mon Feb 9 11:15:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1598871928; cv=none; d=zohomail.com; s=zohoarc; b=XdOPS0noQlq2EDAf7HUiH5dLLUJX1zOQDMHNKtY1CjcFMt2AZ/2X1icNvOMIN03JTcPMTV+UaMzBQqyEmM4p/JelkywfQoaF00IFlf45yHqVRQXRLNvulaV6QWk6W4/TwKE7RTRKAbU2XudLxkbNGtG5Q/5gEf/yB2reaOfeF1w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598871928; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=7MEBuq0zfJBQ1/zxCRza1DPT/6+tMCyqccviMn0hSOs=; b=VpPoAsvg+vSxBZxBIyVfhA3Jo6RdKvSTtmmPWwkxnuPexzgpGZPF2A6MfvZKEbhBSUQBjdBk1gHu7X82gwCuDlm8WSHa50ZKgX0EwH3ZlYN3cHQyY8TYhtoYfhll+a12NT9FfKwKc0COGx1fc/vGJAPM9YJBvTSekjQStlvjLIw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1598871928926480.3692544190509; Mon, 31 Aug 2020 04:05:28 -0700 (PDT) Received: from localhost ([::1]:55752 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kChct-0002sz-J7 for importer@patchew.org; Mon, 31 Aug 2020 07:05:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47058) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kChbw-0001FM-JZ for qemu-devel@nongnu.org; Mon, 31 Aug 2020 07:04:28 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:47826 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kChbv-0008My-1r for qemu-devel@nongnu.org; Mon, 31 Aug 2020 07:04:28 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-379-mIbTpIIRM-qIZClj-GrNIA-1; Mon, 31 Aug 2020 07:04:22 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EEEC910066FA; Mon, 31 Aug 2020 11:04:20 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-54.ams2.redhat.com [10.36.112.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id E684F7E303; Mon, 31 Aug 2020 11:04:16 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 1FF8D7828; Mon, 31 Aug 2020 13:04:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598871866; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7MEBuq0zfJBQ1/zxCRza1DPT/6+tMCyqccviMn0hSOs=; b=Q67TXJpVjVZbqbSTWCjWy5o8is0VTKVuc6yhntYY3lmxkR0Wf+5Mx4UKxeTPpmhQkZzg9n E9GqBYWCDjtO+qpC/lTHwkCcNjl7n0gI0fjPdSQM/i+S03h09SHMaLniZnG3fZZ784rExZ kGWpwcqWDsYIFX17CAdCXDR/I1AIATo= X-MC-Unique: mIbTpIIRM-qIZClj-GrNIA-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PULL 2/5] vnc-auth-sasl: Plug memleak in vnc_socket_ip_addr_string Date: Mon, 31 Aug 2020 13:04:13 +0200 Message-Id: <20200831110416.15176-3-kraxel@redhat.com> In-Reply-To: <20200831110416.15176-1-kraxel@redhat.com> References: <20200831110416.15176-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.120; envelope-from=kraxel@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/31 02:54:46 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Li Qiang , Pan Nengyuan , Gerd Hoffmann , Euler Robot Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Pan Nengyuan 'addr' is forgot to free in vnc_socket_ip_addr_string error path. Fix that. Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Reviewed-by: Li Qiang Message-Id: <20200831134315.1221-11-pannengyuan@huawei.com> Signed-off-by: Gerd Hoffmann --- ui/vnc-auth-sasl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/vnc-auth-sasl.c b/ui/vnc-auth-sasl.c index 7b2b09f24276..0517b2ead9ce 100644 --- a/ui/vnc-auth-sasl.c +++ b/ui/vnc-auth-sasl.c @@ -522,6 +522,7 @@ vnc_socket_ip_addr_string(QIOChannelSocket *ioc, =20 if (addr->type !=3D SOCKET_ADDRESS_TYPE_INET) { error_setg(errp, "Not an inet socket type"); + qapi_free_SocketAddress(addr); return NULL; } ret =3D g_strdup_printf("%s;%s", addr->u.inet.host, addr->u.inet.port); --=20 2.27.0 From nobody Mon Feb 9 11:15:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1598872040; cv=none; d=zohomail.com; s=zohoarc; b=g8vCZ9iV/hDCs0Erwncg94pJhNJoaHziUXSYuRwNb3eq0JtXEAXJ8EnJ/kUt6dKcANdkzQs8QyJ9xJV20/PadjnQ+KFIo5qW0lghFBfaV0f43UllEcdo5KXa2WQyct2bV2bDgnK1GTyVGYiL9vj2wdKcgyf5QD9Riw/ZmNVqfMM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598872040; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=GarPJ/SS+I4xiksXFaevRanhYl5N9gBrHJ/iFNSYCF0=; b=duUrYxCiAKEpt7z45Ys2Hqq0//O4GZAd7+nh3fGWI2CFIUYm6zzObsrqKd3TQ3nRH5djv32hliH/rKNgyxaA3EIiEsda46D1cESIZkMM0CM2CcvYvzIVsJ6i2XYuMFWjMacKLGTGqSkgdSonwiLwTGI1tQrXzKsddRLod3hwU4g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1598872040921514.2296836503065; Mon, 31 Aug 2020 04:07:20 -0700 (PDT) Received: from localhost ([::1]:34818 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCheh-0006BB-Hg for importer@patchew.org; Mon, 31 Aug 2020 07:07:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47026) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kChbu-0001CT-Uh for qemu-devel@nongnu.org; Mon, 31 Aug 2020 07:04:26 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:20049 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kChbs-0008MF-CJ for qemu-devel@nongnu.org; Mon, 31 Aug 2020 07:04:26 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-402-jRJJvjcAOvmAsegg2O3ZFw-1; Mon, 31 Aug 2020 07:04:21 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9C298801F95 for ; Mon, 31 Aug 2020 11:04:20 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-54.ams2.redhat.com [10.36.112.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0A0DD7EB78; Mon, 31 Aug 2020 11:04:16 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 28C8B204AE; Mon, 31 Aug 2020 13:04:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598871863; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GarPJ/SS+I4xiksXFaevRanhYl5N9gBrHJ/iFNSYCF0=; b=MRd1Ye2/GUMmY9qe08tMMuMif9zvWPBfoA1kqa4qol//lKQCLsoQD3nBY3TxjgH+gX6Y5H 3J8uqJ+uH39AXoan9ihYw7cKkUN5FofHYCqLTt41xt/qMrQgkPj0Dl5JbLW5zI8m56VJ2m 7P1IralNAHuFtTIoiNeEsVa9AuV3nrs= X-MC-Unique: jRJJvjcAOvmAsegg2O3ZFw-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PULL 3/5] meson: fix keymaps witout qemu-keymap Date: Mon, 31 Aug 2020 13:04:14 +0200 Message-Id: <20200831110416.15176-4-kraxel@redhat.com> In-Reply-To: <20200831110416.15176-1-kraxel@redhat.com> References: <20200831110416.15176-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0.0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.120; envelope-from=kraxel@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/31 02:13:08 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" In case the qemu-keymap tool generating them is neither installed on the system nor built from sources (due to xkbcommon not being available) qemu will not find the keymaps when started directly from the build tree, This happens because commit ddcf607fa3d6 ("meson: drop keymaps symlink") removed the symlink to the source tree, and the special handling for install doesn't help in case we do not install qemu. Lets fix that by simply copying over the file from the source tree as fallback. Reported-by: Thomas Huth Signed-off-by: Gerd Hoffmann Message-id: 20200827102617.14448-1-kraxel@redhat.com --- pc-bios/keymaps/meson.build | 28 +++++++++++++++++++--------- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/pc-bios/keymaps/meson.build b/pc-bios/keymaps/meson.build index b737c8223031..e102dd56b454 100644 --- a/pc-bios/keymaps/meson.build +++ b/pc-bios/keymaps/meson.build @@ -38,19 +38,29 @@ if meson.is_cross_build() or 'CONFIG_XKBCOMMON' not in = config_host else native_qemu_keymap =3D qemu_keymap endif + t =3D [] foreach km, args: keymaps - t +=3D custom_target(km, - build_by_default: true, - output: km, - command: [native_qemu_keymap, '-f', '@OUTPUT@', args.= split()], - install_dir: config_host['qemu_datadir'] / 'keymaps') + if native_qemu_keymap.found() + # generate with qemu-kvm + t +=3D custom_target(km, + build_by_default: true, + output: km, + command: [native_qemu_keymap, '-f', '@OUTPUT@', arg= s.split()], + install_dir: config_host['qemu_datadir'] / 'keymaps= ') + else + # copy from source tree + t +=3D custom_target(km, + build_by_default: true, + input: km, + output: km, + command: ['cp', '@INPUT@', '@OUTPUT@'], + install_dir: config_host['qemu_datadir'] / 'keymaps= ') + endif endforeach -if t.length() > 0 + +if native_qemu_keymap.found() alias_target('update-keymaps', t) -else - # install from the source tree - install_data(keymaps.keys(), install_dir: config_host['qemu_datadir'] / = 'keymaps') endif =20 install_data(['sl', 'sv'], install_dir: config_host['qemu_datadir'] / 'key= maps') --=20 2.27.0 From nobody Mon Feb 9 11:15:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1598871926; cv=none; d=zohomail.com; s=zohoarc; b=g85bhMqt9r35WNGxu71V8toBWxMZX/ndnzDFU9B+5GEAT5Jy/WMHAsS0UaxOYagPRLA15y7WA19msDDSOBmKaA6oArhJx/borSvNR/zJxXMIhhH9oK/YhNLbhVLSkgYpGdPRB0ofNc8RJ5cRf4STfwhvzOYzgpTwoK5/0+pEmXU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598871926; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Oh0dsR9TI3mzIVeN0IPikw4F2PQLKCbM82ZwfYzDhZo=; b=DS3vO4XnwDGmlgkj5HNX2QIw+7DbM/ivg1dYVJxIN5VhddI/qnpczoaq6qgFcxyTxjOY1FQS0M5pPNdwHfZGTfOrzV74AQEE11SF986yMp8IiV+bFw3BG8WURM67GS954eooGWXoUHf6swtPSci+Jw/fNDszNZZ+zVoWaMPGiTo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1598871926585432.42847621688134; Mon, 31 Aug 2020 04:05:26 -0700 (PDT) Received: from localhost ([::1]:55476 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kChcr-0002mH-4a for importer@patchew.org; Mon, 31 Aug 2020 07:05:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kChbu-0001C3-HF for qemu-devel@nongnu.org; Mon, 31 Aug 2020 07:04:26 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:46605 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kChbs-0008MC-44 for qemu-devel@nongnu.org; Mon, 31 Aug 2020 07:04:26 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-391-mMAjwlKfPSWqNoU5qcjfPA-1; Mon, 31 Aug 2020 07:04:21 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 208B510ABDA0; Mon, 31 Aug 2020 11:04:20 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-54.ams2.redhat.com [10.36.112.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id 033DB757C0; Mon, 31 Aug 2020 11:04:17 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 31A0431E23; Mon, 31 Aug 2020 13:04:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598871863; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Oh0dsR9TI3mzIVeN0IPikw4F2PQLKCbM82ZwfYzDhZo=; b=dD6PXUEOs55TuecYEpMvXIIJ9+vsIbW1c4ITzef3yDDEaoytQqZ6x8oBV54ZBh2QVOlsn9 CVCt6wfqG7YS06f6NsEOVpnmerC/d6d8c1oxj0XVMADmNa+ZTf+h6+UAhs5GvzmM5f9jxU 9ahpTy8JaIDAPguw9KjBXkj7g7T7kk0= X-MC-Unique: mMAjwlKfPSWqNoU5qcjfPA-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PULL 4/5] ui: Add more mouse buttons to SPICE Date: Mon, 31 Aug 2020 13:04:15 +0200 Message-Id: <20200831110416.15176-5-kraxel@redhat.com> In-Reply-To: <20200831110416.15176-1-kraxel@redhat.com> References: <20200831110416.15176-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0.003 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.120; envelope-from=kraxel@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/31 02:54:46 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann , Frediano Ziglio Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Frediano Ziglio Add support for SIDE and EXTRA buttons. The constants for buttons in both SPICE and QEMU are defined as LEFT MIDDLE RIGHT UP DOWN SIDE EXTRA (same order). "button_mask" contains for each bit the state of a button. Qemu currently uses bits 0, 1, 2 respectively as LEFT, RIGHT, MIDDLE; also add bits 4 and 5 as UP and DOWN (using wheel movements). SPICE protocol uses a bitmask based on the order above where LEFT is bit 0, MIDDLE is bit 1 and so on till EXTRA being bit 6. To avoid clash with Qemu usage SPICE bitmask from SIDE are move a bit more resulting respectively in 0x40 and 0x80 values. Signed-off-by: Frediano Ziglio Message-id: 20200820145851.50846-1-fziglio@redhat.com Signed-off-by: Gerd Hoffmann --- ui/spice-input.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/spice-input.c b/ui/spice-input.c index cd4bb0043fd9..d5bba231c95c 100644 --- a/ui/spice-input.c +++ b/ui/spice-input.c @@ -123,6 +123,8 @@ static void spice_update_buttons(QemuSpicePointer *poin= ter, [INPUT_BUTTON_RIGHT] =3D 0x02, [INPUT_BUTTON_WHEEL_UP] =3D 0x10, [INPUT_BUTTON_WHEEL_DOWN] =3D 0x20, + [INPUT_BUTTON_SIDE] =3D 0x40, + [INPUT_BUTTON_EXTRA] =3D 0x80, }; =20 if (wheel < 0) { --=20 2.27.0 From nobody Mon Feb 9 11:15:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1598871929; cv=none; d=zohomail.com; s=zohoarc; b=U2aOn5YFJONJXtPOiG+ktjMep3+DAxKtVV+M0QqH1FjMTGb4xsehhiic8dlxwQuvKatTT8hETXQOJVzUeuHH02E2Pb7H6kzcxxNRtphE3NggKN3p635IdNyYCA3RoimeTx2xWyzmxe058ifUTn4UuozzZqhpEiMsJ0+TOBLZ8cA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598871929; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=05wm/L/XPk6410ikRNnz1N7rEdTkTuz4gpHOoZ6FZPg=; b=MXhr0E+PAblM9k4n+lgHS3YPeE5U08l0xxuSopvHnTD5NxNtdc4hDiknVCQHFsG67Jp5by+E1PDu9O5kTNB4ITXjGKLSkWpUmDeljCm4cWEoyQ7aHNHzVoYcoYVpTQSEvRnnjN+HRkzfEENiUiIlRAe2UqseUjNIn0oeWXftSFA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1598871929529401.6709264932829; Mon, 31 Aug 2020 04:05:29 -0700 (PDT) Received: from localhost ([::1]:55792 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kChct-0002tq-UI for importer@patchew.org; Mon, 31 Aug 2020 07:05:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47044) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kChbv-0001Da-OK for qemu-devel@nongnu.org; Mon, 31 Aug 2020 07:04:27 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:46981 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kChbt-0008Ma-Kp for qemu-devel@nongnu.org; Mon, 31 Aug 2020 07:04:27 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-304-dnbMtM8lMlipSVZaSnZ2wA-1; Mon, 31 Aug 2020 07:04:22 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8EA4518A224B; Mon, 31 Aug 2020 11:04:21 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-54.ams2.redhat.com [10.36.112.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id F36A31002D40; Mon, 31 Aug 2020 11:04:20 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 3AD4431E68; Mon, 31 Aug 2020 13:04:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598871864; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=05wm/L/XPk6410ikRNnz1N7rEdTkTuz4gpHOoZ6FZPg=; b=Q1PjcLHdOKvfCB4bnKrTUOVgqqrz4FGwLyOnpQGC6zyF93VISWBEUCuyBcTibww2BU9NK1 Mw9kOZLlSPeuoODEi8z0gzRwP6ndLiDPxeSQ5IVIhsNs4U1bHdPhwl3pLWdaZaXzjS+XT0 VJytHa7ZnkvceFmZe5Y8v6naQBjuqJs= X-MC-Unique: dnbMtM8lMlipSVZaSnZ2wA-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PULL 5/5] ui/gtk: Update refresh interval after widget is realized Date: Mon, 31 Aug 2020 13:04:16 +0200 Message-Id: <20200831110416.15176-6-kraxel@redhat.com> In-Reply-To: <20200831110416.15176-1-kraxel@redhat.com> References: <20200831110416.15176-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/31 03:56:57 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Gerd Hoffmann , Nikola Pavlica Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Philippe Mathieu-Daud=C3=A9 Nikola reported on Windows when gd_vc_gfx_init() is called, the window is not yet realized, so we run gd_refresh_rate_millihz(NULL) which returns 0 milli-Hertz. When a Widget is realized, it fires a 'realized' event. We already have the gd_draw_event() handler registered for this even, so simply move the gd_refresh_rate_millihz() there. When the event fires, the window is known to exist. This completes commit c4c00922cc original intention. Reported-by: Nikola Pavlica Tested-by: Nikola Pavlica Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-id: 20200817172331.598255-1-philmd@redhat.com Suggested-by: Nikola Pavlica Tested-by: Nikola Pavlica Signed-off-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 52 ++++++++++++++++++++++++++-------------------------- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index b0cc08ad6da7..7a717ce8e5e4 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -744,6 +744,25 @@ static void gd_resize_event(GtkGLArea *area, =20 #endif =20 +/* + * If available, return the refresh rate of the display in milli-Hertz, + * else return 0. + */ +static int gd_refresh_rate_millihz(GtkWidget *window) +{ +#ifdef GDK_VERSION_3_22 + GdkWindow *win =3D gtk_widget_get_window(window); + + if (win) { + GdkDisplay *dpy =3D gtk_widget_get_display(window); + GdkMonitor *monitor =3D gdk_display_get_monitor_at_window(dpy, win= ); + + return gdk_monitor_get_refresh_rate(monitor); + } +#endif + return 0; +} + static gboolean gd_draw_event(GtkWidget *widget, cairo_t *cr, void *opaque) { VirtualConsole *vc =3D opaque; @@ -751,6 +770,7 @@ static gboolean gd_draw_event(GtkWidget *widget, cairo_= t *cr, void *opaque) int mx, my; int ww, wh; int fbw, fbh; + int refresh_rate_millihz; =20 #if defined(CONFIG_OPENGL) if (vc->gfx.gls) { @@ -771,6 +791,12 @@ static gboolean gd_draw_event(GtkWidget *widget, cairo= _t *cr, void *opaque) return FALSE; } =20 + refresh_rate_millihz =3D gd_refresh_rate_millihz(vc->window ? + vc->window : s->window); + if (refresh_rate_millihz) { + vc->gfx.dcl.update_interval =3D MILLISEC_PER_SEC / refresh_rate_mi= llihz; + } + fbw =3D surface_width(vc->gfx.ds); fbh =3D surface_height(vc->gfx.ds); =20 @@ -1949,31 +1975,11 @@ static GtkWidget *gd_create_menu_machine(GtkDisplay= State *s) return machine_menu; } =20 -/* - * If available, return the refresh rate of the display in milli-Hertz, - * else return 0. - */ -static int gd_refresh_rate_millihz(GtkWidget *window) -{ -#ifdef GDK_VERSION_3_22 - GdkWindow *win =3D gtk_widget_get_window(window); - - if (win) { - GdkDisplay *dpy =3D gtk_widget_get_display(window); - GdkMonitor *monitor =3D gdk_display_get_monitor_at_window(dpy, win= ); - - return gdk_monitor_get_refresh_rate(monitor); - } -#endif - return 0; -} - static GSList *gd_vc_gfx_init(GtkDisplayState *s, VirtualConsole *vc, QemuConsole *con, int idx, GSList *group, GtkWidget *view_menu) { bool zoom_to_fit =3D false; - int refresh_rate_millihz; =20 vc->label =3D qemu_console_get_label(con); vc->s =3D s; @@ -2031,12 +2037,6 @@ static GSList *gd_vc_gfx_init(GtkDisplayState *s, Vi= rtualConsole *vc, vc->gfx.kbd =3D qkbd_state_init(con); vc->gfx.dcl.con =3D con; =20 - refresh_rate_millihz =3D gd_refresh_rate_millihz(vc->window ? - vc->window : s->window); - if (refresh_rate_millihz) { - vc->gfx.dcl.update_interval =3D MILLISEC_PER_SEC / refresh_rate_mi= llihz; - } - register_displaychangelistener(&vc->gfx.dcl); =20 gd_connect_vc_gfx_signals(vc); --=20 2.27.0