From nobody Sat May 18 15:38:14 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1598637872; cv=none; d=zohomail.com; s=zohoarc; b=N4dv19WzcnSL6nQ760QKFMZZFx5IYniD6qFdAez95rILdKDvba/M+dGqLMMx6clOakdJ823ACeMttCPlOB3/yNr3n4EgEp4mFF5s2kD52YMuPCfE8hyl4uZT9jX+99H3xrlr35NtqXyPibTbapPCtLVnvc43jWErflrRzGFmTPI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598637872; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=DZszukU5Z/VedP7Gi8MxkvM7fSfNSRPJAs1Yn+4Y17M=; b=XFurZhTY5hGcdIScVahoVjBqNdeyAa3HGwoiiCcWgQi8Rhzak5f8lSQfUUWUCmWdyL93bQzb9jlY8lQqMhGIVTN1P7iX3nq3ID/QcvryAT+ZQGS3+KtBDVaiSijKeWKDOSdY2gtURIz4efj0xmU3OBz8IZ+UlfB4e+Q2VxZl0Tw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1598637872099638.2616048871654; Fri, 28 Aug 2020 11:04:32 -0700 (PDT) Received: from localhost ([::1]:45868 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBijn-0002uu-7k for importer@patchew.org; Fri, 28 Aug 2020 14:04:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51406) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBiiA-0001Kc-3E for qemu-devel@nongnu.org; Fri, 28 Aug 2020 14:02:50 -0400 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]:38839) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kBii8-0002HA-FO for qemu-devel@nongnu.org; Fri, 28 Aug 2020 14:02:49 -0400 Received: by mail-pl1-x641.google.com with SMTP id t11so29328plr.5 for ; Fri, 28 Aug 2020 11:02:48 -0700 (PDT) Received: from localhost.localdomain ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id w14sm41656pfi.211.2020.08.28.11.02.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Aug 2020 11:02:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=DZszukU5Z/VedP7Gi8MxkvM7fSfNSRPJAs1Yn+4Y17M=; b=pgDpj8RMQnzchc4VU898wPTuz0IG0elIuqpcdNREwyfQazG+mQP+pAmTCzcZO0iBrZ uZDYmOwCBar5VVIXWzzkWCIRuEGm7gDwP+t2AH0hNSfEUd9CHafH1Mc3o4K1GvkFX+Iy 2jhdl6PVhRmPmwP2WssvlLH7pNyX87ApnbFuIBIQN2d+wn0lcM32nmjQUeD6bt6yr0Ot +HLcN4yBrwQ2XdfRZeWkV6KzwvbcZbN2GF0Z+yvirHyd09fP7TzwTVNhKjR5W4DIC90Q vdKfDWcZdS4m886OcsKFX+hWqDz8SH1cZKz2ZeXAqAaYeTf4S/VxKAarufASZqQ1jXlD EdIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DZszukU5Z/VedP7Gi8MxkvM7fSfNSRPJAs1Yn+4Y17M=; b=dAkj4hOOxxaGnVh/fWBeJRw84Mh2C3lHEgDcqpcyaooPxmYzuAf/IV3qC4sVZiQI3/ bPoL4tRTAMXmwvBkTjANgcPjgHGus989PalmuEvQhdvRQU7m0D57sl36jKQynRoaU4ZQ qK2OtYVF09Z+/bEz6i6sKp7+9uoTMYQVlQDjnwXqRFUQLVP+65hOdXklEAO8SRxTckeR OJs4oFEWbcP5ggLcSN+xOUFPP10xBPPl8F7ociFGktfehhCCWqD5a3tD/Ghlyj9TOrnO CHQh1Gr1lBERCBwcfaddik3Au0Pksm4rM/DNbk8Nde1JMBWOt8MHJMbTM3SjHlO86SpY GAEg== X-Gm-Message-State: AOAM5311N8+qnNrHCagyVpmHdr9WAKZOnQXXroTlBi06+AozP3YOEieu KtH/i2YrIItoJxl9LXTXrOnW/7L5icEXWw== X-Google-Smtp-Source: ABdhPJy2AO1cDvIKPeCQSm40tX4Ne11oTcOvrCGY6TuOoCSYrE8XwL1T1Zb1XnMTqwpMwsstIkv7yQ== X-Received: by 2002:a17:90a:bc09:: with SMTP id w9mr182920pjr.43.1598637766597; Fri, 28 Aug 2020 11:02:46 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 1/3] softmmu/cpus: Only set parallel_cpus for SMP Date: Fri, 28 Aug 2020 11:02:41 -0700 Message-Id: <20200828180243.443016-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200828180243.443016-1-richard.henderson@linaro.org> References: <20200828180243.443016-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::641; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x641.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" Do not set parallel_cpus if there is only one cpu instantiated. This will allow tcg to use serial code to implement atomics. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- softmmu/cpus.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/softmmu/cpus.c b/softmmu/cpus.c index a802e899ab..e3b98065c9 100644 --- a/softmmu/cpus.c +++ b/softmmu/cpus.c @@ -1895,6 +1895,16 @@ static void qemu_tcg_init_vcpu(CPUState *cpu) if (!tcg_region_inited) { tcg_region_inited =3D 1; tcg_region_init(); + /* + * If MTTCG, and we will create multiple cpus, + * then we will have cpus running in parallel. + */ + if (qemu_tcg_mttcg_enabled()) { + MachineState *ms =3D MACHINE(qdev_get_machine()); + if (ms->smp.max_cpus > 1) { + parallel_cpus =3D true; + } + } } =20 if (qemu_tcg_mttcg_enabled() || !single_tcg_cpu_thread) { @@ -1904,7 +1914,6 @@ static void qemu_tcg_init_vcpu(CPUState *cpu) =20 if (qemu_tcg_mttcg_enabled()) { /* create a thread per vCPU with TCG (MTTCG) */ - parallel_cpus =3D true; snprintf(thread_name, VCPU_THREAD_NAME_SIZE, "CPU %d/TCG", cpu->cpu_index); =20 --=20 2.25.1 From nobody Sat May 18 15:38:14 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1598637874; cv=none; d=zohomail.com; s=zohoarc; b=H7RzWA6yfxDn+31sq7tc6peftOUOhJHWddX8u106VYCSr2IGWna+PtTF/223Blu+wFKtFi69Re76ci1Fb6+2H8q5ZJabsEMjE33Xb3LWJO6K9Vrm5xY+HezgTaxQnsvP71AGPr13em8+rXvb29Vyb0aF0EKmNheN/40qusFteMY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598637874; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VyJnYP7qAols/iC/DSxuiqYaX1lrROChX36Ffe0CjsQ=; b=JY3QPHzgHkqpG+ySpzDdWLrQZD1vVvKJI1BagBbUZDHnLHYZH8qJVGkMXmjE36hMQNDIHFWwiR/SmtyCytcF0xc+jQGGu1YVRB1SwbiG3hLy1aKWKvD8UbAJunlFDyDwRZrADKrW/ERueprrAfgkyzVcWIZGG6dCmBTX8RvhCKM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 159863787488584.17321379753128; Fri, 28 Aug 2020 11:04:34 -0700 (PDT) Received: from localhost ([::1]:46052 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBijp-0002zb-R2 for importer@patchew.org; Fri, 28 Aug 2020 14:04:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51430) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBiiB-0001NN-Br for qemu-devel@nongnu.org; Fri, 28 Aug 2020 14:02:51 -0400 Received: from mail-pj1-x1042.google.com ([2607:f8b0:4864:20::1042]:50839) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kBii9-0002HK-J7 for qemu-devel@nongnu.org; Fri, 28 Aug 2020 14:02:51 -0400 Received: by mail-pj1-x1042.google.com with SMTP id i13so93276pjv.0 for ; Fri, 28 Aug 2020 11:02:49 -0700 (PDT) Received: from localhost.localdomain ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id w14sm41656pfi.211.2020.08.28.11.02.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Aug 2020 11:02:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=VyJnYP7qAols/iC/DSxuiqYaX1lrROChX36Ffe0CjsQ=; b=Xsqp2k2qBPtA8+olX+1YI0tuJcxzPTIIOF4OVphA373zeaF4z4eO4eqoa+WVCKsOPn YFojTm14v/lF5tlvk9XMZ3f3hXjPD7PNx/sP1cTkoK91X1dP3OZCNApnS8DvF9ZJQEb9 29P9qPD//jXpdq3lmQO5qKPLU5g/pBiZ3dRSE7LM+hNJNHbn0uB2FI1ECFFB6CjHOT+M iJqCGWkLxCBCdE0NA5Unvir4Ur0+yIPHr2KPe+L3lJ+9BagxFCAyF5d3hncLeSxy22ls RnB4icsi94nk3zZdpRSrXUq7kOOqe25ubbIBjTm6MXp/7R7blIe6rxdVFoAjahUi6iKw 9a7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VyJnYP7qAols/iC/DSxuiqYaX1lrROChX36Ffe0CjsQ=; b=NPEXIV6tCtAYxYiug/BQa+wQSp8L5h4neVncujsN+klxSGDTxHsokM2oQhZqDVOmPl ELG7LuPazg11cghM8XZgp8a1NSRocx+zyUiYO3nrFrP9hOiV5JFeB4cwQFV5GJ9+yU42 EZkLZMlD+ypXu+CHhdaFQQ0OcG82+b/05ffZtmsKuumbpfWxkWziscN7qC2J6awn7K5W RuwphrBtYiCl7vVxNma9kTmp2C5xwz9iTGERb6yXs9nyGfFJ6S8p3xh7JoXRtVlcRPCy ENYOaTP7E8tZmsbS+wtMIfSiWXLmM0xl8j+FnvSxv2bgu0RzBR5rDbeZUPqeKUW2u/Rt PUag== X-Gm-Message-State: AOAM533TJtirvO+DE03ZFoPMuyNqqZ9u77VCs1Td3PsUAasR6Ww/PgX7 mEqpKfI5IWoVdV2VFfNArLTsXOEMXLm/KA== X-Google-Smtp-Source: ABdhPJxDdGzi2BVho6DoQiJm5CAhnFrh+V23N2HqYmbPKBZvcVI6WNQM4aZAW0e+6eOS3K5h3gXc1Q== X-Received: by 2002:a17:90b:4b03:: with SMTP id lx3mr167302pjb.143.1598637767860; Fri, 28 Aug 2020 11:02:47 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 2/3] tcg: Eliminate one store for in-place 128-bit dup_mem Date: Fri, 28 Aug 2020 11:02:42 -0700 Message-Id: <20200828180243.443016-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200828180243.443016-1-richard.henderson@linaro.org> References: <20200828180243.443016-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1042; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1042.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" Do not store back to the exact memory from which we just loaded. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- tcg/tcg-op-gvec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tcg/tcg-op-gvec.c b/tcg/tcg-op-gvec.c index 793d4ba64c..fcc25b04e6 100644 --- a/tcg/tcg-op-gvec.c +++ b/tcg/tcg-op-gvec.c @@ -1581,7 +1581,7 @@ void tcg_gen_gvec_dup_mem(unsigned vece, uint32_t dof= s, uint32_t aofs, TCGv_vec in =3D tcg_temp_new_vec(TCG_TYPE_V128); =20 tcg_gen_ld_vec(in, cpu_env, aofs); - for (i =3D 0; i < oprsz; i +=3D 16) { + for (i =3D (aofs =3D=3D dofs) * 16; i < oprsz; i +=3D 16) { tcg_gen_st_vec(in, cpu_env, dofs + i); } tcg_temp_free_vec(in); @@ -1591,7 +1591,7 @@ void tcg_gen_gvec_dup_mem(unsigned vece, uint32_t dof= s, uint32_t aofs, =20 tcg_gen_ld_i64(in0, cpu_env, aofs); tcg_gen_ld_i64(in1, cpu_env, aofs + 8); - for (i =3D 0; i < oprsz; i +=3D 16) { + for (i =3D (aofs =3D=3D dofs) * 16; i < oprsz; i +=3D 16) { tcg_gen_st_i64(in0, cpu_env, dofs + i); tcg_gen_st_i64(in1, cpu_env, dofs + i + 8); } --=20 2.25.1 From nobody Sat May 18 15:38:14 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1598637878; cv=none; d=zohomail.com; s=zohoarc; b=QLhSOc7lbg3bjtM20M3ereVaJQPb5i+OqIPGBqXTaV6Ecy2nR7F94EJojN2Ql5gDO0KG5yRww5yxdrt4I6haqotGN9iL9Rkw/lMqLvlXeAjLukB72o/SD16NKAZhzaWZfCRlpmm1oer43T9uHTxQeB8AOpQ1dh690Do2XzFaHhY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598637878; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=al4HxnT9REeNzlCVwjlrJn8dPB8N3tcD/YiO2+sLUwI=; b=GlmDigfx6Sow06xKEaeJv9MRGJi8bFR7vfVbQHiBPg25NhFyQkpkOtYeJ5DMd7pX3wA0t5x0Dn3LIaJjN9nRHzsNcO+pv4uvYRQVDvKE1JQU5yCqNBQ9h6hbZSyH7h9AYveidv9WaBQTL9fXMTwTzFG1ttWtnxoyk9eGkxaWt3I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1598637878719558.0739847707255; Fri, 28 Aug 2020 11:04:38 -0700 (PDT) Received: from localhost ([::1]:46392 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBijt-00039W-Ll for importer@patchew.org; Fri, 28 Aug 2020 14:04:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51448) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBiiC-0001QT-QE for qemu-devel@nongnu.org; Fri, 28 Aug 2020 14:02:52 -0400 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]:47019) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kBiiB-0002Ic-1p for qemu-devel@nongnu.org; Fri, 28 Aug 2020 14:02:52 -0400 Received: by mail-pl1-x632.google.com with SMTP id k13so9659plk.13 for ; Fri, 28 Aug 2020 11:02:50 -0700 (PDT) Received: from localhost.localdomain ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id w14sm41656pfi.211.2020.08.28.11.02.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Aug 2020 11:02:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=al4HxnT9REeNzlCVwjlrJn8dPB8N3tcD/YiO2+sLUwI=; b=d04X5wX9rCdT+fojg5bMJ5ellBegC4ckJKn9ZhNbyavThE3HeIkgkuAMDiklcnJrPs awPPHcaIxN3+lqKLOTFs1RFxYaKi7iIbUOtNLFF8Ms7SdyraBl4TRXTmkabiqGxBlccl vs38iLCq+4JRk8HygSx5ObgJkxAD2X2ZwekPFhJT9ywRwVMmTWq8za74J+SkFs8ylLga 7eB3vboSiWYZtvTR4RmTslOHz2Jph5vnE86J2u739P+9p6qQKtNpqFnjcVmp3Gbv7ZSX mTVEpKacIj+U+LwwPl3fYRTJhxLxVZ0HAblxb0xEoo8BYjxhZzazUEbaMstm/UdkhGAB I9WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=al4HxnT9REeNzlCVwjlrJn8dPB8N3tcD/YiO2+sLUwI=; b=RV8zlctH77MIL1N3X9MXnHQzRRrsDYgy2N+1Zs7Dke6MH89p+bcxE0YLJRop3gfYxL oZ1XO6Bov6aYDmzUhPXIdNAmEWANQK6Zcl1r+ULBub+xR0hGxTUwgcSzVGxrRPdlfYcU LSU8X20bBjiQPSTkSN3MAZAShRknbohTXTGPtty2o6fshqTtnPp2HdCjLvn5fmRAohLE Ycb2GD60Bk33W9CwffLicaYWaju+5ADA0DGVMq32E5lNYN0ImMPXkOeuZ8L3VLGcujoL 47QitZRd6PMNLDAo+1B5+CJ4yvpbtnsBGILX3fQa9/ac+AHod/ZQ/5HNiYMIZUsZ7cLv 7O5w== X-Gm-Message-State: AOAM530cRyMRRzoIHuwegYmMJlPf46y1X5bzE3RHSMiBZ54k2eSu//d7 c2XsioJjzlWID93hjxtXWID9bqAopXUa0g== X-Google-Smtp-Source: ABdhPJz7FaEE5EgbQ4jn/TAXnXcelBGTGQIOEoWfKk19ut4uPZdhP5+K1qSgWyK+cgzeitPV5DHhmg== X-Received: by 2002:a17:90a:1992:: with SMTP id 18mr170930pji.135.1598637769136; Fri, 28 Aug 2020 11:02:49 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 3/3] tcg: Implement 256-bit dup for tcg_gen_gvec_dup_mem Date: Fri, 28 Aug 2020 11:02:43 -0700 Message-Id: <20200828180243.443016-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200828180243.443016-1-richard.henderson@linaro.org> References: <20200828180243.443016-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::632; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x632.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" We already support duplication of 128-bit blocks. This extends that support to 256-bit blocks. This will be needed by SVE2. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- tcg/tcg-op-gvec.c | 52 ++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 49 insertions(+), 3 deletions(-) diff --git a/tcg/tcg-op-gvec.c b/tcg/tcg-op-gvec.c index fcc25b04e6..7ebd9e8298 100644 --- a/tcg/tcg-op-gvec.c +++ b/tcg/tcg-op-gvec.c @@ -1570,12 +1570,10 @@ void tcg_gen_gvec_dup_mem(unsigned vece, uint32_t d= ofs, uint32_t aofs, do_dup(vece, dofs, oprsz, maxsz, NULL, in, 0); tcg_temp_free_i64(in); } - } else { + } else if (vece =3D=3D 4) { /* 128-bit duplicate. */ - /* ??? Dup to 256-bit vector. */ int i; =20 - tcg_debug_assert(vece =3D=3D 4); tcg_debug_assert(oprsz >=3D 16); if (TCG_TARGET_HAS_v128) { TCGv_vec in =3D tcg_temp_new_vec(TCG_TYPE_V128); @@ -1601,6 +1599,54 @@ void tcg_gen_gvec_dup_mem(unsigned vece, uint32_t do= fs, uint32_t aofs, if (oprsz < maxsz) { expand_clr(dofs + oprsz, maxsz - oprsz); } + } else if (vece =3D=3D 5) { + /* 256-bit duplicate. */ + int i; + + tcg_debug_assert(oprsz >=3D 32); + tcg_debug_assert(oprsz % 32 =3D=3D 0); + if (TCG_TARGET_HAS_v256) { + TCGv_vec in =3D tcg_temp_new_vec(TCG_TYPE_V256); + + tcg_gen_ld_vec(in, cpu_env, aofs); + for (i =3D (aofs =3D=3D dofs) * 32; i < oprsz; i +=3D 32) { + tcg_gen_st_vec(in, cpu_env, dofs + i); + } + tcg_temp_free_vec(in); + } else if (TCG_TARGET_HAS_v128) { + TCGv_vec in0 =3D tcg_temp_new_vec(TCG_TYPE_V128); + TCGv_vec in1 =3D tcg_temp_new_vec(TCG_TYPE_V128); + + tcg_gen_ld_vec(in0, cpu_env, aofs); + tcg_gen_ld_vec(in1, cpu_env, aofs + 16); + for (i =3D (aofs =3D=3D dofs) * 32; i < oprsz; i +=3D 32) { + tcg_gen_st_vec(in0, cpu_env, dofs + i); + tcg_gen_st_vec(in1, cpu_env, dofs + i + 16); + } + tcg_temp_free_vec(in0); + tcg_temp_free_vec(in1); + } else { + TCGv_i64 in[4]; + int j; + + for (j =3D 0; j < 4; ++j) { + in[j] =3D tcg_temp_new_i64(); + tcg_gen_ld_i64(in[j], cpu_env, aofs + j * 8); + } + for (i =3D (aofs =3D=3D dofs) * 32; i < oprsz; i +=3D 32) { + for (j =3D 0; j < 4; ++j) { + tcg_gen_st_i64(in[j], cpu_env, dofs + i + j * 8); + } + } + for (j =3D 0; j < 4; ++j) { + tcg_temp_free_i64(in[j]); + } + } + if (oprsz < maxsz) { + expand_clr(dofs + oprsz, maxsz - oprsz); + } + } else { + g_assert_not_reached(); } } =20 --=20 2.25.1