From nobody Fri Dec 19 04:28:20 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1598607047; cv=none; d=zohomail.com; s=zohoarc; b=ZwY9xW3wTxIySzwvGWifYw7Iou2sMakrEc9DOZgu15hnfq8rGgsYX2EPmRXLNFFKOOuVgwaOduh6AHgt4R60Bfx95TGYdibRjrMvcYFwPtwnorf8ap0f+Al0sMpRTaMUK1z93e2WKCtE14V8WoonNulanbL5n2u2Is4iCdJcQZo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598607047; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=pXn9jEw0LzQcgHngHnQYKyL6TbEOp1hHuZtBzavzb4E=; b=ZmhmWQ0vhOHPQ4kA6a2wNQ1aCf1r0Mfd/30u36/kY6NLf3enQe1OAnfprwQvZA83CZOWfS9Uxkq2fn+6fnWP+9QxlDiCvUpYIX7J4QbnoDvOD65pWBS4m5tTHDGtZ763z67bRFlNRe1CgC6ozp/ZLcLsx5yLje8Y+B/H22VAIZM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1598607047239666.0880208080374; Fri, 28 Aug 2020 02:30:47 -0700 (PDT) Received: from localhost ([::1]:51706 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBaib-0007Cn-K2 for importer@patchew.org; Fri, 28 Aug 2020 05:30:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45962) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBacd-0004Pc-Ta for qemu-devel@nongnu.org; Fri, 28 Aug 2020 05:24:35 -0400 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:34380) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kBacc-0004IL-4G for qemu-devel@nongnu.org; Fri, 28 Aug 2020 05:24:35 -0400 Received: by mail-wr1-x442.google.com with SMTP id f7so640715wrw.1 for ; Fri, 28 Aug 2020 02:24:33 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id t13sm912304wru.65.2020.08.28.02.24.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Aug 2020 02:24:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=pXn9jEw0LzQcgHngHnQYKyL6TbEOp1hHuZtBzavzb4E=; b=AFhFyX0ZeXYCzQuTsP7Sw4MZRVoG57dFOaAUTssBGEW83KVN4HXNPKnI4An/xIkmIv 1Q8BiIX1wF6MgpF6Bo/6G6u4xVKBGGKu/iGxAbNmPO5xD6XGaYNZpNKTsjj4qxqXMkL3 BhYjD4hzCaDwnRizYcmODwoAKoA5H3CogOSQ8BXoOy4FxUG3Mgu/xHGBJkaxvBI/zSLZ juN7bGUUlj8zju9tPT7ZiprI1huSSvrp/ME/XulybEI1vg6GKXXVTSFIzlkUkXbsUJ6k OjYhZlMJDBoQcrJ5Ot1fd5upInXhwWCYprfIJnIG7Xg8I2AUHxl/efMAfmPwHQabo5Zm S8mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pXn9jEw0LzQcgHngHnQYKyL6TbEOp1hHuZtBzavzb4E=; b=WuNMD3Z5O9QL4uHrnTR+Ut+AFOid1PZBmezE0GykhyU+xCCGHcIFoTqSyjr81fy1WI WP8CtLSvXpFu8t71Uc7xfZAFxIA5TT3/Ac4JCUqwbVFR/QzeafNkerdiNVjqVM9zGH2g dqbTuA3TGb9t6TFgycq8reOobfWNDfR5XM6uUI2L8jwXxsGk8MoqyssmGyZ3wzYdNMFG wNN0oRrQ1pC7drIyV0jWJxam4MmkwVVb1O3Nbr4pm30KY2BrTvuVd+kaHmpnE1DhVzan krx3d7oK05Tc+E5KvOu6SWa1FrcIzFWPGiv1UR7d02iLDQxuDTGYkExoqm/EgEQkF2YA MGMg== X-Gm-Message-State: AOAM533Hlsp22Yo7ZR7afKqgpRj7ZqbyO/eHo62/+SiiZ+8pobDdZSdx Q/0DzU7Ku10t4N8JqVyg4cS+g0Z0+rQ0wnG4 X-Google-Smtp-Source: ABdhPJz6MqxqcixLZhphttw4mUpvDyflaYNzhlfIhJ4s9IxNmQVjMYrdZs7akhnCzeGst4vnaYMizw== X-Received: by 2002:adf:80c7:: with SMTP id 65mr618326wrl.35.1598606672501; Fri, 28 Aug 2020 02:24:32 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 15/35] hw/misc/unimp: Display value after offset Date: Fri, 28 Aug 2020 10:23:53 +0100 Message-Id: <20200828092413.22206-16-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200828092413.22206-1-peter.maydell@linaro.org> References: <20200828092413.22206-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::442; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x442.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) From: Philippe Mathieu-Daud=C3=A9 To better align the read/write accesses, display the value after the offset (read accesses only display the offset). Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-id: 20200812190206.31595-2-f4bug@amsat.org Signed-off-by: Peter Maydell --- hw/misc/unimp.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/misc/unimp.c b/hw/misc/unimp.c index bc4084d344e..ee2e536c8b1 100644 --- a/hw/misc/unimp.c +++ b/hw/misc/unimp.c @@ -22,7 +22,7 @@ static uint64_t unimp_read(void *opaque, hwaddr offset, u= nsigned size) { UnimplementedDeviceState *s =3D UNIMPLEMENTED_DEVICE(opaque); =20 - qemu_log_mask(LOG_UNIMP, "%s: unimplemented device read " + qemu_log_mask(LOG_UNIMP, "%s: unimplemented device read " "(size %d, offset 0x%" HWADDR_PRIx ")\n", s->name, size, offset); return 0; @@ -34,9 +34,9 @@ static void unimp_write(void *opaque, hwaddr offset, UnimplementedDeviceState *s =3D UNIMPLEMENTED_DEVICE(opaque); =20 qemu_log_mask(LOG_UNIMP, "%s: unimplemented device write " - "(size %d, value 0x%" PRIx64 - ", offset 0x%" HWADDR_PRIx ")\n", - s->name, size, value, offset); + "(size %d, offset 0x%" HWADDR_PRIx + ", value 0x%" PRIx64 ")\n", + s->name, size, offset, value); } =20 static const MemoryRegionOps unimp_ops =3D { --=20 2.20.1