From nobody Sun Nov 16 04:02:27 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1598538234; cv=none; d=zohomail.com; s=zohoarc; b=Awf6z/+Vw+IMjTeZ05Df83PBMr4HAofSQ8/fKUIY2T9DT9YWPaTMP9XZ7W1EqETCg4o7Cm4JC+BHz0WTnDHUWN3P6YVw4mHySrYdS8UsR1CswJ/aPK2n3uglossO6ETEepTRFgRAueYFnr3gOuIYQ5fY5q/isLm7bcjgDQ+FU+k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598538234; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=iXeCFKhJr5VHWF8iqZzpuXLLKSb9/Kc70vN+Jyf2Zzg=; b=I6IR3VJeY/I3LpmQ0l3yS6D1LuckhXTmfzRDRWop5nAHtmvLXCJ/W2tgo4HYe1CnSI9IbHxLBP4V918c2sMzXBptII1sNEyOC8vdhZ1SJomkiB8xW8fiHQzncIvqoHvsqvim6nqL+og3L+nwMnNcSCXN46zRIJh73OIiHBfbdg0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1598538234156345.9479308912804; Thu, 27 Aug 2020 07:23:54 -0700 (PDT) Received: from localhost ([::1]:37548 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBIoi-00075j-Nu for importer@patchew.org; Thu, 27 Aug 2020 10:23:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58644) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBIoA-0006gn-W1 for qemu-devel@nongnu.org; Thu, 27 Aug 2020 10:23:19 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:56060 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kBIo9-0003DF-0n for qemu-devel@nongnu.org; Thu, 27 Aug 2020 10:23:18 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-165-rgZsz7FANa2Tp1pL6DmBbw-1; Thu, 27 Aug 2020 10:23:06 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7F16718B9EC3; Thu, 27 Aug 2020 14:23:05 +0000 (UTC) Received: from localhost (ovpn-115-8.ams2.redhat.com [10.36.115.8]) by smtp.corp.redhat.com (Postfix) with ESMTP id 068145D9E8; Thu, 27 Aug 2020 14:23:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598538195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iXeCFKhJr5VHWF8iqZzpuXLLKSb9/Kc70vN+Jyf2Zzg=; b=VNL1/5v9NwSP50Xxu56l/lr61jRVIFeLbWNCg8njDVk9sKlETAcqyN5p9h72NntSghspqy PinIdKR4K2S2mRkMrRX0c5vkiz1oTh+mF1Idmyno4R9xOCZVtOOrDhO/XPtkErQ639UXGx IGOLmkVIWj1AUHfti/H8so20/YUv3XQ= X-MC-Unique: rgZsz7FANa2Tp1pL6DmBbw-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PATCH] meson: fix SystemTap Unknown variable "exe_name" Date: Thu, 27 Aug 2020 15:22:45 +0100 Message-Id: <20200827142245.108147-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.120; envelope-from=stefanha@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/27 02:56:52 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.959, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MIME_BASE64_TEXT=1.741, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Stefan Hajnoczi , Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The SystemTap tapset generation code used a stale variable name 'exe_name'. This caused the following meson error: Unknown variable "exe_name" The variable should be exe['name']. This fixes ./configure --enable-trace-backend=3Ddtrace with SystemTap. Reported-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- meson.build | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/meson.build b/meson.build index f0fe5f8799..f2aa5a7700 100644 --- a/meson.build +++ b/meson.build @@ -1029,14 +1029,14 @@ foreach target : target_dirs =20 if 'CONFIG_TRACE_SYSTEMTAP' in config_host foreach stp: [ - {'ext': '.stp-build', 'fmt': 'stap', 'bin': meson.current_build_di= r() / exe_name, 'install': false}, - {'ext': '.stp', 'fmt': 'stap', 'bin': get_option('prefix') / get_o= ption('bindir') / exe_name, 'install': true}, + {'ext': '.stp-build', 'fmt': 'stap', 'bin': meson.current_build_di= r() / exe['name'], 'install': false}, + {'ext': '.stp', 'fmt': 'stap', 'bin': get_option('prefix') / get_o= ption('bindir') / exe['name'], 'install': true}, {'ext': '-simpletrace.stp', 'fmt': 'simpletrace-stap', 'bin': '', = 'install': true}, {'ext': '-log.stp', 'fmt': 'log-stap', 'bin': '', 'install': true}, ] - custom_target(exe_name + stp['ext'], + custom_target(exe['name'] + stp['ext'], input: trace_events_all, - output: exe_name + stp['ext'], + output: exe['name'] + stp['ext'], capture: true, install: stp['install'], install_dir: config_host['qemu_datadir'] / '../syste= mtap/tapset', --=20 2.26.2