From nobody Sun Nov 16 00:54:43 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1598528849; cv=none; d=zohomail.com; s=zohoarc; b=NbzAemBVfWHUN2z57ig7wZFSejqJQBwhy72LzUWFH62yzJUiFPhn2V2pOA0sGNfmYeuLinKSCrhFnmJfaC7XicCs6DIkjMFYVvNGJwXzhHeSoRdeArNGIlqkFYMbtorIDj61jjZGgHejHE9u7CRpdzkU6Otz9UVi/EWxR03L/AE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598528849; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=8tOsxx+fqigrLxDJOkhzgXsA2Ui9uyEGgNbc/S/z3OQ=; b=EUBUMe5LM6EhcRCJ2260ctpMQKhPdWFhuyXEtFAWuuCDsXOlmWsv0yfrYptGWqCRzEPz1u7O1snH7hbIzssvwg9j1Q8L+5c8vU4t90sTTv/Eua9zVFj1/ho8eQ7/htSN6Xd3BtIB7+9lCfsTFzJLl51y4FeQovfhcu0mvs5b1v4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1598528848994395.31425858022124; Thu, 27 Aug 2020 04:47:28 -0700 (PDT) Received: from localhost ([::1]:53942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBGNK-0003N6-Ap for importer@patchew.org; Thu, 27 Aug 2020 07:47:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43716) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBGMg-0002kc-Q8 for qemu-devel@nongnu.org; Thu, 27 Aug 2020 07:46:46 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:47115 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kBGMe-0006w4-RB for qemu-devel@nongnu.org; Thu, 27 Aug 2020 07:46:46 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-343-qmLmxje4MfWg5pPSO4SmoQ-1; Thu, 27 Aug 2020 07:46:35 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 03663185FD78; Thu, 27 Aug 2020 11:46:34 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-91.phx2.redhat.com [10.3.112.91]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ADB735D9CC; Thu, 27 Aug 2020 11:46:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598528803; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8tOsxx+fqigrLxDJOkhzgXsA2Ui9uyEGgNbc/S/z3OQ=; b=WlaF0skqH1EK4zpOzyPJR5sfhq+793cO3mubo79LhOUVqwQVUlCtEdCO6lH0mqQBy1g1r1 T7tCA5H2Sfl7nDnYQjnlPCzQ8+R6hRVvlGjDL7qxo0TbZN8XKSm8Ohlq5YTSJyskqSS/bn Jao0y777z02Gt9f1jXQkrIkbInGuikg= X-MC-Unique: qmLmxje4MfWg5pPSO4SmoQ-1 From: P J P To: John Snow Subject: [PATCH] hw/ide: check null block pointer before blk_drain Date: Thu, 27 Aug 2020 17:14:28 +0530 Message-Id: <20200827114428.1850912-1-ppandit@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ppandit@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.81; envelope-from=ppandit@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/27 00:53:04 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.959, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ruhr-University , QEMU Developers , qemu-block@nongnu.org, Prasad J Pandit Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Prasad J Pandit While cancelling an i/o operation via ide_cancel_dma_sync(), check for null block pointer before calling blk_drain(). Avoid null pointer dereference. -> https://ruhr-uni-bochum.sciebo.de/s/NNWP2GfwzYKeKwE?path=3D%2Fide_nullp= tr1 =3D=3D1803100=3D=3DHint: address points to the zero page. #0 blk_bs ../block/block-backend.c:714 #1 blk_drain ../block/block-backend.c:1715 #2 ide_cancel_dma_sync ../hw/ide/core.c:723 #3 bmdma_cmd_writeb ../hw/ide/pci.c:298 #4 bmdma_write ../hw/ide/piix.c:75 #5 memory_region_write_accessor ../softmmu/memory.c:483 #6 access_with_adjusted_size ../softmmu/memory.c:544 #7 memory_region_dispatch_write ../softmmu/memory.c:1465 #8 flatview_write_continue ../exec.c:3176 ... Reported-by: Ruhr-University Signed-off-by: Prasad J Pandit --- hw/ide/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index d997a78e47..038af1cd6b 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -718,7 +718,7 @@ void ide_cancel_dma_sync(IDEState *s) * whole DMA operation will be submitted to disk with a single * aio operation with preadv/pwritev. */ - if (s->bus->dma->aiocb) { + if (s->blk && s->bus->dma->aiocb) { trace_ide_cancel_dma_sync_remaining(); blk_drain(s->blk); assert(s->bus->dma->aiocb =3D=3D NULL); --=20 2.26.2