From nobody Tue Feb 10 02:00:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1598526616; cv=none; d=zohomail.com; s=zohoarc; b=Teq4rwdfDKjfGKuGSzv0aCwUxDmRDOnj3Fhh5bXtdogEbXjtobdWlPplsr5hn7w5TrcDgNnPfH8mZG/czT02uiv9MYZOPbvaBvtDlB6VFKvrUwFKy6NOI9QSBvHiMDDSbDA6vAUgriJmXvmWixJH3MEglbTlR7XQuM/Vp4ufTEo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598526616; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VRsW0ko/o6Vwl34rY7vRG2up1M814rhQ+ycMxHHVmDM=; b=O0PSRziLgBslCmc5nLO19TRRvPB6pWOkpUMJYpKmX++PlI36/R4pGGx8LCT3aI3hiMDXlbCUk+b13W0+vURGawRZr6CvW/fF/ACGu2u1L62CStVDsMS1uwjbk+iatrbI3IKc1dX9bpBpt5zI0NVv0yTldnRU7ST9xU4kNQJ0sy8= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 159852661614646.74420601823351; Thu, 27 Aug 2020 04:10:16 -0700 (PDT) Received: from localhost ([::1]:39696 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBFnK-0005YT-8m for importer@patchew.org; Thu, 27 Aug 2020 07:10:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51152) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBFiJ-0004iU-9n; Thu, 27 Aug 2020 07:05:06 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:4663 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBFiG-0007aF-PP; Thu, 27 Aug 2020 07:05:03 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 54DA8EB59F40A3DDEFF0; Thu, 27 Aug 2020 19:04:56 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Thu, 27 Aug 2020 19:04:46 +0800 From: Chen Qun To: , Subject: [PATCH v3 08/10] usb/bus: Remove dead assignment in usb_get_fw_dev_path() Date: Thu, 27 Aug 2020 19:03:09 +0800 Message-ID: <20200827110311.164316-9-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20200827110311.164316-1-kuhn.chenqun@huawei.com> References: <20200827110311.164316-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=kuhn.chenqun@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/27 02:12:47 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, pannengyuan@huawei.com, Markus Armbruster , Gerd Hoffmann , Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: qemu/hw/usb/bus.c:615:13: warning: Value stored to 'pos' is never read pos +=3D snprintf(fw_path + pos, fw_len - pos, "%s@%lx", Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Markus Armbruster Reviewed-by: Gerd Hoffmann --- Cc: Gerd Hoffmann Cc: Markus Armbruster v2->v3: The format of the snprintf statement is modified(Base on Markus rev= iew). --- hw/usb/bus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/usb/bus.c b/hw/usb/bus.c index b17bda3b29..2b11041451 100644 --- a/hw/usb/bus.c +++ b/hw/usb/bus.c @@ -612,8 +612,8 @@ static char *usb_get_fw_dev_path(DeviceState *qdev) in++; } else { /* the device itself */ - pos +=3D snprintf(fw_path + pos, fw_len - pos, "%s@%lx", - qdev_fw_name(qdev), nr); + snprintf(fw_path + pos, fw_len - pos, "%s@%lx", + qdev_fw_name(qdev), nr); break; } } --=20 2.23.0