From nobody Tue Feb 10 06:57:59 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1598526664; cv=none; d=zohomail.com; s=zohoarc; b=Wzdn7vb/6hkcDnMh+elPmfq7Um9Nb5od5xx7JqiNSZ8B3Vw7vaETS3/9hagENRTsMlYJteWEV+L5thiyW/e4110iBuMv8e4NSpq74W3+RqmFVhf82M+ZHicnoqL196GvyQeGVaK+wsxKZALaD42CcVtsLoQG2XPlEjfQqUhQcRw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598526664; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nzEQ2cAgXY4pl78GIGciJmkO2mp6KfG6vAyAPn1Gos0=; b=c/AVKMe9YcxycxEjRY1TSE0Htxe6Gfg/DEwJaerV/bdPU5JP5LKpMs/ARjHs+XGLMCrutMq1PnonVgcz2Tttb2ZN0cRZvxoDVK3iXgMkZiq8mAVech5sgG/BWp8lZpkkpfzMYgM6PoPVafbjZKliqqn7teKP46vwWQF5MjH1rlY= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1598526664649867.493282379126; Thu, 27 Aug 2020 04:11:04 -0700 (PDT) Received: from localhost ([::1]:42172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBFo7-0006es-AE for importer@patchew.org; Thu, 27 Aug 2020 07:11:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51150) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBFiJ-0004iC-35; Thu, 27 Aug 2020 07:05:06 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:4664 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBFiG-0007aG-OG; Thu, 27 Aug 2020 07:05:02 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 5D581C9810B99A41AAEB; Thu, 27 Aug 2020 19:04:56 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Thu, 27 Aug 2020 19:04:49 +0800 From: Chen Qun To: , Subject: [PATCH v3 10/10] hw/display/vga:Remove redundant statement in vga_draw_graphic() Date: Thu, 27 Aug 2020 19:03:11 +0800 Message-ID: <20200827110311.164316-11-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20200827110311.164316-1-kuhn.chenqun@huawei.com> References: <20200827110311.164316-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=kuhn.chenqun@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/27 02:12:47 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, pannengyuan@huawei.com, Li Qiang , Gerd Hoffmann , Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: hw/display/vga.c:1677:9: warning: Value stored to 'update' is never read update =3D full_update; ^ ~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Gerd Hoffmann Reviewed-by: Li Qiang --- Cc: Gerd Hoffmann --- hw/display/vga.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/display/vga.c b/hw/display/vga.c index 061fd9ab8f..836ad50c7b 100644 --- a/hw/display/vga.c +++ b/hw/display/vga.c @@ -1674,7 +1674,6 @@ static void vga_draw_graphic(VGACommonState *s, int f= ull_update) if (!(s->cr[VGA_CRTC_MODE] & 2)) { addr =3D (addr & ~0x8000) | ((y1 & 2) << 14); } - update =3D full_update; page0 =3D addr & s->vbe_size_mask; page1 =3D (addr + bwidth - 1) & s->vbe_size_mask; if (full_update) { --=20 2.23.0