From nobody Fri May 17 09:18:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1598526375; cv=none; d=zohomail.com; s=zohoarc; b=YaUqgR+hkW9JVglHEP1eYCIiIqtuZ8/RgqRX1xsufV5lCxYgDTRk3T2Nv94kSxdxR9zaQd6lG+OyvXxqoCQcJ5W5VwCV9WpM5ZwLZ0BRhwsWKk9zX6Nt5tU1jVIbRjxosCEJ8WscFPGEzUXgJLwwIG5REdyPWJQxEjKRLETgPxw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598526375; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=F7w0cdQGqE+alPXXcYsyddG5YfckdHtI63p3drBcw+E=; b=i7ELfjsgxrw6bTBoknrIxNrwHvp28t1t6yqTK02cGrQNqkbUxKQ8gN+xILXZGrWKgJQpUBX/flaYIXCV0/Aqeef+y0neFmJkJrt5pP8B7MKoj5QzM6Av11mwcks6/XMDLslXHdErjzu/t79S+rS2m9PkY9o2/++aXQloHCx6HCQ= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 159852637515497.31122151962154; Thu, 27 Aug 2020 04:06:15 -0700 (PDT) Received: from localhost ([::1]:49098 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBFjR-0006JV-RI for importer@patchew.org; Thu, 27 Aug 2020 07:06:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51028) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBFi8-0004S0-IU; Thu, 27 Aug 2020 07:04:52 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:55878 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBFi6-0007YW-MO; Thu, 27 Aug 2020 07:04:52 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 7A12B32A161703756873; Thu, 27 Aug 2020 19:04:45 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Thu, 27 Aug 2020 19:04:24 +0800 From: Chen Qun To: , Subject: [PATCH v3 01/10] hw/arm/virt-acpi-build:Remove dead assignment in build_madt() Date: Thu, 27 Aug 2020 19:03:02 +0800 Message-ID: <20200827110311.164316-2-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20200827110311.164316-1-kuhn.chenqun@huawei.com> References: <20200827110311.164316-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.35; envelope-from=kuhn.chenqun@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/27 05:22:41 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , zhang.zhanghailiang@huawei.com, "Michael S. Tsirkin" , pannengyuan@huawei.com, Euler Robot , Li Qiang , Shannon Zhao , qemu-arm@nongnu.org, Igor Mammedov , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: hw/arm/virt-acpi-build.c:641:5: warning: Value stored to 'madt' is never re= ad madt =3D acpi_data_push(table_data, sizeof *madt); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Igor Mammedov Reviewed-by: Li Qiang --- Cc: Shannon Zhao Cc: Peter Maydell Cc: "Michael S. Tsirkin" Cc: Igor Mammedov Cc: qemu-arm@nongnu.org --- hw/arm/virt-acpi-build.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index 91f0df7b13..f830f9b779 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm/virt-acpi-build.c @@ -633,12 +633,11 @@ build_madt(GArray *table_data, BIOSLinker *linker, Vi= rtMachineState *vms) int madt_start =3D table_data->len; const MemMapEntry *memmap =3D vms->memmap; const int *irqmap =3D vms->irqmap; - AcpiMultipleApicTable *madt; AcpiMadtGenericDistributor *gicd; AcpiMadtGenericMsiFrame *gic_msi; int i; =20 - madt =3D acpi_data_push(table_data, sizeof *madt); + acpi_data_push(table_data, sizeof(AcpiMultipleApicTable)); =20 gicd =3D acpi_data_push(table_data, sizeof *gicd); gicd->type =3D ACPI_APIC_GENERIC_DISTRIBUTOR; --=20 2.23.0 From nobody Fri May 17 09:18:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1598526462; cv=none; d=zohomail.com; s=zohoarc; b=UNSuvcrU0hObEy5h+qILtMMU7272r7Nk/Nlpbz3GrVmY7C0S9YhrzcPM1lGu8KUvUTQ+gwDND4TvsWUzYgRciA6TNCPh3YPxG3wDrhoVkklM3KsJsm6simIpfnvBvvdiLfRPYfIA8HljewJvlt3eeheJ6hil/x+zaMP043PXKGQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598526462; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=53yy+2zpRIoQ3n3m/P42TrDw08grpiqw5i/ZO5Hnook=; b=QRNVweF4Kmng+JM0fjW2VlPO0NG8xtCsPyx+5wfd7odBDTNqPdQ64+L2YQTdUpVlI2sJIqhgzTiq97fVfWkIUmdaHez6iyazN4HddKmEB7SNRxJGg+ybcIe17qkf500em9TdwjoTwRb22El5oTljE6hboLCzjTOQh97x7+JtIo0= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1598526462413316.7433514997051; Thu, 27 Aug 2020 04:07:42 -0700 (PDT) Received: from localhost ([::1]:56598 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBFkr-0000xS-4V for importer@patchew.org; Thu, 27 Aug 2020 07:07:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51044) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBFi9-0004T4-S1; Thu, 27 Aug 2020 07:04:54 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:4279 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBFi7-0007YZ-Rg; Thu, 27 Aug 2020 07:04:53 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id AFB2A7BCA8D9987C4F8C; Thu, 27 Aug 2020 19:04:46 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Thu, 27 Aug 2020 19:04:36 +0800 From: Chen Qun To: , Subject: [PATCH v3 02/10] hw/arm/omap1:Remove redundant statement in omap_clkdsp_read() Date: Thu, 27 Aug 2020 19:03:03 +0800 Message-ID: <20200827110311.164316-3-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20200827110311.164316-1-kuhn.chenqun@huawei.com> References: <20200827110311.164316-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.191; envelope-from=kuhn.chenqun@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/27 02:09:23 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , zhang.zhanghailiang@huawei.com, pannengyuan@huawei.com, Li Qiang , qemu-arm@nongnu.org, Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: hw/arm/omap1.c:1760:15: warning: Value stored to 'cpu' during its initialization is never read CPUState *cpu =3D CPU(s->cpu); ^~~ ~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Peter Maydell Reviewed-by: Li Qiang --- Cc: Peter Maydell Cc: qemu-arm@nongnu.org --- hw/arm/omap1.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/arm/omap1.c b/hw/arm/omap1.c index 6ba0df6b6d..02c0f66431 100644 --- a/hw/arm/omap1.c +++ b/hw/arm/omap1.c @@ -1774,7 +1774,6 @@ static uint64_t omap_clkdsp_read(void *opaque, hwaddr= addr, return s->clkm.dsp_rstct2; =20 case 0x18: /* DSP_SYSST */ - cpu =3D CPU(s->cpu); return (s->clkm.clocking_scheme << 11) | s->clkm.cold_start | (cpu->halted << 6); /* Quite useless... */ } --=20 2.23.0 From nobody Fri May 17 09:18:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1598526417; cv=none; d=zohomail.com; s=zohoarc; b=bFId4qCQJnt9ObXM521OiopqY/jy+Ex2GcTFv/t1tsnRXPBZgXRm6w0cFZhPGCrzidNVIR3NO87fjNezLaDAQE+S0KgaXWpTr4xIwgzAJEdRAA6lWDvXSh3XzKjw7TZ20ea1qmlCrCdLw3GR9OnosZ75+dzrnEAtWKnnjlzRUIs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598526417; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=CnxtUdaH9UNMttja+HXa/6sJDi8VtooJ24udDqKjf4U=; b=I7jFRep85uAkIdcrRj1EXjL8sJI2GXBRqWzubiFrvMPBmgbBXAG2Se3xHCzHJqv2Bi98SQeuf2F+0WJkadavXY3UemmiWlpbnFjCGqg6HY1Q/oDNfqLBn+qxoAQDYVvUWvJUIhpMhEaB2ECAi3nC7d8ZaNt3HvP2evBICehqK9c= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1598526417147884.2273779545108; Thu, 27 Aug 2020 04:06:57 -0700 (PDT) Received: from localhost ([::1]:52396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBFk6-0007eA-RZ for importer@patchew.org; Thu, 27 Aug 2020 07:06:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51042) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBFi9-0004T1-HM; Thu, 27 Aug 2020 07:04:54 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:4714 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBFi7-0007Ya-Ns; Thu, 27 Aug 2020 07:04:53 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id B3F4B7A128B3CE8B252E; Thu, 27 Aug 2020 19:04:46 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Thu, 27 Aug 2020 19:04:37 +0800 From: Chen Qun To: , Subject: [PATCH v3 03/10] target/arm/translate-a64:Remove dead assignment in handle_scalar_simd_shli() Date: Thu, 27 Aug 2020 19:03:04 +0800 Message-ID: <20200827110311.164316-4-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20200827110311.164316-1-kuhn.chenqun@huawei.com> References: <20200827110311.164316-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.191; envelope-from=kuhn.chenqun@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/27 02:09:23 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , zhang.zhanghailiang@huawei.com, pannengyuan@huawei.com, qemu-arm@nongnu.org, Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: target/arm/translate-a64.c:8635:14: warning: Value stored to 'tcg_rn' durin= g its initialization is never read TCGv_i64 tcg_rn =3D new_tmp_a64(s); ^~~~~~ ~~~~~~~~~~~~~~ target/arm/translate-a64.c:8636:14: warning: Value stored to 'tcg_rd' durin= g its initialization is never read TCGv_i64 tcg_rd =3D new_tmp_a64(s); ^~~~~~ ~~~~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Peter Maydell --- Cc: Peter Maydell Cc: qemu-arm@nongnu.org v2->v3:According to Peter's review, the variable 's' does not have a memlea= k, so deleted the description about memleak. --- target/arm/translate-a64.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 534c3ff5f3..c83bb85e4e 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -8632,8 +8632,8 @@ static void handle_scalar_simd_shli(DisasContext *s, = bool insert, int size =3D 32 - clz32(immh) - 1; int immhb =3D immh << 3 | immb; int shift =3D immhb - (8 << size); - TCGv_i64 tcg_rn =3D new_tmp_a64(s); - TCGv_i64 tcg_rd =3D new_tmp_a64(s); + TCGv_i64 tcg_rn; + TCGv_i64 tcg_rd; =20 if (!extract32(immh, 3, 1)) { unallocated_encoding(s); --=20 2.23.0 From nobody Fri May 17 09:18:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1598526375; cv=none; d=zohomail.com; s=zohoarc; b=UzY+FnLxarSREr1nGo3Gm0GLZY71NYIzFsISfsyeUnq/dXLyEuHoaiDarfk76YLqwxVxMUKgSD8GTA/uZG6AWPjEKBJpcSek6Nr0RfrrfESFvfcc0ZLkQvl9P3e28k6RbYF3ngkAC3LlZCYexhIIDmF32UZq2PDGNFMBcKhS9+4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598526375; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=7cVyG11w/8+BZc8SG8Y6j4NjN5v3sRvqclDb9+qjVuM=; b=kAViBzne+IEiGFLabovM1ri4NHWTKgc5rsmtNMOd5cS3SZZOqk9b7mDFTe0uroSu8NGma9YmE5kcFyeZO+FEgrDG5XJsDUnigwvA1seCFeAyK/vUMHPsWIPyJKp+7NAMBBBZ+XsOCesN0Jn3zzO1hNYMwZaQ5yWkWdbpjiVmV6Y= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1598526375850972.5907057192536; Thu, 27 Aug 2020 04:06:15 -0700 (PDT) Received: from localhost ([::1]:49160 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBFjS-0006L1-Gq for importer@patchew.org; Thu, 27 Aug 2020 07:06:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51014) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBFi7-0004QV-Fr; Thu, 27 Aug 2020 07:04:51 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:4278 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBFi5-0007YX-Mo; Thu, 27 Aug 2020 07:04:51 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id AAF88638985D7F1FDEBD; Thu, 27 Aug 2020 19:04:46 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Thu, 27 Aug 2020 19:04:39 +0800 From: Chen Qun To: , Subject: [PATCH v3 04/10] target/arm/translate-a64:Remove redundant statement in disas_simd_two_reg_misc_fp16() Date: Thu, 27 Aug 2020 19:03:05 +0800 Message-ID: <20200827110311.164316-5-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20200827110311.164316-1-kuhn.chenqun@huawei.com> References: <20200827110311.164316-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.191; envelope-from=kuhn.chenqun@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/27 02:09:23 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , zhang.zhanghailiang@huawei.com, pannengyuan@huawei.com, qemu-arm@nongnu.org, Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: target/arm/translate-a64.c:13007:5: warning: Value stored to 'rd' is never = read rd =3D extract32(insn, 0, 5); ^ ~~~~~~~~~~~~~~~~~~~~~ target/arm/translate-a64.c:13008:5: warning: Value stored to 'rn' is never = read rn =3D extract32(insn, 5, 5); ^ ~~~~~~~~~~~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Peter Maydell --- Cc: Peter Maydell Cc: qemu-arm@nongnu.org --- target/arm/translate-a64.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index c83bb85e4e..47cce160d8 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -13016,9 +13016,6 @@ static void disas_simd_two_reg_misc_fp16(DisasConte= xt *s, uint32_t insn) fpop =3D deposit32(opcode, 5, 1, a); fpop =3D deposit32(fpop, 6, 1, u); =20 - rd =3D extract32(insn, 0, 5); - rn =3D extract32(insn, 5, 5); - switch (fpop) { case 0x1d: /* SCVTF */ case 0x5d: /* UCVTF */ --=20 2.23.0 From nobody Fri May 17 09:18:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1598526661; cv=none; d=zohomail.com; s=zohoarc; b=MF3q6CxsmwkiPgR7o16IeBIaSTNmofnjWSY/bn+w9mBKr64pLWgMH/NCLCWSpY32J0P/LgejQCPnCtaxmY33xncWgaAm1s8jbPwQzEiO0K5oymNw8aTwFgDAerhv0RG3YqiT4A/dqTJbDHJ8OX9vOTkja+OKk38+Mhev7VHmDkI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598526661; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+GnQgYk+px6N1qHwkd/wqpacYxRUJ6eEd5e2AFXpjys=; b=ZupxMi8Xfgio1hMlonb/e4TFnD1vb721qm9Ow3NGdf68A3/l6INy51kbxS5PIq6w/UBZfZSdUUbLVYb+Pk3+qp1iKrIFgzCxtLkiJ6NUmHlUxstdF1I7jv2TvqOTdm8zv98lcuVJm24lRunRIw1cD7PHx7BCLSmj92WQVfQx3zM= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15985266617331002.34599175053; Thu, 27 Aug 2020 04:11:01 -0700 (PDT) Received: from localhost ([::1]:41828 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBFo4-0006W0-Be for importer@patchew.org; Thu, 27 Aug 2020 07:11:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51090) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBFiF-0004bF-0U; Thu, 27 Aug 2020 07:04:59 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:4716 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBFiA-0007ZO-L0; Thu, 27 Aug 2020 07:04:58 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 4482742FB23E5C05DAF2; Thu, 27 Aug 2020 19:04:51 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Thu, 27 Aug 2020 19:04:41 +0800 From: Chen Qun To: , Subject: [PATCH v3 05/10] hw/virtio/vhost-user:Remove dead assignment in scrub_shadow_regions() Date: Thu, 27 Aug 2020 19:03:06 +0800 Message-ID: <20200827110311.164316-6-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20200827110311.164316-1-kuhn.chenqun@huawei.com> References: <20200827110311.164316-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.191; envelope-from=kuhn.chenqun@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/27 02:09:23 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, "Michael S. Tsirkin" , pannengyuan@huawei.com, Raphael Norwitz , Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: hw/virtio/vhost-user.c:606:9: warning: Value stored to 'mr' is never read mr =3D vhost_user_get_mr_data(reg->userspace_addr, &offset, &fd); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Raphael Norwitz --- Cc: "Michael S. Tsirkin" Cc: Raphael Norwitz --- hw/virtio/vhost-user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index d7e2423762..9c5b4f7fbc 100644 --- a/hw/virtio/vhost-user.c +++ b/hw/virtio/vhost-user.c @@ -603,7 +603,7 @@ static void scrub_shadow_regions(struct vhost_dev *dev, */ for (i =3D 0; i < dev->mem->nregions; i++) { reg =3D &dev->mem->regions[i]; - mr =3D vhost_user_get_mr_data(reg->userspace_addr, &offset, &fd); + vhost_user_get_mr_data(reg->userspace_addr, &offset, &fd); if (fd > 0) { ++fd_num; } --=20 2.23.0 From nobody Fri May 17 09:18:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1598526505; cv=none; d=zohomail.com; s=zohoarc; b=h+Cc0Qf99Bfw6Q4ml2YXz0Tl+t2dRVffl4VYXqT35tWcefOF5s9Z0+O44C2ygSwMSGHSbuI4IsklzESPix398wl7IO1B0jPmuIDXRRL31OY7YST0XMIveB9Pp4hXMv8rqi5UdcC1yGzl/nTqSCeTdz49yJP+BbcFCvCRPFLBou4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598526505; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=oQ3JFzjQmohugPO88pce20JLlzFeQ1An3nhZIDzuQUI=; b=KWdg/cKY8B6qi7Lc4aHGR1+NuHFW0/Kpx2EqP0OQlhLDe++VsuTC+1lDH5UXa2VBXPS5pDWwXYAgjmmI9LkTO40k5Dny4unp071YKme6/0DlhNaYybYvG3s8PPYW5K+kXhd074PTa8cnxtpjr3z2p093a7lRGUL7eP8WLexqPtw= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1598526505527438.9992572016115; Thu, 27 Aug 2020 04:08:25 -0700 (PDT) Received: from localhost ([::1]:59732 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBFlY-0002GV-79 for importer@patchew.org; Thu, 27 Aug 2020 07:08:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51096) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBFiG-0004dS-7m; Thu, 27 Aug 2020 07:05:00 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:4717 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBFiA-0007ZQ-LJ; Thu, 27 Aug 2020 07:04:59 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 494F1E29ACC98C5A2225; Thu, 27 Aug 2020 19:04:51 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Thu, 27 Aug 2020 19:04:42 +0800 From: Chen Qun To: , Subject: [PATCH v3 06/10] hw/net/virtio-net:Remove redundant statement in virtio_net_rsc_tcp_ctrl_check() Date: Thu, 27 Aug 2020 19:03:07 +0800 Message-ID: <20200827110311.164316-7-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20200827110311.164316-1-kuhn.chenqun@huawei.com> References: <20200827110311.164316-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.191; envelope-from=kuhn.chenqun@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/27 02:09:23 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, "Michael S. Tsirkin" , pannengyuan@huawei.com, Jason Wang , Li Qiang , Euler Robot , Chen Qun , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Clang static code analyzer show warning: hw/net/virtio-net.c:2077:5: warning: Value stored to 'tcp_flag' is never re= ad tcp_flag &=3D VIRTIO_NET_TCP_FLAG; ^ ~~~~~~~~~~~~~~~~~~~ The 'VIRTIO_NET_TCP_FLAG' is '0x3F'. The last =E2=80=98tcp_flag=E2=80=99 as= signment statement is the same as that of the first two statements. Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Li Qiang --- Cc: "Michael S. Tsirkin" Cc: Jason Wang --- hw/net/virtio-net.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index a1fe9e9285..cb0d27084c 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -2075,7 +2075,6 @@ static int virtio_net_rsc_tcp_ctrl_check(VirtioNetRsc= Chain *chain, tcp_flag =3D htons(tcp->th_offset_flags); tcp_hdr =3D (tcp_flag & VIRTIO_NET_TCP_HDR_LENGTH) >> 10; tcp_flag &=3D VIRTIO_NET_TCP_FLAG; - tcp_flag =3D htons(tcp->th_offset_flags) & 0x3F; if (tcp_flag & TH_SYN) { chain->stat.tcp_syn++; return RSC_BYPASS; --=20 2.23.0 From nobody Fri May 17 09:18:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1598526515; cv=none; d=zohomail.com; s=zohoarc; b=CABbGTVXQy08KaDEsiDcilG3D8yOlez+YYyBfI192PPfa6QU39F3EtbNAsoRjhJB4NmODBykVlA2IedebXf7RAA0zHxcOrarVN8figRb1ybtHs++KuUkj4O3gJHboG5E6iBVwz5azuxqUyTZt62g9EvClud9ojkHjyUMCI3lnQc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598526515; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=1VqyG8lBL1IjKk4xCqlnSG/3vts+kaxH4MgupbQePJM=; b=EEJEpKf0ikSUIaFiKZ9W7PMegdMiaDTeco6/AfysS7UcbIAOm+Ku0E3M9fQ4Du/XgLXLe/36P5H5S1HdWjbFbiKKMNGhYaCRlLMqTsolvwOEClUMpszGSf26+z7+yWKdfk0pEt2kWBWDgOS9Zdb7LKIUTofHR7kcgpzYY7BNS9g= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 159852651535198.32283486522294; Thu, 27 Aug 2020 04:08:35 -0700 (PDT) Received: from localhost ([::1]:60804 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBFlh-0002h0-V9 for importer@patchew.org; Thu, 27 Aug 2020 07:08:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51068) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBFiC-0004YR-ES; Thu, 27 Aug 2020 07:04:56 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:4715 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBFiA-0007ZL-Jm; Thu, 27 Aug 2020 07:04:56 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 3F8E0423732E145726B2; Thu, 27 Aug 2020 19:04:51 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Thu, 27 Aug 2020 19:04:44 +0800 From: Chen Qun To: , Subject: [PATCH v3 07/10] vfio/platform: Remove dead assignment in vfio_intp_interrupt() Date: Thu, 27 Aug 2020 19:03:08 +0800 Message-ID: <20200827110311.164316-8-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20200827110311.164316-1-kuhn.chenqun@huawei.com> References: <20200827110311.164316-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.191; envelope-from=kuhn.chenqun@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/27 02:09:23 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, Li Qiang , pannengyuan@huawei.com, Eric Auger , Alex Williamson , Stefan Hajnoczi , Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: hw/vfio/platform.c:239:9: warning: Value stored to 'ret' is never read ret =3D event_notifier_test_and_clear(intp->interrupt); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Eric Auger Reviewed-by: Stefan Hajnoczi Reviewed-by: Li Qiang --- Cc: Alex Williamson Cc: Eric Auger Cc: Stefan Hajnoczi --- hw/vfio/platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c index ac2cefc9b1..869ed2c39d 100644 --- a/hw/vfio/platform.c +++ b/hw/vfio/platform.c @@ -236,7 +236,7 @@ static void vfio_intp_interrupt(VFIOINTp *intp) trace_vfio_intp_interrupt_set_pending(intp->pin); QSIMPLEQ_INSERT_TAIL(&vdev->pending_intp_queue, intp, pqnext); - ret =3D event_notifier_test_and_clear(intp->interrupt); + event_notifier_test_and_clear(intp->interrupt); return; } =20 --=20 2.23.0 From nobody Fri May 17 09:18:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1598526616; cv=none; d=zohomail.com; s=zohoarc; b=Teq4rwdfDKjfGKuGSzv0aCwUxDmRDOnj3Fhh5bXtdogEbXjtobdWlPplsr5hn7w5TrcDgNnPfH8mZG/czT02uiv9MYZOPbvaBvtDlB6VFKvrUwFKy6NOI9QSBvHiMDDSbDA6vAUgriJmXvmWixJH3MEglbTlR7XQuM/Vp4ufTEo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598526616; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VRsW0ko/o6Vwl34rY7vRG2up1M814rhQ+ycMxHHVmDM=; b=O0PSRziLgBslCmc5nLO19TRRvPB6pWOkpUMJYpKmX++PlI36/R4pGGx8LCT3aI3hiMDXlbCUk+b13W0+vURGawRZr6CvW/fF/ACGu2u1L62CStVDsMS1uwjbk+iatrbI3IKc1dX9bpBpt5zI0NVv0yTldnRU7ST9xU4kNQJ0sy8= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 159852661614646.74420601823351; Thu, 27 Aug 2020 04:10:16 -0700 (PDT) Received: from localhost ([::1]:39696 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBFnK-0005YT-8m for importer@patchew.org; Thu, 27 Aug 2020 07:10:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51152) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBFiJ-0004iU-9n; Thu, 27 Aug 2020 07:05:06 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:4663 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBFiG-0007aF-PP; Thu, 27 Aug 2020 07:05:03 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 54DA8EB59F40A3DDEFF0; Thu, 27 Aug 2020 19:04:56 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Thu, 27 Aug 2020 19:04:46 +0800 From: Chen Qun To: , Subject: [PATCH v3 08/10] usb/bus: Remove dead assignment in usb_get_fw_dev_path() Date: Thu, 27 Aug 2020 19:03:09 +0800 Message-ID: <20200827110311.164316-9-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20200827110311.164316-1-kuhn.chenqun@huawei.com> References: <20200827110311.164316-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=kuhn.chenqun@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/27 02:12:47 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, pannengyuan@huawei.com, Markus Armbruster , Gerd Hoffmann , Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: qemu/hw/usb/bus.c:615:13: warning: Value stored to 'pos' is never read pos +=3D snprintf(fw_path + pos, fw_len - pos, "%s@%lx", Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Markus Armbruster Reviewed-by: Gerd Hoffmann --- Cc: Gerd Hoffmann Cc: Markus Armbruster v2->v3: The format of the snprintf statement is modified(Base on Markus rev= iew). --- hw/usb/bus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/usb/bus.c b/hw/usb/bus.c index b17bda3b29..2b11041451 100644 --- a/hw/usb/bus.c +++ b/hw/usb/bus.c @@ -612,8 +612,8 @@ static char *usb_get_fw_dev_path(DeviceState *qdev) in++; } else { /* the device itself */ - pos +=3D snprintf(fw_path + pos, fw_len - pos, "%s@%lx", - qdev_fw_name(qdev), nr); + snprintf(fw_path + pos, fw_len - pos, "%s@%lx", + qdev_fw_name(qdev), nr); break; } } --=20 2.23.0 From nobody Fri May 17 09:18:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1598526550; cv=none; d=zohomail.com; s=zohoarc; b=IRidOp/QqUZeP+Y4aHgh5TYqKEg9CYEY0WEqJGLiW/cqJGFr7h9OQYqD4C6zkkKRD41y57Y0t7CexU6Q5zpfU/zCT/YpDRKxFBM6H1hpn/Id+/nVWVV8AJNFk0YbJzDs9+Fsuzzd5MxD4zb9R4ljvUZ5EFtMcMdJyuF0UKWqyCw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598526550; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=GfxOpBR7moVf07kiESltYJfRB0nP0N58x1Pue9s1bis=; b=SqrX+RQmK/2sAGeSt6bPPpwaQ18/ht4CTqee5j7/FF5hiH0j4qGWsHheTW7XtJ3TdjbXF3kkuDFczxA9oBsifp975oe3mR2J66QMhtQJWTGY3RQSRhZlVRWk606z2PCZclobEjLkuXa4fShkyrOalkofBEVOnLYpeZtKhUOd9Wk= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1598526550506558.2820026867793; Thu, 27 Aug 2020 04:09:10 -0700 (PDT) Received: from localhost ([::1]:36684 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBFmH-0004KN-BB for importer@patchew.org; Thu, 27 Aug 2020 07:09:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51144) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBFiI-0004gL-Bw; Thu, 27 Aug 2020 07:05:02 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:4662 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBFiG-0007aE-Ia; Thu, 27 Aug 2020 07:05:02 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 59319B7F0F57BDD1D744; Thu, 27 Aug 2020 19:04:56 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Thu, 27 Aug 2020 19:04:47 +0800 From: Chen Qun To: , Subject: [PATCH v3 09/10] hw/intc: fix default registers value in exynos4210_combiner_read() Date: Thu, 27 Aug 2020 19:03:10 +0800 Message-ID: <20200827110311.164316-10-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20200827110311.164316-1-kuhn.chenqun@huawei.com> References: <20200827110311.164316-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=kuhn.chenqun@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/27 02:12:47 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , zhang.zhanghailiang@huawei.com, Igor Mitsyanko , pannengyuan@huawei.com, Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: hw/intc/exynos4210_combiner.c:231:9: warning: Value stored to 'val' is neve= r read val =3D s->reg_set[offset >> 2]; The default register return value should be return 'val'. Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Peter Maydell --- Cc: Igor Mitsyanko Cc: Peter Maydell v2->v3: Change default register return value from '0' to 'val =3D s->reg_se= t[offset >> 2]'. --- hw/intc/exynos4210_combiner.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/intc/exynos4210_combiner.c b/hw/intc/exynos4210_combiner.c index b8561e4180..59dd27fb16 100644 --- a/hw/intc/exynos4210_combiner.c +++ b/hw/intc/exynos4210_combiner.c @@ -229,7 +229,6 @@ exynos4210_combiner_read(void *opaque, hwaddr offset, u= nsigned size) TARGET_FMT_plx "offset\n", offset); } val =3D s->reg_set[offset >> 2]; - return 0; } return val; } --=20 2.23.0 From nobody Fri May 17 09:18:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1598526664; cv=none; d=zohomail.com; s=zohoarc; b=Wzdn7vb/6hkcDnMh+elPmfq7Um9Nb5od5xx7JqiNSZ8B3Vw7vaETS3/9hagENRTsMlYJteWEV+L5thiyW/e4110iBuMv8e4NSpq74W3+RqmFVhf82M+ZHicnoqL196GvyQeGVaK+wsxKZALaD42CcVtsLoQG2XPlEjfQqUhQcRw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598526664; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nzEQ2cAgXY4pl78GIGciJmkO2mp6KfG6vAyAPn1Gos0=; b=c/AVKMe9YcxycxEjRY1TSE0Htxe6Gfg/DEwJaerV/bdPU5JP5LKpMs/ARjHs+XGLMCrutMq1PnonVgcz2Tttb2ZN0cRZvxoDVK3iXgMkZiq8mAVech5sgG/BWp8lZpkkpfzMYgM6PoPVafbjZKliqqn7teKP46vwWQF5MjH1rlY= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1598526664649867.493282379126; Thu, 27 Aug 2020 04:11:04 -0700 (PDT) Received: from localhost ([::1]:42172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBFo7-0006es-AE for importer@patchew.org; Thu, 27 Aug 2020 07:11:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51150) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBFiJ-0004iC-35; Thu, 27 Aug 2020 07:05:06 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:4664 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBFiG-0007aG-OG; Thu, 27 Aug 2020 07:05:02 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 5D581C9810B99A41AAEB; Thu, 27 Aug 2020 19:04:56 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Thu, 27 Aug 2020 19:04:49 +0800 From: Chen Qun To: , Subject: [PATCH v3 10/10] hw/display/vga:Remove redundant statement in vga_draw_graphic() Date: Thu, 27 Aug 2020 19:03:11 +0800 Message-ID: <20200827110311.164316-11-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20200827110311.164316-1-kuhn.chenqun@huawei.com> References: <20200827110311.164316-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=kuhn.chenqun@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/27 02:12:47 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, pannengyuan@huawei.com, Li Qiang , Gerd Hoffmann , Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: hw/display/vga.c:1677:9: warning: Value stored to 'update' is never read update =3D full_update; ^ ~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Gerd Hoffmann Reviewed-by: Li Qiang --- Cc: Gerd Hoffmann --- hw/display/vga.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/display/vga.c b/hw/display/vga.c index 061fd9ab8f..836ad50c7b 100644 --- a/hw/display/vga.c +++ b/hw/display/vga.c @@ -1674,7 +1674,6 @@ static void vga_draw_graphic(VGACommonState *s, int f= ull_update) if (!(s->cr[VGA_CRTC_MODE] & 2)) { addr =3D (addr & ~0x8000) | ((y1 & 2) << 14); } - update =3D full_update; page0 =3D addr & s->vbe_size_mask; page1 =3D (addr + bwidth - 1) & s->vbe_size_mask; if (full_update) { --=20 2.23.0