From nobody Mon Feb 9 19:05:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1598477449; cv=none; d=zohomail.com; s=zohoarc; b=oI0967eoctLTGaPJURM0JLDKGnUBJiXVO8ok3fqxZ6pQAWPQD0fwmDQyXzZEwgpWJsyczl0CWrAZ5XofUP49Va6zuufz6x55QElwMc4fEbcgH47q41TYNPa2s8rxTnjdyxpN5jE9RKbyoCrJXADSNJlwJnrQBG6h4anpeJnxK0g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598477449; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=BGqg5N9qiBZemBYDpsbY0fVHhIdmSwhMF/PC/bBHt8o=; b=RGd2/Jz9C3/M28u3/RBd+Hev7hdOZvEF+xWwmz6FpakntlsyfkcoAjNVMZXizXhRDSy4/W0giwd/NGtiEyHEChgHPU7pgnOkEOF1OAgbx5V1ZwC+BK4LBrEIxliRHXlIQnOo8jRZIwhPcDd13cUhD7l+9mb9wYRq8GSmr0IH72g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 159847744969658.24185769100711; Wed, 26 Aug 2020 14:30:49 -0700 (PDT) Received: from localhost ([::1]:47058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kB30J-0001WE-C4 for importer@patchew.org; Wed, 26 Aug 2020 17:30:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35274) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kB2k7-0008PM-Cj for qemu-devel@nongnu.org; Wed, 26 Aug 2020 17:14:03 -0400 Received: from mout.gmx.net ([212.227.17.21]:58637) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kB2k2-0002V6-Js for qemu-devel@nongnu.org; Wed, 26 Aug 2020 17:14:03 -0400 Received: from ls3530.fritz.box ([92.116.186.77]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mr9G2-1kvfyK3dby-00oCmj; Wed, 26 Aug 2020 23:13:50 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1598476431; bh=WOmbPSJ1IovLaHobnoaa9ga8qpoZn56dcothAl1FiBM=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=EDJv+9ZBAf2dikXl4ESGdgTkQGpACSf2XGCOFlSwTpiIVnp9p4NLf4qbyvH1K3aOI Y3exqD/9c827c/4H30L0I2f2y3SlIh7Htp10GdZRvafKsswzqlUGhfrlG3O4QIcnOX b7Nx5JuH2LZ+InNLfFW1t7Uh4MXd/ErGJzH8xkxE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c From: Helge Deller To: peter.maydell@linaro.org, qemu-devel@nongnu.org Subject: [PULL v5 08/12] Revert "hw/display/artist: Avoid drawing line when nothing to display" Date: Wed, 26 Aug 2020 23:13:41 +0200 Message-Id: <20200826211345.14295-9-deller@gmx.de> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200826211345.14295-1-deller@gmx.de> References: <20200826211345.14295-1-deller@gmx.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:d51Jk091MHy0/uWiAvsPCMxV5KgbRoHY+vZnwzS2JW5OCyaxnhO Eza8yfR1MgljjIOIB1L8BRK2oE3V9A12reouPPfBzhU1bTFlwXxqLBZ7hLUlbR7A6pCDWqt onkuXZClDKT3S7iV+ZegTDM4+Ltp660r0fVfJ9ijKFHghuUd42VMfljeR+zROYTtqr9nUIs 9RfqZknpSQM5b2OvlMqeQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:U0iJNkCBwKM=:SyUI7T0s0fzUU9Rqdm8d3d +snLy+Eso6T3ASvrz5AstxfVmko/vN9hP88Xr5AXFJNZEQmRjpFpNwuMBZegazYf7ckF7rb46 BpS+hJRSWR6J0g+OSWA/ZESwfDOgH7YmKCW9LKX+7RwLuULeq6kekAikUkVL+SZAbL/Km4n8x ilzOf3cBOov1FTGM7kH6h0neWJ5EfTqxk6yD7uq+6mGv7/cWH5uhPAUnC90fWConvoZNXpNji n97lNjaqZv7F2gYzzq4yigcg4FZ9Jog6sJMgFLxSLsgeRjr2fsMIGcwBn4GGkEatmbLSA4E/L z2Awxq3FuVpn5CJORXNsM4aEUW8qsTJQLTDcm1iMdRpBR2Z0oq5m96UcOA4Qh6x13+49MVmB9 2t4S3OomBpJEz2JF8+5P06ZCSauGyxVp3q2JQTpprH5t29GrosYhGzVBdyvjxYRo41s3Znkz2 wlUrP6g7LxubmsSxaBMbNI2+KpmJmpEwTotF58DpK4LPq5upKU59+ZjHpaAkHKO7tsJP/7zsb nwvXyYA8+D7LSzcbjjWebrA9cSjwGtmlZQOckkQrUx0PSDlIXZwvFGUAErqJF7vbSlggq0aI6 7TsyUDixX6fFDlfc+v6Coh66UorRSKG0mdcrmNlTaTM1OT5P5sdCHXK5XR9Dfu/K46jtx34K/ FOmLyOBNeOiugWBCDHGVqpeY4ISkJTM8VivJTxiNbyp8lhW66peTef0ITGvj5kRl47Qp+D1gt 0svxkserlN7uB32e2c8xaY78i5k4ZPiF9SuApBru86DRHX50kynoAiG7YfsiT1gB8K18QwFBd e75TFG1H9nXq1u3RgFf1ik3yTmXhiFBd//qlJKL/BZqTVW6j/6esScQ7FBGR+Tjoeb41wW6MG TtOnUZjlRdt5IXXZtNlCnwF3tq3+4ozNcwRg0qHOX1mwWJspOX5y6MXLOz/bRoTW+9l3glXqy eEBWXVqbvoRsu9OyQgfiLFsiMPmEpzvtYIiIJXu8xlVZkFpxgWPUUlOplt/8m9Qa9QtMLnPHM 20a67xRsaBTTKz+0L4k/w1vUYfVxMNMQqHMwGy67JXMGUQmI0MlAVltyTofc8d2X6f0w2sBBW gWFiGhK7ETJ6Zq1Or8Rzq6janHhokVpKbpcX+ya3XtyEuZD4JA1F1HlB+xJD0d8IvqZdwKODM tebWZQseRyC2ggVNeM1oda86QBjhY60zaICqxJkbCVfH7ILOzu3+wLxWy/i42FeqXy/9TPyua YS2sfvs12vRdV427S Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=212.227.17.21; envelope-from=deller@gmx.de; helo=mout.gmx.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/26 17:13:54 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Helge Deller , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmx.net) Content-Type: text/plain; charset="utf-8" This reverts commit b0f6455feac97e41045ee394e11c24d92c370f6e. It's wrong. A line could even be a dot. Signed-off-by: Helge Deller --- hw/display/artist.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/display/artist.c b/hw/display/artist.c index 47de17b9e9..f37aa9eb49 100644 --- a/hw/display/artist.c +++ b/hw/display/artist.c @@ -591,9 +591,6 @@ static void draw_line(ARTISTState *s, int x1, int y1, i= nt x2, int y2, } else { dy =3D y1 - y2; } - if (!dx || !dy) { - return; - } c1 =3D false; if (dy > dx) { -- 2.21.3