From nobody Mon Feb 9 16:45:02 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1598476751; cv=none; d=zohomail.com; s=zohoarc; b=b0rwMxRLb+8+qVLumTlLLzNixd51Kr+ElDPnX5DaA0MXxCSQTGGf4Zp75n+cO4sNg79FopuX1pX1ExOLb7TqWuXlijD/MH/ssgIaHzfRQ65DiRTpdmEmaSgeKMu/zTuefJ4B2lcM10W05Z5hnyQ8KF6uSI4phO5OFrHOCHgdnEc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598476751; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=thkeJyf4jAsFMhgQJexxT6UHt2wYzzUDg4Xd6RdhHy8=; b=OfhTLdpK7U33qQeejRZKmd6ASX4ecxSMl1ael+O7HlWX78copJs0v+nr4LZAiMGYOaDAI0YQhzyIdXsiqT1dX4V/lIVa2sqpzdstIoEGZS3mzFT8kQjGO4h23tJK3KD4aXdHjI5XRC+aeVmQdAUXJxR1sVbTuWGFHHFDuHTZvxU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1598476751021676.2911328560305; Wed, 26 Aug 2020 14:19:11 -0700 (PDT) Received: from localhost ([::1]:57096 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kB2p3-0001uM-GR for importer@patchew.org; Wed, 26 Aug 2020 17:19:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35256) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kB2k6-0008Ox-Rv for qemu-devel@nongnu.org; Wed, 26 Aug 2020 17:14:02 -0400 Received: from mout.gmx.net ([212.227.17.22]:47441) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kB2k2-0002V7-Ft for qemu-devel@nongnu.org; Wed, 26 Aug 2020 17:14:02 -0400 Received: from ls3530.fritz.box ([92.116.186.77]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MwQTF-1kRcFf0tzZ-00sQ1e; Wed, 26 Aug 2020 23:13:50 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1598476430; bh=ffjQD9P6e3SE1TvisnqQkLG+rj6/1Nng0HQOzVbN1Mw=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=RXK3koUskAtpzEbiHNM/CwbFTQiry0bWpITi/kqEa/vrqfZ67SGQgqc/u8RaeOZVd LwB8EFoOxdC9GHsLvmXm0pIbpyR1xZSM5FDFmM0bJVbcjqOfCZkgfDkhnEw30cI6KC XGOy4lTgEIynhqTcCIQJIw2Fc+iku5/BetKptaHI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c From: Helge Deller To: peter.maydell@linaro.org, qemu-devel@nongnu.org Subject: [PULL v5 05/12] hw/hppa/lasi: Don't abort on invalid IMR value Date: Wed, 26 Aug 2020 23:13:38 +0200 Message-Id: <20200826211345.14295-6-deller@gmx.de> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200826211345.14295-1-deller@gmx.de> References: <20200826211345.14295-1-deller@gmx.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:3kfGOFg2TmyHoaLpgmi0KvD+71Gb0OFxCKmK850eyct/5vSNYqH ORiNOeDd2o2TH+rsfFpskImz6yaTz7aoS6a6ubo3UgeXg83MRXapQcraSRcMzgR25Py0Pre sNO5sdwRS+It3QY7PlElVQ5TRJ9R6lqfhSVgjAJ/X6HblNiPvIljLXgLuhmzQa3WpkWx5z5 0mNGiwk5gahFQTEwjyR8w== X-UI-Out-Filterresults: notjunk:1;V03:K0:kElX1+bVBs0=:TH5s3t88ySSaPteL+yx4g/ oUkNbF+JlpsoMM9mpj6JdCh4IJWwgD46wYJekpoIVZtK+frDFyPlnYrzTVGpPpvCXdwfM0e+5 X80610MiblVloh42xKWTrgNT4QB8m5PeD5cs/5yRf1YNocv37aS5Sq1tztxFeeBiMzRPOUWdv 7c7cVxWWoiTqZe81M04E524HWXWUZwe8DkQxZK96ywys80yZYW5KWU0xzpXFlphhQPmS1dx2u zVwvEDaxJKNUKSEmvjVlOI8dc/bwdOf3VKG6gc70ggZkvKihcZdttc0j4xtQ5HsT1RnBzGvJL EEXZt57C04Usdnp9NaZ4jf0CoZidGn6tEOAvdVzZ8fLcSuY6pk4vl6eihGq2GRfow1yJRzT/6 9yunf8N4quSgdzA1BAuiKg8VPyDe4KhVjjdaoYXh3Aq4cYA85peajjCJ+95Qocy911S9Zj21B 6io3PlyC4U5WAl0wwwipUAf7cNOmnxT5GKoL12PHi4df4c78jVjBQjCWFGVCmm5m8DwXygk2m Dm43y1nyvRU/I+v9jdP9r/0zx24rIkuL8q6D40mTTpR9BQIZHLwWUtvnWGgCkB3BQn5FLLhJB FSBdH0L4XiFWNJkLdP5o+ety6wQHuV02jTyCmaH6gERW5Y4t5kEJLtq+ypGaUUVxgO94fyiEG mQWawUS2XkLp0nDErRI9hY3xiaLL3vBHB8HLxUvrSE0fqLN43SdlyWF19dEAc+33I4mCaFuXK 45misuvXc89ChUUZohSO/iJYKnq/GoIRbsqBSOMVwQY6X9JvuNWFNjpiQSmDelomPh/bQI7ES Uv9mY118zwVLKsb5mLWooosYNLK8fgem0k/otGrPnCyxXF1OSRgiFtZl70edD7FTNIzh/zGRP u81rru5yuJdjFbAg0BlCCCjl/12uOsbrqBYP1UViSHGfPRmEGS2+hfl0qmE+8oQW/jp4sP9J5 x4vxBKNac9v7zMlNr2/uuTS8iavZvdp4ryEk46Q9vS2gL+haTfPtqEHBVfn4UO8jZ43Znc6HM ONjeV2qo002JXD1CMDm9F2J8xjG0C6qgFOPQEEnVYgeZiqYlDfoyJuu5qMdJ9KIm0xOg3ucVO uglvPacSdoXMUcrJFDElY14S7HKKzv8mu0+L1NI1agNHJNxCo/DQdOvNF+74NXcGAQXaWulbh /6NH6HUKrcARE3bv67YONItNnzuLKZ8pPxU4RuQ76tZRsELFlc0DswPGFP98FQvovz+t1MVDt Z392F+flCh2dnNxQf Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=212.227.17.22; envelope-from=deller@gmx.de; helo=mout.gmx.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/26 16:12:45 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Helge Deller , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmx.net) Content-Type: text/plain; charset="utf-8" NetBSD initializes the LASI IMR value with 0xffffffff to disable all LASI interrupts. This triggered an assert() and stopped the emulation. By repla= cing the check with a warning in the guest log we now allow NetBSD to boot again. Signed-off-by: Helge Deller --- hw/hppa/lasi.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/hppa/lasi.c b/hw/hppa/lasi.c index ffcbb988b8..194aa3e619 100644 --- a/hw/hppa/lasi.c +++ b/hw/hppa/lasi.c @@ -11,6 +11,7 @@ #include "qemu/osdep.h" #include "qemu/units.h" +#include "qemu/log.h" #include "qapi/error.h" #include "cpu.h" #include "trace.h" @@ -170,8 +171,11 @@ static MemTxResult lasi_chip_write_with_attrs(void *op= aque, hwaddr addr, /* read-only. */ break; case LASI_IMR: - s->imr =3D val; /* 0x20 ?? */ - assert((val & LASI_IRQ_BITS) =3D=3D val); + s->imr =3D val; + if (((val & LASI_IRQ_BITS) !=3D val) && (val !=3D 0xffffffff)) + qemu_log_mask(LOG_GUEST_ERROR, + "LASI: tried to set invalid %lx IMR value.\n", + (unsigned long) val); break; case LASI_IPR: /* Any write to IPR clears the register. */ -- 2.21.3