From nobody Tue Feb 10 19:09:01 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1598444315; cv=none; d=zohomail.com; s=zohoarc; b=GKiYXqCu049ngyWyOna+MaG2OsEqc9JjY/ztAWhQ5YLQKHdk+wRQLbkbTTD7n5QyY3+TJYw9hFgr0OGsLNonzEAuirDCwqfKR0dmUi6zo6EYMvtWMi9fGQoYvlG/DkHoCRhunRi9OWunl94ad1+6ZxVACBnv4Hpzf2yryeRlFlU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598444315; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=8qpUvndftLJI0tCOmudBGnAuo0hzOAfD2TEeHijwwlg=; b=U/ARFE4AR11374ypM4Tew/uPWk7m04cd5cnq7jNRLrcApBOsadeMXawb6htZdlZaEj5nngzqMBEyrpsoo6ih7i81ji7j2E21FYcsUncfuDRqBZkMXIWAOQW3rnZuSsfgvZ/wOqLbbUbJbygmo37u4WJsT7E4KkhLQMr6gzmlxvg= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1598444315825496.9344699522644; Wed, 26 Aug 2020 05:18:35 -0700 (PDT) Received: from localhost ([::1]:52454 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAuNu-00056N-Jf for importer@patchew.org; Wed, 26 Aug 2020 08:18:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37514) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAuMf-0003ax-BV; Wed, 26 Aug 2020 08:17:17 -0400 Received: from proxmox-new.maurer-it.com ([212.186.127.180]:39896) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAuMb-0004Cl-UM; Wed, 26 Aug 2020 08:17:17 -0400 Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 98364448C0; Wed, 26 Aug 2020 14:17:01 +0200 (CEST) From: Stefan Reiter To: qemu-block@nongnu.org Subject: [PATCH 3/3] backup: initialize bcs bitmap on job create, not start Date: Wed, 26 Aug 2020 14:13:59 +0200 Message-Id: <20200826121359.15450-4-s.reiter@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200826121359.15450-1-s.reiter@proxmox.com> References: <20200826121359.15450-1-s.reiter@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=212.186.127.180; envelope-from=s.reiter@proxmox.com; helo=proxmox-new.maurer-it.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/26 08:17:01 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, w.bumiller@proxmox.com, armbru@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, jsnow@redhat.com, dietmar@proxmox.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" After backup_init_bcs_bitmap the copy-before-write behaviour is active. This way, multiple backup jobs created at once but running in a sequential transaction will still represent the same point in time. Signed-off-by: Stefan Reiter --- I'd imagine this was done on job start for a purpose, so this is potentially wrong. In testing it works fine. Sent along for feedback, since it would be necessary to really make use of = the sequential backup feature (without it, the individual backup jobs would not= have a consistent view of the guest). block/backup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/backup.c b/block/backup.c index 4f13bb20a5..14660eef45 100644 --- a/block/backup.c +++ b/block/backup.c @@ -237,8 +237,6 @@ static int coroutine_fn backup_run(Job *job, Error **er= rp) BackupBlockJob *s =3D container_of(job, BackupBlockJob, common.job); int ret =3D 0; =20 - backup_init_bcs_bitmap(s); - if (s->sync_mode =3D=3D MIRROR_SYNC_MODE_TOP) { int64_t offset =3D 0; int64_t count; @@ -471,6 +469,8 @@ BlockJob *backup_job_create(const char *job_id, BlockDr= iverState *bs, block_job_add_bdrv(&job->common, "target", target, 0, BLK_PERM_ALL, &error_abort); =20 + backup_init_bcs_bitmap(job); + return &job->common; =20 error: --=20 2.20.1