From nobody Mon Feb 9 21:38:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1598384675; cv=none; d=zohomail.com; s=zohoarc; b=XZL+ZDhW5FnxzVEgiukNYP+jQcXSknGHI0SX29mZrUGGN3szEOWTTxoNUAhBBe+qZy1Eg7o20eDugjmEx6Q/qj9D+2vK2hgbpbRc3B9yPmQZCHrlkG6w08bIyCg7rWI32zhCS64EoEYin93lalDcgbELeIYzzwWKXf3R4HMaRnk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598384675; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/XFmSQxil6m9x0uqlxeY68vshsXG5CyWP9ebo2MkDbA=; b=FAwQRB3ZcUT2/MGJ5nFbv1zlkYfSxqt3frAVbZmbJQmJRRotXfAIt/xfVZVQYLZmaLHBnnScE6I/zRLliPm3NcWgMnkKimVBsRPBMZ+W0bbg9+NUDHmOqnHP5hAtihnSP37qJtgPTHYdIN3H3CGWDpxXnYodHwpB4YlDyfvVozc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 159838467547457.77009346726152; Tue, 25 Aug 2020 12:44:35 -0700 (PDT) Received: from localhost ([::1]:34196 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAery-0004ls-6R for importer@patchew.org; Tue, 25 Aug 2020 15:44:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40682) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAeXM-0002Yd-Bt for qemu-devel@nongnu.org; Tue, 25 Aug 2020 15:23:16 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:39834 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kAeXK-0006LM-92 for qemu-devel@nongnu.org; Tue, 25 Aug 2020 15:23:15 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-48-LUHRZBPmPQWdOM4CIzh4Ew-1; Tue, 25 Aug 2020 15:23:11 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C8BF8807354 for ; Tue, 25 Aug 2020 19:23:10 +0000 (UTC) Received: from localhost (unknown [10.10.67.254]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8F62619C4F; Tue, 25 Aug 2020 19:23:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598383393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/XFmSQxil6m9x0uqlxeY68vshsXG5CyWP9ebo2MkDbA=; b=CITI1qzdxNA8/bTgCH80qcRSNwqKu5iyt7Qm0ZS9//2NkhoBoXaShtBmQxc9rVu9u/bYyn ONz/gH3t1hythJ/+hiXkmWNRwIaF8goyfoDhJSE7TXd+wva4r3J2ShdsrhKvpyrLmTqjhk xEYB83fWPhfQ9IbqVbZJn6l1AjVdnV8= X-MC-Unique: LUHRZBPmPQWdOM4CIzh4Ew-1 From: Eduardo Habkost To: qemu-devel@nongnu.org Subject: [PATCH v3 54/74] qom: make object_ref/unref use a void * instead of Object *. Date: Tue, 25 Aug 2020 15:20:50 -0400 Message-Id: <20200825192110.3528606-55-ehabkost@redhat.com> In-Reply-To: <20200825192110.3528606-1-ehabkost@redhat.com> References: <20200825192110.3528606-1-ehabkost@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/25 01:35:36 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.958, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , "Daniel P. Berrange" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) From: Daniel P. Berrang=C3=A9 The object_ref/unref methods are intended for use with any subclass of the base Object. Using "Object *" in the signature is not adding any meaningful level of type safety, since callers simply use "OBJECT(ptr)" and this expands to an unchecked cast "(Object *)". By using "void *" we enable the object_unref() method to be used to provide support for g_autoptr() with any subclass. Signed-off-by: Daniel P. Berrang=C3=A9 Message-Id: <20200723181410.3145233-2-berrange@redhat.com> --- Changes v2 -> v3: none Changes v1 -> v2: none --- include/qom/object.h | 4 ++-- qom/object.c | 6 ++++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/include/qom/object.h b/include/qom/object.h index 0f3a60617c..1f8aa2d48e 100644 --- a/include/qom/object.h +++ b/include/qom/object.h @@ -1035,7 +1035,7 @@ GSList *object_class_get_list_sorted(const char *impl= ements_type, * as its reference count is greater than zero. * Returns: @obj */ -Object *object_ref(Object *obj); +Object *object_ref(void *obj); =20 /** * object_unref: @@ -1044,7 +1044,7 @@ Object *object_ref(Object *obj); * Decrease the reference count of a object. A object cannot be freed as = long * as its reference count is greater than zero. */ -void object_unref(Object *obj); +void object_unref(void *obj); =20 /** * object_property_try_add: diff --git a/qom/object.c b/qom/object.c index 00fdf89b3b..b1822a2ef4 100644 --- a/qom/object.c +++ b/qom/object.c @@ -1124,8 +1124,9 @@ GSList *object_class_get_list_sorted(const char *impl= ements_type, object_class_cmp); } =20 -Object *object_ref(Object *obj) +Object *object_ref(void *objptr) { + Object *obj =3D OBJECT(objptr); if (!obj) { return NULL; } @@ -1133,8 +1134,9 @@ Object *object_ref(Object *obj) return obj; } =20 -void object_unref(Object *obj) +void object_unref(void *objptr) { + Object *obj =3D OBJECT(objptr); if (!obj) { return; } --=20 2.26.2