From nobody Sat May 18 23:55:07 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1598374381; cv=none; d=zohomail.com; s=zohoarc; b=fFLupafWL4/qgOV9JJeYK5uQctHYtbNZUWWaB6Ew1/G4X5YsIW1x9DAjuJUJjEY3EdYfK2KUuUBA4S8JD26q2eyWEXts9m3bK1HsNYVUUgCI/exA/jHRjGlSesVsMI22d3Zrf2aIvuQnU/9m86sw9j4E6sGQKe3LVdfW9QDbsx4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598374381; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=fIVyrpVHMw6tNd0qd5YUw4P9aigzbhlX4LJYiIphK6A=; b=g8f7pLBhhpjWo30ptLK0LZxXOaMpo2SICzW1A0cX02YR+LkhNbVmNsEX+L6ZaSiYTCHoeh+s7nS+6uDE0Q/i5akLexm0dro3+22BJLzO+KIQ2wG23j/2WY1VhU551RyAMvSXwkDPmkKi/D1Q9uahWsmob/l+dBV8pCMTZ/yYH4A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 159837438166843.34888602971307; Tue, 25 Aug 2020 09:53:01 -0700 (PDT) Received: from localhost ([::1]:53126 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAcBw-0000Qr-Cz for importer@patchew.org; Tue, 25 Aug 2020 12:53:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58050) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAcBL-0008Gz-Ft for qemu-devel@nongnu.org; Tue, 25 Aug 2020 12:52:23 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:45126) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kAcBJ-0003V6-KM for qemu-devel@nongnu.org; Tue, 25 Aug 2020 12:52:23 -0400 Received: by mail-wr1-x444.google.com with SMTP id h15so6712045wrt.12 for ; Tue, 25 Aug 2020 09:52:20 -0700 (PDT) Received: from vanye.hemma.eciton.net (cpc92302-cmbg19-2-0-cust304.5-4.cable.virginm.net. [82.1.209.49]) by smtp.gmail.com with ESMTPSA id v9sm20281870wru.37.2020.08.25.09.52.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2020 09:52:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fIVyrpVHMw6tNd0qd5YUw4P9aigzbhlX4LJYiIphK6A=; b=Nl+O7UlR0KSc9w/ZPf//XlYBzkvkzudcCbX0bJx7ZgY/uc6DnGZVoLEG2U3eV7HrmV 50q6jDUKtMae+2lRRm6rTxDee2DYLGpL/6GyHObdoYjAiiK6IQr1B8+eK65+ctvKFSeg rJCtRRb5wym/O5a82S78/yBZObYNUSd5NIYhweDAdQBrZh61AkItUOX4Ta5/OU3iBDjA JLOm+rmV+FMiXDEXjFHKS2Aa5IY+rf1fLHBEQe8cpSW94HFw6NrXusZo2mtBkYSedopy 5fh6Gh8Rzi0riiAipO97XRkRHWPlCTfddCJUZIC3yVt8H0hh+GOapsi1QmDiPW/yDvUf 7gPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fIVyrpVHMw6tNd0qd5YUw4P9aigzbhlX4LJYiIphK6A=; b=eQRrg18SdayalTvBqH44iKm5nA2Z1r63BlNRqiE7MHt2aQ9wSZDdvjmAIrgPMm4DWs t8igZxeCGwdbF+OnEcXbrRxCl2aQ10GXuEV829uY5TSg29PCApZE0lWwye3kSi0YlklN vbDeq6kblfXn32tqqNUlz/nn6KWGASMMC0Biy4a79SeReZ/3SmnPi+mK5pbokNdw4u6a snhHF+8F8ah2LAvMyLHC1yeor4507SPZ70rf2cuHxZNJa0G/+vkLKx55QZwCIoOsrKVU fwkuhHsJsHdoZg+r14CVwtIGqTcie1eCCv2ZET3kwzpPNRP7WgW8QgcboB5B/gehVQq7 LdWA== X-Gm-Message-State: AOAM5305doKVuERScJcybkelv59nciva2klQLJxwmKv7dZlaboENOlOx aj6qxCdj1H0DaRGqJ8i/uGxrFQ== X-Google-Smtp-Source: ABdhPJzsFmU+P/xZtsbSm2+Ko/ieKSMSeCqd6geInZKHzcO0/ARQnZNLbz86aKu/1cUZ/fqfrvgB1g== X-Received: by 2002:adf:80cb:: with SMTP id 69mr12191966wrl.313.1598374339637; Tue, 25 Aug 2020 09:52:19 -0700 (PDT) From: Leif Lindholm To: qemu-arm@nongnu.org Subject: [PATCH] hw/arm/sbsa-ref: add "reg" property to DT cpu nodes Date: Tue, 25 Aug 2020 17:52:17 +0100 Message-Id: <20200825165217.7379-1-leif@nuviainc.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::444; envelope-from=leif@nuviainc.com; helo=mail-wr1-x444.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Graeme Gregory , Peter Maydell , Radoslaw Biernacki , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The sbsa-ref platform uses a minimal device tree to pass amount of memory as well as number of cpus to the firmware. However, when dumping that minimal dtb (with -M sbsa-virt,dumpdtb=3D), the resulting blob generates a warning when decompiled by dtc due to lack of reg property. Add a simple reg property per cpu, representing a 64-bit MPIDR_EL1. Signed-off-by: Leif Lindholm --- hw/arm/sbsa-ref.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c index f030a416fd..167c57a08b 100644 --- a/hw/arm/sbsa-ref.c +++ b/hw/arm/sbsa-ref.c @@ -183,7 +183,22 @@ static void create_fdt(SBSAMachineState *sms) g_free(matrix); } =20 + /* + * From Documentation/devicetree/bindings/arm/cpus.yaml + * On ARM v8 64-bit systems this property is required + * and matches the MPIDR_EL1 register affinity bits. + * + * * If cpus node's #address-cells property is set to 2 + * + * The first reg cell bits [7:0] must be set to + * bits [39:32] of MPIDR_EL1. + * + * The second reg cell bits [23:0] must be set to + * bits [23:0] of MPIDR_EL1. + */ qemu_fdt_add_subnode(sms->fdt, "/cpus"); + qemu_fdt_setprop_cell(sms->fdt, "/cpus", "#address-cells", 2); + qemu_fdt_setprop_cell(sms->fdt, "/cpus", "#size-cells", 0x0); =20 for (cpu =3D sms->smp_cpus - 1; cpu >=3D 0; cpu--) { char *nodename =3D g_strdup_printf("/cpus/cpu@%d", cpu); @@ -191,6 +206,7 @@ static void create_fdt(SBSAMachineState *sms) CPUState *cs =3D CPU(armcpu); =20 qemu_fdt_add_subnode(sms->fdt, nodename); + qemu_fdt_setprop_u64(sms->fdt, nodename, "reg", cpu); =20 if (ms->possible_cpus->cpus[cs->cpu_index].props.has_node_id) { qemu_fdt_setprop_cell(sms->fdt, nodename, "numa-node-id", --=20 2.20.1