From nobody Sun Feb 8 22:21:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1598106610; cv=none; d=zohomail.com; s=zohoarc; b=Qv29CIxdBkLFqux8cZvCx7IEUO8lj3yyl/76kyFUihN0KFWmwSHJ0C9s2sSAk1FBFA48vwUxzu0vBV6dwLYno1qiAxTBjFAEwKnWaGNovACFFHHMS1uagt0oneNl1H7qP9ADOzxpyEhgXT2WuS66pwN3gTpOd1F78zTZuepNdIQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598106610; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5N1TvfeN9sguGH6fYWdtTuciXS7DxS//XoBqhXVC5YM=; b=nc3tVafL8n0gO9fVV7OGh0h7ZyTWweU42DwcaVahJy5wAIXyphYua+Et9q10G5/wSkJyKHEM+GJLZfFv61DOQ0+XcUajKxMADxgsVPsFH22T2bGA4Uz/oQxUrmr0xvdIYt2YRzhlFIYEH2Rmq+snc7xP1YLJ1PQJNW9n1CVeKLc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1598106610196892.2716338242759; Sat, 22 Aug 2020 07:30:10 -0700 (PDT) Received: from localhost ([::1]:32916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k9UX2-0000k6-U7 for importer@patchew.org; Sat, 22 Aug 2020 10:30:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58628) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k9UVU-0007tu-8C for qemu-devel@nongnu.org; Sat, 22 Aug 2020 10:28:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:47289) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k9UVS-0003E1-Ji for qemu-devel@nongnu.org; Sat, 22 Aug 2020 10:28:31 -0400 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-11-cA3jFe3ZNOOEl6f0fC69sw-1; Sat, 22 Aug 2020 10:28:25 -0400 Received: by mail-wr1-f70.google.com with SMTP id m7so1751252wrb.20 for ; Sat, 22 Aug 2020 07:28:25 -0700 (PDT) Received: from localhost.localdomain (121.red-81-40-121.staticip.rima-tde.net. [81.40.121.121]) by smtp.gmail.com with ESMTPSA id z203sm10504145wmc.31.2020.08.22.07.28.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Aug 2020 07:28:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598106509; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5N1TvfeN9sguGH6fYWdtTuciXS7DxS//XoBqhXVC5YM=; b=DwaIV3I2xDJaUB+4N2CNn8Petdcg4LJbzBxLJoyc7tGZ7fZHLwrMzQfVX6FVIRv+itKR49 mvL+Lf/abnXtTZeN8mQdT3q5nHRZAk1eHKDnPG9GNw3uJZ91lHqFw4RMkjQ/5SPOyQ37af eO4ntq/EiVFuVsAAAklpE9Qrm9EHILM= X-MC-Unique: cA3jFe3ZNOOEl6f0fC69sw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5N1TvfeN9sguGH6fYWdtTuciXS7DxS//XoBqhXVC5YM=; b=Ypv9p2yDrYFMYWtqox26Jf2iUUDAyaTk4Sa1MlpG/WU9J0o2zM7GUEmZr910j//CDJ bECqa8mcLdkDme484hMAIQ1i4gix1L2XcjtkiMyvawV9a/zTIAPG5Us6AjF2pq8l99a1 fHBIsT4/LSkDHGKwvQlSNPklIPJdXnLVWE/7ydz0dwZ/9tc/Y6gKVqpYrvh/TYoZyWDl JqPKKTPI6QgEeXaCjSTjY5hrAHrv3ZY9oJnnZ1WozHQHo7KTGWV4S8IG1e2LfQwRs/k+ TX340/pfyub2JJycmJpFUUcHElB4tcOdE83Q0AAO5d/yv6cWsLiErBa5TxMgBrJ6i+uy LcTg== X-Gm-Message-State: AOAM5307vOvOkXK0gw8U2FHFerOCwFZrQv2SthzjTDC3OtM2UOvc2IOk DcqudQU/fHR0cRZRAVBh8b8JYjyKF+UuxvnvQr1+4QuJhAaB9Iu6HhLuYn2TzxDfH4Jzg2IlSIR s2reiPGARd84a7F8= X-Received: by 2002:a1c:4c17:: with SMTP id z23mr8981653wmf.49.1598106504403; Sat, 22 Aug 2020 07:28:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyc6BPGcRPVr66IVWJ6fOki+xcWb8V8BjD9BRgqnRX+s3OxQFiw+8mncA00FT8qWqk806OZuA== X-Received: by 2002:a1c:4c17:: with SMTP id z23mr8981637wmf.49.1598106504205; Sat, 22 Aug 2020 07:28:24 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 1/2] hw/isa/superio: Set abstract TYPE_ISA_SUPERIO instance size Date: Sat, 22 Aug 2020 16:28:15 +0200 Message-Id: <20200822142816.1318214-2-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200822142816.1318214-1-philmd@redhat.com> References: <20200822142816.1318214-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/22 10:28:29 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , "Michael S. Tsirkin" , Jiaxun Yang , Aleksandar Markovic , Paolo Bonzini , Huacai Chen , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Instead of setting the instance size on each implementations, set it on the abstract parent, so we are sure no implementation will forget to set it. Reported-by: Eduardo Habkost Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Eduardo Habkost --- hw/isa/isa-superio.c | 2 +- hw/isa/smc37c669-superio.c | 1 - hw/isa/vt82c686.c | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/isa/isa-superio.c b/hw/isa/isa-superio.c index e2e47d8fd99..83eb21ebb2a 100644 --- a/hw/isa/isa-superio.c +++ b/hw/isa/isa-superio.c @@ -182,6 +182,7 @@ static const TypeInfo isa_superio_type_info =3D { .name =3D TYPE_ISA_SUPERIO, .parent =3D TYPE_ISA_DEVICE, .abstract =3D true, + .instance_size =3D sizeof(ISASuperIODevice), .class_size =3D sizeof(ISASuperIOClass), .class_init =3D isa_superio_class_init, }; @@ -200,7 +201,6 @@ static void fdc37m81x_class_init(ObjectClass *klass, vo= id *data) static const TypeInfo fdc37m81x_type_info =3D { .name =3D TYPE_FDC37M81X_SUPERIO, .parent =3D TYPE_ISA_SUPERIO, - .instance_size =3D sizeof(ISASuperIODevice), .class_init =3D fdc37m81x_class_init, }; =20 diff --git a/hw/isa/smc37c669-superio.c b/hw/isa/smc37c669-superio.c index 18287741cb4..9e59dc16039 100644 --- a/hw/isa/smc37c669-superio.c +++ b/hw/isa/smc37c669-superio.c @@ -103,7 +103,6 @@ static void smc37c669_class_init(ObjectClass *klass, vo= id *data) static const TypeInfo smc37c669_type_info =3D { .name =3D TYPE_SMC37C669_SUPERIO, .parent =3D TYPE_ISA_SUPERIO, - .instance_size =3D sizeof(ISASuperIODevice), .class_size =3D sizeof(ISASuperIOClass), .class_init =3D smc37c669_class_init, }; diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c index 18160ca445d..a4b84d405d0 100644 --- a/hw/isa/vt82c686.c +++ b/hw/isa/vt82c686.c @@ -533,7 +533,6 @@ static void vt82c686b_superio_class_init(ObjectClass *k= lass, void *data) static const TypeInfo via_superio_info =3D { .name =3D TYPE_VT82C686B_SUPERIO, .parent =3D TYPE_ISA_SUPERIO, - .instance_size =3D sizeof(ISASuperIODevice), .class_size =3D sizeof(ISASuperIOClass), .class_init =3D vt82c686b_superio_class_init, }; --=20 2.26.2 From nobody Sun Feb 8 22:21:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1598106701; cv=none; d=zohomail.com; s=zohoarc; b=JruHdGLoLnucisaLlBMG3hIQGhrf4eQVkaVwLcqJb2ZNMpMtSITudpxkNkoX/BwSlbWMr635ZjZY38/LxdR2GSnXmbgiEl4NjpZjb75N3OAmzRkwHUJx3tkKDtrx8Mo8qa0zAW13TPiO2jU3+2DHAHk27fIaVhgTS673bDJI3dg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598106701; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=mQe3QmceCc/tiRIrUidZfVVvAGh31Rv4ZDjVDhX3dPk=; b=ho6ZtAkGWpP4zsYzbEXuBrL59F+ziDHPV/WR7/dIQBM9dJOzfPQ1+9sm2fV607JAEcMBZZ+A2l44dS0iWKqpDs7/PhWf3f5EN1RwJM4gP5mKITB8Ra+fXA4j7MFsdF4FGOobVhdt/W2RPOAOa/QMvEo7i532blcwNuWVwwttngs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1598106701468934.9241311575149; Sat, 22 Aug 2020 07:31:41 -0700 (PDT) Received: from localhost ([::1]:35944 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k9UYV-00027z-N1 for importer@patchew.org; Sat, 22 Aug 2020 10:31:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58648) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k9UVX-0007yK-Ul for qemu-devel@nongnu.org; Sat, 22 Aug 2020 10:28:35 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:58016 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k9UVW-0003EC-6v for qemu-devel@nongnu.org; Sat, 22 Aug 2020 10:28:35 -0400 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-336-E0r9JirnPNGgrYQlMjgQNQ-1; Sat, 22 Aug 2020 10:28:30 -0400 Received: by mail-wr1-f72.google.com with SMTP id e12so1760110wra.13 for ; Sat, 22 Aug 2020 07:28:30 -0700 (PDT) Received: from localhost.localdomain (121.red-81-40-121.staticip.rima-tde.net. [81.40.121.121]) by smtp.gmail.com with ESMTPSA id b14sm11434171wrj.93.2020.08.22.07.28.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Aug 2020 07:28:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598106512; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mQe3QmceCc/tiRIrUidZfVVvAGh31Rv4ZDjVDhX3dPk=; b=dhyKjQET/nTiFDb3P6JVZ0AsiUb03rdkoOucoJZzlNLAD4995t2q7VJ7lGymT6JsBbBXZ8 pfS2HWcUcKklbCyRMpc6mg9XJtZ2LBQZxFtgwxZ9FIatXQl/5pyIadY2BxF+Q49UvYLo2z tNLgTEqPO+r6shnyYyo/cy46H1eMcNY= X-MC-Unique: E0r9JirnPNGgrYQlMjgQNQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mQe3QmceCc/tiRIrUidZfVVvAGh31Rv4ZDjVDhX3dPk=; b=FwGvkWpl6wRqX72pyRuGn6vtjVCk74xRLssFUMBohMcVZVFKU6FuszDTCEE4jO92VJ lSihciQ6wFU0TIfyi96srd5UdzGlnUwnhtFEQvYSj0CdJsduoCtNf7ROaL9yo2EHI7iZ mbubnm/0VZkqdYayfWSM+IsZWig+sj236m7/SHmyMazHfaLLjHw9RxXWRLqNOodSc2A9 HQtSczEbsHkPHvEA4EM4GCPakQ953/J6UObqweeD6R2+9BGAtmF1cfWf6lf4Sy9pfs9g GbuUsDzNCCtnFbQ66lyJy8dubabXKG2gE9EScyZy+XaoZbFLFe8dJY8LKVv/X/2FgTEc pApA== X-Gm-Message-State: AOAM532OCwAZzqX3AtEESAlyPIgNUKvxoDkRTUP2yLg9CPpj+gUJiZSz 2zNFb3Teg4ysBKEL/4zLMO2JT8G0oHprVV70vPQxDsneA5ZnmVzoAkGiefJijSPI3dqpuUfY3+b 4Nj+Iq5MDD1RPfiw= X-Received: by 2002:a1c:283:: with SMTP id 125mr8972510wmc.12.1598106509463; Sat, 22 Aug 2020 07:28:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwaVN7dnbDmUJdjo97lChf1n2TBXjc+C5nifIFmPd4ikNVUf2yLTl89cgSlTNG3inH8AVEKdg== X-Received: by 2002:a1c:283:: with SMTP id 125mr8972496wmc.12.1598106509291; Sat, 22 Aug 2020 07:28:29 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 2/2] hw/isa/superio: Do not enforce class_size when inherited from parent Date: Sat, 22 Aug 2020 16:28:16 +0200 Message-Id: <20200822142816.1318214-3-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200822142816.1318214-1-philmd@redhat.com> References: <20200822142816.1318214-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.120; envelope-from=philmd@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/22 10:28:32 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , "Michael S. Tsirkin" , Jiaxun Yang , Aleksandar Markovic , Paolo Bonzini , Huacai Chen , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Eduardo Habkost When a class inherits from an abstract parent, its class_size is already initialized to its parent size. If the class is not extended, it is pointless to set the class_size field again. Signed-off-by: Eduardo Habkost Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/isa/smc37c669-superio.c | 1 - hw/isa/vt82c686.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/isa/smc37c669-superio.c b/hw/isa/smc37c669-superio.c index 9e59dc16039..18cdc641e13 100644 --- a/hw/isa/smc37c669-superio.c +++ b/hw/isa/smc37c669-superio.c @@ -103,7 +103,6 @@ static void smc37c669_class_init(ObjectClass *klass, vo= id *data) static const TypeInfo smc37c669_type_info =3D { .name =3D TYPE_SMC37C669_SUPERIO, .parent =3D TYPE_ISA_SUPERIO, - .class_size =3D sizeof(ISASuperIOClass), .class_init =3D smc37c669_class_init, }; =20 diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c index a4b84d405d0..49f2b21cebe 100644 --- a/hw/isa/vt82c686.c +++ b/hw/isa/vt82c686.c @@ -533,7 +533,6 @@ static void vt82c686b_superio_class_init(ObjectClass *k= lass, void *data) static const TypeInfo via_superio_info =3D { .name =3D TYPE_VT82C686B_SUPERIO, .parent =3D TYPE_ISA_SUPERIO, - .class_size =3D sizeof(ISASuperIOClass), .class_init =3D vt82c686b_superio_class_init, }; =20 --=20 2.26.2