From nobody Fri May 17 03:39:48 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1598106149; cv=none; d=zohomail.com; s=zohoarc; b=FjY9rM9Pnnve/GmZfruB78BAgkxu+l8jHtpaAVzLjRYkqrI1LmojBGKAXsniZlBJcTESEKvhpTlZgVqQmXoPBOEuz25naPgWxKbYjJlBfXjg2llH5AR4HyA0Qm657SgbpPgC1sSfKleIO5yOsZ1pFDe6he0lO34GkPv0e7eEh/A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598106149; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=f+1QVYQOzQZYw50deyHBN5VIG7WppOlPOHIOiqTBVMk=; b=I6ey+afAj846PCdbQP8b9XBVxAwMbaBfUF89PUXMTByIpHvg+6U0iKqt0/N+dXIAO2s/ogXmW4Hv2u6Dcln/oiSVrHgMMWIQsLf+KtfNS+fukBwXTHwYfLdsBclisa7t/JkpDN+KOm86U0F2QOwIl8NTvc9ZiVh42Af6oGZZ6oQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1598106149257612.2795331064575; Sat, 22 Aug 2020 07:22:29 -0700 (PDT) Received: from localhost ([::1]:51896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k9UPb-00056E-Hj for importer@patchew.org; Sat, 22 Aug 2020 10:22:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57536) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k9UOj-0004fA-0a for qemu-devel@nongnu.org; Sat, 22 Aug 2020 10:21:33 -0400 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:37708) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k9UOh-0002Z5-C9 for qemu-devel@nongnu.org; Sat, 22 Aug 2020 10:21:32 -0400 Received: by mail-wm1-x344.google.com with SMTP id x9so439773wmi.2 for ; Sat, 22 Aug 2020 07:21:30 -0700 (PDT) Received: from localhost.localdomain (121.red-81-40-121.staticip.rima-tde.net. [81.40.121.121]) by smtp.gmail.com with ESMTPSA id f16sm11385740wro.34.2020.08.22.07.21.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Aug 2020 07:21:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=f+1QVYQOzQZYw50deyHBN5VIG7WppOlPOHIOiqTBVMk=; b=o9pSqAn2f+dCyOL/24UH+orbyKvqw6Jy0LneInKT2i44r743Q3ucMrucbcE6mW4+gn /01OtZknplqpWOJVVySFb4ZgnDHa8zAPXPetjbzARMBGBaA6Sxs8tMBx2CJA8mr+uCom 82xQheOqiYPoJ1mXs5dvMxMfWq7QEb8fPco3YwJ12huEiQVOYbgmAu5sLyhhEjdkYGWQ WZdkcFauEWUhdMuQt7iElmDXdD+qt04KgnfrRjT4vbJPx9pFOUWYGAQBPxOcRNHzrcv1 FpbZ+0zjAWbhzdau4JY3mCvlaqq+nQ9c3x/A8V7pR4CUehslVjGgx44j6rL33MNjN5mb higw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=f+1QVYQOzQZYw50deyHBN5VIG7WppOlPOHIOiqTBVMk=; b=RzWA5nmcHDLlExiduKV4zQFSjfw5oT0uG3fZ0maUdJ+SkpTKIsMEDkJXFIjIPEKCWN CRPbc3yFhXOvDq9mXOrcQ+DBW2k4eWcjjDeW6a7gpwtFTQUHq6a3vWsujlzcdHPtZc3t zF3744bQyga3XunGkCgvGkCisxp7d0QpJxRWRIgX9Y7BiVkmkuRnCDDAubg+vei9Ohwh 4GXf1i+vM6sJr+aJD7BtGjoeLoKkyNNwqVpt/mYV6QguNpRKPFatb8dSDQqnwSa7qZNg 6Gn2ygUTvHYPNOLnJaBN+29+CaamJY+6p7QwsLpWAYcwROp7NE0IoYKEiPmySP+mxOkx OBIQ== X-Gm-Message-State: AOAM533dNFnuRmCSEz8EM7obe3CKDOpHvJXm9AUJrdJWX4iLO2wwCPpC 1aoR0x2CzMitlZxkoFE6vu0b+kTpAhY= X-Google-Smtp-Source: ABdhPJwCU95iMOyOmMPVpPVgHcQHBzHALqhPCIgLB9Rn1/FBmmk5TfdsjVYwqh689r5GYaPSJnL1AA== X-Received: by 2002:a1c:7918:: with SMTP id l24mr7497451wme.132.1598106089455; Sat, 22 Aug 2020 07:21:29 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH v2] hw/display/tcx: Allow 64-bit accesses to framebuffer stippler and blitter Date: Sat, 22 Aug 2020 16:21:27 +0200 Message-Id: <20200822142127.1316231-1-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::344; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x344.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Lorenz , 1892540@bugs.launchpad.net, Andreas Gustafsson , Mark Cave-Ayland , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) The S24/TCX datasheet is listed as "Unable to locate" on [1]. However the NetBSD revision 1.32 of the driver introduced 64-bit accesses to the stippler and blitter [2]. It is safe to assume these memory regions are 64-bit accessible. QEMU implementation is 32-bit, so fill the 'impl' fields. [1] http://web.archive.org/web/20111209011516/http://wikis.sun.com/display/= FOSSdocs/Home [2] http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/dev/sbus/tcx.c.diff?r1=3D1.= 31&r2=3D1.32 Reported-by: Andreas Gustafsson Buglink: https://bugs.launchpad.net/bugs/1892540 Fixes: 55d7bfe2293 ("tcx: Implement hardware acceleration") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Tested-by: Michael S. Tsirkin --- Since v1: - added missing uncommitted staged changes... (tcx_blit_ops) --- hw/display/tcx.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/hw/display/tcx.c b/hw/display/tcx.c index 1fb45b1aab8..96c6898b149 100644 --- a/hw/display/tcx.c +++ b/hw/display/tcx.c @@ -548,20 +548,28 @@ static const MemoryRegionOps tcx_stip_ops =3D { .read =3D tcx_stip_readl, .write =3D tcx_stip_writel, .endianness =3D DEVICE_NATIVE_ENDIAN, - .valid =3D { + .impl =3D { .min_access_size =3D 4, .max_access_size =3D 4, }, + .valid =3D { + .min_access_size =3D 4, + .max_access_size =3D 8, + }, }; =20 static const MemoryRegionOps tcx_rstip_ops =3D { .read =3D tcx_stip_readl, .write =3D tcx_rstip_writel, .endianness =3D DEVICE_NATIVE_ENDIAN, - .valid =3D { + .impl =3D { .min_access_size =3D 4, .max_access_size =3D 4, }, + .valid =3D { + .min_access_size =3D 4, + .max_access_size =3D 8, + }, }; =20 static uint64_t tcx_blit_readl(void *opaque, hwaddr addr, @@ -650,10 +658,14 @@ static const MemoryRegionOps tcx_rblit_ops =3D { .read =3D tcx_blit_readl, .write =3D tcx_rblit_writel, .endianness =3D DEVICE_NATIVE_ENDIAN, - .valid =3D { + .impl =3D { .min_access_size =3D 4, .max_access_size =3D 4, }, + .valid =3D { + .min_access_size =3D 4, + .max_access_size =3D 8, + }, }; =20 static void tcx_invalidate_cursor_position(TCXState *s) --=20 2.26.2