From nobody Mon Feb 9 10:29:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1597942968; cv=none; d=zohomail.com; s=zohoarc; b=XRib2KtO9TMOzSuyO4Ja1HJvFPGqwxx4IkT68/XWP9WVQME8WpF+IU6A8RnhYxyYiviOJM3YYFOAGQvIzObCAnt9MJGwRgmjkoAi/8g0mfdCdsFJD7WbhtjquhiTbfYaFmkEdfSODBF87YyuaJ9kNPqDewGdTJJ8ZdL7er4fcAY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597942968; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=xMDzywp//OugMrKjSizTC3WTyFIJ7uQWbux4Y7eWkQY=; b=mZ8v4qYgQNVifhUpCz6Pjjv8h7XUZCyhE/DhSRKsC4h0mVmp+LVahqGoNVidlJ9/yQZemlI5oA7Y1wzp9s5FOaFPg707vkT9pu5VIkOw0hw3kZZhf+UTnqUFPCxHVyLtCJ/DsLl+3Xlbi3R8MTd/NluoBnw5S8ac0T/dlHjkJDc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1597942968379685.8261375103199; Thu, 20 Aug 2020 10:02:48 -0700 (PDT) Received: from localhost ([::1]:57060 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k8nxe-0007kW-Lu for importer@patchew.org; Thu, 20 Aug 2020 13:02:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35680) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k8nua-0003VK-AG for qemu-devel@nongnu.org; Thu, 20 Aug 2020 12:59:36 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:21625 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k8nuX-0006DH-Np for qemu-devel@nongnu.org; Thu, 20 Aug 2020 12:59:35 -0400 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-200-dY8FWrNnN9eTG7CwsF4nOA-1; Thu, 20 Aug 2020 12:59:31 -0400 Received: by mail-wm1-f70.google.com with SMTP id u14so1941791wml.0 for ; Thu, 20 Aug 2020 09:59:31 -0700 (PDT) Received: from x1w.redhat.com (121.red-81-40-121.staticip.rima-tde.net. [81.40.121.121]) by smtp.gmail.com with ESMTPSA id j4sm5136932wmi.48.2020.08.20.09.59.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2020 09:59:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597942772; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xMDzywp//OugMrKjSizTC3WTyFIJ7uQWbux4Y7eWkQY=; b=HRB/u5DDJLJNVgnnSJRdSYTdJMXUWgSJNBUrzQTW6fEs0u1KMWTnXUX9QkVknACe2+VXHT mw2OeyXQ644cy3zdPfTJxKCvDoWpkCTHfistWBKgCN+YuAXbxUM3Eo0Ha/guV8X8MM6RE1 7Am6TWU0f6QmV42M50cR85+4VUqfpBw= X-MC-Unique: dY8FWrNnN9eTG7CwsF4nOA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xMDzywp//OugMrKjSizTC3WTyFIJ7uQWbux4Y7eWkQY=; b=rumhFKVe1rqq7nx50A4Pox7PV/wGtUhs71KSxTTnsdMu2+RQrsicjA7FpfdFmd/Gyj mAT+u2v4cduqrdFJJa48DCX+xf4BKZlt/hL4TdcqK/aCtMfKyx7u8+8/37kOnQWWDxea rkCXIp+tvS+2lCHbu5hMNyzM95JeuXspIpUoWClhJr7SxBne4t4jQ8m3KJwCcgUgKmXU 0X2lXMFvBeOOYygj62cAnyjrEHhyS4/KKaC73GWbveqLXODhlAz+DL+jviSB8jl3qN21 /EBhzLlONGL7gTm5sWYD2PK+hvtvEjPK0eLhrx/SbYoTXPCFYrzhH0SaXfhSxgomuvpC pLyA== X-Gm-Message-State: AOAM531fuqhyZXSOanfbGeHRYPsR8q801Oz0D73JbpKMZ4PcgCMBOUlg maLM9GnreTbl0s3S/7rliIqEFvLn1wTDqG+uJ7rTPy4XwPgkPg5EvdtIg5NWRNV8Y/otXWCvEzV QMSXae69MagjsV+s= X-Received: by 2002:a7b:c401:: with SMTP id k1mr4259211wmi.18.1597942770038; Thu, 20 Aug 2020 09:59:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyIlDAdqewr7poOXewRpVpML2nR7umyFdrOqfMoM0E+zIsKaFM90r1HpKBZxKX7NTWwSS9XKA== X-Received: by 2002:a7b:c401:: with SMTP id k1mr4259203wmi.18.1597942769906; Thu, 20 Aug 2020 09:59:29 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v5 05/15] block/nvme: Improve error message when IO queue creation failed Date: Thu, 20 Aug 2020 18:58:51 +0200 Message-Id: <20200820165901.1139109-6-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200820165901.1139109-1-philmd@redhat.com> References: <20200820165901.1139109-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/20 03:03:34 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Kevin Wolf , qemu-block@nongnu.org, Max Reitz , Stefan Hajnoczi , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Do not use the same error message for different failures. Display a different error whether it is the CQ or the SQ. Reviewed-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Stefano Garzarella --- block/nvme.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/nvme.c b/block/nvme.c index 003809fbd83..53448b7d230 100644 --- a/block/nvme.c +++ b/block/nvme.c @@ -648,7 +648,7 @@ static bool nvme_add_io_queue(BlockDriverState *bs, Err= or **errp) .cdw11 =3D cpu_to_le32(0x3), }; if (nvme_cmd_sync(bs, s->queues[INDEX_ADMIN], &cmd)) { - error_setg(errp, "Failed to create io queue [%d]", n); + error_setg(errp, "Failed to create CQ io queue [%d]", n); nvme_free_queue_pair(q); return false; } @@ -659,7 +659,7 @@ static bool nvme_add_io_queue(BlockDriverState *bs, Err= or **errp) .cdw11 =3D cpu_to_le32(0x1 | (n << 16)), }; if (nvme_cmd_sync(bs, s->queues[INDEX_ADMIN], &cmd)) { - error_setg(errp, "Failed to create io queue [%d]", n); + error_setg(errp, "Failed to create SQ io queue [%d]", n); nvme_free_queue_pair(q); return false; } --=20 2.26.2