From nobody Sat Feb 7 06:39:52 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1597935609; cv=none; d=zohomail.com; s=zohoarc; b=dg5M/jFRPPWx5tDWgygdQLQ1PP0TTVQx+9idVfm3iLOLliLNnbgKQ0XUmysB2mMQZ1yAHFT08bi/sSVRqptY0xB1IMIS14I7h//w/yZv7rZZfADzMlmSK/yiCXZuIhGpiJ3208YMKljsUGBsiAucb448xJEtypxIW0WuTHZIV3M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597935609; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=0bFXu0/5Hwwr35baKveo9eGBIbuOUSmbsq/iU/omYQ0=; b=fNyp1wWibFmYlGbm/DiNN4KfHm4ffnRAem6AnR67IS8tLrQHpCyrac6q6Svto16gf3N5T4Gz2+UcqrYSzJ+m+2iB/P7ZYaKlOabyK8YKrPzpPHxtFA+zXjGmrEtkZcYhZeAXbAbgrPJPw3KAbkUrd0cSEMoYp3rAXu2tS/pyFHk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1597935609445533.6611774141437; Thu, 20 Aug 2020 08:00:09 -0700 (PDT) Received: from localhost ([::1]:45752 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k8m2w-0002Hk-2D for importer@patchew.org; Thu, 20 Aug 2020 11:00:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60034) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k8m24-0001q8-17 for qemu-devel@nongnu.org; Thu, 20 Aug 2020 10:59:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:24635) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k8m22-000526-5J for qemu-devel@nongnu.org; Thu, 20 Aug 2020 10:59:11 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-250-M2QOJH3EOaaUSWRq_qCMuw-1; Thu, 20 Aug 2020 10:59:02 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7BDF4425CB; Thu, 20 Aug 2020 14:59:01 +0000 (UTC) Received: from fziglio.remote.csb (unknown [10.40.195.108]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3CBAA60BF1; Thu, 20 Aug 2020 14:58:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597935548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0bFXu0/5Hwwr35baKveo9eGBIbuOUSmbsq/iU/omYQ0=; b=NPS8LPwURO4gP+oASLJRUc9aTfdHGJt7XZxCOe39cEAA8ZwblCW9iip4YC69UkNLTAGMlx pg1C+98Xt9vMZYvaczzutXdqMtMv178tyU4r51OcW/YeeDZjfjBjSpGgR3dP7B2jzQbEdS 8vbEl/rvMRlx20EpBI7GSoGLDJZ7sMI= X-MC-Unique: M2QOJH3EOaaUSWRq_qCMuw-1 From: Frediano Ziglio To: Gerd Hoffmann Subject: [PATCH] ui: Add more mouse buttons to SPICE Date: Thu, 20 Aug 2020 15:58:51 +0100 Message-Id: <20200820145851.50846-1-fziglio@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=fziglio@redhat.com X-Mimecast-Spam-Score: 0.003 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=fziglio@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/20 09:00:23 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Frediano Ziglio Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Frediano Ziglio Add support for SIDE and EXTRA buttons. The constants for buttons in both SPICE and QEMU are defined as LEFT MIDDLE RIGHT UP DOWN SIDE EXTRA (same order). "button_mask" contains for each bit the state of a button. Qemu currently uses bits 0, 1, 2 respectively as LEFT, RIGHT, MIDDLE; also add bits 4 and 5 as UP and DOWN (using wheel movements). SPICE protocol uses a bitmask based on the order above where LEFT is bit 0, MIDDLE is bit 1 and so on till EXTRA being bit 6. To avoid clash with Qemu usage SPICE bitmask from SIDE are move a bit more resulting respectively in 0x40 and 0x80 values. Signed-off-by: Frediano Ziglio --- ui/spice-input.c | 2 ++ 1 file changed, 2 insertions(+) See also https://gitlab.freedesktop.org/spice/spice/-/merge_requests/140 diff --git a/ui/spice-input.c b/ui/spice-input.c index cd4bb0043f..d5bba231c9 100644 --- a/ui/spice-input.c +++ b/ui/spice-input.c @@ -123,6 +123,8 @@ static void spice_update_buttons(QemuSpicePointer *poin= ter, [INPUT_BUTTON_RIGHT] =3D 0x02, [INPUT_BUTTON_WHEEL_UP] =3D 0x10, [INPUT_BUTTON_WHEEL_DOWN] =3D 0x20, + [INPUT_BUTTON_SIDE] =3D 0x40, + [INPUT_BUTTON_EXTRA] =3D 0x80, }; =20 if (wheel < 0) { --=20 2.25.4