From nobody Tue Feb 10 01:33:17 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1597724647; cv=none; d=zohomail.com; s=zohoarc; b=N2wb1DCTE41NQJ4zBnfq4hjvGQESQaMmWbse4dcstHZwLCS0fPlQkT6Bc1HkSo0s92AbGB4XUXZPL63fu9ZfFPHGhF+7M/gZTynjBv8UtVRU5EW98UoMjWZ7p/foSCBDFQdvndD1nCBNlwpi91+JEpAt9K++taFl0asX/CmQ9Uk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597724647; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=YlkFBfe6eLYH0BcmiZ1nLVAHGfnY0V5i0Jp7kXtVug4=; b=KnUYhU2k8nB36DH21E1ZRDLTxhLgoT05F7L25Ht2KOsSahkPbElGYrHBL8AH6QqIuiCqsNzWVEQovwBZ41zhI1RDi8Ec8DvhcWflbjjQbDdBBEmyRWVXAIVMciK6qKfb22ywftt5ajM7aGI6H83McKK4CfeFx6fQ5sqnlvkP+Rw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1597724647385990.0256920579052; Mon, 17 Aug 2020 21:24:07 -0700 (PDT) Received: from localhost ([::1]:40458 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k7tAM-0005oo-5D for importer@patchew.org; Tue, 18 Aug 2020 00:24:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49948) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k7t68-0007MV-CI; Tue, 18 Aug 2020 00:19:44 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:38053) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k7t66-0006LN-2y; Tue, 18 Aug 2020 00:19:44 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 4BVyNZ3nT3z9sV1; Tue, 18 Aug 2020 14:19:26 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1597724366; bh=DDx05xw1OIDE5M5zfqz3Kclc5VMes58zkL4yq+6/qGI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mEtxObkOXS7US8DR1ge+lWMSFOKqonHduSLejpPLOA4DlK1iIhhZP6NwUwbW+LPUS DUp6a5yUkcAahQLcknv6MlToN/z00tkwQZGiom9KT8akkVl/PlmJLYbQcSFp7XZYbw 7o6vsdVb0PynDlrOMX8ewlYQNcyWVQefPLKox2iw= From: David Gibson To: peter.maydell@linaro.org, groug@kaod.org Subject: [PULL 09/40] spapr: Forbid nested KVM-HV in pre-power9 compat mode Date: Tue, 18 Aug 2020 14:18:51 +1000 Message-Id: <20200818041922.251708-10-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200818041922.251708-1-david@gibson.dropbear.id.au> References: <20200818041922.251708-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2401:3900:2:1::2; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -9 X-Spam_score: -1.0 X-Spam_bar: - X-Spam_report: (-1.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Greg Kurz Nested KVM HV only works if the kernel is using the radix MMU mode, ie. the CPU is POWER9 and it is not running in some pre-power9 compat mode. Otherwise, the KVM HV module fails to load in the guest with -ENODEV. It might be painful for a user to discover this late that nested cannot work with their setup. Erroring out at machine init instead seems to be the best we can do. Signed-off-by: Greg Kurz Reviewed-by: Laurent Vivier Message-Id: <159491948127.188975.9621435875869177751.stgit@bahia.lan> Signed-off-by: David Gibson --- hw/ppc/spapr_caps.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/hw/ppc/spapr_caps.c b/hw/ppc/spapr_caps.c index 275f5bd034..10a80a8159 100644 --- a/hw/ppc/spapr_caps.c +++ b/hw/ppc/spapr_caps.c @@ -382,6 +382,8 @@ static void cap_nested_kvm_hv_apply(SpaprMachineState *= spapr, uint8_t val, Error **errp) { ERRP_GUARD(); + PowerPCCPU *cpu =3D POWERPC_CPU(first_cpu); + if (!val) { /* capability disabled by default */ return; @@ -391,6 +393,14 @@ static void cap_nested_kvm_hv_apply(SpaprMachineState = *spapr, error_setg(errp, "No Nested KVM-HV support in TCG"); error_append_hint(errp, "Try appending -machine cap-nested-hv=3Dof= f\n"); } else if (kvm_enabled()) { + if (!ppc_check_compat(cpu, CPU_POWERPC_LOGICAL_3_00, 0, + spapr->max_compat_pvr)) { + error_setg(errp, "Nested KVM-HV only supported on POWER9"); + error_append_hint(errp, + "Try appending -machine max-cpu-compat=3Dpow= er9\n"); + return; + } + if (!kvmppc_has_cap_nested_kvm_hv()) { error_setg(errp, "KVM implementation does not support Nested KVM-HV"= ); --=20 2.26.2