From nobody Tue Feb 10 02:30:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1597655296; cv=none; d=zohomail.com; s=zohoarc; b=B9qkTMaSk4A8Gq0irFAgTXzGFnxTRwvzg7RuyDlgQubcHog/GlC0q9swgJ0We3E7J71+35T5ONVVEoqJBMfyzhEs7MKuwrZcwV+zV7SRVzrrteqQjWa6mMCnTazjUZX4n0RrWA1nH/atvYe7OKMTZCPRgMI5Vijc3J0qOk7Cd3Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597655296; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=1h242cn87gEvHPFkSZYXTg01bP4q0OLx1vN+0ljsauE=; b=U26y5buOhJo22VLj4Ypl6di3alLu0X0q3BCz0y67KPx+c5UJIZt8JA7xpr84rawYaV2Afq6e3zTFNtZ4nTS26yHxYjAt0fWf1S0Mx153K14X623TMJfSfyhShK+Ikd44f1xJJ3S2e1TU7+uNj2gwLvLcVNCe/V7tmo4uwCDoQdI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1597655296143991.721228654327; Mon, 17 Aug 2020 02:08:16 -0700 (PDT) Received: from localhost ([::1]:40820 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k7b7m-0007ND-Sy for importer@patchew.org; Mon, 17 Aug 2020 05:08:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45224) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k7ard-0000Lt-MQ for qemu-devel@nongnu.org; Mon, 17 Aug 2020 04:51:33 -0400 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]:34541) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k7arc-00055f-0z for qemu-devel@nongnu.org; Mon, 17 Aug 2020 04:51:33 -0400 Received: by mail-pj1-x1030.google.com with SMTP id c10so7664036pjn.1 for ; Mon, 17 Aug 2020 01:51:31 -0700 (PDT) Received: from frankchang-ThinkPad-T490.internal.sifive.com (114-34-229-221.HINET-IP.hinet.net. [114.34.229.221]) by smtp.gmail.com with ESMTPSA id d9sm16478588pgv.45.2020.08.17.01.51.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2020 01:51:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=1h242cn87gEvHPFkSZYXTg01bP4q0OLx1vN+0ljsauE=; b=iEJ2iWXQugy5FhCt7OsBPG4L5fyPkM/RyaLiszoqdPpwPrqclvuHWGZ7cyv8A4huns ccETFwpPxiH6jaQAzSNOxcn33+A6W1wHgjkjkV0f/2ou72yKYnf8Hf75q1/Cc6l3t/F3 kNQWG8bmHqltafeZhT0UOrtbKagx4hIHQjWBkBRUjXh9rkubP8GjXRFv/NpdhJ/Z3gxR sUcbYdchGhu5AW89AIG6mApBWZaSYvKjebfapJpU/UTBV7hrChU+MF7ESFw1Vkycsml0 hm69+yogqhkjVYrrnI3Pji5RsW6QkLJhXw137yv6BDqOGhi901TIe8dEZk1URAjzW/kI MNng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1h242cn87gEvHPFkSZYXTg01bP4q0OLx1vN+0ljsauE=; b=cDM6iSXF/SqH1OCDPjXEIUWrcqrkBrZPt7W5Q5eOy72+1meJTTKl+aJn79SKdjMkkD gFk3/zQnfKXtKtU/GJCA6rCDyYtZtBqKyZfTp8rvcgkD3FzdxhoprF2wad1R2o5AqsMb DqH5IpGicfjIo2uTngsliI1G9O+BMjSJ5Xw1hDOEDMoh03vthOgPSMHyXd57Bj/vek7u LOx28YYX0PCDjXfnoqtzk9xG81Kdiii/Oq4pLbriRj2TjAD0Kno1xhJsuOfFCy3et6Yb jl8IS+UM5KbrQA4eqe0mlunvgFajy9qZAEz8s7a+NcAlD6WVkoFtGpXxBSERAANs/2hH tVZg== X-Gm-Message-State: AOAM531r6/cIZbkZpSDStwEAvIpukOEtwGmYbjlcW1jKROufwV1Cn93S wjWiX3T/nJvA6eg3MJu85/soNJCSqii+2Q== X-Google-Smtp-Source: ABdhPJyBT/uND6XfoetXDkek9aCr5OAkBN8RyNY8eFxNgP+hzjSlXT/p6hIohQ246Akug1ldoqbdAA== X-Received: by 2002:a17:90a:ff07:: with SMTP id ce7mr11695001pjb.192.1597654290418; Mon, 17 Aug 2020 01:51:30 -0700 (PDT) From: frank.chang@sifive.com To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org Subject: [RFC v4 30/70] target/riscv: rvv-1.0: set-X-first mask bit instructions Date: Mon, 17 Aug 2020 16:49:15 +0800 Message-Id: <20200817084955.28793-31-frank.chang@sifive.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200817084955.28793-1-frank.chang@sifive.com> References: <20200817084955.28793-1-frank.chang@sifive.com> Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1030; envelope-from=frank.chang@sifive.com; helo=mail-pj1-x1030.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Frank Chang , Alistair Francis , Palmer Dabbelt , Sagar Karandikar , Bastian Koppelmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Frank Chang Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/insn32.decode | 6 +++--- target/riscv/insn_trans/trans_rvv.inc.c | 5 ++++- target/riscv/vector_helper.c | 4 ---- 3 files changed, 7 insertions(+), 8 deletions(-) diff --git a/target/riscv/insn32.decode b/target/riscv/insn32.decode index d72120cfd85..0992d6ac86d 100644 --- a/target/riscv/insn32.decode +++ b/target/riscv/insn32.decode @@ -593,9 +593,9 @@ vmornot_mm 011100 - ..... ..... 010 ..... 1010111 = @r vmxnor_mm 011111 - ..... ..... 010 ..... 1010111 @r vpopc_m 010000 . ..... 10000 010 ..... 1010111 @r2_vm vfirst_m 010000 . ..... 10001 010 ..... 1010111 @r2_vm -vmsbf_m 010110 . ..... 00001 010 ..... 1010111 @r2_vm -vmsif_m 010110 . ..... 00011 010 ..... 1010111 @r2_vm -vmsof_m 010110 . ..... 00010 010 ..... 1010111 @r2_vm +vmsbf_m 010100 . ..... 00001 010 ..... 1010111 @r2_vm +vmsif_m 010100 . ..... 00011 010 ..... 1010111 @r2_vm +vmsof_m 010100 . ..... 00010 010 ..... 1010111 @r2_vm viota_m 010110 . ..... 10000 010 ..... 1010111 @r2_vm vid_v 010110 . 00000 10001 010 ..... 1010111 @r1_vm vext_x_v 001100 1 ..... ..... 010 ..... 1010111 @r diff --git a/target/riscv/insn_trans/trans_rvv.inc.c b/target/riscv/insn_tr= ans/trans_rvv.inc.c index e1f9903a8b5..b21fa747d84 100644 --- a/target/riscv/insn_trans/trans_rvv.inc.c +++ b/target/riscv/insn_trans/trans_rvv.inc.c @@ -2966,7 +2966,10 @@ static bool trans_vfirst_m(DisasContext *s, arg_rmr = *a) #define GEN_M_TRANS(NAME) \ static bool trans_##NAME(DisasContext *s, arg_rmr *a) \ { \ - if (vext_check_isa_ill(s)) { \ + if (require_rvv(s) && \ + vext_check_isa_ill(s) && \ + require_vm(a->vm, a->rd) && \ + (a->rd !=3D a->rs2)) { \ uint32_t data =3D 0; \ gen_helper_gvec_3_ptr *fn =3D gen_helper_##NAME; \ TCGLabel *over =3D gen_new_label(); \ diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c index 973eb689c51..716e1926ee2 100644 --- a/target/riscv/vector_helper.c +++ b/target/riscv/vector_helper.c @@ -4493,7 +4493,6 @@ enum set_mask_type { static void vmsetm(void *vd, void *v0, void *vs2, CPURISCVState *env, uint32_t desc, enum set_mask_type type) { - uint32_t vlmax =3D env_archcpu(env)->cfg.vlen; uint32_t vm =3D vext_vm(desc); uint32_t vl =3D env->vl; int i; @@ -4523,9 +4522,6 @@ static void vmsetm(void *vd, void *v0, void *vs2, CPU= RISCVState *env, } } } - for (; i < vlmax; i++) { - vext_set_elem_mask(vd, i, 0); - } } =20 void HELPER(vmsbf_m)(void *vd, void *v0, void *vs2, CPURISCVState *env, --=20 2.17.1