From nobody Mon Feb 9 20:34:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1597654787; cv=none; d=zohomail.com; s=zohoarc; b=DICPLtgzl9fm6wnysd1m2OGtCzDhZR7nmWMv8n7yiBSTDxKymsOe/ZvThTG+IPOjvMDP5Q3h0OCWO4i9/b8TTlBb4DMwvELoHbWjXLOL6fXeWe7By0o0ujTiygj1v9DG2+QqWC0b7PapcNQryefCrXgzpbS9mgIuHDVUD7CLFZk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597654787; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=LdFgf4NPBtoeqHpSLjq5VQqyoxEgDzcCNkK0t9em+iQ=; b=kFmQ1U2XdjY8FYXOeBJ/9K6rx5PPekWtqDVtRwNW70AKIvO6RWybQ+JkwvnLUKz38vnJADCrDzrV1Dgdmn9/FEEiSZoEylACwByNe4J6N8Ta9bSN1Y6jgZHfa9DHAnkpF9MXDl4shMp3pcRs5wWxKBBTfczAR1WBbinBAqxjKk8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1597654787647915.6242607535511; Mon, 17 Aug 2020 01:59:47 -0700 (PDT) Received: from localhost ([::1]:54472 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k7aza-000718-5z for importer@patchew.org; Mon, 17 Aug 2020 04:59:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45158) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k7arY-000077-9J for qemu-devel@nongnu.org; Mon, 17 Aug 2020 04:51:28 -0400 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]:42366) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k7arW-00054o-I8 for qemu-devel@nongnu.org; Mon, 17 Aug 2020 04:51:27 -0400 Received: by mail-pl1-x62e.google.com with SMTP id f5so7157269plr.9 for ; Mon, 17 Aug 2020 01:51:26 -0700 (PDT) Received: from frankchang-ThinkPad-T490.internal.sifive.com (114-34-229-221.HINET-IP.hinet.net. [114.34.229.221]) by smtp.gmail.com with ESMTPSA id d9sm16478588pgv.45.2020.08.17.01.51.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2020 01:51:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=LdFgf4NPBtoeqHpSLjq5VQqyoxEgDzcCNkK0t9em+iQ=; b=XB2bK0ifvc/Pafw+8p3LqBDW1g0WMYG+SbdiDZyHX2rq9TriBAXzegJwMgrQIA4OOF DAt7ZTx5GT2/92kSfA7Q6SVEDcHRe1pgo23ujltCnftAmg+YW4yxK3StyRs0tjhApRmx j6S5T+FP+qrj9WB16CU/igMmHRNjBGwLHOvlJ0Vjt1vlQHDSM1Q1jrAwgZS+sP5VUFEx 1H5tP5AkXB5qtmoPL5PxQxHa82VHQjoWeAuvLDxac3x0FlhnzUj3h1IBF99aGvassj3e ehvo0TJy4pmbcOVdk3+QwSNb/fuGWdLWK5dwK/rXxv8pVMMBOtlqTXmdMvXJKShNXgZG t7lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=LdFgf4NPBtoeqHpSLjq5VQqyoxEgDzcCNkK0t9em+iQ=; b=Jgw9K3IIyvpPxkY00mg8QZYFbDMwvUPlq5kla9VcIXFgBmnjGi3kq0T7dI2Yx7G8KO rF4zoVgfVq4OVMiQeVjx4ea5kTJNxslE9waWpaXyH3L6goRh7/74ePZGJvF9WShHDhi6 ASJ5WJLcYcsiD6BPgA/d9gLR0+IcOsegLntHcR+1mpPagb/J+7kFm9709AzNdPbe9vW8 oWf0g7d51WqT7jkfVIG1W1d+/X/RMyFVFe/b4qlnQ3UoYm4IcS6n/1lXrnZq0JSd4jWX 6OhgIBt6JhcWJIOrz12b78Iy4ipBnYEqnKudfIwrJG80IKIq0pyNSQyRfjQBJAPuhTTJ FyHA== X-Gm-Message-State: AOAM5319IRbNFvJF3ktcNIsZGYUmzRYvOLlsdCAPrnAdGg7+39ocGbnQ ZdHmFF58VwaFeNNR15BblAs+T0QOa5WnrQ== X-Google-Smtp-Source: ABdhPJz8N6fT2prIb1G+GfHxEg+rze8PEY0cz8yCZqnxYTrvHFXGWjlsFlqLpLPd9g9CL9n0Vjbvqg== X-Received: by 2002:a17:902:690a:: with SMTP id j10mr10481468plk.155.1597654285078; Mon, 17 Aug 2020 01:51:25 -0700 (PDT) From: frank.chang@sifive.com To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org Subject: [RFC v4 28/70] target/riscv: rvv-1.0: mask population count instruction Date: Mon, 17 Aug 2020 16:49:13 +0800 Message-Id: <20200817084955.28793-29-frank.chang@sifive.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200817084955.28793-1-frank.chang@sifive.com> References: <20200817084955.28793-1-frank.chang@sifive.com> Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62e; envelope-from=frank.chang@sifive.com; helo=mail-pl1-x62e.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Frank Chang , Alistair Francis , Palmer Dabbelt , Sagar Karandikar , Bastian Koppelmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Frank Chang Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/helper.h | 2 +- target/riscv/insn32.decode | 2 +- target/riscv/insn_trans/trans_rvv.inc.c | 7 ++++--- target/riscv/vector_helper.c | 6 +++--- 4 files changed, 9 insertions(+), 8 deletions(-) diff --git a/target/riscv/helper.h b/target/riscv/helper.h index 25d076d71a8..0a1179370b1 100644 --- a/target/riscv/helper.h +++ b/target/riscv/helper.h @@ -1066,7 +1066,7 @@ DEF_HELPER_6(vmnor_mm, void, ptr, ptr, ptr, ptr, env,= i32) DEF_HELPER_6(vmornot_mm, void, ptr, ptr, ptr, ptr, env, i32) DEF_HELPER_6(vmxnor_mm, void, ptr, ptr, ptr, ptr, env, i32) =20 -DEF_HELPER_4(vmpopc_m, tl, ptr, ptr, env, i32) +DEF_HELPER_4(vpopc_m, tl, ptr, ptr, env, i32) =20 DEF_HELPER_4(vmfirst_m, tl, ptr, ptr, env, i32) =20 diff --git a/target/riscv/insn32.decode b/target/riscv/insn32.decode index a800c989050..3d2d43ebd8a 100644 --- a/target/riscv/insn32.decode +++ b/target/riscv/insn32.decode @@ -591,7 +591,7 @@ vmor_mm 011010 - ..... ..... 010 ..... 1010111 = @r vmnor_mm 011110 - ..... ..... 010 ..... 1010111 @r vmornot_mm 011100 - ..... ..... 010 ..... 1010111 @r vmxnor_mm 011111 - ..... ..... 010 ..... 1010111 @r -vmpopc_m 010100 . ..... ----- 010 ..... 1010111 @r2_vm +vpopc_m 010000 . ..... 10000 010 ..... 1010111 @r2_vm vmfirst_m 010101 . ..... ----- 010 ..... 1010111 @r2_vm vmsbf_m 010110 . ..... 00001 010 ..... 1010111 @r2_vm vmsif_m 010110 . ..... 00011 010 ..... 1010111 @r2_vm diff --git a/target/riscv/insn_trans/trans_rvv.inc.c b/target/riscv/insn_tr= ans/trans_rvv.inc.c index 2c6efce00a7..ce963c33af8 100644 --- a/target/riscv/insn_trans/trans_rvv.inc.c +++ b/target/riscv/insn_trans/trans_rvv.inc.c @@ -2895,8 +2895,8 @@ GEN_MM_TRANS(vmnor_mm) GEN_MM_TRANS(vmornot_mm) GEN_MM_TRANS(vmxnor_mm) =20 -/* Vector mask population count vmpopc */ -static bool trans_vmpopc_m(DisasContext *s, arg_rmr *a) +/* Vector mask population count vpopc */ +static bool trans_vpopc_m(DisasContext *s, arg_rmr *a) { if (require_rvv(s) && vext_check_isa_ill(s)) { @@ -2915,13 +2915,14 @@ static bool trans_vmpopc_m(DisasContext *s, arg_rmr= *a) tcg_gen_addi_ptr(src2, cpu_env, vreg_ofs(s, a->rs2)); tcg_gen_addi_ptr(mask, cpu_env, vreg_ofs(s, 0)); =20 - gen_helper_vmpopc_m(dst, mask, src2, cpu_env, desc); + gen_helper_vpopc_m(dst, mask, src2, cpu_env, desc); gen_set_gpr(a->rd, dst); =20 tcg_temp_free_ptr(mask); tcg_temp_free_ptr(src2); tcg_temp_free(dst); tcg_temp_free_i32(desc); + return true; } return false; diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c index f802e8c9c05..13694c1b2c4 100644 --- a/target/riscv/vector_helper.c +++ b/target/riscv/vector_helper.c @@ -4447,9 +4447,9 @@ GEN_VEXT_MASK_VV(vmnor_mm, DO_NOR) GEN_VEXT_MASK_VV(vmornot_mm, DO_ORNOT) GEN_VEXT_MASK_VV(vmxnor_mm, DO_XNOR) =20 -/* Vector mask population count vmpopc */ -target_ulong HELPER(vmpopc_m)(void *v0, void *vs2, CPURISCVState *env, - uint32_t desc) +/* Vector mask population count vpopc */ +target_ulong HELPER(vpopc_m)(void *v0, void *vs2, CPURISCVState *env, + uint32_t desc) { target_ulong cnt =3D 0; uint32_t vm =3D vext_vm(desc); --=20 2.17.1