From nobody Sun May 12 12:51:56 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1597602413; cv=none; d=zohomail.com; s=zohoarc; b=aGkBP0jR6+rOyLcmA7WnEKVIhccQTPM+znOXZ/aGH+5hRoQS8xuincgmBOswQrtxPgaaUeRvfm9wmUSWH22BFSuD93Fuba0j7OssE82THsI4acN/ynrO4R83quH/f6aDhgpFQEbV0MA6Bcsos2aGfA494NvDFr4UN3m6EVk4DBA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597602413; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=foLrN1/bHDkeocz+h/WD6CFykMSU5DGbqxqlC9JoDZ0=; b=C+dQ0eMyDTICNNb9hD/8+VyuFTeq/GV+NEPFLiUtZHNPAksMTSyRMqBulsmcyRh7FmE8UNxFZH6/z2YRLFlvvxV1si9oFltRzM4fTaCyztzBmaKj+cSFudy8AQm2EqqH34jVWwaM5lml6c1i88i6gWIBngO8XlUjpJZOoBk8EP4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1597602413500117.13823319842254; Sun, 16 Aug 2020 11:26:53 -0700 (PDT) Received: from localhost ([::1]:45352 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k7NMp-0007KT-Dj for importer@patchew.org; Sun, 16 Aug 2020 14:26:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53610) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k7NMA-0006s5-TA for qemu-devel@nongnu.org; Sun, 16 Aug 2020 14:26:10 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:42830) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k7NM6-0005gZ-OQ for qemu-devel@nongnu.org; Sun, 16 Aug 2020 14:26:10 -0400 Received: by mail-wr1-x444.google.com with SMTP id r4so12726332wrx.9 for ; Sun, 16 Aug 2020 11:26:06 -0700 (PDT) Received: from localhost.localdomain (121.red-81-40-121.staticip.rima-tde.net. [81.40.121.121]) by smtp.gmail.com with ESMTPSA id p22sm24809489wmc.38.2020.08.16.11.26.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Aug 2020 11:26:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=foLrN1/bHDkeocz+h/WD6CFykMSU5DGbqxqlC9JoDZ0=; b=XcJp083NiZJQep0L3SjYSS7TBnnmKvVBIa6+1iQiEnz5CEzuq1S8C3XHCwpUHdSzFC UMvi9JDk2AXEjjn5b1hlXOIoU/ze4a5g2b+3ZAuoPVu5gwQ4f2aBeMmMQ0tl8hiDFgHY GP25+B94IRyaU9YxX3ZHD6Dnk2evE97gI/6Qy3F1wMiv6J+V4wAk0dagsAMUGh81IUIw VbTYWAmQ+2CWQ1G/3+KdzS5K2gPsHf5ygUfwaceIe89HWTA9NSa7Vmr06rD22adgxAsk z72ffD9l8TixzEkq+RfU2FFRESfqAiSoRvpeL0mu5S7O/ayWWc/y+SxjzbDd0458okL3 BAyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=foLrN1/bHDkeocz+h/WD6CFykMSU5DGbqxqlC9JoDZ0=; b=FkuJ9TFlJ4OxnnNYfeIzLuJ3F7IoQMiu54DRI/gnkKoggQSZgIPPmU4/ZjYDf7YRU6 Ad/SuhnttddG98cZ+/5ngYnCPmd0IxaEbjNJdkOd8ua+T1SgZ9l4TRc4E+795AopbGwM BAdaKJL4/8tFVPpnObzad2LIiCYH3P6VoYtQJwBZqOfpfCuQfKw1jY95nh8n/GrN/W/V 0O5JiglQrqSaR57YXiqKEaWNz0LimHRly321O0m4+sxRr/5FV20SjiL38EVtVTj2K0Bt STYaCGp67f3EveuOyYTMR2FI6t2TzBFUm942vHY2hOUxlI3TxgAeI7fMsP9jAdz+GA6Z OaKw== X-Gm-Message-State: AOAM533oAGdEkzDJsCQBNgvi82Y5Qq57x87XXzhPsJt7c09zy1GQMUQe NrKR1S65LWA2+SSzXEGBkqySypt4PXo= X-Google-Smtp-Source: ABdhPJzRFJf/+Mejp5ebiQENr6A7tJIaOeJ6kM7/MwJJ2WKMQ8akKQpG1DaOA0mi9r4SbDHrzYR42A== X-Received: by 2002:a05:6000:118c:: with SMTP id g12mr11541210wrx.212.1597602364656; Sun, 16 Aug 2020 11:26:04 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH] memory: Initialize MemoryRegionOps for RAM memory regions Date: Sun, 16 Aug 2020 20:26:02 +0200 Message-Id: <20200816182602.352-1-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::444; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x444.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Alex Williamson , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) There is an issue when using memory_region_dispatch_read() or memory_region_dispatch_write() on RAM memory regions. RAM memory regions are initialized as: memory_region_init_ram() -> memory_region_init_ram_nomigrate() -> memory_region_init_ram_shared_nomigrate() -> memory_region_init() -> object_initialize(TYPE_MEMORY_REGION) -> memory_region_initfn() -> mr->ops =3D &unassigned_mem_ops; Later when accessing the alias, the memory_region_dispatch_read() flow is: memory_region_dispatch_read() -> memory_region_dispatch_read1() -> if (mr->ops->read) { ... } ^^^^^^ NULL deref as unassigned_mem_ops.read is NULL. memory_region_dispatch_write() -> if (mr->ops->write) { ... } ^^^^^^^ NULL deref as unassigned_mem_ops.read is NULL. Fix by initializing the MemoryRegionOps to ram_device_mem_ops, this way the memory accesses are properly dispatched using memory_region_ram_device_read() / memory_region_ram_device_write(). Fixes: 4a2e242bbb ("memory: Don't use memcpy for ram_device regions") Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- softmmu/memory.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/softmmu/memory.c b/softmmu/memory.c index af25987518..2fce3fef2d 100644 --- a/softmmu/memory.c +++ b/softmmu/memory.c @@ -1509,6 +1509,8 @@ void memory_region_init_ram_shared_nomigrate(MemoryRe= gion *mr, Error *err =3D NULL; memory_region_init(mr, owner, name, size); mr->ram =3D true; + mr->ops =3D &ram_device_mem_ops; + mr->opaque =3D mr; mr->terminates =3D true; mr->destructor =3D memory_region_destructor_ram; mr->ram_block =3D qemu_ram_alloc(size, share, mr, &err); @@ -1533,6 +1535,8 @@ void memory_region_init_resizeable_ram(MemoryRegion *= mr, Error *err =3D NULL; memory_region_init(mr, owner, name, size); mr->ram =3D true; + mr->ops =3D &ram_device_mem_ops; + mr->opaque =3D mr; mr->terminates =3D true; mr->destructor =3D memory_region_destructor_ram; mr->ram_block =3D qemu_ram_alloc_resizeable(size, max_size, resized, @@ -1558,6 +1562,8 @@ void memory_region_init_ram_from_file(MemoryRegion *m= r, Error *err =3D NULL; memory_region_init(mr, owner, name, size); mr->ram =3D true; + mr->ops =3D &ram_device_mem_ops; + mr->opaque =3D mr; mr->terminates =3D true; mr->destructor =3D memory_region_destructor_ram; mr->align =3D align; @@ -1581,6 +1587,8 @@ void memory_region_init_ram_from_fd(MemoryRegion *mr, Error *err =3D NULL; memory_region_init(mr, owner, name, size); mr->ram =3D true; + mr->ops =3D &ram_device_mem_ops; + mr->opaque =3D mr; mr->terminates =3D true; mr->destructor =3D memory_region_destructor_ram; mr->ram_block =3D qemu_ram_alloc_from_fd(size, mr, @@ -1603,6 +1611,8 @@ void memory_region_init_ram_ptr(MemoryRegion *mr, { memory_region_init(mr, owner, name, size); mr->ram =3D true; + mr->ops =3D &ram_device_mem_ops; + mr->opaque =3D mr; mr->terminates =3D true; mr->destructor =3D memory_region_destructor_ram; mr->dirty_log_mask =3D tcg_enabled() ? (1 << DIRTY_MEMORY_CODE) : 0; --=20 2.21.3