From nobody Wed Feb 11 07:12:52 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1597401098; cv=none; d=zohomail.com; s=zohoarc; b=MroL6w880dU678bbnRXhd5Dcdk2E3tsKVGA9tztUDRcOqWqMvYY6W8pg6bGNd0FskPWqu3lCqCb3L/qdQO2tul3ZLr3VLMD0+FQulvvMTN0kYHYUVRWmy8Z6e8w2vaQfwSYGvs+7GfHWQyr0RxDQwllwi0yLBUqtx16Z2gE6Pmw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597401098; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2mG3sm2Gma8B2PzAgK2++UHf36tQyuw9T4MAlumlczo=; b=Yq0sud8P0KzMTVpxJylvtzlqqIJ5OW/EhB3HJAgp+b7wv2Khwbw7wIMGkwRwEuFWuToNW0nG9S/vQZLMBPCmjY7SVeLlCE/eQTyOz0kgyjRsef+U44Cda0uHMOGnJoWlvCVrp3zAQlUM5Hp0QN5pCDZIXDEApGmRojOXXbZy9fA= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1597401098605157.4970233241337; Fri, 14 Aug 2020 03:31:38 -0700 (PDT) Received: from localhost ([::1]:47468 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6Wzp-00008e-88 for importer@patchew.org; Fri, 14 Aug 2020 06:31:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50158) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6W9a-0006cA-Sc for qemu-devel@nongnu.org; Fri, 14 Aug 2020 05:37:38 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:4191 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6W9W-00061x-9Z for qemu-devel@nongnu.org; Fri, 14 Aug 2020 05:37:38 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 76DBE841F3AAD1BF9166; Fri, 14 Aug 2020 17:37:25 +0800 (CST) Received: from opensource.huawei.com (10.175.100.152) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Fri, 14 Aug 2020 17:37:16 +0800 From: Pan Nengyuan To: Subject: [PATCH 01/12] qga/channel-posix: Plug memory leak in ga_channel_write_all() Date: Fri, 14 Aug 2020 12:02:30 -0400 Message-ID: <20200814160241.7915-2-pannengyuan@huawei.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20200814160241.7915-1-pannengyuan@huawei.com> References: <20200814160241.7915-1-pannengyuan@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.100.152] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=pannengyuan@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/14 05:37:26 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DATE_IN_FUTURE_06_12=1.947, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Roth , kuhn.chenqun@huawei.com, Pan Nengyuan , zhang.zhanghailiang@huawei.com, euler.robot@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Missing g_error_free on error path in ga_channel_write_all(). Fix that. Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Reviewed-by: Li Qiang --- Cc: Michael Roth --- qga/channel-posix.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qga/channel-posix.c b/qga/channel-posix.c index 8fc205ad21..0b151cb87b 100644 --- a/qga/channel-posix.c +++ b/qga/channel-posix.c @@ -249,7 +249,7 @@ GIOStatus ga_channel_write_all(GAChannel *c, const gcha= r *buf, gsize size) buf +=3D written; } else if (status !=3D G_IO_STATUS_AGAIN) { g_warning("error writing to channel: %s", err->message); - return status; + goto out; } } =20 @@ -261,6 +261,10 @@ GIOStatus ga_channel_write_all(GAChannel *c, const gch= ar *buf, gsize size) g_warning("error flushing channel: %s", err->message); } =20 +out: + if (err) { + g_error_free(err); + } return status; } =20 --=20 2.18.2