From nobody Sun May 12 02:33:43 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1597401098; cv=none; d=zohomail.com; s=zohoarc; b=MroL6w880dU678bbnRXhd5Dcdk2E3tsKVGA9tztUDRcOqWqMvYY6W8pg6bGNd0FskPWqu3lCqCb3L/qdQO2tul3ZLr3VLMD0+FQulvvMTN0kYHYUVRWmy8Z6e8w2vaQfwSYGvs+7GfHWQyr0RxDQwllwi0yLBUqtx16Z2gE6Pmw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597401098; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2mG3sm2Gma8B2PzAgK2++UHf36tQyuw9T4MAlumlczo=; b=Yq0sud8P0KzMTVpxJylvtzlqqIJ5OW/EhB3HJAgp+b7wv2Khwbw7wIMGkwRwEuFWuToNW0nG9S/vQZLMBPCmjY7SVeLlCE/eQTyOz0kgyjRsef+U44Cda0uHMOGnJoWlvCVrp3zAQlUM5Hp0QN5pCDZIXDEApGmRojOXXbZy9fA= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1597401098605157.4970233241337; Fri, 14 Aug 2020 03:31:38 -0700 (PDT) Received: from localhost ([::1]:47468 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6Wzp-00008e-88 for importer@patchew.org; Fri, 14 Aug 2020 06:31:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50158) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6W9a-0006cA-Sc for qemu-devel@nongnu.org; Fri, 14 Aug 2020 05:37:38 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:4191 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6W9W-00061x-9Z for qemu-devel@nongnu.org; Fri, 14 Aug 2020 05:37:38 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 76DBE841F3AAD1BF9166; Fri, 14 Aug 2020 17:37:25 +0800 (CST) Received: from opensource.huawei.com (10.175.100.152) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Fri, 14 Aug 2020 17:37:16 +0800 From: Pan Nengyuan To: Subject: [PATCH 01/12] qga/channel-posix: Plug memory leak in ga_channel_write_all() Date: Fri, 14 Aug 2020 12:02:30 -0400 Message-ID: <20200814160241.7915-2-pannengyuan@huawei.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20200814160241.7915-1-pannengyuan@huawei.com> References: <20200814160241.7915-1-pannengyuan@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.100.152] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=pannengyuan@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/14 05:37:26 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DATE_IN_FUTURE_06_12=1.947, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Roth , kuhn.chenqun@huawei.com, Pan Nengyuan , zhang.zhanghailiang@huawei.com, euler.robot@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Missing g_error_free on error path in ga_channel_write_all(). Fix that. Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Reviewed-by: Li Qiang --- Cc: Michael Roth --- qga/channel-posix.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qga/channel-posix.c b/qga/channel-posix.c index 8fc205ad21..0b151cb87b 100644 --- a/qga/channel-posix.c +++ b/qga/channel-posix.c @@ -249,7 +249,7 @@ GIOStatus ga_channel_write_all(GAChannel *c, const gcha= r *buf, gsize size) buf +=3D written; } else if (status !=3D G_IO_STATUS_AGAIN) { g_warning("error writing to channel: %s", err->message); - return status; + goto out; } } =20 @@ -261,6 +261,10 @@ GIOStatus ga_channel_write_all(GAChannel *c, const gch= ar *buf, gsize size) g_warning("error flushing channel: %s", err->message); } =20 +out: + if (err) { + g_error_free(err); + } return status; } =20 --=20 2.18.2 From nobody Sun May 12 02:33:43 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1597400988; cv=none; d=zohomail.com; s=zohoarc; b=eFg2cNxb+BaTKGpeUyWIX+JrNLjoOoUsMmZ18MTB1XdDFNl65fwn0kTOmXqInr4mruyD2LRxrugCNcKgtX0GLeW5+CAuZEILDsmZKj61Zt9U7zqFF0yJLWmNA+Tfw2pWM5EV9OnUhMpavN8a63gnz4TcGKlIaONE4jQr+f1WURo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597400988; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=w/RdF2aKUctaZy+DlGJgyClIQJTRD01277KLDLSNbaQ=; b=Lxi4yPqewxcGcIl6GQ6rqKLq6loVt9BJBVRNxBqGW18v90BF8zcVrBktey1hVmDWdkNBiEwbPfcaLUyJj7rokrd9xpB/zcpTxlx9AqSsVGDxy775e3HYR+RpEA7l2cMeogJyM00QktcYlfdeq64rF1+OZ/XlnfEdGyz0YRkmrlY= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 159740098815367.61546735555726; Fri, 14 Aug 2020 03:29:48 -0700 (PDT) Received: from localhost ([::1]:41354 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6Wy2-00061l-EA for importer@patchew.org; Fri, 14 Aug 2020 06:29:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50154) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6W9a-0006Zw-6l; Fri, 14 Aug 2020 05:37:38 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:4190 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6W9W-00061w-Ld; Fri, 14 Aug 2020 05:37:37 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 7D93D775999ABFB96CFC; Fri, 14 Aug 2020 17:37:25 +0800 (CST) Received: from opensource.huawei.com (10.175.100.152) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Fri, 14 Aug 2020 17:37:18 +0800 From: Pan Nengyuan To: Subject: [PATCH 02/12] hw/vfio/ap: Plug memleak in vfio_ap_get_group() Date: Fri, 14 Aug 2020 12:02:31 -0400 Message-ID: <20200814160241.7915-3-pannengyuan@huawei.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20200814160241.7915-1-pannengyuan@huawei.com> References: <20200814160241.7915-1-pannengyuan@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.100.152] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=pannengyuan@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/14 05:37:26 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DATE_IN_FUTURE_06_12=1.947, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tony Krowiak , Thomas Huth , zhang.zhanghailiang@huawei.com, Pierre Morel , Cornelia Huck , Pan Nengyuan , qemu-s390x@nongnu.org, Halil Pasic , Christian Borntraeger , Alex Williamson , euler.robot@huawei.com, kuhn.chenqun@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Missing g_error_free() in vfio_ap_get_group() error path. Fix that. Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Reviewed-by: Li Qiang Reviewed-by: Pierre Morel --- Cc: Cornelia Huck Cc: Thomas Huth Cc: Christian Borntraeger Cc: Tony Krowiak Cc: Halil Pasic Cc: Pierre Morel Cc: Alex Williamson Cc: qemu-s390x@nongnu.org --- hw/vfio/ap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c index b9330a8e6f..cec6fe1599 100644 --- a/hw/vfio/ap.c +++ b/hw/vfio/ap.c @@ -71,6 +71,7 @@ static VFIOGroup *vfio_ap_get_group(VFIOAPDevice *vapdev,= Error **errp) if (!group_path) { error_setg(errp, "%s: no iommu_group found for %s: %s", VFIO_AP_DEVICE_TYPE, vapdev->vdev.sysfsdev, gerror->mes= sage); + g_error_free(gerror); return NULL; } =20 --=20 2.18.2 From nobody Sun May 12 02:33:43 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1597400904; cv=none; d=zohomail.com; s=zohoarc; b=dc+WxSHdnZWNgV5sc2Kaeib1bwv382uesEGzCmMjSgOHAMUeghlPAk+5zTakzCbQULfZNPgceaPEEr/MAx2l6U4WuCr1P+u4THwIaiutW3x5g6lxofvIQMbyFFiG8+rsn1e3x+U/ckPHwcBMto9MSwvQUbRTFuqZBA5AYYeemU4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597400904; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ql1eSwjRxBpAY3WWLGVTPOCOU0CrQ72OKUat0LBmuD8=; b=YZDBFv4qrPvkpOOZGiovogxIzsdbDQ3/tZznYTfocP29RTWQ1J3Js9nCGv6jtTSxajwgsawDlOI5fgGga/ChsdPpnFjTHUE3NDBXKFMuqQwd1xDwYwDPagsRdrp9ueUZVm4cjVEDfGanQj3KfaCaUFMXid7q17j95ZfCxX0mn1o= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1597400904060984.99771106153; Fri, 14 Aug 2020 03:28:24 -0700 (PDT) Received: from localhost ([::1]:35158 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6Wwg-0003XY-4K for importer@patchew.org; Fri, 14 Aug 2020 06:28:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50090) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6W9Y-0006Vg-6F for qemu-devel@nongnu.org; Fri, 14 Aug 2020 05:37:36 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:60254 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6W9V-00063K-N7 for qemu-devel@nongnu.org; Fri, 14 Aug 2020 05:37:35 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 8CDFF54A535041EAC688; Fri, 14 Aug 2020 17:37:30 +0800 (CST) Received: from opensource.huawei.com (10.175.100.152) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Fri, 14 Aug 2020 17:37:20 +0800 From: Pan Nengyuan To: Subject: [PATCH 03/12] elf2dmp/qemu_elf: Plug memleak in QEMU_Elf_init Date: Fri, 14 Aug 2020 12:02:32 -0400 Message-ID: <20200814160241.7915-4-pannengyuan@huawei.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20200814160241.7915-1-pannengyuan@huawei.com> References: <20200814160241.7915-1-pannengyuan@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.100.152] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.32; envelope-from=pannengyuan@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/14 05:21:34 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DATE_IN_FUTURE_06_12=1.947, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kuhn.chenqun@huawei.com, Pan Nengyuan , zhang.zhanghailiang@huawei.com, Viktor Prutyanov , euler.robot@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Missing g_error_free in QEMU_Elf_init() error path. Fix that. Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Reviewed-by: Li Qiang Reviewed-by: Viktor Prutyanov --- Cc: Viktor Prutyanov --- contrib/elf2dmp/qemu_elf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/elf2dmp/qemu_elf.c b/contrib/elf2dmp/qemu_elf.c index 0db7816586..b601b6d7ba 100644 --- a/contrib/elf2dmp/qemu_elf.c +++ b/contrib/elf2dmp/qemu_elf.c @@ -126,6 +126,7 @@ int QEMU_Elf_init(QEMU_Elf *qe, const char *filename) qe->gmf =3D g_mapped_file_new(filename, TRUE, &gerr); if (gerr) { eprintf("Failed to map ELF dump file \'%s\'\n", filename); + g_error_free(gerr); return 1; } =20 --=20 2.18.2 From nobody Sun May 12 02:33:43 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1597402341; cv=none; d=zohomail.com; s=zohoarc; b=jLRuvJL0PBJQRGYc5rDuFRXKPzbaGyBp8aH5ns7bd6+lXM/vWFHQvOWdtD4zR3vwCfLnFMFGyorJTrJzZZQq0awnDLDW8ULKsU497TLvllw+CA+t16JFilr9FQODkg3Ay7lvwlcUjE9UKAnJ225xxnfcwW4JbgD6ri7M2RzznCI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597402341; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=d6f9P696Dk4OTiCRsMk2rjbJaTYUs6dui0HRIe1H1jI=; b=jtKlePEHJHnb0FknbpXayn/d36+87fdMaNNFPqzk54cEwm6CSSNvUvrezFiwjYHkb4ZchevDfSyVV1SR02ffJqKv95E8uL+1eR5HzXYhuqxzRMqPu2W1ueAUnL45OP/JM5i91k+RGfCx7gAO44LJldsGS6e55X267bmmvwgt9kg= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15974023418941016.8320373840522; Fri, 14 Aug 2020 03:52:21 -0700 (PDT) Received: from localhost ([::1]:56670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6XJs-00027O-8e for importer@patchew.org; Fri, 14 Aug 2020 06:52:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50132) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6W9Z-0006Xf-B2 for qemu-devel@nongnu.org; Fri, 14 Aug 2020 05:37:37 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:60252 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6W9V-00063J-NS for qemu-devel@nongnu.org; Fri, 14 Aug 2020 05:37:37 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 89367E0E8AD5A31AA29D; Fri, 14 Aug 2020 17:37:30 +0800 (CST) Received: from opensource.huawei.com (10.175.100.152) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Fri, 14 Aug 2020 17:37:21 +0800 From: Pan Nengyuan To: Subject: [PATCH 04/12] elf2dmp/pdb: Plug memleak in pdb_init_from_file Date: Fri, 14 Aug 2020 12:02:33 -0400 Message-ID: <20200814160241.7915-5-pannengyuan@huawei.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20200814160241.7915-1-pannengyuan@huawei.com> References: <20200814160241.7915-1-pannengyuan@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.100.152] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.32; envelope-from=pannengyuan@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/14 05:21:34 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DATE_IN_FUTURE_06_12=1.947, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kuhn.chenqun@huawei.com, Pan Nengyuan , zhang.zhanghailiang@huawei.com, Viktor Prutyanov , euler.robot@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Missing g_error_free in pdb_init_from_file() error path. Fix that. Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Reviewed-by: Li Qiang Reviewed-by: Viktor Prutyanov --- Cc: Viktor Prutyanov --- contrib/elf2dmp/pdb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/elf2dmp/pdb.c b/contrib/elf2dmp/pdb.c index a5bd40c99d..b3a6547068 100644 --- a/contrib/elf2dmp/pdb.c +++ b/contrib/elf2dmp/pdb.c @@ -285,6 +285,7 @@ int pdb_init_from_file(const char *name, struct pdb_rea= der *reader) reader->gmf =3D g_mapped_file_new(name, TRUE, &gerr); if (gerr) { eprintf("Failed to map PDB file \'%s\'\n", name); + g_error_free(gerr); return 1; } =20 --=20 2.18.2 From nobody Sun May 12 02:33:43 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1597401475; cv=none; d=zohomail.com; s=zohoarc; b=iO/eZTWMGklpR/6C8G3CVJz5SCzEvabrpGp8uRQ4uMBsMMsce/AovkZFPfk+c9oS8ACcOpb46Bfq3D0Zqe4C+RIBe+Qqk4cIWHH6QMfPdLfbUpawg3TJItWEe6flPx8Cs7wlznBn+QIOJwVN7bfPNCvE9OWmwe7beMEeySWa0aU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597401475; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=bhdCW+t05kmZmxMVkc7t0JiDsjyrGJ+AWT0PysYo5dg=; b=CruG55ySiR+8HTfZWK3eV7B8izTBaDRXqPH7btw+kt1VG1R1t7cCEXkRNijRxHnqSui+xy+l3ofBrFibF2ufQ7NRcm4tJ4ykHwm5giFoyzZGtt0lqe0Z0r+q+K5OUC5gnuma80VpOMjRu4AcP3m0Qfl4AgywUdNBbOvoxT7gYts= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1597401475788454.24917265208273; Fri, 14 Aug 2020 03:37:55 -0700 (PDT) Received: from localhost ([::1]:44826 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6X5u-0002DC-MA for importer@patchew.org; Fri, 14 Aug 2020 06:37:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50136) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6W9Z-0006YL-Ic for qemu-devel@nongnu.org; Fri, 14 Aug 2020 05:37:37 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:60256 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6W9V-00063L-PZ for qemu-devel@nongnu.org; Fri, 14 Aug 2020 05:37:37 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 907A846EBE7D07AC7A14; Fri, 14 Aug 2020 17:37:30 +0800 (CST) Received: from opensource.huawei.com (10.175.100.152) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Fri, 14 Aug 2020 17:37:23 +0800 From: Pan Nengyuan To: Subject: [PATCH 05/12] target/i386/sev: Plug memleak in sev_read_file_base64 Date: Fri, 14 Aug 2020 12:02:34 -0400 Message-ID: <20200814160241.7915-6-pannengyuan@huawei.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20200814160241.7915-1-pannengyuan@huawei.com> References: <20200814160241.7915-1-pannengyuan@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.100.152] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.32; envelope-from=pannengyuan@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/14 05:21:34 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DATE_IN_FUTURE_06_12=1.947, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, euler.robot@huawei.com, Pan Nengyuan , Eduardo Habkost , Paolo Bonzini , kuhn.chenqun@huawei.com, Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Missing g_error_free() in sev_read_file_base64() error path. Fix that. Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Reviewed-by: Li Qiang --- Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost --- target/i386/sev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/i386/sev.c b/target/i386/sev.c index c3ecf86704..de4818da6d 100644 --- a/target/i386/sev.c +++ b/target/i386/sev.c @@ -500,6 +500,7 @@ sev_read_file_base64(const char *filename, guchar **dat= a, gsize *len) =20 if (!g_file_get_contents(filename, &base64, &sz, &error)) { error_report("failed to read '%s' (%s)", filename, error->message); + g_error_free(error); return -1; } =20 --=20 2.18.2 From nobody Sun May 12 02:33:43 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1597400194; cv=none; d=zohomail.com; s=zohoarc; b=gUsJ4BI2Rd0l6uEzCnha6mzXuKsyudg04R/eBsjvanr7JVO8BdSImXxMIngz1CYYtnIl1eu3vu3qaTtLQgMG1Dg/OoQl0L/ohTk3d8XLTe72MmlM+K3B5v0Mn3RfsZbAXVPIJMCxAUlUCGBqZmYX1XFHrgImveFMP1/zCS2Hp18= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597400194; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Sx0h+6k9ldHnte18ji0W6QK8wl11c0PSzvrLSdC9BRI=; b=AkrrLQUhKUc4vg5+OYJst0vtOdPjuh5fr1NSyQ3M7MmW7l7NL2C7bWOvW/tHuMoLlcuUsp7G930Ezn9H/YqAB7dlqBNiFkPro+9pMRCnTk37TGz4vvdIiPY8Obxn7rTrD9GKYmjuPXHEISyIRCij5LenxVUloqk2VTeqC+v3Hpo= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1597400194821549.1389481559952; Fri, 14 Aug 2020 03:16:34 -0700 (PDT) Received: from localhost ([::1]:40288 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6WlF-0007g9-Fc for importer@patchew.org; Fri, 14 Aug 2020 06:16:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50200) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6W9c-0006h4-Of for qemu-devel@nongnu.org; Fri, 14 Aug 2020 05:37:40 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:42560 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6W9a-000642-Rx for qemu-devel@nongnu.org; Fri, 14 Aug 2020 05:37:40 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id A8CF3FB1BB408885D010; Fri, 14 Aug 2020 17:37:35 +0800 (CST) Received: from opensource.huawei.com (10.175.100.152) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Fri, 14 Aug 2020 17:37:24 +0800 From: Pan Nengyuan To: Subject: [PATCH 06/12] ui/gtk-gl-area: Plug memleak in gd_gl_area_create_context() Date: Fri, 14 Aug 2020 12:02:35 -0400 Message-ID: <20200814160241.7915-7-pannengyuan@huawei.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20200814160241.7915-1-pannengyuan@huawei.com> References: <20200814160241.7915-1-pannengyuan@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.100.152] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.35; envelope-from=pannengyuan@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/14 05:21:34 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DATE_IN_FUTURE_06_12=1.947, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kuhn.chenqun@huawei.com, Gerd Hoffmann , Pan Nengyuan , zhang.zhanghailiang@huawei.com, euler.robot@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Receiving error in local variable err, and forgot to free it. Considering that there is no place to deal with it. Clean up. Reported-by: Euler Robot Signed-off-by: Pan Nengyuan --- Cc: Gerd Hoffmann --- ui/gtk-gl-area.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c index 85f9d14c51..c740a7eb14 100644 --- a/ui/gtk-gl-area.c +++ b/ui/gtk-gl-area.c @@ -142,15 +142,14 @@ QEMUGLContext gd_gl_area_create_context(DisplayChange= Listener *dcl, VirtualConsole *vc =3D container_of(dcl, VirtualConsole, gfx.dcl); GdkWindow *window; GdkGLContext *ctx; - GError *err =3D NULL; =20 gtk_gl_area_make_current(GTK_GL_AREA(vc->gfx.drawing_area)); window =3D gtk_widget_get_window(vc->gfx.drawing_area); - ctx =3D gdk_window_create_gl_context(window, &err); + ctx =3D gdk_window_create_gl_context(window, NULL); gdk_gl_context_set_required_version(ctx, params->major_ver, params->minor_ver); - gdk_gl_context_realize(ctx, &err); + gdk_gl_context_realize(ctx, NULL); return ctx; } =20 --=20 2.18.2 From nobody Sun May 12 02:33:43 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1597401570; cv=none; d=zohomail.com; s=zohoarc; b=aT0MjzIQdDZInpKWBcqrHpp1s/EcUipw9AigzjOTiEKksSiI5yvZieo+YJyAMQukdM5LJUDGXmhAfnIzV5v/NWfMDHEWcJ9TeurcBoKHNr21q6uyrbfSYonoHbmUb9l6vyV5nc/CFxp4pqqVcnilQJGtRaCepdOm4IJ8kYLP5EM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597401570; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=f+16oHHm7gSI9uoqbC9YqComMiY3HOM970DYeYNaDlk=; b=lJzHqFhloibnragWd5mrcHK+vp6vTrtvBYBtFtyxeCyYBeqoC5jeJkWUHTJUab7aweNXSUyg/B4yxugZAkz+VPfc8KR3EbUhcO6jtghMsVbb4VTtIgynrGJ5tkCai4Q1vKdaCWi6oov5gkK3UZXyDpRoNz70Ma/n2HPU+5okgqs= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 159740157088454.37246093183603; Fri, 14 Aug 2020 03:39:30 -0700 (PDT) Received: from localhost ([::1]:49398 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6X7R-00045B-Ik for importer@patchew.org; Fri, 14 Aug 2020 06:39:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50208) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6W9d-0006k1-OA for qemu-devel@nongnu.org; Fri, 14 Aug 2020 05:37:41 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:42554 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6W9a-000640-RZ for qemu-devel@nongnu.org; Fri, 14 Aug 2020 05:37:41 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id A496AF8118EE37C6E4E3; Fri, 14 Aug 2020 17:37:35 +0800 (CST) Received: from opensource.huawei.com (10.175.100.152) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Fri, 14 Aug 2020 17:37:26 +0800 From: Pan Nengyuan To: Subject: [PATCH 07/12] target/i386/cpu: Fix memleak in x86_cpu_class_check_missing_features Date: Fri, 14 Aug 2020 12:02:36 -0400 Message-ID: <20200814160241.7915-8-pannengyuan@huawei.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20200814160241.7915-1-pannengyuan@huawei.com> References: <20200814160241.7915-1-pannengyuan@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.100.152] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.35; envelope-from=pannengyuan@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/14 05:21:34 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DATE_IN_FUTURE_06_12=1.947, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, euler.robot@huawei.com, Pan Nengyuan , Eduardo Habkost , Paolo Bonzini , kuhn.chenqun@huawei.com, Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" 'err' forgot to free in x86_cpu_class_check_missing_features error path. Fix that. Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Reviewed-by: Li Qiang --- Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost --- target/i386/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 588f32e136..4678aac0b4 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -4872,6 +4872,7 @@ static void x86_cpu_class_check_missing_features(X86C= PUClass *xcc, new->value =3D g_strdup("type"); *next =3D new; next =3D &new->next; + error_free(err); } =20 x86_cpu_filter_features(xc, false); --=20 2.18.2 From nobody Sun May 12 02:33:43 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1597402408; cv=none; d=zohomail.com; s=zohoarc; b=neQD0fhVIw3wI1Eh1VCxiS5XeyZizavBga75D10UM58qvtiCFOk5nbZpoYPSRKZR8eC63NW1dWNtYr0QpB+5lysCFef6lbabJEz348A+EavGH287GVocDpDtaap2fI2ZHXRM2zLs5CZVWja8X41radaXofloiqRj9vAQrXWzhOw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597402408; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=liN6fNVcnREadH2sBgW3C4AGf3bTllvE436mAYmf5pE=; b=YIKGhMG5jZ/cZ6uj8Tora2zUwrDrfQHtdyscmTzvoZtlkBuTNx+StUWTeBg/FTJhRpoLjjwuRo2rbjeqc7HqRXpc/JalKUVP++7I/xvm5JiKUmwFaYAwG3Ld9leKFGKCqKQTswq21mc9vA2yEpl3f7ROoQHdW7PMAtqQqHE9P0U= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1597402408889681.9171383691893; Fri, 14 Aug 2020 03:53:28 -0700 (PDT) Received: from localhost ([::1]:58892 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6XKx-00036g-NT for importer@patchew.org; Fri, 14 Aug 2020 06:53:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50202) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6W9d-0006hs-0v for qemu-devel@nongnu.org; Fri, 14 Aug 2020 05:37:41 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:42550 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6W9a-000641-V6 for qemu-devel@nongnu.org; Fri, 14 Aug 2020 05:37:40 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id A07A01ABD2FE3A78F995; Fri, 14 Aug 2020 17:37:35 +0800 (CST) Received: from opensource.huawei.com (10.175.100.152) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Fri, 14 Aug 2020 17:37:27 +0800 From: Pan Nengyuan To: Subject: [PATCH 08/12] migration/colo: Plug memleaks in colo_process_incoming_thread Date: Fri, 14 Aug 2020 12:02:37 -0400 Message-ID: <20200814160241.7915-9-pannengyuan@huawei.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20200814160241.7915-1-pannengyuan@huawei.com> References: <20200814160241.7915-1-pannengyuan@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.100.152] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.35; envelope-from=pannengyuan@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/14 05:21:34 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DATE_IN_FUTURE_06_12=1.947, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, Juan Quintela , Pan Nengyuan , "Dr. David Alan Gilbert" , euler.robot@huawei.com, kuhn.chenqun@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" 'local_err' forgot to free in colo_process_incoming_thread error path. Fix that. Reported-by: Euler Robot Signed-off-by: Pan Nengyuan --- Cc: Hailiang Zhang Cc: Juan Quintela Cc: "Dr. David Alan Gilbert" --- migration/colo.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/migration/colo.c b/migration/colo.c index ea7d1e9d4e..17b5afc6b5 100644 --- a/migration/colo.c +++ b/migration/colo.c @@ -870,6 +870,7 @@ void *colo_process_incoming_thread(void *opaque) replication_start_all(REPLICATION_MODE_SECONDARY, &local_err); if (local_err) { qemu_mutex_unlock_iothread(); + error_report_err(local_err); goto out; } #else @@ -882,6 +883,7 @@ void *colo_process_incoming_thread(void *opaque) colo_send_message(mis->to_src_file, COLO_MESSAGE_CHECKPOINT_READY, &local_err); if (local_err) { + error_report_err(local_err); goto out; } =20 --=20 2.18.2 From nobody Sun May 12 02:33:43 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1597402465; cv=none; d=zohomail.com; s=zohoarc; b=EUhAhYRsmJj2qQPAqhh7L2TxVAKpJaj+W/Mw9lNtJUu/sqjDu8JgFUh4A+hXXO96a6zaSyAyh6wK9RjjNRxw56NjqhKaghmlKDCIQhQWW5tax1QaebakEQfcAH6ycrGw/w9/7KaJrxCFNn4SW1y+LJlYQS7Otwb45Ekr31/El8Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597402465; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ecI3W7NgkX5d5g1Ec5aYI3yBJVfprfk8BMzIDxK4jHE=; b=kiAcfxLc0UqSeRebEqYi+LcB/1UkdoYJBLEWixwfWfa0pNIQeiWsU8QmXIdZSis2UtnS/nmGA6BYDQBn7UMUDC6WRicz3Rd/AunfxR5ywGr84lKvc1pbRj4gy6yFkbwkLPCh1h7hGL+voR4srpPKPC6T74nN+/EFR11tfT7XLt8= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1597402465839895.5115260211589; Fri, 14 Aug 2020 03:54:25 -0700 (PDT) Received: from localhost ([::1]:32860 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6XLs-00043z-En for importer@patchew.org; Fri, 14 Aug 2020 06:54:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50204) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6W9d-0006ii-Ai; Fri, 14 Aug 2020 05:37:41 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:42538 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6W9b-00063z-AW; Fri, 14 Aug 2020 05:37:40 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 974DDB647A421D7CE8D9; Fri, 14 Aug 2020 17:37:35 +0800 (CST) Received: from opensource.huawei.com (10.175.100.152) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Fri, 14 Aug 2020 17:37:29 +0800 From: Pan Nengyuan To: Subject: [PATCH 09/12] blockdev: Fix a memleak in drive_backup_prepare() Date: Fri, 14 Aug 2020 12:02:38 -0400 Message-ID: <20200814160241.7915-10-pannengyuan@huawei.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20200814160241.7915-1-pannengyuan@huawei.com> References: <20200814160241.7915-1-pannengyuan@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.100.152] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.35; envelope-from=pannengyuan@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/14 05:21:34 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DATE_IN_FUTURE_06_12=1.947, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , zhang.zhanghailiang@huawei.com, qemu-block@nongnu.org, Pan Nengyuan , Markus Armbruster , Max Reitz , euler.robot@huawei.com, kuhn.chenqun@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" 'local_err' seems forgot to propagate in error path, it'll cause a memleak. Fix it. Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Reviewed-by: Kevin Wolf Reviewed-by: Li Qiang --- Cc: Kevin Wolf Cc: Max Reitz Cc: Markus Armbruster Cc: qemu-block@nongnu.org --- blockdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/blockdev.c b/blockdev.c index 3848a9c8ab..842ac289c1 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1801,6 +1801,7 @@ static void drive_backup_prepare(BlkActionState *comm= on, Error **errp) if (set_backing_hd) { bdrv_set_backing_hd(target_bs, source, &local_err); if (local_err) { + error_propagate(errp, local_err); goto unref; } } --=20 2.18.2 From nobody Sun May 12 02:33:43 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1597401184; cv=none; d=zohomail.com; s=zohoarc; b=dEnAIZzwzVsTO1PlrPDtFCM9ZdxPtj9U1VWOUshq3VAteX1pVg2xuOryd7os5F+y2VGVVv9Lkp3FzG1xIkLxFYxMThhLuf0dXz2SGBAWAnigrkpG/wJcnRKxUAHVIe3yW9yjWhcKyA8GAUPSePKZvv52WyKy6NovlqG4D8YR/74= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597401184; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/PLxfu5S3t3t03FiNrNpyBIPClQqrSBQLRXlTUmseEM=; b=HO0635QKU0ol/vi6UleMrLB601HPz3zX7bdVXM/aqMwYqnQV8IhLXLdmuSdnJXaiYelEhtuI56xjg14MJWquQ4mN1um50o8v+mN+bV3QmUIG4folPTcPIP9I1m9XtooC3LU36Yp9yIUU0v5Os+kkImqD7XKr51n1zrgcUsSvquE= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1597401184607500.06468678926433; Fri, 14 Aug 2020 03:33:04 -0700 (PDT) Received: from localhost ([::1]:53734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6X1D-0002h6-Fc for importer@patchew.org; Fri, 14 Aug 2020 06:33:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50246) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6W9i-0006wl-8K; Fri, 14 Aug 2020 05:37:46 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:4194 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6W9f-00066R-Dc; Fri, 14 Aug 2020 05:37:45 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id AA92BFE0730BE1EFE97F; Fri, 14 Aug 2020 17:37:40 +0800 (CST) Received: from opensource.huawei.com (10.175.100.152) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Fri, 14 Aug 2020 17:37:30 +0800 From: Pan Nengyuan To: Subject: [PATCH 10/12] block/file-posix: fix a possible undefined behavior Date: Fri, 14 Aug 2020 12:02:39 -0400 Message-ID: <20200814160241.7915-11-pannengyuan@huawei.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20200814160241.7915-1-pannengyuan@huawei.com> References: <20200814160241.7915-1-pannengyuan@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.100.152] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=pannengyuan@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/14 05:37:26 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DATE_IN_FUTURE_06_12=1.947, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , zhang.zhanghailiang@huawei.com, qemu-block@nongnu.org, Pan Nengyuan , Max Reitz , euler.robot@huawei.com, kuhn.chenqun@huawei.com, Aarushi Mehta Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" local_err is not initialized to NULL, it will cause a assert error as below: qemu/util/error.c:59: error_setv: Assertion `*errp =3D=3D NULL' failed. Fixes: c6447510690 Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Reviewed-by: Kevin Wolf Reviewed-by: Li Qiang Reviewed-by: Stefano Garzarella --- Cc: Kevin Wolf Cc: Max Reitz Cc: Aarushi Mehta Cc: qemu-block@nongnu.org --- block/file-posix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/file-posix.c b/block/file-posix.c index 9a00d4190a..697a7d9eea 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -2113,7 +2113,7 @@ static void raw_aio_attach_aio_context(BlockDriverSta= te *bs, #endif #ifdef CONFIG_LINUX_IO_URING if (s->use_linux_io_uring) { - Error *local_err; + Error *local_err =3D NULL; if (!aio_setup_linux_io_uring(new_context, &local_err)) { error_reportf_err(local_err, "Unable to use linux io_uring, " "falling back to thread pool: "); --=20 2.18.2 From nobody Sun May 12 02:33:43 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1597401654; cv=none; d=zohomail.com; s=zohoarc; b=cMPitOdiB9N0IE/qyE1ZSIbzkfUbYgUc2wXGV0oWLkV4DLnxkdqF+2emeethc8+NKht02kBTzYLn1ArqZouCVBuJZpSv/unsB1f6D7GQLeDxZ6RJvLgas9uI7tENj73WafsfZqDjHHhEa4c5iSKtriC6falvbBr3ot1bty3d/MA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597401654; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Q60oOQmQN/ggIcXC7rPYHS3Rba9Y4dsEwlHnAwsidfQ=; b=nx0miv1OMH6ivXqbixMysX+kFft7IGulWJC//482WlugP9Owcv5puVyPDpIBgMkO0K0tKnEhghmkk33jbqRJdmEc9NfkZJEFBa0x4WwYsVDOGylAE2VoWv65Ihp6X7+fr6QDRQ1aodRNdmx1t5YbURwMnUS8IJjW0irwzb8jEJw= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 159740165477995.89487694889817; Fri, 14 Aug 2020 03:40:54 -0700 (PDT) Received: from localhost ([::1]:53554 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6X8m-0005tH-W7 for importer@patchew.org; Fri, 14 Aug 2020 06:40:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50242) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6W9h-0006w2-Tc for qemu-devel@nongnu.org; Fri, 14 Aug 2020 05:37:45 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:4192 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6W9f-00066K-2u for qemu-devel@nongnu.org; Fri, 14 Aug 2020 05:37:45 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id A3201CE7498850A6096C; Fri, 14 Aug 2020 17:37:40 +0800 (CST) Received: from opensource.huawei.com (10.175.100.152) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Fri, 14 Aug 2020 17:37:32 +0800 From: Pan Nengyuan To: Subject: [PATCH 11/12] vnc-auth-sasl: Plug memleak in vnc_socket_ip_addr_string Date: Fri, 14 Aug 2020 12:02:40 -0400 Message-ID: <20200814160241.7915-12-pannengyuan@huawei.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20200814160241.7915-1-pannengyuan@huawei.com> References: <20200814160241.7915-1-pannengyuan@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.100.152] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=pannengyuan@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/14 05:37:26 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DATE_IN_FUTURE_06_12=1.947, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kuhn.chenqun@huawei.com, Gerd Hoffmann , Pan Nengyuan , zhang.zhanghailiang@huawei.com, euler.robot@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" 'addr' forgot to free in vnc_socket_ip_addr_string error path. Fix that. Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Reviewed-by: Li Qiang --- Cc: Gerd Hoffmann --- ui/vnc-auth-sasl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/vnc-auth-sasl.c b/ui/vnc-auth-sasl.c index 7b2b09f242..0517b2ead9 100644 --- a/ui/vnc-auth-sasl.c +++ b/ui/vnc-auth-sasl.c @@ -522,6 +522,7 @@ vnc_socket_ip_addr_string(QIOChannelSocket *ioc, =20 if (addr->type !=3D SOCKET_ADDRESS_TYPE_INET) { error_setg(errp, "Not an inet socket type"); + qapi_free_SocketAddress(addr); return NULL; } ret =3D g_strdup_printf("%s;%s", addr->u.inet.host, addr->u.inet.port); --=20 2.18.2 From nobody Sun May 12 02:33:43 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1597400311; cv=none; d=zohomail.com; s=zohoarc; b=IPz4yBLaeHLIX58szir+yePsB2dm1ZsaCcXvFzd733WVQn5dAdueuDwUQ+3sAWDUkkjHyCE9iFMQPhV/rru0HH9++6fn3kNpfNE5euFC5BiKu8xVxP/CeeDwCFreCTQKL46kQTXkmVJ+FaiVsVKhPqZpov8qlQ5otlA7RhZuj/s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597400311; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=NrGFxsqxxrjg7hOkQa2zLVd+Z1GV41/jdXAZx9aDiw4=; b=EEz5kJnZNsP4m56XRz1O5DJdeVV3l8KNdJiqkq9kSZD9cdpuI9r7hvsa5Lc89wVmimqhf3qp0vIlEV4n/V66nTKI5qgDoQ7u9a+nIsAJqgbyP2s6XTSRmmNKvIKo8dl2Q8qXJzQY0h54JZ+OnCkUUGfrYhKLAdUIUYjory28uLU= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1597400311751751.2887112439242; Fri, 14 Aug 2020 03:18:31 -0700 (PDT) Received: from localhost ([::1]:48092 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6Wn8-0002Xe-GB for importer@patchew.org; Fri, 14 Aug 2020 06:18:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50232) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6W9g-0006t6-Sv for qemu-devel@nongnu.org; Fri, 14 Aug 2020 05:37:44 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:4193 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6W9f-00066M-35 for qemu-devel@nongnu.org; Fri, 14 Aug 2020 05:37:44 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id A75AFBDE989CDF2FE366 for ; Fri, 14 Aug 2020 17:37:40 +0800 (CST) Received: from opensource.huawei.com (10.175.100.152) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Fri, 14 Aug 2020 17:37:33 +0800 From: Pan Nengyuan To: Subject: [PATCH 12/12] test-util-sockets: Fix a memleak in test_socket_unix_abstract_good Date: Fri, 14 Aug 2020 12:02:41 -0400 Message-ID: <20200814160241.7915-13-pannengyuan@huawei.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20200814160241.7915-1-pannengyuan@huawei.com> References: <20200814160241.7915-1-pannengyuan@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.100.152] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=pannengyuan@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/14 05:37:26 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DATE_IN_FUTURE_06_12=1.947, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kuhn.chenqun@huawei.com, Pan Nengyuan , zhang.zhanghailiang@huawei.com, euler.robot@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix a memleak in test_socket_unix_abstract_good(). Reported-by: Euler Robot Signed-off-by: Pan Nengyuan --- tests/test-util-sockets.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/test-util-sockets.c b/tests/test-util-sockets.c index 261dc48c03..5c4204a130 100644 --- a/tests/test-util-sockets.c +++ b/tests/test-util-sockets.c @@ -312,6 +312,7 @@ static void test_socket_unix_abstract_good(void) g_thread_join(cli); g_thread_join(serv); =20 + g_rand_free(r); g_free(abstract_sock_name); } #endif --=20 2.18.2