From nobody Mon Feb 9 09:53:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1597342616; cv=none; d=zohomail.com; s=zohoarc; b=j5V5wsYkH+bNF0SvE8DsbclWXJCe2K97Z/mHIlDlLmGxwtnqGTjiW5ekeyq/PcVHzOhx3P1tSEk2SK9Ocjn1lUyYDgtYKVecGlImJ2geQOXWKkhc7liDnWGX1yKzbZU4PWLCB+AFjsf4VsGdiMzXRH6XKKvHxzaNLYrBhUud/fU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597342616; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=j9GDX3AzwLrTPKd/a6Iu2AywVyzyfLUmvNotg0xMMvE=; b=m/rOvPLo5w4Z+Dvw+7cbLA8BQ8+Wu+qhnrFJ6mKZ+9B12Cpmp+zMD+caU19BkJCNVGZ1tBpBvogf+cQww9t2t1qrilndi0ssKEPMt2gGwA4q2DtwBiWUXalpck37HyMnuGxyD+HZfTW2et5danVppj3p7cXFBEMXmyvyL0QdU2c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1597342616765129.41052782335373; Thu, 13 Aug 2020 11:16:56 -0700 (PDT) Received: from localhost ([::1]:46428 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6HmZ-000870-Cg for importer@patchew.org; Thu, 13 Aug 2020 14:16:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54782) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6HlG-0006rc-6B for qemu-devel@nongnu.org; Thu, 13 Aug 2020 14:15:34 -0400 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:55355) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k6HlE-0005yB-Oc for qemu-devel@nongnu.org; Thu, 13 Aug 2020 14:15:33 -0400 Received: by mail-wm1-x341.google.com with SMTP id 9so5459600wmj.5 for ; Thu, 13 Aug 2020 11:15:32 -0700 (PDT) Received: from localhost.localdomain (121.red-81-40-121.staticip.rima-tde.net. [81.40.121.121]) by smtp.gmail.com with ESMTPSA id h14sm10039926wml.30.2020.08.13.11.15.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2020 11:15:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=j9GDX3AzwLrTPKd/a6Iu2AywVyzyfLUmvNotg0xMMvE=; b=WKVongumjoDoIZpKQhX8WJK7uhKPsqnaxmFpoT8NEHcyE/DQhsNxEJB1vIOnE48HpX lBdd5xADH8xkqSFf9xd2GN2LF6kSTON7aY9ow3d28D8l4RT9MaoVjM2aO5eSaZx2CurA XlNUVFfKmBBLfJdN50oslxkJMRUPr/cLxl1Kx70bR2X4EIBexEdtQMd/iqXrrER1bVo2 FQjFRJKFa9QDkR++WSBG35lVfxACEeau2nivSOvCyapy8687SEiZy+qIibZmuKvNTVlA QgTHv57U8/YnQ1kfYwn5k1lvFE7DH29QBbc8DQQVoSyGTJzfbDeSWxONDZMKke9sszKQ FCJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=j9GDX3AzwLrTPKd/a6Iu2AywVyzyfLUmvNotg0xMMvE=; b=j5XM4cmK5oW467G3yDhelHaoGugKlofZ/KQEqTVaHJkA7kQu4sNo1AoFyupVFHBsls OcA4oQbrsIlkrj5EtcDeI7EIYWkdkae0DJsY3G54mCaepR5lgdkP6alYOV/xK5/y7bwa V+taY/mgmEzijdjtW8nKXnIGzs0tUk4oVRWDeoepiMPsenbLd6JwE5jx8NflE0tN8TPi VAcxepSZMeYAPAkQ/8xCNcpYOZjo5OkornUtln8/hX5kBCogD9EyFPGToNSCpzb+Qz7h x3Tq1EFuoljwcTszvRYuKKOXwj80tDRTpepsurwY1yY5SlCeCl0f8RHT2ajTYygZhUI3 NjTA== X-Gm-Message-State: AOAM5303ztqDLf1ekTizGd9LR+KaehAc3ywGH5I5Ucawi1+THvnizLb5 RT9gkDndsHGnuSmKgxU2cH6EPAPG X-Google-Smtp-Source: ABdhPJzumBfUyBxOxYCs/Hqe0JrWt3d932pQ57FnBmhPnhuKd3I9dLCssB8fe090vgTqLAqfjCSDpQ== X-Received: by 2002:a1c:8195:: with SMTP id c143mr5574166wmd.85.1597342531035; Thu, 13 Aug 2020 11:15:31 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH v2 1/3] target/mips/op_helper: Convert multiple if() to switch case Date: Thu, 13 Aug 2020 20:15:25 +0200 Message-Id: <20200813181527.22551-2-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200813181527.22551-1-f4bug@amsat.org> References: <20200813181527.22551-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::341; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x341.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Aleksandar Rikalo , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Markovic , Aurelien Jarno Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) The cache operation is encoded in bits [20:18] of the instruction. The 'op' argument of helper_cache() contains the bits [20:16]. Extract the 3 bits and parse them using a switch case. This allow us to handle multiple cache types (the cache type is encoded in bits [17:16]). Previously the if() block was only checking the D-Cache (Primary Data or Unified Primary). Now we also handle the I-Cache (Primary Instruction), S-Cache (Secondary) and T-Cache (Terciary). Reported-by: Jiaxun Yang Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang --- target/mips/op_helper.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/target/mips/op_helper.c b/target/mips/op_helper.c index 9552b280e0..92c399d8d4 100644 --- a/target/mips/op_helper.c +++ b/target/mips/op_helper.c @@ -1574,15 +1574,22 @@ void helper_msa_st_d(CPUMIPSState *env, uint32_t wd, void helper_cache(CPUMIPSState *env, target_ulong addr, uint32_t op) { #ifndef CONFIG_USER_ONLY + uint32_t cache_operation =3D extract32(op, 2, 3); target_ulong index =3D addr & 0x1fffffff; - if (op =3D=3D 9) { + + switch (cache_operation) { + case 0b010: /* Index Store Tag */ memory_region_dispatch_write(env->itc_tag, index, env->CP0_TagLo, MO_64, MEMTXATTRS_UNSPECIFIED); - } else if (op =3D=3D 5) { + break; + case 0b001: /* Index Load Tag */ memory_region_dispatch_read(env->itc_tag, index, &env->CP0_TagLo, MO_64, MEMTXATTRS_UNSPECIFIED); + break; + default: + break; } #endif } --=20 2.21.3 From nobody Mon Feb 9 09:53:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1597342696; cv=none; d=zohomail.com; s=zohoarc; b=YAqbqSSb4HQD8LODSPOorssbxXMI5z18RwuPsBqNoxkNuxwo0Eq5kmlaciLKyKf8yiCJ5J+WNu6MX/gm3pVNFlC8soLwYvzYisLXHAYSQ5hqfqRZXJLUmo4lJqXlkl5vND8HTXhdhYGHHlz0HPZZl9DOaBBOVy7/+G73Y03Umm8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597342696; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=UDbCjqzlKjTAWmhYvIyTUkU9gxUtTAYKow3YrvF3QOE=; b=aIgxOoiHRxeZtauGirC79+7na6ouActegKMCVzflagr5WN9LXjQkvXmeo90NInaeylMyacUZ7BaxESGke/hwQjnM8EBu1bwSmHZ5i+ety7Ame54bdMdAHVnuPjeMYGqDrpev+SHjMpb4ZnHMcsU4Y/Wugh3/IXN6QUwlrbl52BA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1597342696681467.13622526826816; Thu, 13 Aug 2020 11:18:16 -0700 (PDT) Received: from localhost ([::1]:51048 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6Hnr-0001a0-Eg for importer@patchew.org; Thu, 13 Aug 2020 14:18:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54792) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6HlH-0006rm-Bg for qemu-devel@nongnu.org; Thu, 13 Aug 2020 14:15:35 -0400 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:39675) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k6HlF-0005yQ-UX for qemu-devel@nongnu.org; Thu, 13 Aug 2020 14:15:35 -0400 Received: by mail-wm1-x342.google.com with SMTP id g75so5841381wme.4 for ; Thu, 13 Aug 2020 11:15:33 -0700 (PDT) Received: from localhost.localdomain (121.red-81-40-121.staticip.rima-tde.net. [81.40.121.121]) by smtp.gmail.com with ESMTPSA id h14sm10039926wml.30.2020.08.13.11.15.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2020 11:15:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UDbCjqzlKjTAWmhYvIyTUkU9gxUtTAYKow3YrvF3QOE=; b=IuoKEmsVDIX/gBWygovC+CzJcJXp06oFQVLl4pK6Xp/iHw7WPH1MrS8XTsD/H8J3UU 1L4KeYQJ+1hhmlVzmUT2Kpnvlirn3keg5EOk0/DV68kZK8QvWcHwgydZ1UEIIKzL3lXn 4zywGpKyXMDYueoazG94TCpycXXPZylFpswt3M09LO4Rz5otluxm6zGRD74mFRDw0xrD aOWHN0J4IV/i/YGG3b+wT9elaCEgmN5TKW/cBqPzR9zMO4HFVmcyaR9FBTYDthaC9Irs PIdZlKrcVj0epnt/YfpKfL6xd+4ha7tJ3PaLJs/eMF/USK7Oz5p+SXhwSur1UFUlmV7k 5fkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=UDbCjqzlKjTAWmhYvIyTUkU9gxUtTAYKow3YrvF3QOE=; b=nPbjqMi6hXDo/u0it5F1pArL6/1UH9QkDD6H6ReJse1GuJkZYF57iELQv9rMenANhQ xBoSnDiBW6z8VvXLFeYpmk55qElEQkNIprPxAm9vnMRlQr7BxeG/Acuu4wseFGNFrbG9 wc6mkIC4g+VyUd8enTWe9bD4J2vAhVUmGdx7NVKHXQ44jGxN3V9zobCHPDUNZUwkujia zyHoALEbqTl/VFYD+IKqDjO6iX5wXygx0QxlFdnS3lzvVxJUhqWaXa+RRYMWzr+FRaOM 4IkJ1NdJ32l6MUPwSiUNHnwy+Yx+9oPm7nyMZFt61kl6AQFRoM+AbD+53fZ7rQSXGt5w liQA== X-Gm-Message-State: AOAM531uNjeVjAmJ6hzwsr1+TkgOzFY9jucGUbw1u9kcmwDw1PDDWv4e dKDNcqOHmexXQg6QbMAdSNgvcSZq X-Google-Smtp-Source: ABdhPJz/vjtwR4PSQYs4iS8zo0DGPEu0h2HkMt5QJz/r7kmZaPRx9sMk+j6ky5s3R80uScv8Fco9gg== X-Received: by 2002:a1c:9d85:: with SMTP id g127mr420457wme.162.1597342532256; Thu, 13 Aug 2020 11:15:32 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH v2 2/3] target/mips/op_helper: Document Invalidate/Writeback opcodes as no-op Date: Thu, 13 Aug 2020 20:15:26 +0200 Message-Id: <20200813181527.22551-3-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200813181527.22551-1-f4bug@amsat.org> References: <20200813181527.22551-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::342; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x342.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Aleksandar Rikalo , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Markovic , Aurelien Jarno Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) QEMU does not model caches, so there is not much to do with the Invalidate/Writeback opcodes. Make it explicit adding a comment. Suggested-by: Jiaxun Yang Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson --- target/mips/op_helper.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/target/mips/op_helper.c b/target/mips/op_helper.c index 92c399d8d4..2496d1dd71 100644 --- a/target/mips/op_helper.c +++ b/target/mips/op_helper.c @@ -1578,16 +1578,19 @@ void helper_cache(CPUMIPSState *env, target_ulong a= ddr, uint32_t op) target_ulong index =3D addr & 0x1fffffff; =20 switch (cache_operation) { - case 0b010: - /* Index Store Tag */ + case 0b010: /* Index Store Tag */ memory_region_dispatch_write(env->itc_tag, index, env->CP0_TagLo, MO_64, MEMTXATTRS_UNSPECIFIED); break; - case 0b001: - /* Index Load Tag */ + case 0b001: /* Index Load Tag */ memory_region_dispatch_read(env->itc_tag, index, &env->CP0_TagLo, MO_64, MEMTXATTRS_UNSPECIFIED); break; + case 0b000: /* Index Invalidate */ + case 0b100: /* Hit Invalidate */ + case 0b110: /* Hit Writeback */ + /* no-op */ + break; default: break; } --=20 2.21.3 From nobody Mon Feb 9 09:53:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1597342619; cv=none; d=zohomail.com; s=zohoarc; b=HdBJCPISrUhiablFGNyzRJUMPFh6Wyr+sAHvC20XKs/jCsij4+boU9sT85OVjxUA1kydMRGDTMLkGYlEf7aX4GHFRtB9P0eE2AKRsSYof+Ds7acaEzA4hVT/P0yvGK49AiaAZVcs4+VKiXenHUqjVk0au01fH2TJ921qYZiZfvY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597342619; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/FDG7shS3VVsrXaxNIhVRLZQrAk5x63G7KkzmWMq+m4=; b=EgocxcCg2E+zX7RJNxSENxKm9VZSbW/Qi7j+M12ZOywIxlFm4aeTHsrws7aAXRbJIMKAR3ktUMrVdNgP8g9VX55GEE0SrlRx9OSeM5p0Sb5h8NGchUjUpYSvemMNa395PeMpOqepEdd3FhTc7bnwCjse0b2eQ5nzCU+ZDXFQcpY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1597342619953790.139297998786; Thu, 13 Aug 2020 11:16:59 -0700 (PDT) Received: from localhost ([::1]:46740 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6Hmc-0008EZ-PI for importer@patchew.org; Thu, 13 Aug 2020 14:16:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54840) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6HlJ-0006vx-Vk for qemu-devel@nongnu.org; Thu, 13 Aug 2020 14:15:38 -0400 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:34854) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k6HlH-0005yd-Jq for qemu-devel@nongnu.org; Thu, 13 Aug 2020 14:15:37 -0400 Received: by mail-wr1-x441.google.com with SMTP id f1so6145398wro.2 for ; Thu, 13 Aug 2020 11:15:35 -0700 (PDT) Received: from localhost.localdomain (121.red-81-40-121.staticip.rima-tde.net. [81.40.121.121]) by smtp.gmail.com with ESMTPSA id h14sm10039926wml.30.2020.08.13.11.15.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2020 11:15:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/FDG7shS3VVsrXaxNIhVRLZQrAk5x63G7KkzmWMq+m4=; b=CW9LVs14ByZ2Cid8eGVur34ImRKKyNMJB/JwvE3sfpkJcXHnWkCk6Kp5ESlvIJOgUa UOtGK/qOivJzHY+3YPIKaE2wkxOaaeyqz5/2ajc0I7vAiunNDFUwfA4jWhftW9eTw4Cm KjTXN2KrIEIl00iqB93aLiUe0Q/9gvBBQr3LIMDasvKc+fju457fz9Qr9kRYmgCt8JRw xZ+T/9F3FtGlMN6IGhyGhrB410PjP78qfCYsr3ifkVAoOfTHzQ9ymqEBO4myx1FL+WUj Ny/YRXVYNXzUnL5sr3cUldQJZYtOo57oF5c5dZszk+m3q52nFW10MzLKJmkiwZ9CMnWq cdjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=/FDG7shS3VVsrXaxNIhVRLZQrAk5x63G7KkzmWMq+m4=; b=o6/xtZZqsWyMpWjAfHSD/ZQzAb3wr0XH6ccF9kGUcQGHnn7s4T5G49/DBkRjvhLvMv HcbIyaObNsF7BS+v2JGU7NulgchxWHTkfKJ62FjwAkstswOW5wcE7MwCHByPdgDRsQSQ 6GTtZm4B8Gc64ndVCEFPNK4AzPWtKSlG0hA2E2+6+Sr8mD30SG67wYnwdYBw04g+xc44 VSueLM1yMhW0f9ihviBtgMPAM8ND/3rIAYONn15jf2wbMqWLnOhZlEmWG5JLI/2RkZS4 tvSHgrIv0R43n4+y1X5zH4iwjTHTkufDfv37vlIxn5wOTt2Jil9K4IePkeqty1UXiZlG lUgg== X-Gm-Message-State: AOAM5317TYcoTwEcGmLKFqncUfsDKqofJmQlGLT5HS1YZxY+/2VRtl0l sxQfiCLERsRjGHpGquPoE75SWLAG X-Google-Smtp-Source: ABdhPJyA6giXVddOi1OVhcEYwFjov30J4vrge5kQt+yaVVl3hSjdR9mi6GFYXdxp55sNaMV8OYG9+w== X-Received: by 2002:adf:9ec5:: with SMTP id b5mr4877785wrf.190.1597342533357; Thu, 13 Aug 2020 11:15:33 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH v2 3/3] target/mips/op_helper: Log unimplemented cache opcode Date: Thu, 13 Aug 2020 20:15:27 +0200 Message-Id: <20200813181527.22551-4-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200813181527.22551-1-f4bug@amsat.org> References: <20200813181527.22551-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::441; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x441.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Aleksandar Rikalo , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Markovic , Aurelien Jarno Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) In case the guest uses a cache opcode we are not expecting, log it to give us a chance to notice it, in case we should actually do something. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/op_helper.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/target/mips/op_helper.c b/target/mips/op_helper.c index 2496d1dd71..a3b27f39db 100644 --- a/target/mips/op_helper.c +++ b/target/mips/op_helper.c @@ -1574,6 +1574,13 @@ void helper_msa_st_d(CPUMIPSState *env, uint32_t wd, void helper_cache(CPUMIPSState *env, target_ulong addr, uint32_t op) { #ifndef CONFIG_USER_ONLY + static const char *type_name[] =3D { + "Primary Instruction", + "Primary Data or Unified Primary", + "Tertiary", + "Secondary" + }; + uint32_t cache_type =3D extract32(op, 0, 2); uint32_t cache_operation =3D extract32(op, 2, 3); target_ulong index =3D addr & 0x1fffffff; =20 @@ -1592,6 +1599,8 @@ void helper_cache(CPUMIPSState *env, target_ulong add= r, uint32_t op) /* no-op */ break; default: + qemu_log_mask(LOG_UNIMP, "cache operation:%u (type: %s cache)\n", + cache_operation, type_name[cache_type]); break; } #endif --=20 2.21.3