From nobody Mon Feb 9 14:44:09 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1597304699; cv=none; d=zohomail.com; s=zohoarc; b=nLmzF96teY0Ho4cKVDYxEv3hAbjwspxgudWcmrq0ODt9/aHqQTu1XM8s4ktAPn1iLsDRm+mqzUucZxbZ27MKQ1QOEnXsibTeBuL+BFc66Z5LlZDcUK1MZyjADgD5oo+jmOzufs/H2SnWFieQqdanXpVf3Cy/tRFBcOrazPMJnlE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597304699; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ekzpegeCwMakb3oaBJkESH8tAYkGas87SDf9d7adufc=; b=BHyRgn2y3gnzlzAih9lq1EJTNIKCWnEqCUbugxqBOvg+g+Epm4Hyrdy1Givkfq63wt+I+XBbrEPUckl4KXIvu9kdQ5k7fOaXiX1JNq3Hvxu2p628WUDqo+uLp2j06aVKCx9QSKlFN82v2nJwd6cG5h9TwXFOFslihK2B26D3EOU= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1597304699367617.0699528736353; Thu, 13 Aug 2020 00:44:59 -0700 (PDT) Received: from localhost ([::1]:44750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k67uz-0001xt-GH for importer@patchew.org; Thu, 13 Aug 2020 03:44:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k67p6-0008KK-Qe; Thu, 13 Aug 2020 03:38:52 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:33550 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k67p1-0001lJ-3S; Thu, 13 Aug 2020 03:38:52 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id DD39D8BFA7CA37F59BD0; Thu, 13 Aug 2020 15:38:31 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.487.0; Thu, 13 Aug 2020 15:38:25 +0800 From: Chen Qun To: , Subject: [PATCH 01/11] hw/arm/virt-acpi-build:Remove dead assignment in build_madt() Date: Thu, 13 Aug 2020 15:37:02 +0800 Message-ID: <20200813073712.4001404-2-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20200813073712.4001404-1-kuhn.chenqun@huawei.com> References: <20200813073712.4001404-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.32; envelope-from=kuhn.chenqun@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/13 03:38:34 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , zhang.zhanghailiang@huawei.com, "Michael S. Tsirkin" , pannengyuan@huawei.com, Shannon Zhao , Igor Mammedov , qemu-arm@nongnu.org, Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: hw/arm/virt-acpi-build.c:641:5: warning: Value stored to 'madt' is never re= ad madt =3D acpi_data_push(table_data, sizeof *madt); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin --- Cc: Shannon Zhao Cc: Peter Maydell Cc: "Michael S. Tsirkin" Cc: Igor Mammedov Cc: qemu-arm@nongnu.org --- hw/arm/virt-acpi-build.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index 91f0df7b13..f830f9b779 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm/virt-acpi-build.c @@ -633,12 +633,11 @@ build_madt(GArray *table_data, BIOSLinker *linker, Vi= rtMachineState *vms) int madt_start =3D table_data->len; const MemMapEntry *memmap =3D vms->memmap; const int *irqmap =3D vms->irqmap; - AcpiMultipleApicTable *madt; AcpiMadtGenericDistributor *gicd; AcpiMadtGenericMsiFrame *gic_msi; int i; =20 - madt =3D acpi_data_push(table_data, sizeof *madt); + acpi_data_push(table_data, sizeof(AcpiMultipleApicTable)); =20 gicd =3D acpi_data_push(table_data, sizeof *gicd); gicd->type =3D ACPI_APIC_GENERIC_DISTRIBUTOR; --=20 2.23.0 From nobody Mon Feb 9 14:44:09 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1597304421; cv=none; d=zohomail.com; s=zohoarc; b=Q/56t+lkK1XZMRTVm8wTkjlGFCNIrXa4S0SU9V+fuTLpoWErYulA/GqAj+8iW5XbJa/00ajKpeg2tn2hVxoGV52vEcIJJq9/UVfQWq2DHlZgEUSD10hEGD2kGxmOTuc4wgXWGYVtYPtAmVv8tuSz5Ik0HKZvDkGR4Oj6np5PXDM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597304421; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qmeUfAFkoMOvX5urtyY8LioTIVWXQc5HNDD2nevyL+4=; b=VoTiQRx7FIPLvPXIQ4JamItHGWKEKg03mMUgevMh3dKN4nmdpXYcv+hm+9wBsp3vSyxVbB4rpY1aws4KP9VStix008MyNOwoctZmoHYzdXCFAbylZDH39Q3xEWCaOZ26CwuQXlXXh5pqx1+nwwBQJSSEjE6topmUXrzQfErpRW8= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1597304421105581.4871422990205; Thu, 13 Aug 2020 00:40:21 -0700 (PDT) Received: from localhost ([::1]:53578 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k67qV-0002MX-RI for importer@patchew.org; Thu, 13 Aug 2020 03:40:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40748) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k67p3-0008Gj-V9; Thu, 13 Aug 2020 03:38:49 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:4234 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k67p1-0001mb-4U; Thu, 13 Aug 2020 03:38:49 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id EA1FDE48838369881333; Thu, 13 Aug 2020 15:38:36 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.487.0; Thu, 13 Aug 2020 15:38:27 +0800 From: Chen Qun To: , Subject: [PATCH 02/11] hw/arm/omap1:Remove redundant statement in omap_clkdsp_read() Date: Thu, 13 Aug 2020 15:37:03 +0800 Message-ID: <20200813073712.4001404-3-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20200813073712.4001404-1-kuhn.chenqun@huawei.com> References: <20200813073712.4001404-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.191; envelope-from=kuhn.chenqun@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/13 03:38:37 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , zhang.zhanghailiang@huawei.com, pannengyuan@huawei.com, qemu-arm@nongnu.org, Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: hw/arm/omap1.c:1760:15: warning: Value stored to 'cpu' during its initialization is never read CPUState *cpu =3D CPU(s->cpu); ^~~ ~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Peter Maydell Cc: qemu-arm@nongnu.org --- hw/arm/omap1.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/arm/omap1.c b/hw/arm/omap1.c index 6ba0df6b6d..02c0f66431 100644 --- a/hw/arm/omap1.c +++ b/hw/arm/omap1.c @@ -1774,7 +1774,6 @@ static uint64_t omap_clkdsp_read(void *opaque, hwaddr= addr, return s->clkm.dsp_rstct2; =20 case 0x18: /* DSP_SYSST */ - cpu =3D CPU(s->cpu); return (s->clkm.clocking_scheme << 11) | s->clkm.cold_start | (cpu->halted << 6); /* Quite useless... */ } --=20 2.23.0 From nobody Mon Feb 9 14:44:09 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1597304586; cv=none; d=zohomail.com; s=zohoarc; b=HOUNvEZLutbkklnxwE1GyyDDie2caf90rsZe4/aZjeyvfZv/DnII7uNYWxeCB5KuMWPfWMNP4r7XGwNBlAj1VrDc+AQN21OKtOGECmTObppaFhtJv2zZsL/cRAP4ATZj1VT0fdm17o45nGSbxIFLtdh8MS7/Jnew20Fi8qhLQGk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597304586; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gFtTC32iKa/QUA4SN+ZfPacfTE1d/dv3O2DWnKOrH+0=; b=bILFGujoaekmw1jCK520ID5hNok7jmGLDw0GhLX4V/a7TESFc1xi5uV2JpI3G8NVybGydXmrB2SAmnTJBiKw/m5mmGWM290J1WOeZfMGWlNBAF+LOVYNLIrABdCx29zgZl4VOQLT22m1Hdk8k5By2DiqhkHSenSuuzEbRjutNDI= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1597304586384766.3673587961538; Thu, 13 Aug 2020 00:43:06 -0700 (PDT) Received: from localhost ([::1]:40418 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k67tB-0008UW-7z for importer@patchew.org; Thu, 13 Aug 2020 03:43:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40742) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k67p3-0008GX-B8; Thu, 13 Aug 2020 03:38:49 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:4233 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k67p1-0001mc-3c; Thu, 13 Aug 2020 03:38:49 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id EF14BCB1AF3474EBED6D; Thu, 13 Aug 2020 15:38:36 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.487.0; Thu, 13 Aug 2020 15:38:30 +0800 From: Chen Qun To: , Subject: [PATCH 03/11] target/arm/translate-a64:Remove dead assignment in handle_scalar_simd_shli() Date: Thu, 13 Aug 2020 15:37:04 +0800 Message-ID: <20200813073712.4001404-4-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20200813073712.4001404-1-kuhn.chenqun@huawei.com> References: <20200813073712.4001404-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.191; envelope-from=kuhn.chenqun@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/13 03:38:37 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , zhang.zhanghailiang@huawei.com, pannengyuan@huawei.com, qemu-arm@nongnu.org, Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: target/arm/translate-a64.c:8635:14: warning: Value stored to 'tcg_rn' durin= g its initialization is never read TCGv_i64 tcg_rn =3D new_tmp_a64(s); ^~~~~~ ~~~~~~~~~~~~~~ target/arm/translate-a64.c:8636:14: warning: Value stored to 'tcg_rd' durin= g its initialization is never read TCGv_i64 tcg_rd =3D new_tmp_a64(s); ^~~~~~ ~~~~~~~~~~~~~~ There is a memory leak for the variable new_tmp_a64 "s". We should delete the assignment. Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Peter Maydell Cc: qemu-arm@nongnu.org --- target/arm/translate-a64.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 534c3ff5f3..c83bb85e4e 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -8632,8 +8632,8 @@ static void handle_scalar_simd_shli(DisasContext *s, = bool insert, int size =3D 32 - clz32(immh) - 1; int immhb =3D immh << 3 | immb; int shift =3D immhb - (8 << size); - TCGv_i64 tcg_rn =3D new_tmp_a64(s); - TCGv_i64 tcg_rd =3D new_tmp_a64(s); + TCGv_i64 tcg_rn; + TCGv_i64 tcg_rd; =20 if (!extract32(immh, 3, 1)) { unallocated_encoding(s); --=20 2.23.0 From nobody Mon Feb 9 14:44:09 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1597304412; cv=none; d=zohomail.com; s=zohoarc; b=HccAkAnaY4g6/ijIbnwVrQ3lywREaLQA+gTAdW2nw88vGxAPw9WuEgnuXmL0GUBgsjfVENbhx6cvYFQvXgkS9WwTINwslBjgQw3nksavdBUCVGa5EeX9t7KfRvg0okBG9vrldafKEGSZ7SOvutyZmtestPvmJ1wZf5kBGFnDAFk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597304412; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=u6T0uLWiLZAGFG8y7fqfJDxKgaukFimKcfPW0IdJszo=; b=MfXNODenldMQq6QPLAnzRUljuMky02r5vgGeMH4cQTZlwtFC8fvQqqCoNgluKb5tfPBef4YDV3MFSA/yaUlZdas2zSUBSlY2tDF3xCCxFH8QSYiiUMOxyycJscY8AkqOGd4E95cObZ/lWLmZcOLp+5167pBgydKn6xGJ785VndA= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1597304412594952.131085595901; Thu, 13 Aug 2020 00:40:12 -0700 (PDT) Received: from localhost ([::1]:52750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k67qN-00022O-5e for importer@patchew.org; Thu, 13 Aug 2020 03:40:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40782) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k67p5-0008H6-7B; Thu, 13 Aug 2020 03:38:51 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:33696 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k67p2-0001n1-RQ; Thu, 13 Aug 2020 03:38:50 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 383BAAF3AFFD708CEE8A; Thu, 13 Aug 2020 15:38:42 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.487.0; Thu, 13 Aug 2020 15:38:32 +0800 From: Chen Qun To: , Subject: [PATCH 04/11] target/arm/translate-a64:Remove redundant statement in disas_simd_two_reg_misc_fp16() Date: Thu, 13 Aug 2020 15:37:05 +0800 Message-ID: <20200813073712.4001404-5-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20200813073712.4001404-1-kuhn.chenqun@huawei.com> References: <20200813073712.4001404-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.32; envelope-from=kuhn.chenqun@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/13 03:38:34 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , zhang.zhanghailiang@huawei.com, pannengyuan@huawei.com, qemu-arm@nongnu.org, Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: target/arm/translate-a64.c:13007:5: warning: Value stored to 'rd' is never = read rd =3D extract32(insn, 0, 5); ^ ~~~~~~~~~~~~~~~~~~~~~ target/arm/translate-a64.c:13008:5: warning: Value stored to 'rn' is never = read rn =3D extract32(insn, 5, 5); ^ ~~~~~~~~~~~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Peter Maydell Cc: qemu-arm@nongnu.org --- target/arm/translate-a64.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index c83bb85e4e..47cce160d8 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -13016,9 +13016,6 @@ static void disas_simd_two_reg_misc_fp16(DisasConte= xt *s, uint32_t insn) fpop =3D deposit32(opcode, 5, 1, a); fpop =3D deposit32(fpop, 6, 1, u); =20 - rd =3D extract32(insn, 0, 5); - rn =3D extract32(insn, 5, 5); - switch (fpop) { case 0x1d: /* SCVTF */ case 0x5d: /* UCVTF */ --=20 2.23.0 From nobody Mon Feb 9 14:44:09 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1597304393; cv=none; d=zohomail.com; s=zohoarc; b=VXX5x7sZ4rsTK+muRA6eCxTyia94k/fE6T9dAdN2/3Dg6yVcq42IPTH/qItybFjbT+SrO2y7EKSPvNK29TCuaL87fvVw/HfsjPMOcjA8FAa44mqXEDwlbKVTLtZTXJbgrteQWQCK6SGaTJqmtaaTf35YOzyCxCUkwIGYG1Wrqug= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597304393; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=s7DS9TsDPl8O7e8kQAvevwjx/y2zIemnShK6cXevLYA=; b=TevORGu5oB2p30+13fXt6pO5ASpViavT7Gez/c2JQ0RMxF2NW3M4lGCTQK/a/NmGZPtPqKe0rYvulHqKX1dfzQRNP0vrMss58f3oP+yOExvyv2NbQMHA3eG9xhyJk+N/9bsvB1voeV3YaNf9/Bzoph767slpFQtKjVckJqSggCQ= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1597304393037173.70312352665746; Thu, 13 Aug 2020 00:39:53 -0700 (PDT) Received: from localhost ([::1]:51790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k67q2-0001fD-IP for importer@patchew.org; Thu, 13 Aug 2020 03:39:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40800) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k67p6-0008JN-F6; Thu, 13 Aug 2020 03:38:52 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:33700 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k67p1-0001n3-Tu; Thu, 13 Aug 2020 03:38:52 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 3CFC488750FE0B924AD5; Thu, 13 Aug 2020 15:38:42 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.487.0; Thu, 13 Aug 2020 15:38:34 +0800 From: Chen Qun To: , Subject: [PATCH 05/11] hw/virtio/vhost-user:Remove dead assignment in scrub_shadow_regions() Date: Thu, 13 Aug 2020 15:37:06 +0800 Message-ID: <20200813073712.4001404-6-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20200813073712.4001404-1-kuhn.chenqun@huawei.com> References: <20200813073712.4001404-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.32; envelope-from=kuhn.chenqun@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/13 03:38:34 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, "Michael S. Tsirkin" , pannengyuan@huawei.com, Raphael Norwitz , Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: hw/virtio/vhost-user.c:606:9: warning: Value stored to 'mr' is never read mr =3D vhost_user_get_mr_data(reg->userspace_addr, &offset, &fd); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Michael S. Tsirkin Reviewed-by: Raphael Norwitz --- Cc: "Michael S. Tsirkin" Cc: Raphael Norwitz --- hw/virtio/vhost-user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index d7e2423762..9c5b4f7fbc 100644 --- a/hw/virtio/vhost-user.c +++ b/hw/virtio/vhost-user.c @@ -603,7 +603,7 @@ static void scrub_shadow_regions(struct vhost_dev *dev, */ for (i =3D 0; i < dev->mem->nregions; i++) { reg =3D &dev->mem->regions[i]; - mr =3D vhost_user_get_mr_data(reg->userspace_addr, &offset, &fd); + vhost_user_get_mr_data(reg->userspace_addr, &offset, &fd); if (fd > 0) { ++fd_num; } --=20 2.23.0 From nobody Mon Feb 9 14:44:09 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1597304493; cv=none; d=zohomail.com; s=zohoarc; b=QtmpuYL5NnVDBxs8r3Cf2aQQy/kDjLMkDdAZs3mvH9DKi1ZMb/nZuJrh+za5hADf1jDXgsfYk0mSlJff5ll53Wo07yoOULodPEIQ52ujjEGgKg4Y9W/CGYoy66HFUbpr1NfLRVITqC3hmkBDz8NXRfxD9clbSNMrNPiKCRrLunU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597304493; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=EH7RgANNsY/hQjjxDu+zJTnLNiPDpQDQLW2QBv8dmI4=; b=ObhmYHCr6JJU5g8AvMYStMrwGJV8gBbVMfMi1w1DoleqJL1ZdJcLOQDDgxPKdoAyGipBv0hw8GzpAjd3rtImhEUst0ahnUWbxOPm1h25DHOavaqtGDSjM38Qf+Z4jvjnOwG7+n0jvQ5EY2IJhCMqcFj52quVez0pmy3ECEA9eAE= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1597304493514607.9804853702723; Thu, 13 Aug 2020 00:41:33 -0700 (PDT) Received: from localhost ([::1]:33144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k67rg-0005YP-4e for importer@patchew.org; Thu, 13 Aug 2020 03:41:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40826) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k67p8-0008OR-AB; Thu, 13 Aug 2020 03:38:54 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:4238 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k67p6-0001oS-FE; Thu, 13 Aug 2020 03:38:53 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 2A6E6751AD03C9EF59B6; Thu, 13 Aug 2020 15:38:47 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.487.0; Thu, 13 Aug 2020 15:38:36 +0800 From: Chen Qun To: , Subject: [PATCH 06/11] hw/net/virtio-net:Remove redundant statement in virtio_net_rsc_tcp_ctrl_check() Date: Thu, 13 Aug 2020 15:37:07 +0800 Message-ID: <20200813073712.4001404-7-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20200813073712.4001404-1-kuhn.chenqun@huawei.com> References: <20200813073712.4001404-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.191; envelope-from=kuhn.chenqun@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/13 03:38:37 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, "Michael S. Tsirkin" , Jason Wang , pannengyuan@huawei.com, Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Clang static code analyzer show warning: hw/net/virtio-net.c:2077:5: warning: Value stored to 'tcp_flag' is never re= ad tcp_flag &=3D VIRTIO_NET_TCP_FLAG; ^ ~~~~~~~~~~~~~~~~~~~ The 'VIRTIO_NET_TCP_FLAG' is '0x3F'. The last =E2=80=98tcp_flag=E2=80=99 as= signment statement is the same as that of the first two statements. Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Michael S. Tsirkin Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- Cc: "Michael S. Tsirkin" Cc: Jason Wang --- hw/net/virtio-net.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index a1fe9e9285..cb0d27084c 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -2075,7 +2075,6 @@ static int virtio_net_rsc_tcp_ctrl_check(VirtioNetRsc= Chain *chain, tcp_flag =3D htons(tcp->th_offset_flags); tcp_hdr =3D (tcp_flag & VIRTIO_NET_TCP_HDR_LENGTH) >> 10; tcp_flag &=3D VIRTIO_NET_TCP_FLAG; - tcp_flag =3D htons(tcp->th_offset_flags) & 0x3F; if (tcp_flag & TH_SYN) { chain->stat.tcp_syn++; return RSC_BYPASS; --=20 2.23.0 From nobody Mon Feb 9 14:44:09 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1597304431; cv=none; d=zohomail.com; s=zohoarc; b=c3xvjiGhu9lkBLQVTeL7g899LPTfklICvSTy/5YwQmmbfhLZdgjiAKWii62QT4p4K27SGEVEqHje1QjkIqw0aMIxDbkxt7IfH/JldM0e2W0YGe/9DDZmZzAmJIStTu9ocSiTn2Kq/OBPUTNP4OMzt5E5B/wBHGd2UHiFogtpUa4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597304431; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=O5CiWEJhKFsyXBQZJafmCH7ErzpqSfRrBjt5t1uQ7FY=; b=ltDCk1uTxHwE9afiS9TiczLFiQwqt4ApwdLm5RAI31MgS3IY1naey409sA1AH65QLCC+atRqeuT78fk7/aKQtRV79xXE/aqqQUT5ov70SabGpZZl+rhDszBGxPy6wj9G4QHyDITLHeFjwrByGxn25Yj8M5Xl51m6kkPKMSVVVuw= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1597304431736327.9107036284389; Thu, 13 Aug 2020 00:40:31 -0700 (PDT) Received: from localhost ([::1]:54668 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k67qg-0002oZ-FW for importer@patchew.org; Thu, 13 Aug 2020 03:40:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40816) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k67p7-0008LA-5R; Thu, 13 Aug 2020 03:38:53 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:4235 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k67p4-0001nh-4f; Thu, 13 Aug 2020 03:38:52 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 16542D1A8532D05068DD; Thu, 13 Aug 2020 15:38:47 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.487.0; Thu, 13 Aug 2020 15:38:37 +0800 From: Chen Qun To: , Subject: [PATCH 07/11] vfio/platform: Remove dead assignment in vfio_intp_interrupt() Date: Thu, 13 Aug 2020 15:37:08 +0800 Message-ID: <20200813073712.4001404-8-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20200813073712.4001404-1-kuhn.chenqun@huawei.com> References: <20200813073712.4001404-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.191; envelope-from=kuhn.chenqun@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/13 03:38:37 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, pannengyuan@huawei.com, Eric Auger , Alex Williamson , Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: hw/vfio/platform.c:239:9: warning: Value stored to 'ret' is never read ret =3D event_notifier_test_and_clear(intp->interrupt); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Eric Auger --- Cc: Alex Williamson Cc: Eric Auger --- hw/vfio/platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c index ac2cefc9b1..869ed2c39d 100644 --- a/hw/vfio/platform.c +++ b/hw/vfio/platform.c @@ -236,7 +236,7 @@ static void vfio_intp_interrupt(VFIOINTp *intp) trace_vfio_intp_interrupt_set_pending(intp->pin); QSIMPLEQ_INSERT_TAIL(&vdev->pending_intp_queue, intp, pqnext); - ret =3D event_notifier_test_and_clear(intp->interrupt); + event_notifier_test_and_clear(intp->interrupt); return; } =20 --=20 2.23.0 From nobody Mon Feb 9 14:44:09 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1597304503; cv=none; d=zohomail.com; s=zohoarc; b=IU6UX1df1s/GaCA67s4b+PSQEs0OOUaJ8zTJDt2WYjVVsVT01QWrM+jftu1uBKQv1Vl65FgddLfbZJPIb7N3kbZF3QuOTq099a4B53C+fVViRIO0Qp9sxSuLHlgj4lrQxmLaYf4FtaAmcGNErs2dxUK2a8Ifwq5wr6wxsZg1Ukc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597304503; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=3Oy8OmT64KT21WT/AEMXAopkPhF1PMJQKISbw7tN314=; b=CQVElKGxXzez9ZqKIiUOCNPfvqAWpj2QwOI/WhrsiBueA8cesyTZk1S87oDuZY21rnQxjAxvrRLEmJDh4Y4GN8MP6iP42vHIzC/aFVna7anzTa1S/Nbn6STXdohBEAMPew32hEMGvI8yR+AH6MhjuNJ5DPkOamoOkOoQpknXa0w= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1597304503295714.3874387797255; Thu, 13 Aug 2020 00:41:43 -0700 (PDT) Received: from localhost ([::1]:33860 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k67rq-0005ps-55 for importer@patchew.org; Thu, 13 Aug 2020 03:41:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40794) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k67p5-0008Hn-Px; Thu, 13 Aug 2020 03:38:51 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:4236 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k67p4-0001nj-1R; Thu, 13 Aug 2020 03:38:51 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 1AD8A883EEDA8CFDD98A; Thu, 13 Aug 2020 15:38:47 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.487.0; Thu, 13 Aug 2020 15:38:39 +0800 From: Chen Qun To: , Subject: [PATCH 08/11] tcg/optimize: Remove redundant statement in tcg_optimize() Date: Thu, 13 Aug 2020 15:37:09 +0800 Message-ID: <20200813073712.4001404-9-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20200813073712.4001404-1-kuhn.chenqun@huawei.com> References: <20200813073712.4001404-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.191; envelope-from=kuhn.chenqun@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/13 03:38:37 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, pannengyuan@huawei.com, Richard Henderson , Euler Robot , Chen Qun , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: tcg/optimize.c:1267:17: warning: Value stored to 'nb_iargs' is never read nb_iargs =3D 2; ^ ~ Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Richard Henderson Cc: Richard Henderson --- tcg/optimize.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 53aa8e5329..d5bea37290 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1264,7 +1264,6 @@ void tcg_optimize(TCGContext *s) op->opc =3D opc =3D (opc =3D=3D INDEX_op_movcond_i32 ? INDEX_op_setcond_i32 : INDEX_op_setcond_i64); - nb_iargs =3D 2; } goto do_default; =20 --=20 2.23.0 From nobody Mon Feb 9 14:44:09 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1597304819; cv=none; d=zohomail.com; s=zohoarc; b=dDwkJpWDDlKMsQ2/+xRB+60Gx4d3582K/v0TpAuko+L4ZFRfUFv5znKk3PCI+eixweYhRSzpdDv4zotUQ5Uey2tXg3cy+Ee09zKUq1mUoTp5d9O0S2zVCU+raGZ3mz0zy11kpbC7E+ofKzUIBVjMrFGhCEObYJZfwj745wjDB58= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597304819; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=MF+OBHXiNdeddOvV53QhGSIe3wj6QTpArs4sOD+/mL4=; b=WMI2/OsoqTg1Rdd7B9O/cH1IoGAU4sP0hr6HzQ91c1tfhY25yNLJVehvuZMOPOL5y907Sw7Ei1sScfmkFB5GkZ7ydNX90JLXlHzEYVKpfyhWajzQqZQ6FkQVMya6sbjZwtvDhmVXTpgy6yoqo/9xvyrC8KRsvp8lcirxZuJahmE= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1597304819442846.1925121507919; Thu, 13 Aug 2020 00:46:59 -0700 (PDT) Received: from localhost ([::1]:53310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k67ww-0005aw-60 for importer@patchew.org; Thu, 13 Aug 2020 03:46:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k67p7-0008N1-OE; Thu, 13 Aug 2020 03:38:53 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:4237 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k67p5-0001nl-QW; Thu, 13 Aug 2020 03:38:53 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 263586F60A2EFA597018; Thu, 13 Aug 2020 15:38:47 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.487.0; Thu, 13 Aug 2020 15:38:40 +0800 From: Chen Qun To: , Subject: [PATCH 09/11] usb/bus: Remove dead assignment in usb_get_fw_dev_path() Date: Thu, 13 Aug 2020 15:37:10 +0800 Message-ID: <20200813073712.4001404-10-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20200813073712.4001404-1-kuhn.chenqun@huawei.com> References: <20200813073712.4001404-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.191; envelope-from=kuhn.chenqun@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/13 03:38:37 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, pannengyuan@huawei.com, Markus Armbruster , Gerd Hoffmann , Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: qemu/hw/usb/bus.c:615:13: warning: Value stored to 'pos' is never read pos +=3D snprintf(fw_path + pos, fw_len - pos, "%s@%lx", Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Gerd Hoffmann Cc: Markus Armbruster --- hw/usb/bus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/usb/bus.c b/hw/usb/bus.c index b17bda3b29..77d3f7ddb8 100644 --- a/hw/usb/bus.c +++ b/hw/usb/bus.c @@ -612,8 +612,8 @@ static char *usb_get_fw_dev_path(DeviceState *qdev) in++; } else { /* the device itself */ - pos +=3D snprintf(fw_path + pos, fw_len - pos, "%s@%lx", - qdev_fw_name(qdev), nr); + snprintf(fw_path + pos, fw_len - pos, "%s@%lx",qdev_fw_name(qd= ev), + nr); break; } } --=20 2.23.0 From nobody Mon Feb 9 14:44:09 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1597304572; cv=none; d=zohomail.com; s=zohoarc; b=Qkp21LJvl/t5Hvf8HiVEv8TYAS90T9F/F2j1D4+UQJ9lHgd4/KU16QvJnsdi4tuU5GwuBf/aWQdVZW/YWtVL0m/mKIdD3GtsK09dUdUahZeqqyBteYyxOwn9t8TD8Q2Z+yLPSI791YBhW8aGe4quXdmK+wAf3E2wDluk4raMBko= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597304572; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+MfPJgrBUItaY/XlPdDgYIsvLWMW20baJ9aT1jERi9A=; b=N53LYbJXcnCleaOXaz7icJlL6DZB+88Cr7gpknnDzkVQgORsnDFnK7uGHUgSKryrbdjw4d+Oir8UPmoz7bkrIKHmVxgJVi1RGFx23EKTISLJbZ78AY8gawHqyeVohAKZn9crb5DkRar/ZaMiUt2salUuD5IqXWyUrlcABhvCmks= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1597304572483915.6370747222712; Thu, 13 Aug 2020 00:42:52 -0700 (PDT) Received: from localhost ([::1]:39698 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k67sx-0008Cs-9F for importer@patchew.org; Thu, 13 Aug 2020 03:42:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40856) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k67pC-00007i-Al; Thu, 13 Aug 2020 03:38:58 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:4180 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k67pA-0001p6-CZ; Thu, 13 Aug 2020 03:38:57 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 30AA6CA9D1453178205B; Thu, 13 Aug 2020 15:38:52 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.487.0; Thu, 13 Aug 2020 15:38:42 +0800 From: Chen Qun To: , Subject: [PATCH 10/11] hw/intc: Remove redundant statement in exynos4210_combiner_read() Date: Thu, 13 Aug 2020 15:37:11 +0800 Message-ID: <20200813073712.4001404-11-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20200813073712.4001404-1-kuhn.chenqun@huawei.com> References: <20200813073712.4001404-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=kuhn.chenqun@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/13 03:38:52 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , zhang.zhanghailiang@huawei.com, Igor Mitsyanko , pannengyuan@huawei.com, Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: hw/intc/exynos4210_combiner.c:231:9: warning: Value stored to 'val' is neve= r read val =3D s->reg_set[offset >> 2]; The default value of 'val' is '0', so we can break the 'default' branch and= return 'val'. Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Igor Mitsyanko Cc: Peter Maydell --- hw/intc/exynos4210_combiner.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/intc/exynos4210_combiner.c b/hw/intc/exynos4210_combiner.c index b8561e4180..e2e745bbaa 100644 --- a/hw/intc/exynos4210_combiner.c +++ b/hw/intc/exynos4210_combiner.c @@ -228,8 +228,7 @@ exynos4210_combiner_read(void *opaque, hwaddr offset, u= nsigned size) hw_error("exynos4210.combiner: overflow of reg_set by 0x" TARGET_FMT_plx "offset\n", offset); } - val =3D s->reg_set[offset >> 2]; - return 0; + break; } return val; } --=20 2.23.0 From nobody Mon Feb 9 14:44:09 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1597304899; cv=none; d=zohomail.com; s=zohoarc; b=bUHAcR1+IfPFGJm67SF6467vckgeEmWnPEdNzK1yMpPlOcGDElsl2bg1Z/2PXLTz2qZjA1NZ2pupdxCg3LN2iJVuvUoqnDl3kPIEAOc0i3ZXf6y9OqEGZwa8ND4jI8wSDT74uFxULfxpU/XBdkzIkdiXUykwB77KOXaH7RqR23U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597304899; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=7ZImKaAuAOQxxC5V8DecTHHzXoy5h+nTC3DK9MMUNUM=; b=RQ5Dw/oTE0/Phmprt3rHNPBs33RZIgg3pYSn3ucPuPIgxfv+jrgW+JtMuUMrsagxagD5WGsznwN65+pZzR7gS6pW6sB7NKNqEITYkxerBej8f7Nm+wnxOiNwxQBQcB8Gmj5CzAzm11fmDxuX48i/dYBQ23pDpMnsfCAXTGt91MY= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1597304899107391.64977053637165; Thu, 13 Aug 2020 00:48:19 -0700 (PDT) Received: from localhost ([::1]:59636 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k67yD-0008AD-SZ for importer@patchew.org; Thu, 13 Aug 2020 03:48:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k67pC-00008k-NW; Thu, 13 Aug 2020 03:38:58 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:4179 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k67pA-0001pE-Q3; Thu, 13 Aug 2020 03:38:58 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 34DAAEBDE788029AA109; Thu, 13 Aug 2020 15:38:52 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.487.0; Thu, 13 Aug 2020 15:38:43 +0800 From: Chen Qun To: , Subject: [PATCH 11/11] hw/display/vga:Remove redundant statement in vga_draw_graphic() Date: Thu, 13 Aug 2020 15:37:12 +0800 Message-ID: <20200813073712.4001404-12-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20200813073712.4001404-1-kuhn.chenqun@huawei.com> References: <20200813073712.4001404-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=kuhn.chenqun@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/13 03:38:52 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chen Qun , Gerd Hoffmann , pannengyuan@huawei.com, zhang.zhanghailiang@huawei.com, Euler Robot Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: hw/display/vga.c:1677:9: warning: Value stored to 'update' is never read update =3D full_update; ^ ~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Gerd Hoffmann --- Cc: Gerd Hoffmann --- hw/display/vga.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/display/vga.c b/hw/display/vga.c index 061fd9ab8f..836ad50c7b 100644 --- a/hw/display/vga.c +++ b/hw/display/vga.c @@ -1674,7 +1674,6 @@ static void vga_draw_graphic(VGACommonState *s, int f= ull_update) if (!(s->cr[VGA_CRTC_MODE] & 2)) { addr =3D (addr & ~0x8000) | ((y1 & 2) << 14); } - update =3D full_update; page0 =3D addr & s->vbe_size_mask; page1 =3D (addr + bwidth - 1) & s->vbe_size_mask; if (full_update) { --=20 2.23.0