From nobody Sun Feb 8 21:28:46 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1597305024; cv=none; d=zohomail.com; s=zohoarc; b=n88Ddt0ycMx6+DQIc5o7Tgz9uFaIz7oUcn7lMnyy76QaPZOUFhRc25ABjkn6WmiSxPd2tdp/H5ESgeixfxyNUCI2zf6CNIxadLsF+lKwsQ0XvcOMsHZLBgOeOfv3Geb+5VbM0EmIECnfxlT883Krv4auaPkaccSzgrIgVxni6YA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597305024; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nMrDvCPiLS3qactv2cpG6RZ0nflNlVJiAcKxN681dHU=; b=nrMx80JmyHvXRH9f+V3IxdiK8jbVx4W0WQKtNZdSEu0JNuicPFA1CkKssRsQ1IQMM8VHxopLCq2ZRipC5mfX/MjB8VmHCrLppmRuklSYparIE70wuGdePy2r4XYVlB4GnNo9qJVktTdnfldd0V1CebepMtNqw/z11Sn16gkmn6g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1597305024979626.9367760638746; Thu, 13 Aug 2020 00:50:24 -0700 (PDT) Received: from localhost ([::1]:40500 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k680F-0003QJ-ET for importer@patchew.org; Thu, 13 Aug 2020 03:50:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42014) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k67um-0002Hw-CS for qemu-devel@nongnu.org; Thu, 13 Aug 2020 03:44:44 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:39889 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k67uk-0002VS-IE for qemu-devel@nongnu.org; Thu, 13 Aug 2020 03:44:44 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-288-PfXKr2MENmyJUZxR3QpR9w-1; Thu, 13 Aug 2020 03:44:37 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0C055107ACCA; Thu, 13 Aug 2020 07:44:34 +0000 (UTC) Received: from localhost (ovpn-114-3.ams2.redhat.com [10.36.114.3]) by smtp.corp.redhat.com (Postfix) with ESMTP id 584DF10013D5; Thu, 13 Aug 2020 07:44:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597304680; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nMrDvCPiLS3qactv2cpG6RZ0nflNlVJiAcKxN681dHU=; b=GLQ01ZFWeoH5IB40qrRZpibBXKVesT6TRBRZslD0J8oVoFtgMvapyR6NsnTsQPCF+Ewn/s BWG3KSnZUcKvLDSuYgDOgmZ6em3teF7hpgtgrztsy/qqcEzRkb/up8E/ZsUSXadrSOJFMG SIIa0f0+EUOJ9tLUBQMwMH94D+H91zw= X-MC-Unique: PfXKr2MENmyJUZxR3QpR9w-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PULL 1/9] scripts/tracetool: Fix dtrace generation for macOS Date: Thu, 13 Aug 2020 06:22:49 +0100 Message-Id: <20200813052257.226142-2-stefanha@redhat.com> In-Reply-To: <20200813052257.226142-1-stefanha@redhat.com> References: <20200813052257.226142-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.120; envelope-from=stefanha@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/13 03:44:21 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MIME_BASE64_TEXT=1.741, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sagar Karandikar , "Michael S. Tsirkin" , Jason Wang , Alistair Francis , Gerd Hoffmann , Li Zhijian , qemu-block@nongnu.org, Juan Quintela , David Hildenbrand , Aleksandar Markovic , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Aleksandar Rikalo , "Dr. David Alan Gilbert" , Cameron Esfahani , Alex Williamson , Stefan Hajnoczi , Palmer Dabbelt , David Gibson , Kevin Wolf , qemu-riscv@nongnu.org, Bastian Koppelmann , Roman Bolshakov , Max Reitz , Zhang Chen , qemu-ppc@nongnu.org, Paolo Bonzini , Aurelien Jarno , Stefan Berger Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Roman Bolshakov dtrace USDT is fully supported since OS X 10.6. There are a few peculiarities compared to other dtrace flavors. 1. It doesn't accept empty files. 2. It doesn't recognize bool type but accepts C99 _Bool. 3. It converts int8_t * in probe points to char * in header files and introduces [-Wpointer-sign] warning. Cc: Cameron Esfahani Signed-off-by: Roman Bolshakov Reviewed-by: Stefan Hajnoczi Message-id: 20200717093517.73397-2-r.bolshakov@yadro.com Signed-off-by: Stefan Hajnoczi --- scripts/tracetool/format/d.py | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/scripts/tracetool/format/d.py b/scripts/tracetool/format/d.py index 0afb5f3f47..353722f89c 100644 --- a/scripts/tracetool/format/d.py +++ b/scripts/tracetool/format/d.py @@ -13,6 +13,7 @@ __email__ =3D "stefanha@redhat.com" =20 =20 from tracetool import out +from sys import platform =20 =20 # Reserved keywords from @@ -34,7 +35,8 @@ def generate(events, backend, group): =20 # SystemTap's dtrace(1) warns about empty "provider qemu {}" but is ha= ppy # with an empty file. Avoid the warning. - if not events: + # But dtrace on macOS can't deal with empty files. + if not events and platform !=3D "darwin": return =20 out('/* This file is autogenerated by tracetool, do not edit. */' @@ -44,6 +46,17 @@ def generate(events, backend, group): for e in events: args =3D [] for type_, name in e.args: + if platform =3D=3D "darwin": + # macOS dtrace accepts only C99 _Bool + if type_ =3D=3D 'bool': + type_ =3D '_Bool' + if type_ =3D=3D 'bool *': + type_ =3D '_Bool *' + # It converts int8_t * in probe points to char * in header + # files and introduces [-Wpointer-sign] warning. + # Avoid it by changing probe type to signed char * beforeh= and. + if type_ =3D=3D 'int8_t *': + type_ =3D 'signed char *' if name in RESERVED_WORDS: name +=3D '_' args.append(type_ + ' ' + name) --=20 2.26.2