From nobody Tue May 21 01:50:21 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1596728087; cv=none; d=zohomail.com; s=zohoarc; b=JvjwiW1Ezq68IGBfyFtywrnRtw0+sSor9rZs8PAiUeGR5TxfWHS62SffrvUOX4F6QKg+5T6YQB9TxYlatXEsFg+b7DVET2L0tCNHNwdj+I+LTlTgJgXV9DOy5GSo5ASK265rSLBTS3SfZEWZgTUXi9kd3q8w/HKtJYQAT4XdHXo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1596728087; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To; bh=gJC2NG30aCv1VEi+zchQA9jqwkJzQkawqfk/at+WSz8=; b=Y6nXd3QFsOgXqcRzihazs9P2ISzXxFAbxFZzCnIi/a+SMxpoCqiTMkabZpQYiySN8pbS/ZNM9rE+wodxyTht12AR9VPvVSyP8bkjTYhhUui14LUB8QHFooZP2ye3GKbauv54elGfs7cuoEqt+ENcnocMWUVptecXBmTu38RAnuc= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 159672808693837.40837974576607; Thu, 6 Aug 2020 08:34:46 -0700 (PDT) Received: from localhost ([::1]:45884 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k3hun-0006OM-LW for importer@patchew.org; Thu, 06 Aug 2020 11:34:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53174) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k3htn-0005aQ-Q2 for qemu-devel@nongnu.org; Thu, 06 Aug 2020 11:33:43 -0400 Received: from mx2.suse.de ([195.135.220.15]:52500) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k3htk-0003se-VZ for qemu-devel@nongnu.org; Thu, 06 Aug 2020 11:33:43 -0400 Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6E174AC7C; Thu, 6 Aug 2020 15:33:56 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Claudio Fontana To: Paolo Bonzini , "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [RFC] checkpatch: detect missing changes to trace-events Date: Thu, 6 Aug 2020 17:33:31 +0200 Message-Id: <20200806153331.23907-1-cfontana@suse.de> X-Mailer: git-send-email 2.16.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/05 23:10:57 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Claudio Fontana , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Claudio Fontana --- scripts/checkpatch.pl | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) We could do something similar to MAINTAINERS for trace-events, ie warning about files added, moved, deleted if we don't see an update to a trace-events file. To make it more solid it would be better to check the actual file contents for #include "trace.h" or "trace-root.h", but I guess this is not possible/practice from checkpatch? If we could only warn for files moved that actually include trace.h or trace-root.h, we could avoid a lot of false positives. Thanks, Claudio diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index bd3faa154c..1c8afebed5 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1300,6 +1300,7 @@ sub process { my $in_header_lines =3D $file ? 0 : 1; my $in_commit_log =3D 0; #Scanning lines before patch my $reported_maintainer_file =3D 0; + my $reported_trace_events_file =3D 0; my $non_utf8_charset =3D 0; =20 our @report =3D (); @@ -1524,15 +1525,24 @@ sub process { if ($line =3D~ /^\s*MAINTAINERS\s*\|/) { $reported_maintainer_file =3D 1; } - +# similar check for trace-events + if ($line =3D~ /^\s*trace-events\s*\|/) { + $reported_trace_events_file =3D 1; + } # Check for added, moved or deleted files - if (!$reported_maintainer_file && !$in_commit_log && + if (!$in_commit_log && ($line =3D~ /^(?:new|deleted) file mode\s*\d+\s*$/ || $line =3D~ /^rename (?:from|to) [\w\/\.\-]+\s*$/ || ($line =3D~ /\{\s*([\w\/\.\-]*)\s*\=3D\>\s*([\w\/\.\-]*)\s*\}/ && (defined($1) || defined($2))))) { - $reported_maintainer_file =3D 1; - WARN("added, moved or deleted file(s), does MAINTAINERS need updating?\= n" . $herecurr); + if (!$reported_maintainer_file) { + $reported_maintainer_file =3D 1; + WARN("added, moved or deleted file(s), does MAINTAINERS need updating?= \n" . $herecurr); + } + if (!$reported_trace_events_file) { + $reported_trace_events_file =3D 1; + WARN("added, moved or deleted file(s), does trace-events need updating= ?\n" . $herecurr); + } } =20 # Check for wrappage within a valid hunk of the file --=20 2.16.4