From nobody Tue Feb 10 14:33:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1596711059; cv=none; d=zohomail.com; s=zohoarc; b=TnMmg/l2e0ohjwS+cFK3aLPM3gtUR2r976ODtL4gOAruCGUpWOnL7SH/iQljzbYBER5ZURIPGKSfgLC9TBRM+FBrTqDczoUdxd6jAKMa0INjBMbuRyZKo0zMwZTcxpVgzOdzomDPQjVJQzM1cHO10bVJHU5V6Ce0GmIhsTTo8t4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1596711059; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=oVvqKqlUGUYnxjk1oIPFfZzk4tyrvTEr7tv+ZDt5Avo=; b=evmYJ4PJsD1WG9wbtimqJy3NUK6Eb9g+7TEJdlLr6aGCbuvPZM2dTEFzkupDuGmn6uX0she+GXuVZxtjh6Xju2WP2ZUlrA1GQ7PdC3uy/5zgmKcdwLxoTNYGmqPdTgRs2UIf1b3FkIl88Gj2vQbfgse1g9DKYZN/AtlZ6GahLK0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1596711059226263.0374828338887; Thu, 6 Aug 2020 03:50:59 -0700 (PDT) Received: from localhost ([::1]:38578 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k3dU9-0005iC-Sv for importer@patchew.org; Thu, 06 Aug 2020 06:50:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39498) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k3dOX-0005UH-JQ for qemu-devel@nongnu.org; Thu, 06 Aug 2020 06:45:09 -0400 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:50678) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k3dOR-0007Ip-6k for qemu-devel@nongnu.org; Thu, 06 Aug 2020 06:45:09 -0400 Received: by mail-wm1-x344.google.com with SMTP id c80so8415564wme.0 for ; Thu, 06 Aug 2020 03:45:02 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id a10sm6042189wrx.15.2020.08.06.03.45.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2020 03:45:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=oVvqKqlUGUYnxjk1oIPFfZzk4tyrvTEr7tv+ZDt5Avo=; b=bcpn54wMF6GymuKOsDDLoxwwiEsFleU/5z/m5wJq+ndG+040IDN1YSAwPjlcBZAlM1 UN1d0f12Img+8uKgcN+VvlgSG+e04JyPU2KoiZsxPGuJHppTFAIyFIOEMC4qHeXJqgXc XxHf8YyxMpQBrXzm+7WqWu9la0vFrCmIdl0G5hZJXwnz5iS/lKQ8ZgROtOV4EAwbc4VI mtSA/+fnD9YfkTUFzKwGcxu1jJ4eH9Ur+rDZBYX3B6yzutnEaINQmYgpE2FTf90iAYM+ sdbMC4yA9bD3m5Lu5t4eAhGrhxDBVgKyTjjAiWI3lC+/mwMsRVY/zXyAwDyiOAbAtHcZ SS7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oVvqKqlUGUYnxjk1oIPFfZzk4tyrvTEr7tv+ZDt5Avo=; b=QmHn57RyhujZoZ+HSAxQ3CDOzjh99FTeR4CPYCMwsiHBOq3vFPozUBPSSImV/pQ3Yp MfTvqfmEdZzoK6g+RiyvqbZMrxUWKPv+1k919KZy4M2ZhwKwRKKl9uedLrUJEwn0qxXV BZYv/b7c5HiXu88EWywR2kk1twbwYCLL2yES7M3CSZL+m5LkOFaFBjEdqbOjzIxOU8Am Y9QqN9wnBgpQoeoyk8XNu5VTqEH0eoOgOomBE+gIC+GaS9B8i2rYKvXGKuxiBxY59QwT lgoy12HUUUlcpWaweqnIZrmaoMJFhSJ8nT4dBobITsMryWYelDAevLOz9IqpNOjNsGPP Lzmg== X-Gm-Message-State: AOAM5308SpDEAIj6jGs2QIuRK8o6x+xev2gb7Q0AG++4uKzt2X44oM7V eP/0nbAiEXQkh3Td7jwkzPLY0aeeTA3sKg== X-Google-Smtp-Source: ABdhPJzd3/P0IgR+Lwbu5iHEi/ag3uY00B7D2MUr+zWTkHtoVhWRgr8RbbcAHETl/Glp9RaDspBuGA== X-Received: by 2002:a1c:c90d:: with SMTP id f13mr7586788wmb.25.1596710701609; Thu, 06 Aug 2020 03:45:01 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH 4/4] target/arm: Use correct FPST for VCMLA, VCADD on fp16 Date: Thu, 6 Aug 2020 11:44:53 +0100 Message-Id: <20200806104453.30393-5-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200806104453.30393-1-peter.maydell@linaro.org> References: <20200806104453.30393-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::344; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x344.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" When we implemented the VCMLA and VCADD insns we put in the code to handle fp16, but left it using the standard fp status flags. Correct them to use FPST_STD_F16 for fp16 operations. Signed-off-by: Peter Maydell Reviewed-by: Alex Benn=C3=A9e --- target/arm/translate-neon.inc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/arm/translate-neon.inc.c b/target/arm/translate-neon.in= c.c index 5158dd14ad2..96e27e28009 100644 --- a/target/arm/translate-neon.inc.c +++ b/target/arm/translate-neon.inc.c @@ -181,7 +181,7 @@ static bool trans_VCMLA(DisasContext *s, arg_VCMLA *a) } =20 opr_sz =3D (1 + a->q) * 8; - fpst =3D fpstatus_ptr(FPST_STD); + fpst =3D fpstatus_ptr(a->size =3D=3D 0 ? FPST_STD_F16 : FPST_STD); fn_gvec_ptr =3D a->size ? gen_helper_gvec_fcmlas : gen_helper_gvec_fcm= lah; tcg_gen_gvec_3_ptr(vfp_reg_offset(1, a->vd), vfp_reg_offset(1, a->vn), @@ -218,7 +218,7 @@ static bool trans_VCADD(DisasContext *s, arg_VCADD *a) } =20 opr_sz =3D (1 + a->q) * 8; - fpst =3D fpstatus_ptr(FPST_STD); + fpst =3D fpstatus_ptr(a->size =3D=3D 0 ? FPST_STD_F16 : FPST_STD); fn_gvec_ptr =3D a->size ? gen_helper_gvec_fcadds : gen_helper_gvec_fca= ddh; tcg_gen_gvec_3_ptr(vfp_reg_offset(1, a->vd), vfp_reg_offset(1, a->vn), @@ -322,7 +322,7 @@ static bool trans_VCMLA_scalar(DisasContext *s, arg_VCM= LA_scalar *a) fn_gvec_ptr =3D (a->size ? gen_helper_gvec_fcmlas_idx : gen_helper_gvec_fcmlah_idx); opr_sz =3D (1 + a->q) * 8; - fpst =3D fpstatus_ptr(FPST_STD); + fpst =3D fpstatus_ptr(a->size =3D=3D 0 ? FPST_STD_F16 : FPST_STD); tcg_gen_gvec_3_ptr(vfp_reg_offset(1, a->vd), vfp_reg_offset(1, a->vn), vfp_reg_offset(1, a->vm), --=20 2.20.1