From nobody Sat May 4 01:14:59 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1596557401; cv=none; d=zohomail.com; s=zohoarc; b=WM9rVoeMAGF2ao2lQbCHRWoCUrDZlQTo6kA9KEeQuovUFSkeSOuzJ8KVARM4y1kMH3YOkMx3dxFNElhM7PNPunuJc7+q74ET1URcORDV+mBhLNo8Ix6mpGfbg2DrL7iGocissC85uP7nrub4L1Lcey2wcng5Q5u1Naf9p0XfcL4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1596557401; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=e9h1dxfcHunD8hLi5hAFgkUxc0WZaXDSQ3fg/GVRuNw=; b=eqSpfeieE2f3J4hcwPKYOH06id4l/4waTrizZRs/cfLh9Rdl5PvI0k0liyn3+GVQgpBlWryjA/nhmqWsyQ4U9mRUK3xSjzKrwI4QM0HuV03SiC77h7W68WM1uerVkEDjrhdJNDnQFvo9SD7IT8rxucCoB1iQW19IblK9bM4/Z4Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1596557401216254.61706758186222; Tue, 4 Aug 2020 09:10:01 -0700 (PDT) Received: from localhost ([::1]:37034 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k2zVn-0004X7-QB for importer@patchew.org; Tue, 04 Aug 2020 12:09:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45132) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k2zUl-0003FH-6w for qemu-devel@nongnu.org; Tue, 04 Aug 2020 12:08:55 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]:33314) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k2zUj-0005m3-I9 for qemu-devel@nongnu.org; Tue, 04 Aug 2020 12:08:54 -0400 Received: by mail-wr1-x42c.google.com with SMTP id p20so3037190wrf.0 for ; Tue, 04 Aug 2020 09:08:53 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id b186sm5625928wme.1.2020.08.04.09.08.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2020 09:08:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=e9h1dxfcHunD8hLi5hAFgkUxc0WZaXDSQ3fg/GVRuNw=; b=oRU5agBGMx3vpPU2okvvejkn6JQ1UfOyFHwt6y6S7xpybG4v8MMS8r16soCxGewGvJ AQHPCqgTLHkps+4bDj3oxLZvQFzVFKEUdX/GhAp89BmAnc/bkQ3wK7GOPlnQi0PGMqc3 jk5YlZ+y04/aG+N1ZpKetBl0I+FkcQLAp6MnpPxcBLVHJ78fBuxn/eJSsg81m6V/uIhQ O9gbVFAcPSFU1p5mDz5/9DmLXYWjTlkM8bb338AudD+jFPPgaJI9lr1exWBFb/ay8PC9 rwUzg8zWq800zinpag3juCjPQyMgYXPfVl2jnV8g1480r4cyrnIJCnaZzm0Reen8QKZI BpGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=e9h1dxfcHunD8hLi5hAFgkUxc0WZaXDSQ3fg/GVRuNw=; b=dRb6JNGJpq/xSa+Sqc0hkbPfZWF5iTHF14ghlIWBW5wP0aEv+8NfW5fQoFV6lx+2tz JGi1xRXhGIMbhJtrWZophRTpGx/ISKJy2Mw0OVuawzbrT9NiIp8iBznIwl1OKDZbbPMK Fh7zNaMfv3g2/L9Sq9VTNSDl2hkhMiIPT68XemPW/8FUWZKrn+UJBz0JKWJpiHEmC3UG WfZ8oOncUjUDtRmVBnlE7tndD4QjOX5FKxkHh0Rl8HpBjqif7HaqASuFbppy8KB2wrdf tu/QWQCJ1C+NSFqM+D9o+1yJOp7QMhjAepTdDXPbCzF/2qVA4ZKRx1no52n/yG+wvYb0 he+Q== X-Gm-Message-State: AOAM532sk4fWxMkoxr+e7cnRWU+DqwWl87YxU0Bv9aap7BCerFi8fV5H YgL4Yf4C040OWQ6rx/OncoPf79/A3AD0JQ== X-Google-Smtp-Source: ABdhPJwmr7dQlZNHnks+5wV7SapB2KOb7dnH6kJofDfjbpze0vTqj0HL2/EKZet6MZ+B+/K99xOyDg== X-Received: by 2002:a5d:4c46:: with SMTP id n6mr21680545wrt.73.1596557330884; Tue, 04 Aug 2020 09:08:50 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 1/2] docs/devel: Document decodetree no-overlap groups Date: Tue, 4 Aug 2020 17:08:42 +0100 Message-Id: <20200804160843.30245-2-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200804160843.30245-1-peter.maydell@linaro.org> References: <20200804160843.30245-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42c.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" From: Richard Henderson When support for this feature went in, the update to the documentation was forgotten. Fixes: 067e8b0f45d6 Reported-by: Peter Maydell Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-id: 20200803205708.315829-1-richard.henderson@linaro.org Signed-off-by: Peter Maydell --- docs/devel/decodetree.rst | 29 ++++++++++++++++++----------- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/docs/devel/decodetree.rst b/docs/devel/decodetree.rst index ce7f52308ff..74f66bf46e2 100644 --- a/docs/devel/decodetree.rst +++ b/docs/devel/decodetree.rst @@ -173,18 +173,25 @@ Pattern Groups =20 Syntax:: =20 - group :=3D '{' ( pat_def | group )+ '}' + group :=3D overlap_group | no_overlap_group + overlap_group :=3D '{' ( pat_def | group )+ '}' + no_overlap_group :=3D '[' ( pat_def | group )+ ']' =20 -A *group* begins with a lone open-brace, with all subsequent lines -indented two spaces, and ending with a lone close-brace. Groups -may be nested, increasing the required indentation of the lines -within the nested group to two spaces per nesting level. +A *group* begins with a lone open-brace or open-bracket, with all +subsequent lines indented two spaces, and ending with a lone +close-brace or close-bracket. Groups may be nested, increasing the +required indentation of the lines within the nested group to two +spaces per nesting level. =20 -Unlike ungrouped patterns, grouped patterns are allowed to overlap. -Conflicts are resolved by selecting the patterns in order. If all -of the fixedbits for a pattern match, its translate function will -be called. If the translate function returns false, then subsequent -patterns within the group will be matched. +Patterns within overlap groups are allowed to overlap. Conflicts are +resolved by selecting the patterns in order. If all of the fixedbits +for a pattern match, its translate function will be called. If the +translate function returns false, then subsequent patterns within the +group will be matched. + +Patterns within no-overlap groups are not allowed to overlap, just +the same as ungrouped patterns. Thus no-overlap groups are intended +to be nested inside overlap groups. =20 The following example from PA-RISC shows specialization of the *or* instruction:: @@ -200,7 +207,7 @@ instruction:: When the *cf* field is zero, the instruction has no side effects, and may be specialized. When the *rt* field is zero, the output is discarded and so the instruction has no effect. When the *rt2* -field is zero, the operation is ``reg[rt] | 0`` and so encodes +field is zero, the operation is ``reg[r1] | 0`` and so encodes the canonical register copy operation. =20 The output from the generator might look like:: --=20 2.20.1 From nobody Sat May 4 01:14:59 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1596557489; cv=none; d=zohomail.com; s=zohoarc; b=gnQ8IjCJytO5AbDIpTlinAIVje2wzUafx0l7RUulHjYPCwMMgkGhYHk87AjxAxL1c8T0q5MskbtF6wjOG+8GAau/atVXvatvDNxp79MPl1VXpgTcJrAmSzQjUxJk5eheJFbtmb2XoIMvamw5Or2lkRvY8HdcblT+2bgjHomYlsI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1596557489; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=xPQDalBP2qoLIoG+4RRB4/KzO/Ml5Sn8Tuw/Y/ydU1E=; b=ErruXfhHG5FWtuYOSZVfBsRoh5DbNHeag+bSLwNkpNVyprWFu2pPy5AivdqpE2XVvOC9Ovh4jCNPFFLNH8GgN/8zCzUQP4VoZ/tyqZycroT8Xxo2nc/pnx3QGl4OTLcwD2dwfHtjiSAsuQpGkfMWux+FUEiVBxp5ZSMFkL5qusI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1596557489463675.8347647792505; Tue, 4 Aug 2020 09:11:29 -0700 (PDT) Received: from localhost ([::1]:42634 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k2zXE-0006rB-0b for importer@patchew.org; Tue, 04 Aug 2020 12:11:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45148) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k2zUp-0003MP-Gk for qemu-devel@nongnu.org; Tue, 04 Aug 2020 12:08:59 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:36197) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k2zUn-0005mL-SS for qemu-devel@nongnu.org; Tue, 04 Aug 2020 12:08:59 -0400 Received: by mail-wr1-x435.google.com with SMTP id 88so37909034wrh.3 for ; Tue, 04 Aug 2020 09:08:57 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id b186sm5625928wme.1.2020.08.04.09.08.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2020 09:08:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=xPQDalBP2qoLIoG+4RRB4/KzO/Ml5Sn8Tuw/Y/ydU1E=; b=nx34AeO3PjOi9dmjw6bOs8pklE4xVIF3U3ca+BlpHY78BIMjaPLXQtCRsM4/c9h/MU M75k5lshsdWjPJr2Ragb301uJEFadwdYpJEPjP9lVWfdxZwO1gbx8MTz4dPHtCKDwxWj 1irYrPOHxdG/z5uEnbrOOKJ2Mysjb1QSeEMsPv5KwISpYNirasbM23dStvwOHIxFGhIZ xL2crD8mHaB1q3pLNTIssatVLy/PyecmWY2OuxAxx+wAtmHjaISnScaYDBR5dAndrhmK VJcfWLafOKhiYiGgNb2iFg3Sp4vnRxh84AZouq6+fwWFzLQ8LAcOrM/LtFarwW9DFnBh i/zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xPQDalBP2qoLIoG+4RRB4/KzO/Ml5Sn8Tuw/Y/ydU1E=; b=dG5HGRT4wrxfyK8D+Fgj7k+Tw2JecknI5PLKPZT6+riV9+3fjGsr0Kmy9VZ/nmi5P7 ty18IFiwvcQjIo//OLVI3UhMGaHPcPHVxAPmdsQ1zSjYqyc2+FUHMuQjR5FPmdbJEc1V j2o0MP7fUv+2qBVXEwHo0oIB4gcqBeRw1I1r8S18gQeGLlogIViHYkBHIqQbmjVLKNY/ L9RxNjYUJtxl+niBOIf++j/6RE/ryaPgCvP7BNJr66xF9IEgwSkOj7E8WLCEFAdMPPCW I9qwGRRRnUwwbghTt8TZj2ioaXsP78yXfNINI+9YMq74k8MuUYtOoVrLgM7tUVVw3ouu KmAg== X-Gm-Message-State: AOAM533CDodPin5lLYX2HuiCER+eY5OJ73v3nBvjgo+Rg5D9nNHzvyKd bNBNkbRtC2+H/F+ao3CCI1y4vWHL9Ao38Q== X-Google-Smtp-Source: ABdhPJy+YTo2UasLXqd1MTESAxHVO+SVn6dtFAjQYvT6sato5wS3JcyaebtWZGHVwD/wVgCfDA6Djg== X-Received: by 2002:a5d:4603:: with SMTP id t3mr2344786wrq.175.1596557335484; Tue, 04 Aug 2020 09:08:55 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 2/2] target/arm: Fix decode of LDRA[AB] instructions Date: Tue, 4 Aug 2020 17:08:43 +0100 Message-Id: <20200804160843.30245-3-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200804160843.30245-1-peter.maydell@linaro.org> References: <20200804160843.30245-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x435.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" From: Peter Collingbourne These instructions use zero as the discriminator, not SP. Signed-off-by: Peter Collingbourne Message-id: 20200804002849.30268-1-pcc@google.com Reviewed-by: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- target/arm/translate-a64.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index c98dfb17a83..534c3ff5f37 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -3429,9 +3429,11 @@ static void disas_ldst_pac(DisasContext *s, uint32_t= insn, =20 if (s->pauth_active) { if (use_key_a) { - gen_helper_autda(dirty_addr, cpu_env, dirty_addr, cpu_X[31]); + gen_helper_autda(dirty_addr, cpu_env, dirty_addr, + new_tmp_a64_zero(s)); } else { - gen_helper_autdb(dirty_addr, cpu_env, dirty_addr, cpu_X[31]); + gen_helper_autdb(dirty_addr, cpu_env, dirty_addr, + new_tmp_a64_zero(s)); } } =20 --=20 2.20.1