[PATCH v2] target/arm: Fix decode of LDRA[AB] instructions

Peter Collingbourne posted 1 patch 3 years, 7 months ago
Test docker-quick@centos7 failed
Test docker-mingw@fedora failed
Test checkpatch failed
Test FreeBSD failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200804002849.30268-1-pcc@google.com
Maintainers: Peter Maydell <peter.maydell@linaro.org>
target/arm/translate-a64.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
[PATCH v2] target/arm: Fix decode of LDRA[AB] instructions
Posted by Peter Collingbourne 3 years, 7 months ago
These instructions use zero as the discriminator, not SP.

Signed-off-by: Peter Collingbourne <pcc@google.com>
---
v2:
- fixed commit message

 target/arm/translate-a64.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index 8c0764957c..c996ca1393 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -3429,9 +3429,11 @@ static void disas_ldst_pac(DisasContext *s, uint32_t insn,
 
     if (s->pauth_active) {
         if (use_key_a) {
-            gen_helper_autda(dirty_addr, cpu_env, dirty_addr, cpu_X[31]);
+            gen_helper_autda(dirty_addr, cpu_env, dirty_addr,
+                             new_tmp_a64_zero(s));
         } else {
-            gen_helper_autdb(dirty_addr, cpu_env, dirty_addr, cpu_X[31]);
+            gen_helper_autdb(dirty_addr, cpu_env, dirty_addr,
+                             new_tmp_a64_zero(s));
         }
     }
 
-- 
2.28.0.163.g6104cc2f0b6-goog


Re: [PATCH v2] target/arm: Fix decode of LDRA[AB] instructions
Posted by Richard Henderson 3 years, 7 months ago
On 8/3/20 5:28 PM, Peter Collingbourne wrote:
> These instructions use zero as the discriminator, not SP.
> 
> Signed-off-by: Peter Collingbourne <pcc@google.com>
> ---
> v2:
> - fixed commit message

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~

Re: [PATCH v2] target/arm: Fix decode of LDRA[AB] instructions
Posted by Peter Maydell 3 years, 7 months ago
On Tue, 4 Aug 2020 at 16:46, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 8/3/20 5:28 PM, Peter Collingbourne wrote:
> > These instructions use zero as the discriminator, not SP.
> >
> > Signed-off-by: Peter Collingbourne <pcc@google.com>
> > ---
> > v2:
> > - fixed commit message
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>



Applied to target-arm.next, thanks.

-- PMM