From nobody Wed Apr 24 12:12:30 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1596128654; cv=none; d=zohomail.com; s=zohoarc; b=Y8565S2NXuKI96NDxhVePB257J/VtoUbBy2WOdJJ8jMQdpTOMbkfLrAhiggHhUoQQYwQt8UWkMaNqdx7Ve6vQ9kR2EGsvINgOXCdJy4AfHqNh3cmLrBByM0dU+VnRLRA022d7gOKyVsbcEUZYmNj/w33l9VP5cOdB8+RIPmESyQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1596128654; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yVg0BC65TTj2TNeSd+KdcP3tFF6Km2gCk+HmGtrYiQY=; b=XuownNAkJ2yx+oIWoQFV4PvTfnZ2vDSeg1qcW7rT2GfljZaPf2MBE+ZxESpEqRHeLKekXyeuOtRE/i4wAppflf5hiMkRWACfpzT3RjMLeftxeBcOTm5ma7wDVGbI/KCFKgLTLYqAdnEIwZ7DkrUYyH/UWGDJdCMFbdKMbiQeZkw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1596128654268631.3543789521578; Thu, 30 Jul 2020 10:04:14 -0700 (PDT) Received: from localhost ([::1]:48854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k1ByW-0005Ox-E7 for importer@patchew.org; Thu, 30 Jul 2020 13:04:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45926) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k1Bth-0001ic-W8 for qemu-devel@nongnu.org; Thu, 30 Jul 2020 12:59:14 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:49864 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k1Btg-0007NF-42 for qemu-devel@nongnu.org; Thu, 30 Jul 2020 12:59:13 -0400 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-226-rf_OS_-dP6imXNyGXSGopw-1; Thu, 30 Jul 2020 12:59:09 -0400 Received: by mail-wr1-f70.google.com with SMTP id 5so8119615wrc.17 for ; Thu, 30 Jul 2020 09:59:08 -0700 (PDT) Received: from localhost.localdomain (214.red-88-21-68.staticip.rima-tde.net. [88.21.68.214]) by smtp.gmail.com with ESMTPSA id a3sm10085764wme.34.2020.07.30.09.59.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2020 09:59:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596128351; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yVg0BC65TTj2TNeSd+KdcP3tFF6Km2gCk+HmGtrYiQY=; b=PrFGvprvw8k5b5hK7E1oY2Ts9UbIPmnZQOZk7lA6D9ODZ/CN/LkwSD3fdiZpUcYAJ7Kpzn NmtxhtE4N0zrcoesDckCdH13UCXId2K2kDtsRIBn8XXCG6o1ZPUBxGV1yDlREE8X4lsBIj NBy2VTEq8POlEWpVIPTg6u3YRAdkm+A= X-MC-Unique: rf_OS_-dP6imXNyGXSGopw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yVg0BC65TTj2TNeSd+KdcP3tFF6Km2gCk+HmGtrYiQY=; b=AN/TTvRI8Z8lcC4UvbhevCeJOQ53s94m6pwFRVDkztiTTwiKZ57c3LGEz6OZszQ3iH Q9RbIdyJ5UORq+60dlh8sB2f+7UDk/p9artAg+1P/KmWEpiVsJDptgeZq324jTBHgop4 YsRUkndmmImSdsJM3jFQM0foNaPoyzQBnu5I5hOQtAEtZzjUKaGn6dehzLM2UY/+Sns2 41w/cSSodA1qUmSgTGk1BpEtlH3hUa4e+7xjYo5Cj35nupTnVQwM19pDoIYUL4yCKpGF 0vpuGSgWwCavU/pPCJGOzLxGM/TjbfeNNOaJmX8QgBbIOwkAtOP9xYYQpQRKG534Gvaz hDdA== X-Gm-Message-State: AOAM532ECn6EL38ZOcsBOHwCmLW+kEbf3lan+quvmMifvBeEufzLrLwt kJaFngMcvWTbbBjk6Uvp1LH27rmpH3uUDhENjEbq0t8hzxQuYcZwt9nxZp9awOBVQTXo4dWcXXX IxdcRveR9sQFJbFw= X-Received: by 2002:a5d:56c9:: with SMTP id m9mr20141396wrw.311.1596128347627; Thu, 30 Jul 2020 09:59:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx0x7vfCTvc4VsBWnL8ygOJZHyTNQpY+1ekW+CiHl9rg0hUwVGwiseolnUN8zKOnfsisD7QXw== X-Received: by 2002:a5d:56c9:: with SMTP id m9mr20141382wrw.311.1596128347454; Thu, 30 Jul 2020 09:59:07 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH-for-5.2 1/2] hw/mips/mipssim: Use MMIO serial device on fake ISA I/O Date: Thu, 30 Jul 2020 18:58:59 +0200 Message-Id: <20200730165900.7030-2-philmd@redhat.com> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200730165900.7030-1-philmd@redhat.com> References: <20200730165900.7030-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.120; envelope-from=philmd@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/29 23:51:30 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Aleksandar Rikalo , "Michael S. Tsirkin" , Aleksandar Markovic , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) The 'mipssim' is not a real hardware, it is a simulator. There is an ISA MMIO space mapped at 0x1fd00000, however this is not a real ISA bus (no ISA IRQ). So can not use the TYPE_ISA_SERIAL device... Instead we have been using a plain MMIO device, but named it IO. TYPE_SERIAL_IO is a superset of TYPE_SERIAL_MM, using regshift=3D0 and endianness=3DDEVICE_LITTLE_ENDIAN. Directly use the TYPE_SERIAL_MM device, enforcing the regshift/endianness values. 'regshift' default is already '0'. 'endianness' is meaningless for 8-bit accesses. Note, there is no migration problem, because TYPE_SERIAL_IO was not migrated. Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/mips/mipssim.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/mips/mipssim.c b/hw/mips/mipssim.c index 1b3b762203..853bbaca58 100644 --- a/hw/mips/mipssim.c +++ b/hw/mips/mipssim.c @@ -216,9 +216,11 @@ mips_mipssim_init(MachineState *machine) * MIPS CPU INT2, which is interrupt 4. */ if (serial_hd(0)) { - DeviceState *dev =3D qdev_new(TYPE_SERIAL_IO); + DeviceState *dev =3D qdev_new(TYPE_SERIAL_MM); =20 qdev_prop_set_chr(dev, "chardev", serial_hd(0)); + qdev_prop_set_uint8(dev, "regshift", 0); + qdev_prop_set_uint8(dev, "endianness", DEVICE_LITTLE_ENDIAN); qdev_set_legacy_instance_id(dev, 0x3f8, 2); sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal); sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, env->irq[4]); --=20 2.21.3 From nobody Wed Apr 24 12:12:30 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1596128447; cv=none; d=zohomail.com; s=zohoarc; b=mSUSKeuDDQE5mRaZydMASX79TOivfrpNlzfCQiEr+CbBhiR3qd2KHSvQTzTlOlQMdkh+nMhxkfd1xcJ6OHR26HcNc0YBcvPKRA1K61yt+hBqkf18t6dg5uIEe/zWzUi6QOpl01dMw5PUWx0FGfZ7Th4jP1EbKJp+f5fIgkiSUOQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1596128447; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=xsvkRs6YLJaQIptiQqmufvIaiTahLTrG2br/J1zshaU=; b=PCEo6jf4i0fJulvdRMKsS8ZHZswum3zJuNBUTVaasFXolVPwU20Jb7R+dVEdjbyzLqxHjD61wBufVNnIRVqsUVe5+voYZJMSmchlOKx8yZimKOuuQlDUSIphdUt9OfQlg3Vnw5XnywkSVs5DzvMFGinbAIWh4ymCzjJnocrv3uA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1596128447494680.6100785016816; Thu, 30 Jul 2020 10:00:47 -0700 (PDT) Received: from localhost ([::1]:43888 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k1BvA-0002r7-1x for importer@patchew.org; Thu, 30 Jul 2020 13:00:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45940) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k1Btn-0001oO-6r for qemu-devel@nongnu.org; Thu, 30 Jul 2020 12:59:19 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:45777 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k1Btl-0007Na-D0 for qemu-devel@nongnu.org; Thu, 30 Jul 2020 12:59:18 -0400 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-172-pCCIoYVQNH--NHuWfjHoeA-1; Thu, 30 Jul 2020 12:59:15 -0400 Received: by mail-wr1-f72.google.com with SMTP id f14so8111613wrm.22 for ; Thu, 30 Jul 2020 09:59:14 -0700 (PDT) Received: from localhost.localdomain (214.red-88-21-68.staticip.rima-tde.net. [88.21.68.214]) by smtp.gmail.com with ESMTPSA id g18sm11198388wru.27.2020.07.30.09.59.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2020 09:59:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596128356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xsvkRs6YLJaQIptiQqmufvIaiTahLTrG2br/J1zshaU=; b=VlGEQUKNxAKwvnv3HHVyCfKoblEcbQjs3RSVCDG53hxvwd/pdJfrzj9S3EjqhBvL2C36nR 8gkW1pTpW2Q4Ntv4bvhcKJpo2LoH+zitd1jTOgelaNNhoiQWFm+524hN3ZMnHi3xzvZnZE EDFfvZfsDDHdsvIZrUC8Y0QQZ9bpTmA= X-MC-Unique: pCCIoYVQNH--NHuWfjHoeA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xsvkRs6YLJaQIptiQqmufvIaiTahLTrG2br/J1zshaU=; b=MoqeK6iYkixWS/XElp/51oQCT19L8peBst9pxTc/nUUEqSjOicyzrkJllIEcIhpQOh QgPcXuaB8oyYWFTNiKLl/cvjC/+SShnX6t9EwSs+NDkEsxcQrX8kNI8ovobc6B9PbdIw qa7eDFTGABT8yFzrwn6rcpBhukzb+k22XmHdlKl4tPAeVeEd+++DxGldtftaoSG96+eA QVpVoOeZ55yjr6V9514pFmMvrjhpzjXJMdYPwM/DhwN5CUfXukouw88gYON9lpSLNDUx tHIoNfP/R0CYVeC2ZzOnwzYUoxLU3NFCuyG90NVS3DeV2H/wWodXak3784L6XmtdfHdK h1LQ== X-Gm-Message-State: AOAM5331luaNYT8SWgbXWNYoAFvC1pEsGsThmZG5KFb3WABt8lFX2w8t sX3bNHFOhYEkvJp+ngX9Pkqo2MiWj3EAyDYildOfuf4ijxl4xZPuvk8N4U/qg8wNJPb3YL0D33S vQkaRYp1UitS9sA0= X-Received: by 2002:a1c:9650:: with SMTP id y77mr158534wmd.101.1596128352621; Thu, 30 Jul 2020 09:59:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxnn3eF39ADajYONkpgFtSa8OUABS1r/WxeKeEQ9uKSNkOSRklLGIB/dZc/SDd3lUmZsRsnYA== X-Received: by 2002:a1c:9650:: with SMTP id y77mr158510wmd.101.1596128352344; Thu, 30 Jul 2020 09:59:12 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH-for-5.2 2/2] hw/char/serial: Remove TYPE_SERIAL_IO (superset of TYPE_SERIAL_MM) Date: Thu, 30 Jul 2020 18:59:00 +0200 Message-Id: <20200730165900.7030-3-philmd@redhat.com> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200730165900.7030-1-philmd@redhat.com> References: <20200730165900.7030-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/30 03:41:52 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Aleksandar Rikalo , "Michael S. Tsirkin" , Aleksandar Markovic , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) TYPE_SERIAL_IO is a superset of TYPE_SERIAL_MM, and it is not used anymore. Remove it. Suggested-by: Paolo Bonzini Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/char/serial.h | 9 --------- hw/char/serial.c | 41 ---------------------------------------- 2 files changed, 50 deletions(-) diff --git a/include/hw/char/serial.h b/include/hw/char/serial.h index 535fa23a2b..81d7ba1917 100644 --- a/include/hw/char/serial.h +++ b/include/hw/char/serial.h @@ -88,12 +88,6 @@ typedef struct SerialMM { uint8_t endianness; } SerialMM; =20 -typedef struct SerialIO { - SysBusDevice parent; - - SerialState serial; -} SerialIO; - extern const VMStateDescription vmstate_serial; extern const MemoryRegionOps serial_io_ops; =20 @@ -105,9 +99,6 @@ void serial_set_frequency(SerialState *s, uint32_t frequ= ency); #define TYPE_SERIAL_MM "serial-mm" #define SERIAL_MM(s) OBJECT_CHECK(SerialMM, (s), TYPE_SERIAL_MM) =20 -#define TYPE_SERIAL_IO "serial-io" -#define SERIAL_IO(s) OBJECT_CHECK(SerialIO, (s), TYPE_SERIAL_IO) - SerialMM *serial_mm_init(MemoryRegion *address_space, hwaddr base, int regshift, qemu_irq irq, int baudbase, diff --git a/hw/char/serial.c b/hw/char/serial.c index 2386479492..fd80ae5592 100644 --- a/hw/char/serial.c +++ b/hw/char/serial.c @@ -985,46 +985,6 @@ const MemoryRegionOps serial_io_ops =3D { .endianness =3D DEVICE_LITTLE_ENDIAN, }; =20 -static void serial_io_realize(DeviceState *dev, Error **errp) -{ - SerialIO *sio =3D SERIAL_IO(dev); - SerialState *s =3D &sio->serial; - - if (!qdev_realize(DEVICE(s), NULL, errp)) { - return; - } - - memory_region_init_io(&s->io, OBJECT(dev), &serial_io_ops, s, "serial"= , 8); - sysbus_init_mmio(SYS_BUS_DEVICE(sio), &s->io); - sysbus_init_irq(SYS_BUS_DEVICE(sio), &s->irq); -} - -static void serial_io_class_init(ObjectClass *klass, void* data) -{ - DeviceClass *dc =3D DEVICE_CLASS(klass); - - dc->realize =3D serial_io_realize; - /* No dc->vmsd: class has no migratable state */ -} - -static void serial_io_instance_init(Object *o) -{ - SerialIO *sio =3D SERIAL_IO(o); - - object_initialize_child(o, "serial", &sio->serial, TYPE_SERIAL); - - qdev_alias_all_properties(DEVICE(&sio->serial), o); -} - - -static const TypeInfo serial_io_info =3D { - .name =3D TYPE_SERIAL_IO, - .parent =3D TYPE_SYS_BUS_DEVICE, - .instance_size =3D sizeof(SerialIO), - .instance_init =3D serial_io_instance_init, - .class_init =3D serial_io_class_init, -}; - static Property serial_properties[] =3D { DEFINE_PROP_CHR("chardev", SerialState, chr), DEFINE_PROP_UINT32("baudbase", SerialState, baudbase, 115200), @@ -1178,7 +1138,6 @@ static const TypeInfo serial_mm_info =3D { static void serial_register_types(void) { type_register_static(&serial_info); - type_register_static(&serial_io_info); type_register_static(&serial_mm_info); } =20 --=20 2.21.3