From nobody Wed May 8 14:35:05 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1596114399; cv=none; d=zohomail.com; s=zohoarc; b=njTIuEFzf/LnOaSHGQhzU3XDM7ESqM77RFI9uOpR3wLvD7rFWPtZ1xFGIwg9Gut/mONn7rULsK9KlqOggH5LRTM352H7ajEKlXnaIewGsvvO5K4zH+fEbzq3FHelmrlRXOIOv75iAzM20BR8a0G/FMKXk9Kg+dzkyxH4c8wAQ2k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1596114399; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=f34LjGwiimzujk/BUJwIoSjvP3RxqckJkqNqZZUl7Fs=; b=ci8P5pb+SFRokdS/R7B6Rd9NXckKDddznUbO73O3/rih9dJXR8TFoImJc1L4sIc2uBHtwrfE1w5DE6enAD1ko5fFE5rxok1BBrCBlQDXLb6izyIiquKvIcA2Jd6Qiw0U/E8MnoaMr4DivBakLufOEI3ldis0ZWZk4UiMEoTO4sk= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1596114399673836.8529912604021; Thu, 30 Jul 2020 06:06:39 -0700 (PDT) Received: from localhost ([::1]:48062 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k18Gc-0005NT-5M for importer@patchew.org; Thu, 30 Jul 2020 09:06:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35252) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k18FX-0004OD-JV for qemu-devel@nongnu.org; Thu, 30 Jul 2020 09:05:31 -0400 Received: from mx2.suse.de ([195.135.220.15]:40490) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k18FV-0002yP-TS for qemu-devel@nongnu.org; Thu, 30 Jul 2020 09:05:31 -0400 Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B06E5AAC7; Thu, 30 Jul 2020 13:05:40 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Bruce Rogers To: qemu-devel@nongnu.org, sgarzare@redhat.com Subject: [PATCH] virtio-mem: Correct format specifier mismatch for RISC-V Date: Thu, 30 Jul 2020 07:05:19 -0600 Message-Id: <20200730130519.168475-1-brogers@suse.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=195.135.220.15; envelope-from=brogers@suse.com; helo=mx2.suse.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/30 02:10:23 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bruce Rogers , david@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" This likely affects other, less popular host architectures as well. Less common host architectures under linux get QEMU_VMALLOC_ALIGN (from which VIRTIO_MEM_MIN_BLOCK_SIZE is derived) define to a variable of type uintptr, which isn't compatible with the format specifier used to print a user message. Since this particular usage of the underlying data seems unique to this file, the simple fix is to just cast QEMU_VMALLOC_ALIGN to uint32_t, which corresponds to the format specifier used. Signed-off-by: Bruce Rogers Acked-by: David Hildenbrand Reviewed-by: Pankaj Gupta Reviewed-by: Stefano Garzarella --- hw/virtio/virtio-mem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/virtio-mem.c b/hw/virtio/virtio-mem.c index c12e9f79b0..7740fc613f 100644 --- a/hw/virtio/virtio-mem.c +++ b/hw/virtio/virtio-mem.c @@ -36,7 +36,7 @@ * Use QEMU_VMALLOC_ALIGN, so no THP will have to be split when unplugging * memory (e.g., 2MB on x86_64). */ -#define VIRTIO_MEM_MIN_BLOCK_SIZE QEMU_VMALLOC_ALIGN +#define VIRTIO_MEM_MIN_BLOCK_SIZE ((uint32_t)QEMU_VMALLOC_ALIGN) /* * Size the usable region bigger than the requested size if possible. Esp. * Linux guests will only add (aligned) memory blocks in case they fully --=20 2.27.0