From nobody Sun Feb 8 13:11:13 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1595860429; cv=none; d=zohomail.com; s=zohoarc; b=J9XCmKBViLi7JChgppxqzw/kLZUUvfLQ0Rq9OOm8COOSSSlahLMDR1t8EuSr5KOXjgMtg4JELLn7Bj9R5bCVjTiXScYVzxLBhXrkQn7eDNEWCWf4TpJfjvC8n28/Kwo8jxrsqhSS+84SCNq/Q6pFeRMxR9ALT5za4/4j1x0RvIc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595860429; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=AHMvwCpHzHvg1F3ImQSbDTzqzrVUtZ/6UHRF8xJVQi0=; b=cuPBxtmUwI+SOmPpSSwQ/25me5gvL1QCVQ3dPq5GUA8ydbO1HX7k+51FBX8sEFQOMuJUL0XV0IG2NMlMhY135staCrnaxX3qH4SiaQAkNx824YEWg45nUeE99KyUAVNP37k9oG0YYbDGrCLVZxhC6YcZ4BIHD26kK+a1Tpk4u8k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 159586042994615.49861070602924; Mon, 27 Jul 2020 07:33:49 -0700 (PDT) Received: from localhost ([::1]:35564 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k04CK-0005AS-G4 for importer@patchew.org; Mon, 27 Jul 2020 10:33:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51722) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k04Ap-0003Ce-UC for qemu-devel@nongnu.org; Mon, 27 Jul 2020 10:32:15 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:44789 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k04Ao-0001F0-4c for qemu-devel@nongnu.org; Mon, 27 Jul 2020 10:32:15 -0400 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-256-bw0cq6NbPHSUmg2a-ted6Q-1; Mon, 27 Jul 2020 10:32:08 -0400 Received: by mail-wr1-f71.google.com with SMTP id 5so3982333wrc.17 for ; Mon, 27 Jul 2020 07:32:07 -0700 (PDT) Received: from redhat.com ([192.117.173.58]) by smtp.gmail.com with ESMTPSA id t189sm16519960wmf.47.2020.07.27.07.32.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2020 07:32:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595860333; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AHMvwCpHzHvg1F3ImQSbDTzqzrVUtZ/6UHRF8xJVQi0=; b=P/k3XT7PSnXa66U0QyYp5pUBsO32HjZKCF0RVGBGlsgYDB0q6admkLEP8ag6Y+VEcN5ynT Ns5T0zaS6Ott8u+8U03FRaH9lY8H7LvhvQsO/dmJUy4waBw/RhselKmDL85T+sxGv4+c0k 5+78M3AbzGPtJnaUCc3DJw8raQ4UlWE= X-MC-Unique: bw0cq6NbPHSUmg2a-ted6Q-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AHMvwCpHzHvg1F3ImQSbDTzqzrVUtZ/6UHRF8xJVQi0=; b=KKq2En3OPT9NL7EDWWjwR41b1RK4mvW4zXR5TgSDGg+Nu7JtjSXF7T390J7Tz0DrnX 0MHdtBB1TgsaUsx2fV1vrg7et9B5+al/UGAsLpChVTeLq0MaapuYj50UIHWKbx+5AWX1 MSp0nsQBy6PLQUkepk14K3oJpkl3bSHfLtSd7qxwb8HsIXeb6cATa33WiWLHrRN2b3yH cHUkeAw0Q4Rr75N3u+ILmvt45aI6M2sTyviVIqD8rx3DmsUdxtEbvB3Kdfe/rZehTlBy zuNXb95YXBFYQoKOPyWHrlH7eYCQlXCn+KyW9Zi0lTpLceDTomaA2pKrRCHdtE4QrUqE t4bg== X-Gm-Message-State: AOAM531CMgJr1/ApOVlsWT+1IsVP/6+6ki1S19AahTyj3Gglyt3V1O1N s6/vJD/D69yAmr/dOr+265E7tZ63zRh2cZh+x7CcKomkpeoiBilg7vTWKX8JUgxxkpYjU3AfhEz H6RGmnYwVLmUimkw= X-Received: by 2002:adf:fd04:: with SMTP id e4mr20145533wrr.353.1595860326180; Mon, 27 Jul 2020 07:32:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzGL1kZ8Xr3yooFaJo/c/8dUrhe/9dCiJHmEOulv57q5J35ewQXvwhLqOaSea2BVAWT0x7b9Q== X-Received: by 2002:adf:fd04:: with SMTP id e4mr20145516wrr.353.1595860325947; Mon, 27 Jul 2020 07:32:05 -0700 (PDT) Date: Mon, 27 Jul 2020 10:32:01 -0400 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Subject: [PULL v2 1/6] virtio-mem-pci: force virtio version 1 Message-ID: <20200727143104.97776-2-mst@redhat.com> References: <20200727143104.97776-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200727143104.97776-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=mst@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/27 01:46:13 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Cornelia Huck , qemu-stable@nongnu.org, David Hildenbrand Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: David Hildenbrand Trying to run simple virtio-mem-pci examples currently fails with qemu-system-x86_64: -device virtio-mem-pci,id=3Dvm0,memdev=3Dmem0,node= =3D0, requested-size=3D300M: device is modern-only, use disable-legacy=3Don due to the added safety checks in 9b3a35ec8236 ("virtio: verify that legacy support is not accidentally on"). As noted by Conny, we have to force virtio version 1. While at it, use qdev_realize() to set the parent bus and realize - like most other virtio-*-pci implementations. Fixes: 0b9a2443a48b ("virtio-pci: Proxy for virtio-mem") Reviewed-by: Cornelia Huck Cc: Cornelia Huck Cc: "Michael S. Tsirkin" Signed-off-by: David Hildenbrand Message-Id: <20200727115905.129397-1-david@redhat.com> Cc: qemu-stable@nongnu.org Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-mem-pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio/virtio-mem-pci.c b/hw/virtio/virtio-mem-pci.c index d375280ee1..590cec041b 100644 --- a/hw/virtio/virtio-mem-pci.c +++ b/hw/virtio/virtio-mem-pci.c @@ -21,8 +21,8 @@ static void virtio_mem_pci_realize(VirtIOPCIProxy *vpci_d= ev, Error **errp) VirtIOMEMPCI *mem_pci =3D VIRTIO_MEM_PCI(vpci_dev); DeviceState *vdev =3D DEVICE(&mem_pci->vdev); =20 - qdev_set_parent_bus(vdev, BUS(&vpci_dev->bus)); - object_property_set_bool(OBJECT(vdev), "realized", true, errp); + virtio_pci_force_virtio_1(vpci_dev); + qdev_realize(vdev, BUS(&vpci_dev->bus), errp); } =20 static void virtio_mem_pci_set_addr(MemoryDeviceState *md, uint64_t addr, --=20 MST From nobody Sun Feb 8 13:11:13 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1595860436; cv=none; d=zohomail.com; s=zohoarc; b=new0+NNrqepS1U+5YocKyQ/098o+ka3Zp7D8kkflvrAI+DE8ASqHX97DBaWSNEZ3hYkTtSyPvMz2grKM2RNtNTMmlOusVlEAHAAEY5xPtYUDKWVmU1Pr8DjJQ6G4RwEr+gBR6s5f7HWyS+wh/SbrVKOEHAI1sX2OsI/rB5iZoLw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595860436; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=hwIlVv8mpoXRCi0ZFuXKLtwB0wnN7U1sjQ8Afgj5tJo=; b=Y7qMuYwnYYoif8APgiYNDEgSndY9rDm3xiVsf8M8cNtA41VcykSB2X1IxsYFORCSCxdXCfc6TdVK25oa1FhrtPThmbfhcmJxSw+kcXZ06cEoHzTDXzYE0OMv7HD2nN/Uu6gqlibx0Io0L9zmsemHAcVGzVg33cS8kWvDSiEiygc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1595860436727788.1780207577464; Mon, 27 Jul 2020 07:33:56 -0700 (PDT) Received: from localhost ([::1]:36140 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k04CQ-0005Or-Au for importer@patchew.org; Mon, 27 Jul 2020 10:33:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51758) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k04As-0003Hd-El for qemu-devel@nongnu.org; Mon, 27 Jul 2020 10:32:18 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:31624 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k04Aq-0001Fe-IJ for qemu-devel@nongnu.org; Mon, 27 Jul 2020 10:32:18 -0400 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-239-TkUryo_RNpiiQtzK9RLUxw-1; Mon, 27 Jul 2020 10:32:11 -0400 Received: by mail-wr1-f71.google.com with SMTP id z1so4001961wrn.18 for ; Mon, 27 Jul 2020 07:32:11 -0700 (PDT) Received: from redhat.com ([192.117.173.58]) by smtp.gmail.com with ESMTPSA id 8sm4800427wrl.7.2020.07.27.07.32.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2020 07:32:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595860335; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hwIlVv8mpoXRCi0ZFuXKLtwB0wnN7U1sjQ8Afgj5tJo=; b=SkfUWuLS9yBp6XzeONGMtje/Focmnon+/vKxVLHwL12l5/yXE1nuTVi9ancdvdMoLxXYWn kTJ7Q9S2y/WPxzgI9Z3zkSZS0FKG3rzKrRyy/r20VVoEfwStADFP7hhmfrol+aNaoVGOfK Xc+6wdV6lRGEWk+XLvu5mwxi55W81Qw= X-MC-Unique: TkUryo_RNpiiQtzK9RLUxw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hwIlVv8mpoXRCi0ZFuXKLtwB0wnN7U1sjQ8Afgj5tJo=; b=HtPtgNAzjWhihfepJsBne6jvalDDiFICuHGHlPPsXTmS4NFDgWHF9HJGYvmoz2Utr4 wQ8BBfl3YdkuzdO9qa/UlCRyVrpifRM9I4V7bFlnHwzGFvcrg2y7LWFgfPikCK4BdmYv /5q+wwcAC16QE/ycsJK03RS5cY85+zg7Y+lZ/Vgau/wJIWkka6btTemqcxCZszbmytZy 8vrtTzVZ2aWOWomOv923FJAhXOn908/zyCSreEqmIFO4EnGZV++GUNEg9gHijly/5RA4 bFjNTpe8wlBpDDVwNDuCHPmdtWeDaG+AhhjPeof3C1Q1/39qE2JWWvDFe+BlftCFnAIS rnqA== X-Gm-Message-State: AOAM532GdoCvG7s6vb5mwXPHnoxer1KhLmeJGPrVRPhRDpz6QAT5enLZ WnfXkHcRVuHaNfAyLwla2YkLBnnEDkQeCyvc1+UkTQWqxGiu6oKAdYGYJ+bdd6UkmTKDGMLYGiA dwcI+Yy3jeofDHss= X-Received: by 2002:adf:c386:: with SMTP id p6mr20577667wrf.344.1595860329876; Mon, 27 Jul 2020 07:32:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJykqx3SEGQdIvzADljKBLZvmJOTkswsBclBGhDa8qwzmeeoGQnOuXJ4I7qRKB2f13laqdwF/Q== X-Received: by 2002:adf:c386:: with SMTP id p6mr20577642wrf.344.1595860329561; Mon, 27 Jul 2020 07:32:09 -0700 (PDT) Date: Mon, 27 Jul 2020 10:32:06 -0400 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Subject: [PULL v2 2/6] hw/pci-host: save/restore pci host config register Message-ID: <20200727143104.97776-3-mst@redhat.com> References: <20200727143104.97776-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200727143104.97776-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.120; envelope-from=mst@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/27 00:16:29 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , "Dr. David Alan Gilbert" , Hogan Wang , qemu-stable@nongnu.org, Hogan Wang , Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Hogan Wang The pci host config register is used to save PCI address for read/write config data. If guest writes a value to config register, and then QEMU pauses the vcpu to migrate, after the migration, the guest will continue to write pci config data, and the write data will be ignored because of new qemu process losing the config register state. To trigger the bug: 1. guest is booting in seabios. 2. guest enables the SMRAM in seabios:piix4_apmc_smm_setup, and then expects to disable the SMRAM by pci_config_writeb. 3. after guest writes the pci host config register, QEMU pauses vcpu to finish migration. 4. guest write of config data(0x0A) fails to disable the SMRAM because the config register state is lost. 5. guest continues to boot and crashes in ipxe option ROM due to SMRAM in enabled state. Example Reproducer: step 1. Make modifications to seabios and qemu for increase reproduction efficiency, write 0xf0 to 0x402 port notify qemu to stop vcpu after 0x0cf8 port wrote i440 configure register. qemu stop vcpu when catch 0x402 port wrote 0xf0. seabios:/src/hw/pci.c @@ -52,6 +52,11 @@ void pci_config_writeb(u16 bdf, u32 addr, u8 val) writeb(mmconfig_addr(bdf, addr), val); } else { outl(ioconfig_cmd(bdf, addr), PORT_PCI_CMD); + if (bdf =3D=3D 0 && addr =3D=3D 0x72 && val =3D=3D 0xa) { + dprintf(1, "stop vcpu\n"); + outb(0xf0, 0x402); // notify qemu to stop vcpu + dprintf(1, "resume vcpu\n"); + } outb(val, PORT_PCI_DATA + (addr & 3)); } } qemu:hw/char/debugcon.c @@ -60,6 +61,9 @@ static void debugcon_ioport_write(void *opaque, hwaddr ad= dr, uint64_t val, printf(" [debugcon: write addr=3D0x%04" HWADDR_PRIx " val=3D0x%02" PRI= x64 "]\n", addr, val); #endif + if (ch =3D=3D 0xf0) { + vm_stop(RUN_STATE_PAUSED); + } /* XXX this blocks entire thread. Rewrite to use * qemu_chr_fe_write and background I/O callbacks */ qemu_chr_fe_write_all(&s->chr, &ch, 1); step 2. start vm1 by the following command line, and then vm stopped. $ qemu-system-x86_64 -machine pc-i440fx-5.0,accel=3Dkvm\ -netdev tap,ifname=3Dtap-test,id=3Dhostnet0,vhost=3Don,downscript=3Dno,scr= ipt=3Dno\ -device virtio-net-pci,netdev=3Dhostnet0,id=3Dnet0,bus=3Dpci.0,addr=3D0x13= ,bootindex=3D3\ -device cirrus-vga,id=3Dvideo0,vgamem_mb=3D16,bus=3Dpci.0,addr=3D0x2\ -chardev file,id=3Dseabios,path=3D/var/log/test.seabios,append=3Don\ -device isa-debugcon,iobase=3D0x402,chardev=3Dseabios\ -monitor stdio step 3. start vm2 to accept vm1 state. $ qemu-system-x86_64 -machine pc-i440fx-5.0,accel=3Dkvm\ -netdev tap,ifname=3Dtap-test1,id=3Dhostnet0,vhost=3Don,downscript=3Dno,sc= ript=3Dno\ -device virtio-net-pci,netdev=3Dhostnet0,id=3Dnet0,bus=3Dpci.0,addr=3D0x13= ,bootindex=3D3\ -device cirrus-vga,id=3Dvideo0,vgamem_mb=3D16,bus=3Dpci.0,addr=3D0x2\ -chardev file,id=3Dseabios,path=3D/var/log/test.seabios,append=3Don\ -device isa-debugcon,iobase=3D0x402,chardev=3Dseabios\ -monitor stdio \ -incoming tcp:127.0.0.1:8000 step 4. execute the following qmp command in vm1 to migrate. (qemu) migrate tcp:127.0.0.1:8000 step 5. execute the following qmp command in vm2 to resume vcpu. (qemu) cont Before this patch, we get KVM "emulation failure" error on vm2. This patch fixes it. Cc: qemu-stable@nongnu.org Signed-off-by: Hogan Wang Message-Id: <20200727084621.3279-1-hogan.wang@huawei.com> Reported-by: "Dr. David Alan Gilbert" Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pci_host.h | 1 + hw/core/machine.c | 1 + hw/i386/pc.c | 3 ++- hw/pci/pci_host.c | 33 +++++++++++++++++++++++++++++++++ 4 files changed, 37 insertions(+), 1 deletion(-) diff --git a/include/hw/pci/pci_host.h b/include/hw/pci/pci_host.h index 9ce088bd13..6210a7e14d 100644 --- a/include/hw/pci/pci_host.h +++ b/include/hw/pci/pci_host.h @@ -45,6 +45,7 @@ struct PCIHostState { MemoryRegion data_mem; MemoryRegion mmcfg; uint32_t config_reg; + bool mig_enabled; PCIBus *bus; =20 QLIST_ENTRY(PCIHostState) next; diff --git a/hw/core/machine.c b/hw/core/machine.c index 2f881d6d75..8d1a90c6cf 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -29,6 +29,7 @@ #include "migration/vmstate.h" =20 GlobalProperty hw_compat_5_0[] =3D { + { "pci-host-bridge", "x-config-reg-migration-enabled", "off" }, { "virtio-balloon-device", "page-poison", "false" }, { "vmport", "x-read-set-eax", "off" }, { "vmport", "x-signal-unsupported-cmd", "off" }, diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 3d419d5991..47c5ca3e34 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -97,7 +97,8 @@ #include "fw_cfg.h" #include "trace.h" =20 -GlobalProperty pc_compat_5_0[] =3D {}; +GlobalProperty pc_compat_5_0[] =3D { +}; const size_t pc_compat_5_0_len =3D G_N_ELEMENTS(pc_compat_5_0); =20 GlobalProperty pc_compat_4_2[] =3D { diff --git a/hw/pci/pci_host.c b/hw/pci/pci_host.c index ce7bcdb1d5..8ca5fadcbd 100644 --- a/hw/pci/pci_host.c +++ b/hw/pci/pci_host.c @@ -22,8 +22,10 @@ #include "hw/pci/pci.h" #include "hw/pci/pci_bridge.h" #include "hw/pci/pci_host.h" +#include "hw/qdev-properties.h" #include "qemu/module.h" #include "hw/pci/pci_bus.h" +#include "migration/vmstate.h" #include "trace.h" =20 /* debug PCI */ @@ -200,12 +202,43 @@ const MemoryRegionOps pci_host_data_be_ops =3D { .endianness =3D DEVICE_BIG_ENDIAN, }; =20 +static bool pci_host_needed(void *opaque) +{ + PCIHostState *s =3D opaque; + return s->mig_enabled; +} + +const VMStateDescription vmstate_pcihost =3D { + .name =3D "PCIHost", + .needed =3D pci_host_needed, + .version_id =3D 1, + .minimum_version_id =3D 1, + .fields =3D (VMStateField[]) { + VMSTATE_UINT32(config_reg, PCIHostState), + VMSTATE_END_OF_LIST() + } +}; + +static Property pci_host_properties_common[] =3D { + DEFINE_PROP_BOOL("x-config-reg-migration-enabled", PCIHostState, + mig_enabled, true), + DEFINE_PROP_END_OF_LIST(), +}; + +static void pci_host_class_init(ObjectClass *klass, void *data) +{ + DeviceClass *dc =3D DEVICE_CLASS(klass); + device_class_set_props(dc, pci_host_properties_common); + dc->vmsd =3D &vmstate_pcihost; +} + static const TypeInfo pci_host_type_info =3D { .name =3D TYPE_PCI_HOST_BRIDGE, .parent =3D TYPE_SYS_BUS_DEVICE, .abstract =3D true, .class_size =3D sizeof(PCIHostBridgeClass), .instance_size =3D sizeof(PCIHostState), + .class_init =3D pci_host_class_init, }; =20 static void pci_host_register_types(void) --=20 MST From nobody Sun Feb 8 13:11:13 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1595860503; cv=none; d=zohomail.com; s=zohoarc; b=WoDEEpplVI7xj2onN2Er5gW2I3dBjxQSouYpkAG09SXGgYW4GaFH/q4vHff2dUyLonliNI53N3lmKGX54RoCQvxspDRny0ED69vCRr6G783b945FhsNKdkBK8M9i3bEiXcdcBncM4orvjJcMStgPwhCFB20s2cyWZKZK6D/ISWQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595860503; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2bb6OtX/LD4ZX58mGeq2eGBkZlXvZDtQoKpqNCcHDcU=; b=GN9rNfgSJbW2d3IcnJbUSpvMc9FBUdgbwBh6gm3Ln9WtrfJPpMKltzVh1oi8dK0h1JxbLzZCLtjSjBHG+31bJLCL16iuPDi8RkHjwTsn5fSB7Kl3H7QRbCW5oEGzXOetGJ88CPm/V0H2PWUO7IJDJW1MizGS8hRzIe9Tq2FFgqQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1595860503301399.58427481485853; Mon, 27 Jul 2020 07:35:03 -0700 (PDT) Received: from localhost ([::1]:42310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k04DW-0007s2-0f for importer@patchew.org; Mon, 27 Jul 2020 10:35:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51774) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k04At-0003KU-OR for qemu-devel@nongnu.org; Mon, 27 Jul 2020 10:32:19 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:44334 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k04Ar-0001Fp-OU for qemu-devel@nongnu.org; Mon, 27 Jul 2020 10:32:19 -0400 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-482-Dx5VBl0TOZife9AjLf0bOg-1; Mon, 27 Jul 2020 10:32:15 -0400 Received: by mail-wr1-f71.google.com with SMTP id e14so571507wrr.7 for ; Mon, 27 Jul 2020 07:32:15 -0700 (PDT) Received: from redhat.com ([192.117.173.58]) by smtp.gmail.com with ESMTPSA id j5sm18383828wmb.15.2020.07.27.07.32.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2020 07:32:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595860337; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2bb6OtX/LD4ZX58mGeq2eGBkZlXvZDtQoKpqNCcHDcU=; b=RduyVAB7mw/7dnqvZi73VNmaqAK5WvvTWy2LELl8vIIpyhNF/2QdGBKCEX00VDeXC74qOi 4zI9UX1VzPupi9exJJbofr2YphJlArVu8YD5ONh8GHk3LEucH8ej9WKdpPZH4bcAwR3YU6 NFpKVJCe5ybAF8Bqdx27WAf6WZ9sp0A= X-MC-Unique: Dx5VBl0TOZife9AjLf0bOg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=2bb6OtX/LD4ZX58mGeq2eGBkZlXvZDtQoKpqNCcHDcU=; b=rYfuy8LJYlD8IMWEXzA9B9Mc4dE6plhKK8tgV3mZDLsLZMOyMrTcbDrLT6irYWRME3 diZiD0jUX7OMmAhs2vV2TtZ1TLVQNPaJsptqcbu4VZEtpopYKj7EapZesB1BBSt9/jTo OIbPT0LSzHxP78TOD2GehGPz8fDMxKPH3HVs4iPQkOXin2kfidMC/vNP3/H9wfzwsRJK UW7X8igw6iWMEMBsK7IBSKJ4jO5ym1lJs+avksaC5VZlEKR5CjalXeRoMpa8ULc3QPxx q0CMc0GQUK7ParjpJIMxhLw0iJWK+zMQpp31nedDA3VXNs0yZWT0QRsbizNcAohrW13K nk8A== X-Gm-Message-State: AOAM533Oj9bdNpy9swdxAYvji+L5CXsf8PDsPWNu382EbhtPiljsSsvf Lo5jxDObaSwkgwnvjpCIV9E/2Izle9tWe6aE3fPEuVBfcExxiHCQUtTcdlYEjK2s0XqPcurRmIq 0tW3oYk8Vpvu6wSY= X-Received: by 2002:a1c:a756:: with SMTP id q83mr20161364wme.168.1595860333701; Mon, 27 Jul 2020 07:32:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzSzUrpz0v6qmVr2GofypNKloGBrkti1fCXSkbtUlmR3gIbEJ9g7sFB907wvtDwe9V74PM3cw== X-Received: by 2002:a1c:a756:: with SMTP id q83mr20161349wme.168.1595860333521; Mon, 27 Jul 2020 07:32:13 -0700 (PDT) Date: Mon, 27 Jul 2020 10:32:10 -0400 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Subject: [PULL v2 3/6] Fix vhost-user buffer over-read on ram hot-unplug Message-ID: <20200727143104.97776-4-mst@redhat.com> References: <20200727143104.97776-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200727143104.97776-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.120; envelope-from=mst@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/27 01:44:14 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , qemu-stable@nongnu.org, Peter Turschmid , Raphael Norwitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Raphael Norwitz The VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS vhost-user protocol feature introduced a shadow-table, used by the backend to dynamically determine how a vdev's memory regions have changed since the last vhost_user_set_mem_table() call. On hot-remove, a memmove() operation is used to overwrite the removed shadow region descriptor(s). The size parameter of this memmove was off by 1 such that if a VM with a backend supporting the VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS filled it's shadow-table (by performing the maximum number of supported hot-add operatons) and attempted to remove the last region, Qemu would read an out of bounds value and potentially crash. This change fixes the memmove() bounds such that this erroneous read can never happen. Signed-off-by: Peter Turschmid Signed-off-by: Raphael Norwitz Message-Id: <1594799958-31356-1-git-send-email-raphael.norwitz@nutanix.com> Fixes: f1aeb14b0809 ("Transmit vhost-user memory regions individually") Reviewed-by: Marc-Andr=C3=A9 Lureau Cc: qemu-stable@nongnu.org Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/vhost-user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index 31231218dc..d7e2423762 100644 --- a/hw/virtio/vhost-user.c +++ b/hw/virtio/vhost-user.c @@ -672,7 +672,7 @@ static int send_remove_regions(struct vhost_dev *dev, memmove(&u->shadow_regions[shadow_reg_idx], &u->shadow_regions[shadow_reg_idx + 1], sizeof(struct vhost_memory_region) * - (u->num_shadow_regions - shadow_reg_idx)); + (u->num_shadow_regions - shadow_reg_idx - 1)); u->num_shadow_regions--; } =20 --=20 MST From nobody Sun Feb 8 13:11:13 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1595860526; cv=none; d=zohomail.com; s=zohoarc; b=BE6fBMnJycZE0UOEy3HYqqcqbBVASCtNZ9Gnb2gYzn8vvRYzYr3J45KDbcKM+GgfoDRgjEiJEYXE5MHPFJMk6wJgq1JKmSnFQP+OeDuwhXJLeeKj34HtlXVoqKw9I6PvxusH9cLE8KP5syFha4RZFAJ3PN4DbwFPDyWAipjV5U8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595860526; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=SlYRcRi7Yo9IrPxeu+mUP+g3rj5dPNkuezWzuDEddIw=; b=MVXqoqLXFEgNcYcodwkCv2+likfnfXZmVNxXGyLF5ru00M6HLuqt++bZlylnT2/qkvbDnRYkiTk4yjACv+RBRih1D5n6ZezFc8xxI3Y+04VncqJngwHhWIfbVPU810TPAsi6n8OLvBL+SMM6JJDTi/Je+kCXEfVh4/c/2zIaSg0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1595860526210749.7329632376111; Mon, 27 Jul 2020 07:35:26 -0700 (PDT) Received: from localhost ([::1]:44160 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k04Ds-0000Bw-TQ for importer@patchew.org; Mon, 27 Jul 2020 10:35:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51820) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k04Ay-0003Sq-7C for qemu-devel@nongnu.org; Mon, 27 Jul 2020 10:32:24 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:34825 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k04Av-0001GK-Ey for qemu-devel@nongnu.org; Mon, 27 Jul 2020 10:32:23 -0400 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-260-Imq_CHA4Mri4RbwILnd1Qg-1; Mon, 27 Jul 2020 10:32:18 -0400 Received: by mail-wr1-f72.google.com with SMTP id j16so4027633wrw.3 for ; Mon, 27 Jul 2020 07:32:18 -0700 (PDT) Received: from redhat.com ([192.117.173.58]) by smtp.gmail.com with ESMTPSA id h11sm13657004wrb.68.2020.07.27.07.32.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2020 07:32:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595860340; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SlYRcRi7Yo9IrPxeu+mUP+g3rj5dPNkuezWzuDEddIw=; b=CkrYl2FId899utNSsOiJbGlB4KXc12fmaExsskgtEbkdnRvwmjq0OXFFqmDV/PzdFBCW4Z tJ4Fbq4fMjdgNubJfboszF2VeHywxAXzFRYM0wy6f0PByUIxJ3fFozPgH+3i3oxx1ekrQD E7h2w6noodsHn+cwhRn5U3NtBVeDcoA= X-MC-Unique: Imq_CHA4Mri4RbwILnd1Qg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=SlYRcRi7Yo9IrPxeu+mUP+g3rj5dPNkuezWzuDEddIw=; b=Bn8lcrYoinrRUDuUnD4+Sx4LZ29IVccw7HK2TV5Fhluo73J1+dSr0ATQpj7KlpSIbw s1dkY70C2lPoiFRu3SKDWdjNDh04iXaQtelszu1FV8qZU11vCYFGVQtBmgA2DLISNO0N 6TxlEsh7w3bXAZEJxK6jv2zSe0DgKJ5pJyf8/Yyja5QX0rswB7MeAX5XatS82cx2DBpy zKXNEeS5/uDFJ1F8ncsy4eGI+m6Iy0mGqQO9tnN/b3teIJR+kro2fgb2HdPQye3QPWbV VNH0fXVZBK7dvKfd5g8d3AqpGb15tPtHrWmX/aIjYEldXpDTM1hSrlWLQRI5ezEPYyMF mckg== X-Gm-Message-State: AOAM533K/KnCWzVqosBdfgJZRAf3CWobupH6StDLOZxhzv5vsNDO46Pc HlrW7TRFDk2qL09ZFExcrESgwTs4sSuxApT1Lsw8ozfRotQECFtfDbyHfx71Bxf7UJrTWDzZ13+ cOt02Jaj6mC4aCOo= X-Received: by 2002:a1c:96c5:: with SMTP id y188mr2138820wmd.72.1595860337453; Mon, 27 Jul 2020 07:32:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxHqvjim4QhRrSK1lx7mSlYHlKJSvdzsZfzNcMtb8BjuiFhBfom6VhLdx7VZfk9XQXrc4wG3g== X-Received: by 2002:a1c:96c5:: with SMTP id y188mr2138803wmd.72.1595860337297; Mon, 27 Jul 2020 07:32:17 -0700 (PDT) Date: Mon, 27 Jul 2020 10:32:14 -0400 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Subject: [PULL v2 4/6] libvhost-user: Report descriptor index on panic Message-ID: <20200727143104.97776-5-mst@redhat.com> References: <20200727143104.97776-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200727143104.97776-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=mst@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/27 01:46:13 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Johannes Berg , qemu-stable@nongnu.org, Raphael Norwitz , Stefan Hajnoczi , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Philippe Mathieu-Daud=C3=A9 We want to report the index of the descriptor, not its pointer. Fixes: 7b2e5c65f4 ("contrib: add libvhost-user") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20200723171935.18535-1-philmd@redhat.com> Reviewed-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Raphael Norwitz Reviewed-by: Stefan Hajnoczi Cc: qemu-stable@nongnu.org Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- contrib/libvhost-user/libvhost-user.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/libvhost-user/libvhost-user.c b/contrib/libvhost-user/= libvhost-user.c index d315db1396..53f16bdf08 100644 --- a/contrib/libvhost-user/libvhost-user.c +++ b/contrib/libvhost-user/libvhost-user.c @@ -2074,7 +2074,7 @@ virtqueue_get_head(VuDev *dev, VuVirtq *vq, =20 /* If their number is silly, that's a fatal mistake. */ if (*head >=3D vq->vring.num) { - vu_panic(dev, "Guest says index %u is available", head); + vu_panic(dev, "Guest says index %u is available", *head); return false; } =20 @@ -2133,7 +2133,7 @@ virtqueue_read_next_desc(VuDev *dev, struct vring_des= c *desc, smp_wmb(); =20 if (*next >=3D max) { - vu_panic(dev, "Desc next is %u", next); + vu_panic(dev, "Desc next is %u", *next); return VIRTQUEUE_READ_DESC_ERROR; } =20 --=20 MST From nobody Sun Feb 8 13:11:13 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1595860430; cv=none; d=zohomail.com; s=zohoarc; b=gyCC8o/aoeQNpg9ofTVevuqI/i3j6xf3Mu823iOGlBtDPYPZH/vhnAJhM/1aReAKl8GHHSjqg+4LroF5PC9R6uYf8U6rXc3/+jxjpJ8x4hta2+TvQ0g2v+RW+GukMbL7Hbd++bQtEvMk2nZSvAMrWRdSwBPmrJ1SfX7yJ2U+KDM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595860430; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nUT7Qbk7nFEddXYspzd8aisJc0jjaXW+jFGJmy8zWts=; b=aO6oVpLTcPi1loZ73TTe6cnunNByqYQ9fNOioYgNQuy1bZIDiQHjSuMTdsDkiyiHc/f6D79+P6u1yUXotB5zRIfny9oDtTxPWwd5aiPIbwkcZhjxyY8LfyC2lmK48r/qI8skPUgduCRQrDum3rIAu5hjtkkv8cIU5P9a5TXZHZM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1595860430502593.2470956062635; Mon, 27 Jul 2020 07:33:50 -0700 (PDT) Received: from localhost ([::1]:35664 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k04CL-0005Cm-2d for importer@patchew.org; Mon, 27 Jul 2020 10:33:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51884) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k04B3-0003X3-Az for qemu-devel@nongnu.org; Mon, 27 Jul 2020 10:32:29 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:58938 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k04B1-0001HB-HZ for qemu-devel@nongnu.org; Mon, 27 Jul 2020 10:32:28 -0400 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-438-1hM2uzHSOmKfC8tE19Odyg-1; Mon, 27 Jul 2020 10:32:22 -0400 Received: by mail-wr1-f71.google.com with SMTP id b13so1243774wrq.19 for ; Mon, 27 Jul 2020 07:32:22 -0700 (PDT) Received: from redhat.com ([192.117.173.58]) by smtp.gmail.com with ESMTPSA id e5sm11873243wrc.37.2020.07.27.07.32.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2020 07:32:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595860346; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nUT7Qbk7nFEddXYspzd8aisJc0jjaXW+jFGJmy8zWts=; b=fRDbaQoEkEAfQIHY3i5i3CfgmtGhQi6YpKaV21/8QDEIaTDp7J6yL8mnt/XJt1xjBblrRb 1mJuov0dLO38iVlrzf43KN4K5ha/0c5EKk5ASfU09h2pw0Tx1tjaJbk4o2mPakxF9k4X0T lJgGcoSUrVbMq9mH2zpo9GTo2FQwQKE= X-MC-Unique: 1hM2uzHSOmKfC8tE19Odyg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nUT7Qbk7nFEddXYspzd8aisJc0jjaXW+jFGJmy8zWts=; b=esBJioYhlfL4hRZdwxQM3STxLCS2vTa90XdWEpE8Qp04CtR5ubPt1TE/2zovQpJRQp OZtJm3lIuah+fvYWKB1+ll8IOnAKroQ77kjP3I6SpUZhqEUf3ttPhK86s6hM2VK5sNI/ q8oGeTDumf0SMow6MUERexUVX9eBGayiQMDLAB9r9Vy+SbQk5Hmi6gYhbVorG315NAZP fWPcdHfYUeaLOB0UUTBQfZEwOKbOdmoxmewMWTpwNvfYJZtY6e9TNL5hEbSLCC+OVUsC eE9YhZefXN6mrF4DmMIk8EBFk9W88kiIMwcrfcgKPuwM4/DtLKz2EEWGwMytzOvXpWEv 8ETw== X-Gm-Message-State: AOAM531/9toX2HnEGXRakGEMyd4qGHnruOCT8D+I5RSu4bxvKUR/blDN a2o9YzkUN58+eTQnX/UVWAaVw+kVtR8JQOPMIgc8tm4Ee5ZY0o1wDlvTAhBOB9vlk/F0dgPtoIw V67qERnf49CKQ6t8= X-Received: by 2002:a5d:5681:: with SMTP id f1mr19717243wrv.192.1595860341049; Mon, 27 Jul 2020 07:32:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx8MHx1L/eyPoQr0fnBOnzpdB3FcgPK1jA6IB8cGpbZnjoG51hhFlDuFbLh3J69EnF+2LRmUA== X-Received: by 2002:a5d:5681:: with SMTP id f1mr19717226wrv.192.1595860340837; Mon, 27 Jul 2020 07:32:20 -0700 (PDT) Date: Mon, 27 Jul 2020 10:32:17 -0400 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Subject: [PULL v2 5/6] vhost-vdpa :Fix Coverity CID 1430270 / CID 1420267 Message-ID: <20200727143104.97776-6-mst@redhat.com> References: <20200727143104.97776-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200727143104.97776-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.120; envelope-from=mst@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/27 01:44:14 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Jason Wang , Li Qiang , qemu-stable@nongnu.org, Cindy Lu Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Cindy Lu In the function vhost_vdpa_dma_map/unmap, The struct msg was not initialize= d all its fields. Signed-off-by: Cindy Lu Message-Id: <20200710064642.24505-1-lulu@redhat.com> Reviewed-by: Peter Maydell Acked-by: Jason Wang Reviewed-by: Li Qiang Cc: qemu-stable@nongnu.org Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/vhost-vdpa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c index 65d5aaf08a..4580f3efd8 100644 --- a/hw/virtio/vhost-vdpa.c +++ b/hw/virtio/vhost-vdpa.c @@ -37,7 +37,7 @@ static bool vhost_vdpa_listener_skipped_section(MemoryReg= ionSection *section) static int vhost_vdpa_dma_map(struct vhost_vdpa *v, hwaddr iova, hwaddr si= ze, void *vaddr, bool readonly) { - struct vhost_msg_v2 msg; + struct vhost_msg_v2 msg =3D {}; int fd =3D v->device_fd; int ret =3D 0; =20 @@ -60,7 +60,7 @@ static int vhost_vdpa_dma_map(struct vhost_vdpa *v, hwadd= r iova, hwaddr size, static int vhost_vdpa_dma_unmap(struct vhost_vdpa *v, hwaddr iova, hwaddr size) { - struct vhost_msg_v2 msg; + struct vhost_msg_v2 msg =3D {}; int fd =3D v->device_fd; int ret =3D 0; =20 --=20 MST From nobody Sun Feb 8 13:11:13 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1595860517; cv=none; d=zohomail.com; s=zohoarc; b=QYZEoVpIrMhFEyH4YdCX8VU4yo+KihjJrq20OTPqP/pAer6Ky2+xEWUzf9I9DS1QYCBKVOgjxlLSe3jbDepBXhV0T7CIJkrDrTRlyIlJ50EFAb+cPHaQiouB02QPvv1vR3FAj0Wv7Nlh3umPAS2Q0G1UKoFHYABnwjVfenAYhpY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595860517; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=uXITvKmBNRuCK1oQcQxl+D6gdJLR2Jn4LOvKMTH1JwU=; b=LnvNcuUApKv9O8Upv6w+JD6NF1QcXbw5UJ30sHa+IyroAuAFU9bGHyh92Ht2QULja1Ow+/VaLpxcK4McEFM9qwr+yRmC5plOToN8Ww7ffbeSNk+Ntv2ZRuOYE02sWja3dAHQT2dCbHCDaEcAbhdMq/nMSqbNzJ0EKFPvJ/J6Tn8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1595860517072185.5243617594548; Mon, 27 Jul 2020 07:35:17 -0700 (PDT) Received: from localhost ([::1]:43414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k04Dj-0008Kf-M1 for importer@patchew.org; Mon, 27 Jul 2020 10:35:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51922) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k04B6-0003aq-Qk for qemu-devel@nongnu.org; Mon, 27 Jul 2020 10:32:32 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:40417 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k04B3-0001HI-PD for qemu-devel@nongnu.org; Mon, 27 Jul 2020 10:32:32 -0400 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-187-NQrOIrtkO9-DpG22NoFh8A-1; Mon, 27 Jul 2020 10:32:26 -0400 Received: by mail-wr1-f71.google.com with SMTP id f7so4000586wrs.8 for ; Mon, 27 Jul 2020 07:32:26 -0700 (PDT) Received: from redhat.com ([192.117.173.58]) by smtp.gmail.com with ESMTPSA id t202sm18517187wmt.20.2020.07.27.07.32.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2020 07:32:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595860348; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uXITvKmBNRuCK1oQcQxl+D6gdJLR2Jn4LOvKMTH1JwU=; b=O08TvgJc6nKNnoCH2Xj5atHouM1/2E7lPCizsaYSP3BaZnYzBFBbIT+hn9IgtVQSyjt95u /E5FP08i9x7ixbjuXn1bk74A/0hOHTXMl62Em+S9y+QCwSiup/gmOFqVMb8A2k3uWNkfBL QNTT4W1x50oVGCuqJXp83h8c2ubZiig= X-MC-Unique: NQrOIrtkO9-DpG22NoFh8A-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=uXITvKmBNRuCK1oQcQxl+D6gdJLR2Jn4LOvKMTH1JwU=; b=UVePNdOfhT5+r8lX36BunrxVaAnJvmCpPa6RpcTUEn0gZcI/bZ0ZOyS2pkdZmnQPaM T2Y4fk0k23TAmcZP6qKf0X8+hnciTCNzzzMluFhKWSmNb/DV+WkUSNnKBLHloUIichKR g9XbCvSF7DoypflGK1uBRRJrbakTu9iCp5bNTaSxTViA1f87r247OqKJ3dllXkLBlwg9 l/tR7rL1Q5fgXxi5M75LN9sFcwgErXjmDPnZz1DNja/72QDZZffLM/3OPiVWrc4HjH8P W5pHSvo8ShPpaYGaGneF0exjwYmOJqpGf2inkxeEUMEA8xa9ll1qZ0JTO1n+Y2bzp4Dl 1WTg== X-Gm-Message-State: AOAM533KRnJjjM/FG48oQXHLER8ykWfLdd9Xztuwla5gHN5235Y2VXDW JLvZl9/UmNOezY5Uxwk1T2PKN/j5ZBgF3TZlI857PIWQNJ7zOwH1jFTdyKkmVu4hauLzm/WUG8r y4dErnIf19jfxcuo= X-Received: by 2002:a1c:a590:: with SMTP id o138mr20556057wme.4.1595860344731; Mon, 27 Jul 2020 07:32:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxnyDHnxSfz+q2pY+M48DicdOBknT09CJVyLud4rXI7HIR7g6ywnP++PxohDaQIXTJ9yU0AbQ== X-Received: by 2002:a1c:a590:: with SMTP id o138mr20556039wme.4.1595860344564; Mon, 27 Jul 2020 07:32:24 -0700 (PDT) Date: Mon, 27 Jul 2020 10:32:21 -0400 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Subject: [PULL v2 6/6] MAINTAINERS: Cover the firmware JSON schema Message-ID: <20200727143104.97776-7-mst@redhat.com> References: <20200727143104.97776-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200727143104.97776-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.120; envelope-from=mst@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/27 00:16:29 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Daniel P . Berrange" , Kashyap Chamarthy , Laszlo Ersek , Richard Henderson , Alex =?utf-8?Q?Benn=C3=A9e?= , Aleksandar Markovic , Gerd Hoffmann , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Philippe Mathieu-Daud=C3=A9 Add an entry to cover firmware.json (see commit 3a0adfc9bf: schema that describes the different uses and properties of virtual machine firmware). Cc: Laszlo Ersek Cc: Gerd Hoffmann Cc: Michael S. Tsirkin Cc: Kashyap Chamarthy Cc: Daniel P. Berrange Suggested-by: Laszlo Ersek Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20200703183450.32398-1-philmd@redhat.com> Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Laszlo Ersek Reviewed-by: Kashyap Chamarthy Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- MAINTAINERS | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3395abd4e1..0886eb3d2b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2667,6 +2667,14 @@ F: include/hw/i2c/smbus_master.h F: include/hw/i2c/smbus_slave.h F: include/hw/i2c/smbus_eeprom.h =20 +Firmware schema specifications +M: Laszlo Ersek +M: Philippe Mathieu-Daud=C3=A9 +R: Daniel P. Berrange +R: Kashyap Chamarthy +S: Maintained +F: docs/interop/firmware.json + EDK2 Firmware M: Laszlo Ersek M: Philippe Mathieu-Daud=C3=A9 --=20 MST