From nobody Sat Feb 7 06:21:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1595858802; cv=none; d=zohomail.com; s=zohoarc; b=Z/hEmAlWBfb3BNUHCoTcCP31cLgOG5b6Dr956+03r+vOX3dDVN+hIJ6MPbSq9s6Rblpb/8Ke7K72HXYK8e7Se9NypYjS9esOvz0g7oMArbU2n60++sXLH5LqSKC5g4aLCSyjscwne7NDqC1A/3goX32SNFQiIKptZpwFvUkIoL8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595858802; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5bEoIqJdCdfb7bKCFHXbgUU0RFnB0O9uMdyPzJNDVhs=; b=oEpUzL+HcUVIagEPIw06WkuVdGuo+2dNu4xFozJM3YcuBviDYE9N9IHSek3qfOfMJJEdjGPlM1S/SC09ceMOcp1fMEnBKZf3CT6pHoGGkz70fCpNI/nGouhUTfWESOHa+wDgG8L0NCWh8xiA4h8Y2e/fjjyKS4OY+qhSGJmbEvc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1595858802906689.8075245439917; Mon, 27 Jul 2020 07:06:42 -0700 (PDT) Received: from localhost ([::1]:41612 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k03m5-0008KK-M9 for importer@patchew.org; Mon, 27 Jul 2020 10:06:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43802) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k03l5-0007QY-5t for qemu-devel@nongnu.org; Mon, 27 Jul 2020 10:05:39 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:23191 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k03l3-0005fi-BM for qemu-devel@nongnu.org; Mon, 27 Jul 2020 10:05:38 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-68-eWDfvmvaPWekxur7t8dcCw-1; Mon, 27 Jul 2020 10:05:34 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 12D7D100CCC1; Mon, 27 Jul 2020 14:05:32 +0000 (UTC) Received: from localhost (ovpn-112-210.ams2.redhat.com [10.36.112.210]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D368C19D82; Mon, 27 Jul 2020 14:05:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595858736; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5bEoIqJdCdfb7bKCFHXbgUU0RFnB0O9uMdyPzJNDVhs=; b=gVnqYT1VXwtgkDU+ccGMVdcJuE+VX5LA3D80iLEPFlzoAAEWMKUfTKKAkXAXtE2ahG+bNI mvwwoRIXcyYA1kGzgqo+FcI5k4ltaCUIUHuI6HLUM3ZVUqzPn7k/Rc90cEESH+ue/WUOND EIi5HyhIymwG8/c4QcXccyheTR/pne4= X-MC-Unique: eWDfvmvaPWekxur7t8dcCw-1 From: Cornelia Huck To: Peter Maydell Subject: [PULL 1/2] s390x/protvirt: allow to IPL secure guests with -no-reboot Date: Mon, 27 Jul 2020 16:05:21 +0200 Message-Id: <20200727140522.251815-2-cohuck@redhat.com> In-Reply-To: <20200727140522.251815-1-cohuck@redhat.com> References: <20200727140522.251815-1-cohuck@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.120; envelope-from=cohuck@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/27 01:44:14 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Janosch Frank , David Hildenbrand , Cornelia Huck , qemu-devel@nongnu.org, Christian Borntraeger , qemu-s390x@nongnu.org, Viktor Mihajlovski Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Christian Borntraeger Right now, -no-reboot prevents secure guests from running. This is correct from an implementation point of view, as we have modeled the transition from non-secure to secure as a program directed IPL. From a user perspective, this is not the behavior of least surprise. We should implement the IPL into protected mode similar to the functions that we use for kdump/kexec. In other words, we do not stop here when -no-reboot is specified on the command line. Like function 0 or function 1, function 10 is not a classic reboot. For example, it can only be called once. Before calling it a second time, a real reboot/reset must happen in-between. So function code 10 is more or less a state transition reset, but not a "standard" reset or reboot. Fixes: 4d226deafc44 ("s390x: protvirt: Support unpack facility") Signed-off-by: Christian Borntraeger Reviewed-by: Janosch Frank Reviewed-by: David Hildenbrand Acked-by: Viktor Mihajlovski Message-Id: <20200721103202.30610-1-borntraeger@de.ibm.com> [CH: tweaked description] Signed-off-by: Cornelia Huck --- hw/s390x/ipl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c index d46b1f094f75..3d2652d75abd 100644 --- a/hw/s390x/ipl.c +++ b/hw/s390x/ipl.c @@ -630,7 +630,8 @@ void s390_ipl_reset_request(CPUState *cs, enum s390_res= et reset_type) } } if (reset_type =3D=3D S390_RESET_MODIFIED_CLEAR || - reset_type =3D=3D S390_RESET_LOAD_NORMAL) { + reset_type =3D=3D S390_RESET_LOAD_NORMAL || + reset_type =3D=3D S390_RESET_PV) { /* ignore -no-reboot, send no event */ qemu_system_reset_request(SHUTDOWN_CAUSE_SUBSYSTEM_RESET); } else { --=20 2.25.4 From nobody Sat Feb 7 06:21:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1595858860; cv=none; d=zohomail.com; s=zohoarc; b=DLKjrs7VDeSKdGzJRLAc9OJ0qa5f6Mu82Ooc3w5yR6MiQUPUrEg/TBSZM8WnhaaUGv149sgzaprQYda9JfJAiZqs3zd6NER4YA5KDe4N44C2Tzm4+uC6ON7Xper5/7lKgtuV1Fnl8USqYWGhUAkVNueS6+AuBGxZ6r+vRUmo3yc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595858860; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qBtSoBSIbi1AVR0dxcXUvPcs+NhmdTZC/sPtkYqnzvM=; b=XF7wT3wWw6BtsuS6bQMB2JWRehPCcwunfmHbxePq5uQlxvSWSxjYzeGfzKPjd+9uegQjxuW+DjvmcEmdEnYA5AdTgduq3agh/A0ZjWqBaele5BsHrYWZMALly0+BjAxldq8ZW9nr9Wy29gqCCDR4qoimXpUPdEMKr8RKdETlPz0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1595858860230444.39898245127984; Mon, 27 Jul 2020 07:07:40 -0700 (PDT) Received: from localhost ([::1]:44282 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k03n0-00012E-Fm for importer@patchew.org; Mon, 27 Jul 2020 10:07:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43836) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k03l7-0007U7-Ou for qemu-devel@nongnu.org; Mon, 27 Jul 2020 10:05:42 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:39806 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k03l6-0005ix-98 for qemu-devel@nongnu.org; Mon, 27 Jul 2020 10:05:41 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-187-jsr2QoDYM2-ABalvNzipgg-1; Mon, 27 Jul 2020 10:05:35 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3F02FE918; Mon, 27 Jul 2020 14:05:34 +0000 (UTC) Received: from localhost (ovpn-112-210.ams2.redhat.com [10.36.112.210]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D5B4F5D9EF; Mon, 27 Jul 2020 14:05:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595858739; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qBtSoBSIbi1AVR0dxcXUvPcs+NhmdTZC/sPtkYqnzvM=; b=EsyZyN4mgzeZeJ+DJOTWitfwXBM0NZs4tsvS1ZEXKRKBoTO8CDUqJO8j/ZOiZolqS40tIc nKDTYnXQbB1HLliTHDHxA1LxeRl/3gQmrvVtl60NzFXaOJr8/vxxqkomNtpiOtTKjdIrJJ 0sjuzQqcohzSm9faq336GVqbV7u9p3o= X-MC-Unique: jsr2QoDYM2-ABalvNzipgg-1 From: Cornelia Huck To: Peter Maydell Subject: [PULL 2/2] s390x/s390-virtio-ccw: fix loadparm property getter Date: Mon, 27 Jul 2020 16:05:22 +0200 Message-Id: <20200727140522.251815-3-cohuck@redhat.com> In-Reply-To: <20200727140522.251815-1-cohuck@redhat.com> References: <20200727140522.251815-1-cohuck@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.81; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/27 03:37:14 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Halil Pasic , qemu-s390x@nongnu.org, Cornelia Huck , qemu-devel@nongnu.org, Thomas Huth Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Halil Pasic The function machine_get_loadparm() is supposed to produce a C-string, that is a NUL-terminated one, but it does not. ElectricFence can detect this problem if the loadparm machine property is used. Let us make the returned string a NUL-terminated one. Fixes: 7104bae9de ("hw/s390x: provide loadparm property for the machine") Signed-off-by: Halil Pasic Reviewed-by: Thomas Huth Message-Id: <20200723162717.88485-1-pasic@linux.ibm.com> Signed-off-by: Cornelia Huck --- hw/s390x/s390-virtio-ccw.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index 8cc2f25d8a6a..403d30e13bca 100644 --- a/hw/s390x/s390-virtio-ccw.c +++ b/hw/s390x/s390-virtio-ccw.c @@ -701,8 +701,12 @@ bool hpage_1m_allowed(void) static char *machine_get_loadparm(Object *obj, Error **errp) { S390CcwMachineState *ms =3D S390_CCW_MACHINE(obj); + char *loadparm_str; =20 - return g_memdup(ms->loadparm, sizeof(ms->loadparm)); + /* make a NUL-terminated string */ + loadparm_str =3D g_memdup(ms->loadparm, sizeof(ms->loadparm) + 1); + loadparm_str[sizeof(ms->loadparm)] =3D 0; + return loadparm_str; } =20 static void machine_set_loadparm(Object *obj, const char *val, Error **err= p) --=20 2.25.4