From nobody Mon Feb 9 17:24:16 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1595855093; cv=none; d=zohomail.com; s=zohoarc; b=DATWWqm2VITI9DYszgN4W9+YVaAiez2/YgYxWqVLZHpwdTaECt6ux35Klq4x3phPC3kI/CW4t5fHKhpyDX9n6eLCLYZ3FRaiLrbQE3QVk69au8PWnXHng6mnRgLHD73+5WpU60MUeRPPhRd+0FhNe3qkAjmTAUWQzBDff+9JAqU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595855093; h=Content-Type:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=9XJ4GAyikVPk6VQ4qHJ0LDHEWptAppmqqhvUqTi7ju0=; b=hSt9wUinodcez944d9kDULpNzJ7EMzPKsI+xm8hQu4dCDsXViHGXPUSSIJIu0cbl1q6S3J5Sf5bama0MYecx8vG660K39zSTVjmQVPzJlYRY6UTF/GFDBvGWGKz4Z2ko+ksYfG/Y/F42zjNAGcbIqZQKsGBFZuoskr8oD2/4wqc= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1595855093915982.8424899160424; Mon, 27 Jul 2020 06:04:53 -0700 (PDT) Received: from localhost ([::1]:60814 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k02oG-0007gi-6w for importer@patchew.org; Mon, 27 Jul 2020 09:04:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48726) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k02n6-0006R7-Re; Mon, 27 Jul 2020 09:03:40 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:4159 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k02n4-0003eI-HC; Mon, 27 Jul 2020 09:03:40 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id C22D3F64D3A1EA21647B; Mon, 27 Jul 2020 21:03:24 +0800 (CST) Received: from DESKTOP-5IS4806.china.huawei.com (10.174.187.22) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Mon, 27 Jul 2020 21:02:53 +0800 From: Keqian Zhu To: , Subject: [PATCH] bugfix: irq: Avoid covering object refcount of qemu_irq Date: Mon, 27 Jul 2020 21:02:25 +0800 Message-ID: <20200727130225.32640-1-zhukeqian1@huawei.com> X-Mailer: git-send-email 2.8.4.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.187.22] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=zhukeqian1@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/27 09:03:25 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , yezengruan@huawei.com, Keqian Zhu , Li Qiang , "Dr . David Alan Gilbert" , Esteban Bosse , Paolo Bonzini , wanghaibin.wang@huawei.com, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Avoid covering object refcount of qemu_irq, otherwise it may causes memory leak. Signed-off-by: Keqian Zhu --- hw/core/irq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/core/irq.c b/hw/core/irq.c index fb3045b912..59af4dfc74 100644 --- a/hw/core/irq.c +++ b/hw/core/irq.c @@ -125,7 +125,9 @@ void qemu_irq_intercept_in(qemu_irq *gpio_in, qemu_irq_= handler handler, int n) int i; qemu_irq *old_irqs =3D qemu_allocate_irqs(NULL, NULL, n); for (i =3D 0; i < n; i++) { - *old_irqs[i] =3D *gpio_in[i]; + old_irqs[i]->handler =3D gpio_in[i]->handler; + old_irqs[i]->opaque =3D gpio_in[i]->opaque; + gpio_in[i]->handler =3D handler; gpio_in[i]->opaque =3D &old_irqs[i]; } --=20 2.19.1