From nobody Sat Nov 15 15:41:02 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1595693230; cv=none; d=zohomail.com; s=zohoarc; b=kZAY3nvM8x+sRYj9GECv9Ckbvxp+KPC62bcx4BrTbNFwpDRReKAEc42Mn7ZEIOjN6auiww0aHpS06/A7HMBsDez32J0VOrPSVQ90oIJa6u+DcsijATHQ9oHUvjTx+UAUNTc9ygUiLRSqgEwudlC9wf1mU/QhVaFBTL2Jp1v6oFo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595693230; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gnoa1BdhL7kq2tWG7eJrriXOQiqaVJzb5Vy0Oiklyc8=; b=RpJECfjjIuirKcgk1SUoBt/N0WiVpWhNo+h6a+T9mXVR6liwXqD56RXk6lWy69SmHrLGtyrYFxd8H5MfIOAUTyWviaxNG+RIEG5aBYlseLuwaZR3Pzq5FfuTAT07EZU4yl8MFcAgRz/N5rePa+vX3B/ygk9VrkS+Rhbc1IESvho= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1595693230200496.87870459104363; Sat, 25 Jul 2020 09:07:10 -0700 (PDT) Received: from localhost ([::1]:55906 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jzMhZ-0003Au-Cq for importer@patchew.org; Sat, 25 Jul 2020 12:07:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54874) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jzMgP-0001sL-53 for qemu-devel@nongnu.org; Sat, 25 Jul 2020 12:05:57 -0400 Received: from mail-pj1-x1044.google.com ([2607:f8b0:4864:20::1044]:52426) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jzMgL-0001qu-Pr for qemu-devel@nongnu.org; Sat, 25 Jul 2020 12:05:56 -0400 Received: by mail-pj1-x1044.google.com with SMTP id gc9so6914557pjb.2 for ; Sat, 25 Jul 2020 09:05:52 -0700 (PDT) Received: from localhost.localdomain (216-160-65-90.tukw.qwest.net. [216.160.65.90]) by smtp.gmail.com with ESMTPSA id e18sm9731801pff.37.2020.07.25.09.05.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jul 2020 09:05:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gnoa1BdhL7kq2tWG7eJrriXOQiqaVJzb5Vy0Oiklyc8=; b=je89Ztd6wGMQ3POyBHQWGk6sexvcNih6H0rmDaVoEhwd4Bkq37z3162GMe+E1R7UVg VNgP6ER0tum9g2nF3w0Mu/pEZADZf2G2O0R72LmkyBk+LYbLbN/SD0rCbRdWJsYBrwOX c6tafMLx1WFGRtVcF1/pzt9Y+97GYWKFTOCJrAD75ElWyETlHNm4vrfpq6t2eRZK/iCU H3BKMvyHSoVJfZ0k6W2elej1d1VDNl4vv2FHsifty/rbsRkDq81WnkzCc8Uiqu5wW580 mvscmBDkqRJOxxtkdAq9fRVXZcvUKKkNni/MWBiL9EO1RarpUFvqZ/VD38vbMgl8UdjT 1bKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gnoa1BdhL7kq2tWG7eJrriXOQiqaVJzb5Vy0Oiklyc8=; b=sNWVR7Qk8o2hlOgzMIAQqi9gaJonK2UnKTAudFG02+DJOBsiznEhBm610DpDamwdVB fHWX8yByGibjqbr4Her9iiVseQDMEWurQP+ESVZXmzHLExB3AxxL6+/Q2X6Wex3UAzLO 0r+DjLnq3ZVXqYYu9CdZ86aWFAUqtdpiE3os8qiip6yWOwvwOQxabvMygo+jhhyc4Usd AqVbRWuspG4AQBov+uizg1jIQ5fFP0/uJsl71K5ihM5gvKxdpMmlHh1PuLW6jMOW0LKh 00I6jYlREf5kiM5TebRYrlui8hV9qj3C2SBlrDV+6x33uPX4CEmn82k35Od9TQ9L8LnO AsRQ== X-Gm-Message-State: AOAM531xR3gYRHSGDrG7x+wVXecCb7R5ljEEqYMCQq7L8vQ1woFTP0xr NfnNH4nFCYyYN1FwPdPggnrNEsIlzcU= X-Google-Smtp-Source: ABdhPJxOP+HQ85hKiLfzyefqqLK4dICoirXaIapYqCPMi1NbinBdkvSmsAGnbZBE6qRtVnYYJN4Jzw== X-Received: by 2002:a17:902:8e86:: with SMTP id bg6mr13120012plb.57.1595693151407; Sat, 25 Jul 2020 09:05:51 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 1/3] tcg: update comments for save_iotlb_data in cputlb Date: Sat, 25 Jul 2020 09:05:46 -0700 Message-Id: <20200725160548.750749-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200725160548.750749-1-richard.henderson@linaro.org> References: <20200725160548.750749-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1044; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1044.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, "Emilio G . Cota" , =?UTF-8?q?Alex=20Benn=C3=A9e?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Alex Benn=C3=A9e I missed Emilio's review comments: Message-ID: <20200718205107.GA994221@sff> and the patch got merged. Correcting the comments now. Reviewed-by: Emilio G. Cota Signed-off-by: Alex Benn=C3=A9e Message-Id: <20200720122358.26881-1-alex.bennee@linaro.org> Signed-off-by: Richard Henderson --- accel/tcg/cputlb.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index d370aedb47..5698292749 100644 --- a/accel/tcg/cputlb.c +++ b/accel/tcg/cputlb.c @@ -1075,10 +1075,8 @@ static uint64_t io_readx(CPUArchState *env, CPUIOTLB= Entry *iotlbentry, =20 /* * Save a potentially trashed IOTLB entry for later lookup by plugin. - * - * We also need to track the thread storage address because the RCU - * cleanup that runs when we leave the critical region (the current - * execution) is actually in a different thread. + * This is read by tlb_plugin_lookup if the iotlb entry doesn't match + * because of the side effect of io_writex changing memory layout. */ static void save_iotlb_data(CPUState *cs, hwaddr addr, MemoryRegionSection *section, hwaddr mr_offset) @@ -1408,8 +1406,9 @@ void *tlb_vaddr_to_host(CPUArchState *env, abi_ptr ad= dr, * This almost never fails as the memory access being instrumented * should have just filled the TLB. The one corner case is io_writex * which can cause TLB flushes and potential resizing of the TLBs - * loosing the information we need. In those cases we need to recover - * data from a copy of the io_tlb entry. + * losing the information we need. In those cases we need to recover + * data from a copy of the iotlbentry. As long as this always occurs + * from the same thread (which a mem callback will be) this is safe. */ =20 bool tlb_plugin_lookup(CPUState *cpu, target_ulong addr, int mmu_idx, --=20 2.25.1 From nobody Sat Nov 15 15:41:02 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1595693248; cv=none; d=zohomail.com; s=zohoarc; b=Q5gV3yfVzK1a09FJA7xBHv5OOx9zm6kJ/nuCGOmC3XyuzusIFf42jXyGh9GvwtsEdbyG0gxOLrMsrxqdbkgMFbvly78hNwAR/kmxGCTvSFCkCRJZGskpHG44jo4o2nx+CJQHR4WODViQ8Hesp72VGdD+69Qt0r1HjqarDIOkSbE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595693248; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=P3LyPyeEcuWa2/MKIfNsGrObBE0H+KsTUZiQvWcLS7o=; b=KeP5XPS2QlUCELhvq1JmF6UTf1Ucbh7xmxjf2Hyurq8McPfzpAhgpSVsxSEkVhgTOUIwiQ8QDLwDa8R/Ry4OxpRi/Xg04axyV/Opb2wjjI12th6V8oeW1wpCGofnC+bFoJ5SMgQeHg7Z4G5RICTEt6HxgO+HGT6j+OI/aYPafSI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1595693248907502.6045962758142; Sat, 25 Jul 2020 09:07:28 -0700 (PDT) Received: from localhost ([::1]:57410 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jzMhs-0003lk-1f for importer@patchew.org; Sat, 25 Jul 2020 12:07:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54878) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jzMgP-0001sp-FH for qemu-devel@nongnu.org; Sat, 25 Jul 2020 12:05:57 -0400 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]:35791) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jzMgN-0001rW-40 for qemu-devel@nongnu.org; Sat, 25 Jul 2020 12:05:57 -0400 Received: by mail-pl1-x644.google.com with SMTP id x9so6058801plr.2 for ; Sat, 25 Jul 2020 09:05:54 -0700 (PDT) Received: from localhost.localdomain (216-160-65-90.tukw.qwest.net. [216.160.65.90]) by smtp.gmail.com with ESMTPSA id e18sm9731801pff.37.2020.07.25.09.05.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jul 2020 09:05:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=P3LyPyeEcuWa2/MKIfNsGrObBE0H+KsTUZiQvWcLS7o=; b=qJon6ZFTh5G2iYoodM/FL3VyvM6wRxCtLL1MAPg741Lm9LZs3zgo7Q0SruRxYrfG46 UIpNkPD56LpYgBNOr3o0TcsYo5Xr2pe9bnD13iv2n8G+/N0bqmjMqenZBuH6tXHri3h3 36lQw2+SGiWIl9Fa53cwQxk/ga1p7obiNrKyY+WNIiJYsa1XWCz8M2ymV+hZf+gBB3m3 1BAOgwiVCT6/YTQ9UOhU+q67/Vsjmb1lAfIT5sN9VJXcoIWWVzcoXf7f7L8QOjzFSMYi JqPj9Imi7Ke2xSC+Z7VbF0FfOtCBaWfjY998MxH4PVqt2yxIRvDDNF1YLUFNxGt+k0mA ZeoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=P3LyPyeEcuWa2/MKIfNsGrObBE0H+KsTUZiQvWcLS7o=; b=ujYfYc2DIdRh/NR0mZBxLvRsJBe1Lg6tD63t6zRsHYI6QuBYUoSD8F87BxwqGxJGx8 idCgHZvJYpMpuYBXIEOCjSmnppxtc+QaSZ584MrOi3Rzg6xNOI2qmXlZIaLulfNwZY4h FugaFDHyQcqGrKvkH4Y2Dj/M3aV8DLtHySsFXbD6eHh+OIUCF7RmJsJRKf5zpyDOUsgs pYso4deCRuBClCM808YlQCXKQGL9UIWGV37hAxpBG5cUPG3IdAYyW1VJMrcbCJrgDfWQ noTTvRHgI66jAQ4xnJgGQqQH3y170e23sbYT3kb/mEcvKR3j7Hrmo/Xlgm8EcVvgQg8D HcyA== X-Gm-Message-State: AOAM533r97xVZw5ExlMTp7hLWP23yipbsPXuTinZIZBFbTAtJNOkIcsu Xr00/vMaEhwdrhsg8Y6Bb9Bgln25/YI= X-Google-Smtp-Source: ABdhPJzJRj5ekfNF7+rp5uGs1XTJhf5SIPY1HSfChRkwNUoUM/4t9XF4CHKJFpOsGobl2YZffvYBZQ== X-Received: by 2002:a17:90a:7103:: with SMTP id h3mr8705954pjk.34.1595693152811; Sat, 25 Jul 2020 09:05:52 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 2/3] target/hppa: Free some temps in do_sub Date: Sat, 25 Jul 2020 09:05:47 -0700 Message-Id: <20200725160548.750749-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200725160548.750749-1-richard.henderson@linaro.org> References: <20200725160548.750749-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::644; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x644.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Sven Schnelle , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Two temps allocated but not freed. Do enough subtractions within a single TB and one can run out of temps entirely. Fixes: b2167459ae ("target-hppa: Implement basic arithmetic") Buglink: https://bugs.launchpad.net/qemu/+bug/1880287 Tested-by: Sven Schnelle Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Richard Henderson Message-Id: <20200720174039.517902-1-richard.henderson@linaro.org> --- target/hppa/translate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 52d7bea1ea..4bd22d4820 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -1294,6 +1294,8 @@ static void do_sub(DisasContext *ctx, unsigned rt, TC= Gv_reg in1, save_or_nullify(ctx, cpu_psw_cb_msb, cb_msb); save_gpr(ctx, rt, dest); tcg_temp_free(dest); + tcg_temp_free(cb); + tcg_temp_free(cb_msb); =20 /* Install the new nullification. */ cond_free(&ctx->null_cond); --=20 2.25.1 From nobody Sat Nov 15 15:41:02 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1595693316; cv=none; d=zohomail.com; s=zohoarc; b=l7/dv/bmp+dg4v8YY4APrCrqNplH3bPeKbpZfVsODwex9i86+tSVLtelKXSjwnGO5NBTKX4RWZYXNfQcFJM3tQvBSP+0iMO38IrOxwGWIUIZ0IDuOQZy3aq+JST4NzaG6n6TCch4yC/umB57yNQQEf0SNlIfXnbylCBt7IUOIJo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595693316; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Tn/0BiX/IEZ1RnYH9GODJ+VXClkGUOJZjcKmp7fXXkU=; b=gRLCGgEYWF2wXEac2i1rj70RuxpdIQRlafhSFUEfjNgjodWr3/Tu3si9CbK/CKAiPVH9jckpl5ptTtiwYVkULJwkl+bjjm/I9X4bgEqqA6wsI/L4E9MeuGQYxQ+ID92ffrwLHVONSPSoSxV497vIhgMt3y1tpmKjzhIbKlF6aBo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 159569331655299.68168279341216; Sat, 25 Jul 2020 09:08:36 -0700 (PDT) Received: from localhost ([::1]:32984 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jzMix-0005JM-OW for importer@patchew.org; Sat, 25 Jul 2020 12:08:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54880) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jzMgP-0001tZ-Qb for qemu-devel@nongnu.org; Sat, 25 Jul 2020 12:05:57 -0400 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]:33858) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jzMgN-0001si-TM for qemu-devel@nongnu.org; Sat, 25 Jul 2020 12:05:57 -0400 Received: by mail-pl1-x632.google.com with SMTP id o1so6064365plk.1 for ; Sat, 25 Jul 2020 09:05:55 -0700 (PDT) Received: from localhost.localdomain (216-160-65-90.tukw.qwest.net. [216.160.65.90]) by smtp.gmail.com with ESMTPSA id e18sm9731801pff.37.2020.07.25.09.05.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jul 2020 09:05:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Tn/0BiX/IEZ1RnYH9GODJ+VXClkGUOJZjcKmp7fXXkU=; b=nHUPrYbAyWW/qrnhxle3v9IaVNTptQIn0+Np29LdK3VhcMNM/69IfX+WkPNIS/k5xo f6CkqPasoGtKuKue+Y4OjOET5Mpd/OvfMNpZ6QvNu9Ds5zeKtTD0hQcA7oTjxXbQUOQR Zywonyjty/JVo+eW9s255rhVbzdpfM2j1pnV3t3JTeloINlxoIp0VqdJYIZssyK9Rq60 cNlSBs71TO9KRNOw3hR14L/0syLz2az/HtnlDKUMA7NFWRMR0Yl+8Q3N6E6oTql1iMfg yz2vp5pv05W3UQtFIouN0AA5DDgMXJWPfympaQ5TtMnA+u4WPD2jT8JvOS1qRZq8Mwqc rP1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Tn/0BiX/IEZ1RnYH9GODJ+VXClkGUOJZjcKmp7fXXkU=; b=eWTAfSc1VrPOzyzOcEHSe5p/2H/Yo+IVQqG3qdyEqRjbSULpNHp3oB4x3SO9Bh++7u cF8fa3sC2qlDsXsk1cH6jLADbbx/2UTH8a0LVbQmElAXBTMYJgwEJGWvKfBFVrRgDb8o AGdJw3Ox5dpFe5FcxgEe0Oim9B0H86gQGKUArebUkLyFxZ8+IE21F6VZTqP1CmnX6hzj B2+aNn9t9OIs9sPVgjMnIstmthpH/oqnUd5sRpqWMwejhd+I+bWOtV6o97nAPxJfT3lF YtPB6Fdm5opEotVVAgTc1q6f0A7+zksogiaYN75iPKCXD+vyaXR6zL2ovmUg9fg0jJ+b PV1Q== X-Gm-Message-State: AOAM533/6A9MOe9mzT6sF4zRlFC55I9Ek5qE9WBgdxz9cKi0uaxyDIlu GpYsQeemfMnGZl9Tx4WHbX3YGqI5MtY= X-Google-Smtp-Source: ABdhPJwH1UAz3Th2al7YTuB1qcJtVKYQ8fVORrBkTFIkFrBtkF6YfoDys1QHhnN1ElBD1yfnQP5xwQ== X-Received: by 2002:a17:90a:1589:: with SMTP id m9mr3308420pja.122.1595693153840; Sat, 25 Jul 2020 09:05:53 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 3/3] target/i386: Save cc_op before loop insns Date: Sat, 25 Jul 2020 09:05:48 -0700 Message-Id: <20200725160548.750749-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200725160548.750749-1-richard.henderson@linaro.org> References: <20200725160548.750749-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::632; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x632.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) We forgot to update cc_op before these branch insns, which lead to losing track of the current eflags. Buglink: https://bugs.launchpad.net/qemu/+bug/1888165 Reviewed-by: Alex Benn=C3=A9e Signed-off-by: Richard Henderson Message-Id: <20200720154028.477457-1-richard.henderson@linaro.org> --- target/i386/translate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/i386/translate.c b/target/i386/translate.c index a1d31f09c1..caea6f5fb1 100644 --- a/target/i386/translate.c +++ b/target/i386/translate.c @@ -7148,6 +7148,7 @@ static target_ulong disas_insn(DisasContext *s, CPUSt= ate *cpu) l1 =3D gen_new_label(); l2 =3D gen_new_label(); l3 =3D gen_new_label(); + gen_update_cc_op(s); b &=3D 3; switch(b) { case 0: /* loopnz */ --=20 2.25.1