From nobody Sat Nov 15 17:47:15 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1595597218; cv=none; d=zohomail.com; s=zohoarc; b=PfnQ7ILZHfAgMWNt1VWeyzcA92dismXhulFo3GcBFdV7Ml4DMF6qRAGh8rDM9IIFYGWoD9bSpjSFmRNDhjEFBji1RUCr6s8HZJgyFcYnV7PPeCwQg0B7FMXcFBJ9C3/9f7zBvGqUFQRN0swvQpermAxoNZlqxxXFIGDCGQaKhfw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595597218; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ajdPE6s1yMNNO7wKORFcQ9vEE0jTRgdP9yYAVOyvGr4=; b=kdPUTy/uaLtWdYEszf8N5Ag2FogeOZmT869IbNPYEDvXpbV+UR1Bo+uC0dABdBp3PduTsWP39P6YnmTK4hrgnaMf1wfBxTbgtG3vSzYUfRf3hlkyjAT8znffEEybjPqPn5DXKbFCYQzQUU9EyyxUCP/pXYxoEo87k5f+yhYNVlg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15955972188771011.1534558068544; Fri, 24 Jul 2020 06:26:58 -0700 (PDT) Received: from localhost ([::1]:59722 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jyxiz-0001kd-DH for importer@patchew.org; Fri, 24 Jul 2020 09:26:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45290) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jyxhs-0008Vc-2f for qemu-devel@nongnu.org; Fri, 24 Jul 2020 09:25:48 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:55239 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jyxhq-00011b-JH for qemu-devel@nongnu.org; Fri, 24 Jul 2020 09:25:47 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-235-ZuJHyflnNiSDcagZzqawkA-1; Fri, 24 Jul 2020 09:25:43 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 75D7A80BCBD; Fri, 24 Jul 2020 13:25:42 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.36.110.43]) by smtp.corp.redhat.com (Postfix) with ESMTP id A3E1C101E1BF; Fri, 24 Jul 2020 13:25:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595597145; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ajdPE6s1yMNNO7wKORFcQ9vEE0jTRgdP9yYAVOyvGr4=; b=eoTrp+r1TiFgrok/BktOUuZqtc2yrG3Kt3p4Z6X5Lzuz77+gF4KFdpXl658XEPv2q8GFDB Vlvh8MKL/kRndlnFpJP0OipQ9gOGGFheJJtrWMzFFRuXJtKtgcOqKvJT0DduwpoPX6Xo8x MXY2xGHk7O6gZ9WfFj3wk8i0Wpz61Uw= X-MC-Unique: ZuJHyflnNiSDcagZzqawkA-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v3 3/4] util: give a specific error message when O_DIRECT doesn't work Date: Fri, 24 Jul 2020 14:25:09 +0100 Message-Id: <20200724132510.3250311-4-berrange@redhat.com> In-Reply-To: <20200724132510.3250311-1-berrange@redhat.com> References: <20200724132510.3250311-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.81; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/24 00:00:27 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , qemu-block@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Markus Armbruster , Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) A common error scenario is to tell QEMU to use O_DIRECT in combination with a filesystem that doesn't support it. To aid users to diagnosing their mistake we want to provide a clear error message when this happens. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Eric Blake --- util/osdep.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/util/osdep.c b/util/osdep.c index 5c0f4684b1..ac3e7f48f1 100644 --- a/util/osdep.c +++ b/util/osdep.c @@ -348,6 +348,19 @@ qemu_open_internal(const char *name, int flags, mode_t= mode, Error **errp) if (flags & O_CREAT) { action =3D "create"; } +#ifdef O_DIRECT + if (errno =3D=3D EINVAL && (flags & O_DIRECT)) { + ret =3D open(name, flags & ~O_DIRECT, mode); + if (ret !=3D -1) { + close(ret); + error_setg(errp, "Could not %s '%s' flags 0x%x: " + "filesystem does not support O_DIRECT", + action, name, flags); + errno =3D EINVAL; /* close() clobbered earlier errno */ + return -1; + } + } +#endif /* O_DIRECT */ error_setg_errno(errp, errno, "Could not %s '%s' flags 0x%x", action, name, flags); } --=20 2.26.2